* [PR PATCH] sbcl: always bootstrap from clisp.
@ 2022-08-13 19:24 ericonr
2022-08-13 19:33 ` classabbyamp
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: ericonr @ 2022-08-13 19:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1335 bytes --]
There is a new pull request by ericonr against master on the void-packages repository
https://github.com/ericonr/void-packages sbcl
https://github.com/void-linux/void-packages/pull/38661
sbcl: always bootstrap from clisp.
Avoid depending on external binaries.
<!-- Uncomment relevant sections and delete options which are not applicable -->
@leahneukirchen what do you think?
#### Testing the changes
- I tested the changes in this PR: **YES** (build side)
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/38661.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sbcl-38661.patch --]
[-- Type: text/x-diff, Size: 2144 bytes --]
From 762a392a73244dbee00f1f63dcfd9733e0d2a7d4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Nogueira?= <erico.erc@gmail.com>
Date: Sat, 13 Aug 2022 16:22:02 -0300
Subject: [PATCH] sbcl: always bootstrap from clisp.
Avoid depending on external binaries.
---
srcpkgs/sbcl/template | 27 +++------------------------
1 file changed, 3 insertions(+), 24 deletions(-)
diff --git a/srcpkgs/sbcl/template b/srcpkgs/sbcl/template
index 990c8b0fd6a9..76c4fb9cf9ba 100644
--- a/srcpkgs/sbcl/template
+++ b/srcpkgs/sbcl/template
@@ -1,10 +1,10 @@
# Template file for 'sbcl'
pkgname=sbcl
version=2.2.7
-revision=1
+revision=2
# make sure the sbcl option in maxima is enabled for the same archs
archs="i686 x86_64* armv7l aarch64 ppc64le*"
-hostmakedepends="iana-etc texinfo"
+hostmakedepends="iana-etc texinfo clisp"
makedepends="libzstd-devel zlib-devel"
conf_files="/etc/sbclrc"
short_desc="Steel Bank Common Lisp"
@@ -16,28 +16,7 @@ distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}-source.tar.bz2"
checksum=ec98996fdaa68009d98b4d7db2189271f2ad455ec322ca95a9c6aebf08bead6d
nocross=yes
nopie=yes
-
-_bootstrap_lisp="bash ../sbcl-*-linux/run-sbcl.sh --no-sysinit --no-userinit --disable-debugger"
-case "$XBPS_TARGET_MACHINE" in
-x86_64)
- distfiles+=" ${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}-x86-64-linux-binary.tar.bz2"
- checksum+=" 4b176dd651437af851f6eb8332b51457f983079d27d347c30c73b3481959be78"
- ;;
-arm*)
- distfiles+=" ${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-1.2.14-armhf-linux-binary.tar.bz2"
- checksum+=" a5fbf1d596a909a7719bc4a958f00e8537bf399fa051f83736baee950b21e56a"
- ;;
-aarch64)
- distfiles+=" ${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-1.3.9-arm64-linux-binary.tar.bz2"
- checksum+=" 14c8fc0f3a03416b5d23763156e2bb28b690fb665af1e6f6112201fd0ddcd512"
- ;;
-i686*|ppc*|*-musl)
- # ecl bootstrap is broken since 2.2.0:
- # https://build.voidlinux.org/builders/x86_64-musl_builder/builds/39694/steps/shell_3/logs/stdio
- makedepends+=" clisp"
- _bootstrap_lisp="clisp"
- ;;
-esac
+_bootstrap_lisp="clisp"
do_build() {
printf '"%s.void.%s"\n' "$version" "$revision" >version.lisp-expr
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: sbcl: always bootstrap from clisp.
2022-08-13 19:24 [PR PATCH] sbcl: always bootstrap from clisp ericonr
@ 2022-08-13 19:33 ` classabbyamp
2022-08-15 15:39 ` leahneukirchen
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: classabbyamp @ 2022-08-13 19:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 178 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/38661#issuecomment-1214211722
Comment:
homepage/changelog can be https
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: sbcl: always bootstrap from clisp.
2022-08-13 19:24 [PR PATCH] sbcl: always bootstrap from clisp ericonr
2022-08-13 19:33 ` classabbyamp
@ 2022-08-15 15:39 ` leahneukirchen
2022-08-16 17:33 ` ericonr
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: leahneukirchen @ 2022-08-15 15:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 228 bytes --]
New comment by leahneukirchen on void-packages repository
https://github.com/void-linux/void-packages/pull/38661#issuecomment-1215185557
Comment:
I'm not super opposed, but it takes like 30min to build instead of 5 on x86_64.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: sbcl: always bootstrap from clisp.
2022-08-13 19:24 [PR PATCH] sbcl: always bootstrap from clisp ericonr
2022-08-13 19:33 ` classabbyamp
2022-08-15 15:39 ` leahneukirchen
@ 2022-08-16 17:33 ` ericonr
2022-08-16 17:40 ` q66
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2022-08-16 17:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 325 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/38661#issuecomment-1216944066
Comment:
Will do, abby, thanks!
I noticed the time issue :/ slower builds vs potentially avoiding future problems (assuming bootstrap with clisp doesn't break either). Not a simple decision
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: sbcl: always bootstrap from clisp.
2022-08-13 19:24 [PR PATCH] sbcl: always bootstrap from clisp ericonr
` (2 preceding siblings ...)
2022-08-16 17:33 ` ericonr
@ 2022-08-16 17:40 ` q66
2022-11-15 2:11 ` github-actions
2022-11-30 2:03 ` [PR PATCH] [Closed]: " github-actions
5 siblings, 0 replies; 7+ messages in thread
From: q66 @ 2022-08-16 17:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 329 bytes --]
New comment by q66 on void-packages repository
https://github.com/void-linux/void-packages/pull/38661#issuecomment-1216951085
Comment:
i'd like ecl bootstrap better, considering clisp is poorly maintained and depends on libffcall which is a massive clusterfuck
but ecl bootstrap has been broken for some time, unfortunately
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: sbcl: always bootstrap from clisp.
2022-08-13 19:24 [PR PATCH] sbcl: always bootstrap from clisp ericonr
` (3 preceding siblings ...)
2022-08-16 17:40 ` q66
@ 2022-11-15 2:11 ` github-actions
2022-11-30 2:03 ` [PR PATCH] [Closed]: " github-actions
5 siblings, 0 replies; 7+ messages in thread
From: github-actions @ 2022-11-15 2:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/38661#issuecomment-1314662356
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR PATCH] [Closed]: sbcl: always bootstrap from clisp.
2022-08-13 19:24 [PR PATCH] sbcl: always bootstrap from clisp ericonr
` (4 preceding siblings ...)
2022-11-15 2:11 ` github-actions
@ 2022-11-30 2:03 ` github-actions
5 siblings, 0 replies; 7+ messages in thread
From: github-actions @ 2022-11-30 2:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1187 bytes --]
There's a closed pull request on the void-packages repository
sbcl: always bootstrap from clisp.
https://github.com/void-linux/void-packages/pull/38661
Description:
Avoid depending on external binaries.
<!-- Uncomment relevant sections and delete options which are not applicable -->
@leahneukirchen what do you think?
#### Testing the changes
- I tested the changes in this PR: **YES** (build side)
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-11-30 2:03 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-13 19:24 [PR PATCH] sbcl: always bootstrap from clisp ericonr
2022-08-13 19:33 ` classabbyamp
2022-08-15 15:39 ` leahneukirchen
2022-08-16 17:33 ` ericonr
2022-08-16 17:40 ` q66
2022-11-15 2:11 ` github-actions
2022-11-30 2:03 ` [PR PATCH] [Closed]: " github-actions
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).