From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] cpp-hocon: add shared library, disable tests build
Date: Sun, 20 Nov 2022 13:45:35 +0100 [thread overview]
Message-ID: <20221120124535.sMxWwPjHE8XRfffEp_a6tEL_z2qTAgPRVtT3p-Zy_e0@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-40645@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1307 bytes --]
There is an updated pull request by paper42 against master on the void-packages repository
https://github.com/paper42/void-packages cpp-hocon
https://github.com/void-linux/void-packages/pull/40645
cpp-hocon: add shared library, disable tests build
tests do not build with gcc 12
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/40645.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cpp-hocon-40645.patch --]
[-- Type: text/x-diff, Size: 5245 bytes --]
From a9aea036c6fa8691ef271ac710da2e30fb0e023f Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sun, 20 Nov 2022 13:19:04 +0100
Subject: [PATCH 1/2] cpp-hocon: build shared library, disable tests
tests do not build with gcc 12
---
common/shlibs | 1 +
srcpkgs/cpp-hocon-devel | 1 +
.../patches/disable-building-tests.patch | 8 ++++++++
srcpkgs/cpp-hocon/template | 17 ++++++++++-------
4 files changed, 20 insertions(+), 7 deletions(-)
create mode 120000 srcpkgs/cpp-hocon-devel
create mode 100644 srcpkgs/cpp-hocon/patches/disable-building-tests.patch
diff --git a/common/shlibs b/common/shlibs
index c103447f8b31..7f07c64149b0 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -4197,3 +4197,4 @@ libabsl_strings.so.2206.0.0 abseil-cpp-20220623.1_1
libabsl_throw_delegate.so.2206.0.0 abseil-cpp-20220623.1_1
libabsl_time_zone.so.2206.0.0 abseil-cpp-20220623.1_1
libabsl_spinlock_wait.so.2206.0.0 abseil-cpp-20220623.1_1
+libcpp-hocon.so.0.3.0 cpp-hocon-0.3.0_5
diff --git a/srcpkgs/cpp-hocon-devel b/srcpkgs/cpp-hocon-devel
new file mode 120000
index 000000000000..8d8bc1453e86
--- /dev/null
+++ b/srcpkgs/cpp-hocon-devel
@@ -0,0 +1 @@
+cpp-hocon
\ No newline at end of file
diff --git a/srcpkgs/cpp-hocon/patches/disable-building-tests.patch b/srcpkgs/cpp-hocon/patches/disable-building-tests.patch
new file mode 100644
index 000000000000..27db097479c7
--- /dev/null
+++ b/srcpkgs/cpp-hocon/patches/disable-building-tests.patch
@@ -0,0 +1,8 @@
+--- a/lib/CMakeLists.txt
++++ b/lib/CMakeLists.txt
+@@ -90,5 +90,3 @@ symbol_exports(lib${PROJECT_NAME} "${CMAKE_CURRENT_LIST_DIR}/inc/hocon/export.h"
+ # This correctly handles DLL installation on Windows.
+ leatherman_install(lib${PROJECT_NAME})
+ install(DIRECTORY inc/hocon DESTINATION include)
+-
+-add_subdirectory(tests)
diff --git a/srcpkgs/cpp-hocon/template b/srcpkgs/cpp-hocon/template
index f61316adcc11..ce521b1395ae 100644
--- a/srcpkgs/cpp-hocon/template
+++ b/srcpkgs/cpp-hocon/template
@@ -1,20 +1,23 @@
# Template file for 'cpp-hocon'
pkgname=cpp-hocon
version=0.3.0
-revision=4
+revision=5
build_style=cmake
+configure_args="-DBUILD_SHARED_LIBS=ON"
hostmakedepends="pkg-config"
makedepends="boost-devel leatherman-devel libcurl-devel"
short_desc="C++ port of the Typesafe Config library"
maintainer="Orphaned <orphan@voidlinux.org>"
license="Apache-2.0"
homepage="https://github.com/puppetlabs/cpp-hocon/"
-distfiles="https://github.com/puppetlabs/cpp-hocon/archive/${version}.tar.gz>${pkgname}-${version}.tar.gz"
+distfiles="https://github.com/puppetlabs/cpp-hocon/archive/${version}.tar.gz"
checksum=dab02354046f05aca6275c746d7583ee5f71853aa5b1d93529564632e184c3dd
-post_install() {
- # this package is a static library,
- # needs to be rebuild when update boost,
- # force an shlib-dependencies
- vbin build/bin/libcpp-hocon_test
+cpp-hocon-devel_package() {
+ depends="${sourcepkg}>=${version}_${revision}"
+ short_desc+=" - development files"
+ pkg_install() {
+ vmove usr/include
+ vmove "usr/lib/*.so"
+ }
}
From 9c53eb50101c002c8ad30b4ef9d7022676de3e28 Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sun, 20 Nov 2022 13:35:34 +0100
Subject: [PATCH 2/2] facter: use shared cpp-hocon
---
srcpkgs/facter/patches/shared_cpp_hcon.patch | 13 +++++++++++++
srcpkgs/facter/template | 4 ++--
2 files changed, 15 insertions(+), 2 deletions(-)
create mode 100644 srcpkgs/facter/patches/shared_cpp_hcon.patch
diff --git a/srcpkgs/facter/patches/shared_cpp_hcon.patch b/srcpkgs/facter/patches/shared_cpp_hcon.patch
new file mode 100644
index 000000000000..37c475697a96
--- /dev/null
+++ b/srcpkgs/facter/patches/shared_cpp_hcon.patch
@@ -0,0 +1,13 @@
+https://github.com/archlinux/svntogit-community/blob/0eb74a76c976a7fd638fbf6cd1c3b47be3dccd8b/trunk/shared_cpp_hcon.patch
+
+diff --git a/cmake/FindCPPHOCON.cmake b/cmake/FindCPPHOCON.cmake
+index 00ba8bd..0df0a51 100644
+--- a/cmake/FindCPPHOCON.cmake
++++ b/cmake/FindCPPHOCON.cmake
+@@ -1,5 +1,5 @@
+ include(FindDependency)
+-find_dependency(CPPHOCON DISPLAY "cpp-hocon" HEADERS "hocon/config.hpp" LIBRARIES "libcpp-hocon.a")
++find_dependency(CPPHOCON DISPLAY "cpp-hocon" HEADERS "hocon/config.hpp" LIBRARIES "libcpp-hocon.so")
+
+ include(FeatureSummary)
+ set_package_properties(CPPHOCON PROPERTIES DESCRIPTION "A C++ parser for the HOCON configuration language" URL "https://github.com/puppetlabs/cpp-hocon")
diff --git a/srcpkgs/facter/template b/srcpkgs/facter/template
index 45c921a0b72d..dc01c966a041 100644
--- a/srcpkgs/facter/template
+++ b/srcpkgs/facter/template
@@ -1,12 +1,12 @@
# Template file for 'facter'
pkgname=facter
version=3.14.16
-revision=4
+revision=5
build_style=cmake
configure_args="-DRUBY_CONFIG_INCLUDE_DIR=${XBPS_CROSS_BASE}/usr/include
-DENABLE_CXX_WERROR=OFF -DCMAKE_INSTALL_LIBDIR=/usr/lib"
hostmakedepends="ruby-devel"
-makedepends="boost-devel cpp-hocon leatherman-devel libblkid-devel libcurl-devel
+makedepends="boost-devel cpp-hocon-devel leatherman-devel libblkid-devel libcurl-devel
ruby-devel yaml-cpp-devel"
depends="net-tools ruby"
short_desc="Collect and display system facts"
next prev parent reply other threads:[~2022-11-20 12:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-20 12:20 [PR PATCH] " paper42
2022-11-20 12:45 ` paper42 [this message]
2022-11-23 7:29 ` kruceter
2022-11-25 10:25 ` sgn
2022-12-03 12:44 ` [PR PATCH] [Updated] " paper42
2022-12-03 12:54 ` sgn
2022-12-03 13:26 ` [PR PATCH] [Merged]: " sgn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221120124535.sMxWwPjHE8XRfffEp_a6tEL_z2qTAgPRVtT3p-Zy_e0@z \
--to=paper42@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).