From: kruceter <kruceter@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: cpp-hocon: add shared library, disable tests build
Date: Wed, 23 Nov 2022 08:29:40 +0100 [thread overview]
Message-ID: <20221123072940.99D2qsy5kCxyuYk63pc9j2uiQVwqDtrdSajZzh5EFEc@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-40645@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 3295 bytes --]
New comment by kruceter on void-packages repository
https://github.com/void-linux/void-packages/pull/40645#issuecomment-1324651994
Comment:
Is this patch suitable for you?
```diff
diff --git a/srcpkgs/facter/template b/srcpkgs/facter/template
index dc01c966a0..dbf8bd0e71 100644
--- a/srcpkgs/facter/template
+++ b/srcpkgs/facter/template
@@ -24,7 +24,7 @@ pre_configure() {
post_build() {
# fixup vendor_ruby usr/lib{32,64} install path to always use usr/lib
- vsed -i build/lib/cmake_install.cmake -e "s;lib32;lib;g" -e "s;lib64;lib;g"
+ vsed -i build/lib/cmake_install.cmake -e "s;lib[0-9][0-9];;g"
}
facter-devel_package() {
```
Tests seem to be failing here:
```
=> facter-3.14.16_5: running post_build ...
=> facter-3.14.16_5: running do_check ...
[0/1] Running tests...
Test project /builddir/facter-3.14.16/build
Start 1: libfacter tests
1/3 Test #1: libfacter tests ..................***Failed 5.57 sec
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
libfacter_test is a Catch v1.10.0 host application.
Run with -? for options
-------------------------------------------------------------------------------
Scenario: using a double fact value
When: serialized to YAML
Then: it should have the same value
-------------------------------------------------------------------------------
/builddir/facter-3.14.16/lib/tests/facts/double_value.cc:27
...............................................................................
/builddir/facter-3.14.16/lib/tests/facts/double_value.cc:30: FAILED:
REQUIRE( string(emitter.c_str()) == "42.4242" )
with expansion:
"42.424199999999999" == "42.4242"
-------------------------------------------------------------------------------
Scenario: using the filesystem resolver
When: populating facts
Then: non-tmpfs mounts should exist
-------------------------------------------------------------------------------
/builddir/facter-3.14.16/lib/tests/facts/linux/filesystem_resolver.cc:37
...............................................................................
/builddir/facter-3.14.16/lib/tests/facts/linux/filesystem_resolver.cc:38: FAILED:
REQUIRE( facts.query<facter::facts::map_value>("mountpoints./") )
with expansion:
NULL
===============================================================================
test cases: 73 | 71 passed | 2 failed
assertions: 12054 | 12052 passed | 2 failed
Start 2: libfacter specs
2/3 Test #2: libfacter specs .................. Passed 4.76 sec
Start 3: facter smoke
3/3 Test #3: facter smoke ..................... Passed 0.51 sec
67% tests passed, 1 tests failed out of 3
Total Test time (real) = 10.95 sec
The following tests FAILED:
1 - libfacter tests (Failed)
Errors while running CTest
FAILED: CMakeFiles/test.util
cd /builddir/facter-3.14.16/build && /usr/bin/ctest --force-new-ctest-process
ninja: build stopped: subcommand failed.
=> ERROR: facter-3.14.16_5: do_check: '${make_check_pre} ${make_cmd} ${makejobs} ${make_check_args} ${make_check_target}' exited with 1
=> ERROR: in do_check() at common/build-style/cmake.sh:127
```
Upstream does not have fixes for them in the "3.*" branch.
next prev parent reply other threads:[~2022-11-23 7:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-20 12:20 [PR PATCH] " paper42
2022-11-20 12:45 ` [PR PATCH] [Updated] " paper42
2022-11-23 7:29 ` kruceter [this message]
2022-11-25 10:25 ` sgn
2022-12-03 12:44 ` [PR PATCH] [Updated] " paper42
2022-12-03 12:54 ` sgn
2022-12-03 13:26 ` [PR PATCH] [Merged]: " sgn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221123072940.99D2qsy5kCxyuYk63pc9j2uiQVwqDtrdSajZzh5EFEc@z \
--to=kruceter@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).