Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] cpp-hocon: add shared library, disable tests build
@ 2022-11-20 12:20 paper42
  2022-11-20 12:45 ` [PR PATCH] [Updated] " paper42
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: paper42 @ 2022-11-20 12:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1302 bytes --]

There is a new pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages cpp-hocon
https://github.com/void-linux/void-packages/pull/40645

cpp-hocon: add shared library, disable tests build
tests do not build with gcc 12

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/40645.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cpp-hocon-40645.patch --]
[-- Type: text/x-diff, Size: 2160 bytes --]

From 0f9de97dcae3de432a60e4689178293f88ee53ea Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sun, 20 Nov 2022 13:19:04 +0100
Subject: [PATCH] cpp-hocon: add shared library, disable tests build

tests do not build with gcc 12
---
 .../cpp-hocon/patches/disable-building-tests.patch   |  8 ++++++++
 srcpkgs/cpp-hocon/template                           | 12 +++---------
 2 files changed, 11 insertions(+), 9 deletions(-)
 create mode 100644 srcpkgs/cpp-hocon/patches/disable-building-tests.patch

diff --git a/srcpkgs/cpp-hocon/patches/disable-building-tests.patch b/srcpkgs/cpp-hocon/patches/disable-building-tests.patch
new file mode 100644
index 000000000000..27db097479c7
--- /dev/null
+++ b/srcpkgs/cpp-hocon/patches/disable-building-tests.patch
@@ -0,0 +1,8 @@
+--- a/lib/CMakeLists.txt
++++ b/lib/CMakeLists.txt
+@@ -90,5 +90,3 @@ symbol_exports(lib${PROJECT_NAME} "${CMAKE_CURRENT_LIST_DIR}/inc/hocon/export.h"
+ # This correctly handles DLL installation on Windows.
+ leatherman_install(lib${PROJECT_NAME})
+ install(DIRECTORY inc/hocon DESTINATION include)
+-
+-add_subdirectory(tests)
diff --git a/srcpkgs/cpp-hocon/template b/srcpkgs/cpp-hocon/template
index f61316adcc11..aeb2a61b376b 100644
--- a/srcpkgs/cpp-hocon/template
+++ b/srcpkgs/cpp-hocon/template
@@ -1,20 +1,14 @@
 # Template file for 'cpp-hocon'
 pkgname=cpp-hocon
 version=0.3.0
-revision=4
+revision=5
 build_style=cmake
+configure_args="-DBUILD_SHARED_LIBS=ON"
 hostmakedepends="pkg-config"
 makedepends="boost-devel leatherman-devel libcurl-devel"
 short_desc="C++ port of the Typesafe Config library"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="Apache-2.0"
 homepage="https://github.com/puppetlabs/cpp-hocon/"
-distfiles="https://github.com/puppetlabs/cpp-hocon/archive/${version}.tar.gz>${pkgname}-${version}.tar.gz"
+distfiles="https://github.com/puppetlabs/cpp-hocon/archive/${version}.tar.gz"
 checksum=dab02354046f05aca6275c746d7583ee5f71853aa5b1d93529564632e184c3dd
-
-post_install() {
-	# this package is a static library,
-	# needs to be rebuild when update boost,
-	# force an shlib-dependencies
-	vbin build/bin/libcpp-hocon_test
-}

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-12-03 13:26 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-20 12:20 [PR PATCH] cpp-hocon: add shared library, disable tests build paper42
2022-11-20 12:45 ` [PR PATCH] [Updated] " paper42
2022-11-23  7:29 ` kruceter
2022-11-25 10:25 ` sgn
2022-12-03 12:44 ` [PR PATCH] [Updated] " paper42
2022-12-03 12:54 ` sgn
2022-12-03 13:26 ` [PR PATCH] [Merged]: " sgn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).