Github messages for voidlinux
 help / color / mirror / Atom feed
From: r-ricci <r-ricci@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Closed]: xbps-src: don't export CCACHE_COMPRESS=1
Date: Sun, 20 Nov 2022 18:58:13 +0100	[thread overview]
Message-ID: <20221120175813.I-zWTW_dRWbM0KrjNQfDLBd62NHNXQ9IvIOx-4PzmDs@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-38986@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1826 bytes --]

There's a closed pull request on the void-packages repository

xbps-src: don't export CCACHE_COMPRESS=1
https://github.com/void-linux/void-packages/pull/38986

Description:
ccache enables compression by default since version 4.0.
This variable is redundant and prevents disabling compression through
a config file (useful e.g. on compressed filesystems).


AFAIK there's no way to disable compression when `CCACHE_COMPRESS` is present, since the environment has the highest precedence, according to the manual:

```
The priorities of configuration options are as follows (where 1 is highest):

 1. Environment variables.

 2. The primary (cache-specific) configuration file (see below).

 3. The secondary (system-wide read-only) configuration file
     <sysconfdir>/ccache.conf (typically /etc/ccache.conf or
     /usr/local/etc/ccache.conf).

 5. Compile-time defaults.
```

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


      parent reply	other threads:[~2022-11-20 17:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-30 16:57 [PR PATCH] " r-ricci
2022-08-31 12:47 ` [PR REVIEW] " sgn
2022-08-31 13:30 ` r-ricci
2022-08-31 14:03 ` [PR PATCH] [Updated] " r-ricci
2022-11-20 17:58 ` r-ricci [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221120175813.I-zWTW_dRWbM0KrjNQfDLBd62NHNXQ9IvIOx-4PzmDs@z \
    --to=r-ricci@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).