Github messages for voidlinux
 help / color / mirror / Atom feed
From: r-ricci <r-ricci@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: xbps-src: don't export CCACHE_COMPRESS=1
Date: Wed, 31 Aug 2022 15:30:04 +0200	[thread overview]
Message-ID: <20220831133004.uOzlwL1WL8FRz4SPGMQ1YSce5gpipPXL0mUVaqvvACQ@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-38986@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 516 bytes --]

New comment by r-ricci on void-packages repository

https://github.com/void-linux/void-packages/pull/38986#issuecomment-1232941831

Comment:
> Disable ccache compression is NOT nice.

This PR doesn't disable compression. As I said, ccache enables compression by default [since version 4.0](https://ccache.dev/releasenotes.html#_ccache_4_0).
Even if you want ccache to perform compression, this variable is redundant.
Removing it changes nothing unless you add `compression = false` to `hostdir/ccache/ccache.conf`.


  parent reply	other threads:[~2022-08-31 13:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-30 16:57 [PR PATCH] " r-ricci
2022-08-31 12:47 ` [PR REVIEW] " sgn
2022-08-31 13:30 ` r-ricci [this message]
2022-08-31 14:03 ` [PR PATCH] [Updated] " r-ricci
2022-11-20 17:58 ` [PR PATCH] [Closed]: " r-ricci

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220831133004.uOzlwL1WL8FRz4SPGMQ1YSce5gpipPXL0mUVaqvvACQ@z \
    --to=r-ricci@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).