* [PR PATCH] doomretro: recompile with newer SDL2
@ 2022-11-27 12:19 meator
2022-11-27 12:21 ` meator
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: meator @ 2022-11-27 12:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 586 bytes --]
There is a new pull request by meator against master on the void-packages repository
https://github.com/meator/void-packages doomretro
https://github.com/void-linux/void-packages/pull/40800
doomretro: recompile with newer SDL2
<!-- Uncomment relevant sections and delete options which are not applicable -->
The current version fails with:
```
The wrong version of SDL2.so was found. DOOM Retro requires v2.24.0.
```
#### Testing the changes
- I tested the changes in this PR: **YES**
A patch file from https://github.com/void-linux/void-packages/pull/40800.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-doomretro-40800.patch --]
[-- Type: text/x-diff, Size: 667 bytes --]
From 5d318a847dbb81978412163636d0290c6aaefa10 Mon Sep 17 00:00:00 2001
From: meator <meator.dev@gmail.com>
Date: Sun, 27 Nov 2022 13:15:25 +0100
Subject: [PATCH] doomretro: recompile with newer SDL2
---
srcpkgs/doomretro/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/doomretro/template b/srcpkgs/doomretro/template
index d2c5f76f2ac9..722ea79bcf01 100644
--- a/srcpkgs/doomretro/template
+++ b/srcpkgs/doomretro/template
@@ -1,7 +1,7 @@
# Template file for 'doomretro'
pkgname=doomretro
version=4.6.2
-revision=2
+revision=3
build_style=cmake
hostmakedepends="pkg-config"
makedepends="SDL2_image-devel SDL2_mixer-devel"
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: doomretro: recompile with newer SDL2
2022-11-27 12:19 [PR PATCH] doomretro: recompile with newer SDL2 meator
@ 2022-11-27 12:21 ` meator
2022-11-27 14:11 ` benalb
2022-11-27 16:15 ` [PR PATCH] [Merged]: " classabbyamp
2 siblings, 0 replies; 9+ messages in thread
From: meator @ 2022-11-27 12:21 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 165 bytes --]
New comment by meator on void-packages repository
https://github.com/void-linux/void-packages/pull/40800#issuecomment-1328235185
Comment:
@benalb ping maintainer.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: doomretro: recompile with newer SDL2
2022-11-27 12:19 [PR PATCH] doomretro: recompile with newer SDL2 meator
2022-11-27 12:21 ` meator
@ 2022-11-27 14:11 ` benalb
2022-11-27 16:15 ` [PR PATCH] [Merged]: " classabbyamp
2 siblings, 0 replies; 9+ messages in thread
From: benalb @ 2022-11-27 14:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 158 bytes --]
New comment by benalb on void-packages repository
https://github.com/void-linux/void-packages/pull/40800#issuecomment-1328255591
Comment:
LGTM. Thank you.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Merged]: doomretro: recompile with newer SDL2
2022-11-27 12:19 [PR PATCH] doomretro: recompile with newer SDL2 meator
2022-11-27 12:21 ` meator
2022-11-27 14:11 ` benalb
@ 2022-11-27 16:15 ` classabbyamp
2 siblings, 0 replies; 9+ messages in thread
From: classabbyamp @ 2022-11-27 16:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 435 bytes --]
There's a merged pull request on the void-packages repository
doomretro: recompile with newer SDL2
https://github.com/void-linux/void-packages/pull/40800
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
The current version fails with:
```
The wrong version of SDL2.so was found. DOOM Retro requires v2.24.0.
```
#### Testing the changes
- I tested the changes in this PR: **YES**
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: doomretro: recompile with newer SDL2
2024-03-24 19:11 [PR PATCH] " meator
` (3 preceding siblings ...)
2024-03-24 19:34 ` Jjp137
@ 2024-03-24 19:41 ` meator
4 siblings, 0 replies; 9+ messages in thread
From: meator @ 2024-03-24 19:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 252 bytes --]
New comment by meator on void-packages repository
https://github.com/void-linux/void-packages/pull/49508#issuecomment-2016922049
Comment:
A comment to `srcpkgs/SDL2/template` could be added to state that `doomretro` should be updated alongside SDL2.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: doomretro: recompile with newer SDL2
2024-03-24 19:11 [PR PATCH] " meator
` (2 preceding siblings ...)
2024-03-24 19:28 ` Jjp137
@ 2024-03-24 19:34 ` Jjp137
2024-03-24 19:41 ` meator
4 siblings, 0 replies; 9+ messages in thread
From: Jjp137 @ 2024-03-24 19:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 527 bytes --]
New comment by Jjp137 on void-packages repository
https://github.com/void-linux/void-packages/pull/49508#issuecomment-2016914776
Comment:
Same here
For future reference, Doom Retro refuses to start if the minor version of the SDL2 libraries it was complied with doesn't match what it is being linked with, so every time an SDL2 library gets a minor update, doomretro will need to be revbumped.
For example, see: https://github.com/bradharding/doomretro/blob/c8dd4139ac87ed01064ff9faffa005cdfbb87901/src/v_video.c#L1740
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: doomretro: recompile with newer SDL2
2024-03-24 19:11 [PR PATCH] " meator
2024-03-24 19:11 ` meator
2024-03-24 19:26 ` AnInternetTroll
@ 2024-03-24 19:28 ` Jjp137
2024-03-24 19:34 ` Jjp137
2024-03-24 19:41 ` meator
4 siblings, 0 replies; 9+ messages in thread
From: Jjp137 @ 2024-03-24 19:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 150 bytes --]
New comment by Jjp137 on void-packages repository
https://github.com/void-linux/void-packages/pull/49508#issuecomment-2016914776
Comment:
Same here
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: doomretro: recompile with newer SDL2
2024-03-24 19:11 [PR PATCH] " meator
2024-03-24 19:11 ` meator
@ 2024-03-24 19:26 ` AnInternetTroll
2024-03-24 19:28 ` Jjp137
` (2 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: AnInternetTroll @ 2024-03-24 19:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 228 bytes --]
New comment by AnInternetTroll on void-packages repository
https://github.com/void-linux/void-packages/pull/49508#issuecomment-2016914334
Comment:
Tested on x86_64-glibc with Ultimate Doom from Steam and it works as expected
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: doomretro: recompile with newer SDL2
2024-03-24 19:11 [PR PATCH] " meator
@ 2024-03-24 19:11 ` meator
2024-03-24 19:26 ` AnInternetTroll
` (3 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: meator @ 2024-03-24 19:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 166 bytes --]
New comment by meator on void-packages repository
https://github.com/void-linux/void-packages/pull/49508#issuecomment-2016910789
Comment:
Ping maintainer: @benalb
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2024-03-24 19:41 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-27 12:19 [PR PATCH] doomretro: recompile with newer SDL2 meator
2022-11-27 12:21 ` meator
2022-11-27 14:11 ` benalb
2022-11-27 16:15 ` [PR PATCH] [Merged]: " classabbyamp
2024-03-24 19:11 [PR PATCH] " meator
2024-03-24 19:11 ` meator
2024-03-24 19:26 ` AnInternetTroll
2024-03-24 19:28 ` Jjp137
2024-03-24 19:34 ` Jjp137
2024-03-24 19:41 ` meator
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).