[PR PATCH] cargo-deny: update to 0.13.5.

[PR PATCH] cargo-deny: update to 0.13.5.

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 1238 bytes --]

There is a new pull request by jcgruenhage against master on the void-packages repository

https://github.com/jcgruenhage/void-packages cargo-deny-0.13.5_1
https://github.com/void-linux/void-packages/pull/40792

cargo-deny: update to 0.13.5.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/40792.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cargo-deny-0.13.5_1-40792.patch --]
[-- Type: text/x-diff, Size: 1802 bytes --]

From 256b485c44f32bd710189874efdcc8d934521ee1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
 <jan.christian@gruenhage.xyz>
Date: Sun, 27 Nov 2022 10:24:54 +0100
Subject: [PATCH] cargo-deny: update to 0.13.5.

---
 srcpkgs/cargo-deny/template | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/cargo-deny/template b/srcpkgs/cargo-deny/template
index ec8ad592b9c6..0ab79398c265 100644
--- a/srcpkgs/cargo-deny/template
+++ b/srcpkgs/cargo-deny/template
@@ -1,23 +1,32 @@
 # Template file for 'cargo-deny'
 pkgname=cargo-deny
-version=0.12.2
+version=0.13.5
 revision=1
+_adv_commit="222ccf84ef7d733a6eac71f694a5e14b4d0d0289"
 build_style=cargo
 configure_args="--no-default-features"
 hostmakedepends="pkg-config"
 makedepends="openssl-devel"
+checkdepends="git"
 short_desc="Cargo plugin to help you manage large dependency graphs"
 maintainer="Jan Christian Grünhage <jan.christian@gruenhage.xyz>"
 license="MIT, Apache-2.0"
 homepage="https://github.com/EmbarkStudios/cargo-deny"
 changelog="https://raw.githubusercontent.com/EmbarkStudios/cargo-deny/main/CHANGELOG.md"
 distfiles="https://github.com/EmbarkStudios/cargo-deny/archive/${version}.tar.gz"
-checksum=7d8a034fe0219f8b7adc0ab25c90f7f253b4c387d7d5c8f74f6ad79f4810dc1e
+checksum=aebfff46cf510fc9a85ce0059e88792c6467f44c17dd29badce50a13af47e4f7
 
 if [ "$XBPS_TARGET_ENDIAN" = "be" ]; then
 	broken="bitvec crate unimplemented for big endian"
 fi
 
+pre_check() {
+	rm -rf tests/advisory-db/github.com-2f857891b7f43c59
+	git clone https://github.com/rustsec/advisory-db.git tests/advisory-db/github.com-2f857891b7f43c59
+	cd tests/advisory-db/github.com-2f857891b7f43c59
+	git checkout ${_adv_commit}
+}
+
 post_install() {
 	vlicense LICENSE-APACHE
 	vlicense LICENSE-MIT

Re: [PR REVIEW] cargo-deny: update to 0.13.5.

[tranzystorek-io]

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

New review comment by tranzystorek-io on void-packages repository

https://github.com/void-linux/void-packages/pull/40792#discussion_r1032899345

Comment:
We should probably fetch advisory-db as a distfile

Re: [PR REVIEW] cargo-deny: update to 0.13.5.

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

New review comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/40792#discussion_r1032899461

Comment:
Doesn't work, it wants a git checkout for the tests

Re: [PR REVIEW] cargo-deny: update to 0.13.5.

[tranzystorek-io]

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

New review comment by tranzystorek-io on void-packages repository

https://github.com/void-linux/void-packages/pull/40792#discussion_r1032899981

Comment:
Ah, nevermind then

Re: [PR REVIEW] cargo-deny: update to 0.13.5.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 279 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/40792#discussion_r1032958021

Comment:
this probably clobbers chroot-git (#39577), can we use that instead? you'll just need to add `/usr/libexec/chroot-git` to PATH

Re: [PR PATCH] [Updated] cargo-deny: update to 0.13.5.

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 1243 bytes --]

There is an updated pull request by jcgruenhage against master on the void-packages repository

https://github.com/jcgruenhage/void-packages cargo-deny-0.13.5_1
https://github.com/void-linux/void-packages/pull/40792

cargo-deny: update to 0.13.5.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/40792.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cargo-deny-0.13.5_1-40792.patch --]
[-- Type: text/x-diff, Size: 1679 bytes --]

From 210708199d07934d375006b2155e0e7cc98ca8c2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
 <jan.christian@gruenhage.xyz>
Date: Sun, 27 Nov 2022 10:24:54 +0100
Subject: [PATCH] cargo-deny: update to 0.13.5.

---
 srcpkgs/cargo-deny/template | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/cargo-deny/template b/srcpkgs/cargo-deny/template
index ec8ad592b9c6..ab4ddbd2a051 100644
--- a/srcpkgs/cargo-deny/template
+++ b/srcpkgs/cargo-deny/template
@@ -1,7 +1,8 @@
 # Template file for 'cargo-deny'
 pkgname=cargo-deny
-version=0.12.2
+version=0.13.5
 revision=1
+_adv_commit="222ccf84ef7d733a6eac71f694a5e14b4d0d0289"
 build_style=cargo
 configure_args="--no-default-features"
 hostmakedepends="pkg-config"
@@ -12,12 +13,19 @@ license="MIT, Apache-2.0"
 homepage="https://github.com/EmbarkStudios/cargo-deny"
 changelog="https://raw.githubusercontent.com/EmbarkStudios/cargo-deny/main/CHANGELOG.md"
 distfiles="https://github.com/EmbarkStudios/cargo-deny/archive/${version}.tar.gz"
-checksum=7d8a034fe0219f8b7adc0ab25c90f7f253b4c387d7d5c8f74f6ad79f4810dc1e
+checksum=aebfff46cf510fc9a85ce0059e88792c6467f44c17dd29badce50a13af47e4f7
 
 if [ "$XBPS_TARGET_ENDIAN" = "be" ]; then
 	broken="bitvec crate unimplemented for big endian"
 fi
 
+pre_check() {
+	rm -rf tests/advisory-db/github.com-2f857891b7f43c59
+	/usr/libexec/chroot-git/git clone https://github.com/rustsec/advisory-db.git tests/advisory-db/github.com-2f857891b7f43c59
+	cd tests/advisory-db/github.com-2f857891b7f43c59
+	/usr/libexec/chroot-git/git checkout ${_adv_commit}
+}
+
 post_install() {
 	vlicense LICENSE-APACHE
 	vlicense LICENSE-MIT

Re: [PR REVIEW] cargo-deny: update to 0.13.5.

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 212 bytes --]

New review comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/40792#discussion_r1032959928

Comment:
This probably also applies to python3-GitPython then, right?

Re: [PR REVIEW] cargo-deny: update to 0.13.5.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/40792#discussion_r1032960155

Comment:
and probably a bunch of other things too :)

Re: [PR REVIEW] cargo-deny: update to 0.13.5.

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 372 bytes --]

New review comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/40792#discussion_r1032963711

Comment:
yay. In that case, wouldn't it make more sense to fix it on a lower level anyway? Knowing that you have to get certain tools from certain other paths is increasing the barrier-to-entry for new maintainers quite a bit IMO

Re: [PR REVIEW] cargo-deny: update to 0.13.5.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 262 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/40792#discussion_r1032963865

Comment:
yes, it does need a lower-level fix (as discussed in the issue) but we shouldn't break things in the meantime

Re: [PR REVIEW] cargo-deny: update to 0.13.5.

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

New review comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/40792#discussion_r1032970310

Comment:
Agreed, which is why I adjusted this to not require `git` in `checkdepends` for now. I'll mark this as resolved.

Re: [PR PATCH] [Merged]: cargo-deny: update to 0.13.5.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 1067 bytes --]

There's a merged pull request on the void-packages repository

cargo-deny: update to 0.13.5.
https://github.com/void-linux/void-packages/pull/40792

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->