* Re: [PR REVIEW] New package: libdrm-tests-2.4.113
2022-11-27 21:24 [PR PATCH] New package: libdrm-tests-2.4.113 MarijnS95
@ 2022-11-28 21:29 ` classabbyamp
2022-11-28 21:29 ` classabbyamp
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: classabbyamp @ 2022-11-28 21:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 216 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/40813#discussion_r1034065884
Comment:
won't be built unless revbumped
```suggestion
revision=2
```
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR REVIEW] New package: libdrm-tests-2.4.113
2022-11-27 21:24 [PR PATCH] New package: libdrm-tests-2.4.113 MarijnS95
2022-11-28 21:29 ` [PR REVIEW] " classabbyamp
@ 2022-11-28 21:29 ` classabbyamp
2022-11-28 22:25 ` MarijnS95
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: classabbyamp @ 2022-11-28 21:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 271 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/40813#discussion_r1034065653
Comment:
maybe let's call it `libdrm-test-progs`, because they're programs to test the sw, not the test suite of libdrm, right?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR REVIEW] New package: libdrm-tests-2.4.113
2022-11-27 21:24 [PR PATCH] New package: libdrm-tests-2.4.113 MarijnS95
2022-11-28 21:29 ` [PR REVIEW] " classabbyamp
2022-11-28 21:29 ` classabbyamp
@ 2022-11-28 22:25 ` MarijnS95
2022-11-28 22:26 ` MarijnS95
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: MarijnS95 @ 2022-11-28 22:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 409 bytes --]
New review comment by MarijnS95 on void-packages repository
https://github.com/void-linux/void-packages/pull/40813#discussion_r1034113458
Comment:
Right, I wasn't sure if adding a new subpackage would have an effect here, since there are two different targets and the contents of the base package do not change. It would still have to build that though, in order to generate contents for the new subpackge.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR REVIEW] New package: libdrm-tests-2.4.113
2022-11-27 21:24 [PR PATCH] New package: libdrm-tests-2.4.113 MarijnS95
` (2 preceding siblings ...)
2022-11-28 22:25 ` MarijnS95
@ 2022-11-28 22:26 ` MarijnS95
2022-11-28 22:36 ` classabbyamp
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: MarijnS95 @ 2022-11-28 22:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 546 bytes --]
New review comment by MarijnS95 on void-packages repository
https://github.com/void-linux/void-packages/pull/40813#discussion_r1034114275
Comment:
This was based on https://packages.debian.org/sid/arm64/libdrm-tests/filelist, but you are correct that these are programs to test (rather, poke around) at the kernel software and underlying hardware, not tests that validate the contents/implementation of `libdrm` (in an isolated manner).
Can rename this if `test-progs` is desired, that is after all how the `meson` config property is named.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR REVIEW] New package: libdrm-tests-2.4.113
2022-11-27 21:24 [PR PATCH] New package: libdrm-tests-2.4.113 MarijnS95
` (3 preceding siblings ...)
2022-11-28 22:26 ` MarijnS95
@ 2022-11-28 22:36 ` classabbyamp
2022-11-28 23:03 ` [PR PATCH] [Updated] " MarijnS95
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: classabbyamp @ 2022-11-28 22:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 272 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/40813#discussion_r1034120718
Comment:
they aren't really targets but split destinations for files, subpackages can only be built if the main package is built
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Updated] New package: libdrm-tests-2.4.113
2022-11-27 21:24 [PR PATCH] New package: libdrm-tests-2.4.113 MarijnS95
` (4 preceding siblings ...)
2022-11-28 22:36 ` classabbyamp
@ 2022-11-28 23:03 ` MarijnS95
2022-11-28 23:04 ` MarijnS95
2022-12-03 17:54 ` [PR PATCH] [Merged]: New package: libdrm-test-progs-2.4.113 sgn
7 siblings, 0 replies; 9+ messages in thread
From: MarijnS95 @ 2022-11-28 23:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1241 bytes --]
There is an updated pull request by MarijnS95 against master on the void-packages repository
https://github.com/MarijnS95/void-packages libdrm-tests
https://github.com/void-linux/void-packages/pull/40813
New package: libdrm-tests-2.4.113
libdrm provides a couple useful progams for printing, testing and validating KMS implementations; include these utilities in a new libdrm-tests package.
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
CC @JamiKettunen
A patch file from https://github.com/void-linux/void-packages/pull/40813.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libdrm-tests-40813.patch --]
[-- Type: text/x-diff, Size: 2018 bytes --]
From 874e7ea1eb1f66c0e9886cbdddb0eaee283d688a Mon Sep 17 00:00:00 2001
From: Marijn Suijten <marijn.suijten@somainline.org>
Date: Sun, 27 Nov 2022 22:19:42 +0100
Subject: [PATCH] New package: libdrm-tests-2.4.113
libdrm provides a couple useful progams for printing, testing and
validating KMS implementations; include these utilities in a new
libdrm-tests package.
---
common/shlibs | 1 +
srcpkgs/libdrm-test-progs | 1 +
srcpkgs/libdrm/template | 12 ++++++++++--
3 files changed, 12 insertions(+), 2 deletions(-)
create mode 120000 srcpkgs/libdrm-test-progs
diff --git a/common/shlibs b/common/shlibs
index fc5bb4dda7e6..9e505aedee74 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -288,6 +288,7 @@ libdrm_intel.so.1 libdrm-2.4.6_1
libdrm_nouveau.so.2 libdrm-2.4.34_1
libdrm_amdgpu.so.1 libdrm-2.4.64_1
libdrm_freedreno.so.1 libdrm-2.4.97_1
+libdrm_etnaviv.so.1 libdrm-2.4.113_2
libXxf86vm.so.1 libXxf86vm-1.0.2_1
libXi.so.6 libXi-1.2.1_1
libdmx.so.1 libdmx-1.0.2_1
diff --git a/srcpkgs/libdrm-test-progs b/srcpkgs/libdrm-test-progs
new file mode 120000
index 000000000000..65c590a735d2
--- /dev/null
+++ b/srcpkgs/libdrm-test-progs
@@ -0,0 +1 @@
+libdrm
\ No newline at end of file
diff --git a/srcpkgs/libdrm/template b/srcpkgs/libdrm/template
index 4efe3b627f8a..6c08ab0096f0 100644
--- a/srcpkgs/libdrm/template
+++ b/srcpkgs/libdrm/template
@@ -1,9 +1,9 @@
# Template file for 'libdrm'
pkgname=libdrm
version=2.4.113
-revision=1
+revision=2
build_style=meson
-configure_args="-Dudev=true -Dvalgrind=disabled"
+configure_args="-Dudev=true -Dvalgrind=disabled -Dinstall-test-programs=true"
hostmakedepends="pkg-config python3-docutils"
makedepends="eudev-libudev-devel libpciaccess-devel"
short_desc="Userspace interface to kernel DRM services"
@@ -32,3 +32,11 @@ libdrm-devel_package() {
vmove "usr/lib/*.so"
}
}
+
+libdrm-test-progs_package() {
+ depends="${sourcepkg}-${version}_${revision}"
+ short_desc+=" - test programs"
+ pkg_install() {
+ vmove usr/bin
+ }
+}
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Updated] New package: libdrm-tests-2.4.113
2022-11-27 21:24 [PR PATCH] New package: libdrm-tests-2.4.113 MarijnS95
` (5 preceding siblings ...)
2022-11-28 23:03 ` [PR PATCH] [Updated] " MarijnS95
@ 2022-11-28 23:04 ` MarijnS95
2022-12-03 17:54 ` [PR PATCH] [Merged]: New package: libdrm-test-progs-2.4.113 sgn
7 siblings, 0 replies; 9+ messages in thread
From: MarijnS95 @ 2022-11-28 23:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1241 bytes --]
There is an updated pull request by MarijnS95 against master on the void-packages repository
https://github.com/MarijnS95/void-packages libdrm-tests
https://github.com/void-linux/void-packages/pull/40813
New package: libdrm-tests-2.4.113
libdrm provides a couple useful progams for printing, testing and validating KMS implementations; include these utilities in a new libdrm-tests package.
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
CC @JamiKettunen
A patch file from https://github.com/void-linux/void-packages/pull/40813.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libdrm-tests-40813.patch --]
[-- Type: text/x-diff, Size: 2041 bytes --]
From afebf24c05d5ac891598a616bbd62cf0101128d3 Mon Sep 17 00:00:00 2001
From: Marijn Suijten <marijn.suijten@somainline.org>
Date: Sun, 27 Nov 2022 22:19:42 +0100
Subject: [PATCH] New package: libdrm-test-progs-2.4.113
libdrm provides a couple useful progams for printing, testing and
validating KMS implementations; include these utilities in a new
libdrm-test-progs subpackage of libdrm.
---
common/shlibs | 1 +
srcpkgs/libdrm-test-progs | 1 +
srcpkgs/libdrm/template | 12 ++++++++++--
3 files changed, 12 insertions(+), 2 deletions(-)
create mode 120000 srcpkgs/libdrm-test-progs
diff --git a/common/shlibs b/common/shlibs
index fc5bb4dda7e6..9e505aedee74 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -288,6 +288,7 @@ libdrm_intel.so.1 libdrm-2.4.6_1
libdrm_nouveau.so.2 libdrm-2.4.34_1
libdrm_amdgpu.so.1 libdrm-2.4.64_1
libdrm_freedreno.so.1 libdrm-2.4.97_1
+libdrm_etnaviv.so.1 libdrm-2.4.113_2
libXxf86vm.so.1 libXxf86vm-1.0.2_1
libXi.so.6 libXi-1.2.1_1
libdmx.so.1 libdmx-1.0.2_1
diff --git a/srcpkgs/libdrm-test-progs b/srcpkgs/libdrm-test-progs
new file mode 120000
index 000000000000..65c590a735d2
--- /dev/null
+++ b/srcpkgs/libdrm-test-progs
@@ -0,0 +1 @@
+libdrm
\ No newline at end of file
diff --git a/srcpkgs/libdrm/template b/srcpkgs/libdrm/template
index 4efe3b627f8a..6c08ab0096f0 100644
--- a/srcpkgs/libdrm/template
+++ b/srcpkgs/libdrm/template
@@ -1,9 +1,9 @@
# Template file for 'libdrm'
pkgname=libdrm
version=2.4.113
-revision=1
+revision=2
build_style=meson
-configure_args="-Dudev=true -Dvalgrind=disabled"
+configure_args="-Dudev=true -Dvalgrind=disabled -Dinstall-test-programs=true"
hostmakedepends="pkg-config python3-docutils"
makedepends="eudev-libudev-devel libpciaccess-devel"
short_desc="Userspace interface to kernel DRM services"
@@ -32,3 +32,11 @@ libdrm-devel_package() {
vmove "usr/lib/*.so"
}
}
+
+libdrm-test-progs_package() {
+ depends="${sourcepkg}-${version}_${revision}"
+ short_desc+=" - test programs"
+ pkg_install() {
+ vmove usr/bin
+ }
+}
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Merged]: New package: libdrm-test-progs-2.4.113
2022-11-27 21:24 [PR PATCH] New package: libdrm-tests-2.4.113 MarijnS95
` (6 preceding siblings ...)
2022-11-28 23:04 ` MarijnS95
@ 2022-12-03 17:54 ` sgn
7 siblings, 0 replies; 9+ messages in thread
From: sgn @ 2022-12-03 17:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1119 bytes --]
There's a merged pull request on the void-packages repository
New package: libdrm-test-progs-2.4.113
https://github.com/void-linux/void-packages/pull/40813
Description:
libdrm provides a couple useful progams for printing, testing and validating KMS implementations; include these utilities in a new libdrm-test-progs subpackage of libdrm.
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
CC @JamiKettunen
^ permalink raw reply [flat|nested] 9+ messages in thread