Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] nvidia: fix restore deleted line 136
@ 2022-11-28 12:44 cmhainesii
  2022-11-28 12:51 ` cmhainesii
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: cmhainesii @ 2022-11-28 12:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 560 bytes --]

There is a new pull request by cmhainesii against master on the void-packages repository

https://github.com/cmhainesii/void-packages nvidia_restore_line136
https://github.com/void-linux/void-packages/pull/40820

nvidia: fix restore deleted line 136
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: YES
- I built this PR locally for my native architecture, x86_64 glibc


A patch file from https://github.com/void-linux/void-packages/pull/40820.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nvidia_restore_line136-40820.patch --]
[-- Type: text/x-diff, Size: 995 bytes --]

From 0da3641c41f87d684f5ca846277cc253d3f49dbe Mon Sep 17 00:00:00 2001
From: Chuck Haines <charlesmhainesii@gmail.com>
Date: Mon, 28 Nov 2022 07:39:40 -0500
Subject: [PATCH] nvidia: fix restore deleted line 136

---
 srcpkgs/nvidia/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/nvidia/template b/srcpkgs/nvidia/template
index 82fa88ed53ce..c8f5dbc937f0 100644
--- a/srcpkgs/nvidia/template
+++ b/srcpkgs/nvidia/template
@@ -4,7 +4,7 @@ _desc="NVIDIA drivers for linux"
 
 pkgname=nvidia
 version=515.86.01
-revision=2
+revision=3
 maintainer="Andrew Benson <abenson+void@gmail.com>"
 license="custom:NVIDIA Proprietary"
 homepage="https://www.nvidia.com/en-us/drivers/unix/"
@@ -133,6 +133,7 @@ do_install() {
 	ln -sf libnvidia-egl-gbm.so.1.1.0 \
 		${DESTDIR}/usr/lib/libnvidia-egl-gbm.so.1
 
+	vmkdir usr/share/glvnd/egl_vendor.d
 	vmkdir usr/share/egl/egl_external_platform.d
 	vinstall 15_nvidia_gbm.json 755 usr/share/egl/egl_external_platform.d
 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: nvidia: fix restore deleted line 136
  2022-11-28 12:44 [PR PATCH] nvidia: fix restore deleted line 136 cmhainesii
@ 2022-11-28 12:51 ` cmhainesii
  2022-11-28 12:51 ` cmhainesii
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: cmhainesii @ 2022-11-28 12:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 236 bytes --]

New comment by cmhainesii on void-packages repository

https://github.com/void-linux/void-packages/pull/40820#issuecomment-1329036135

Comment:
I inadvertently deleted a vmkdir on line 136 in my previous commit that is still necessary.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: nvidia: fix restore deleted line 136
  2022-11-28 12:44 [PR PATCH] nvidia: fix restore deleted line 136 cmhainesii
  2022-11-28 12:51 ` cmhainesii
@ 2022-11-28 12:51 ` cmhainesii
  2022-11-28 12:54 ` kruceter
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: cmhainesii @ 2022-11-28 12:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

New comment by cmhainesii on void-packages repository

https://github.com/void-linux/void-packages/pull/40820#issuecomment-1329036135

Comment:
I inadvertently deleted a vmkdir on line 136 of the template in my previous commit that is still necessary.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: nvidia: fix restore deleted line 136
  2022-11-28 12:44 [PR PATCH] nvidia: fix restore deleted line 136 cmhainesii
  2022-11-28 12:51 ` cmhainesii
  2022-11-28 12:51 ` cmhainesii
@ 2022-11-28 12:54 ` kruceter
  2022-11-28 14:03 ` ahesford
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: kruceter @ 2022-11-28 12:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 155 bytes --]

New comment by kruceter on void-packages repository

https://github.com/void-linux/void-packages/pull/40820#issuecomment-1329044105

Comment:
cc: @abenson

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: nvidia: fix restore deleted line 136
  2022-11-28 12:44 [PR PATCH] nvidia: fix restore deleted line 136 cmhainesii
                   ` (2 preceding siblings ...)
  2022-11-28 12:54 ` kruceter
@ 2022-11-28 14:03 ` ahesford
  2022-11-29  0:13 ` nvidia: restore usr/share/glvnd/egl_vendor.d abenson
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: ahesford @ 2022-11-28 14:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 269 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/40820#issuecomment-1329161351

Comment:
A commit message like "nvidia:  restore usr/share/glvnd/egl_vendor.d" is more informative than "fix restore deleted line 136".

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: nvidia: restore usr/share/glvnd/egl_vendor.d
  2022-11-28 12:44 [PR PATCH] nvidia: fix restore deleted line 136 cmhainesii
                   ` (3 preceding siblings ...)
  2022-11-28 14:03 ` ahesford
@ 2022-11-29  0:13 ` abenson
  2022-11-29 11:43 ` [PR PATCH] [Updated] " cmhainesii
  2022-11-29 19:45 ` [PR PATCH] [Merged]: " abenson
  6 siblings, 0 replies; 8+ messages in thread
From: abenson @ 2022-11-29  0:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 337 bytes --]

New comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/40820#issuecomment-1329909230

Comment:
You need to edit the actual commit message, not the PR title.

    $ git commit --amend

Change the message, save, and quit.  Then force push your changes to this branch.

    $ git push -f

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Updated] nvidia: restore usr/share/glvnd/egl_vendor.d
  2022-11-28 12:44 [PR PATCH] nvidia: fix restore deleted line 136 cmhainesii
                   ` (4 preceding siblings ...)
  2022-11-29  0:13 ` nvidia: restore usr/share/glvnd/egl_vendor.d abenson
@ 2022-11-29 11:43 ` cmhainesii
  2022-11-29 19:45 ` [PR PATCH] [Merged]: " abenson
  6 siblings, 0 replies; 8+ messages in thread
From: cmhainesii @ 2022-11-29 11:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 573 bytes --]

There is an updated pull request by cmhainesii against master on the void-packages repository

https://github.com/cmhainesii/void-packages nvidia_restore_line136
https://github.com/void-linux/void-packages/pull/40820

nvidia: restore usr/share/glvnd/egl_vendor.d
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: YES
- I built this PR locally for my native architecture, x86_64 glibc


A patch file from https://github.com/void-linux/void-packages/pull/40820.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nvidia_restore_line136-40820.patch --]
[-- Type: text/x-diff, Size: 1003 bytes --]

From 2f95659150f2c11b4fc7fe86ce35ed08f223c54e Mon Sep 17 00:00:00 2001
From: Chuck Haines <charlesmhainesii@gmail.com>
Date: Mon, 28 Nov 2022 07:39:40 -0500
Subject: [PATCH] nvidia: restore usr/share/glvnd/egl_vendor.d

---
 srcpkgs/nvidia/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/nvidia/template b/srcpkgs/nvidia/template
index 82fa88ed53ce..c8f5dbc937f0 100644
--- a/srcpkgs/nvidia/template
+++ b/srcpkgs/nvidia/template
@@ -4,7 +4,7 @@ _desc="NVIDIA drivers for linux"
 
 pkgname=nvidia
 version=515.86.01
-revision=2
+revision=3
 maintainer="Andrew Benson <abenson+void@gmail.com>"
 license="custom:NVIDIA Proprietary"
 homepage="https://www.nvidia.com/en-us/drivers/unix/"
@@ -133,6 +133,7 @@ do_install() {
 	ln -sf libnvidia-egl-gbm.so.1.1.0 \
 		${DESTDIR}/usr/lib/libnvidia-egl-gbm.so.1
 
+	vmkdir usr/share/glvnd/egl_vendor.d
 	vmkdir usr/share/egl/egl_external_platform.d
 	vinstall 15_nvidia_gbm.json 755 usr/share/egl/egl_external_platform.d
 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Merged]: nvidia: restore usr/share/glvnd/egl_vendor.d
  2022-11-28 12:44 [PR PATCH] nvidia: fix restore deleted line 136 cmhainesii
                   ` (5 preceding siblings ...)
  2022-11-29 11:43 ` [PR PATCH] [Updated] " cmhainesii
@ 2022-11-29 19:45 ` abenson
  6 siblings, 0 replies; 8+ messages in thread
From: abenson @ 2022-11-29 19:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 396 bytes --]

There's a merged pull request on the void-packages repository

nvidia: restore usr/share/glvnd/egl_vendor.d
https://github.com/void-linux/void-packages/pull/40820

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: YES
- I built this PR locally for my native architecture, x86_64 glibc


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-11-29 19:45 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-28 12:44 [PR PATCH] nvidia: fix restore deleted line 136 cmhainesii
2022-11-28 12:51 ` cmhainesii
2022-11-28 12:51 ` cmhainesii
2022-11-28 12:54 ` kruceter
2022-11-28 14:03 ` ahesford
2022-11-29  0:13 ` nvidia: restore usr/share/glvnd/egl_vendor.d abenson
2022-11-29 11:43 ` [PR PATCH] [Updated] " cmhainesii
2022-11-29 19:45 ` [PR PATCH] [Merged]: " abenson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).