[PR PATCH] i2pd: add vlogger

[PR PATCH] i2pd: add vlogger

[steinex]

[-- Attachment #1: Type: text/plain, Size: 1245 bytes --]

There is a new pull request by steinex against master on the void-packages repository

https://github.com/steinex/void-packages i2pd
https://github.com/void-linux/void-packages/pull/40926

i2pd: add vlogger
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/40926.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-i2pd-40926.patch --]
[-- Type: text/x-diff, Size: 994 bytes --]

From 9c1879f5f0fd8304d2f802b7f0d92cbb978bffd1 Mon Sep 17 00:00:00 2001
From: Frank Steinborn <steinex@nognu.de>
Date: Tue, 6 Dec 2022 11:09:17 +0100
Subject: [PATCH] i2pd: add vlogger

---
 srcpkgs/i2pd/files/i2pd/log/run | 1 +
 srcpkgs/i2pd/template           | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
 create mode 120000 srcpkgs/i2pd/files/i2pd/log/run

diff --git a/srcpkgs/i2pd/files/i2pd/log/run b/srcpkgs/i2pd/files/i2pd/log/run
new file mode 120000
index 000000000000..282a06461da7
--- /dev/null
+++ b/srcpkgs/i2pd/files/i2pd/log/run
@@ -0,0 +1 @@
+/usr/sbin/vlogger
\ No newline at end of file
diff --git a/srcpkgs/i2pd/template b/srcpkgs/i2pd/template
index 239f4b7cd63f..eed1dc68d531 100644
--- a/srcpkgs/i2pd/template
+++ b/srcpkgs/i2pd/template
@@ -1,7 +1,7 @@
 # Template file for 'i2pd'
 pkgname=i2pd
 version=2.44.0
-revision=1
+revision=2
 build_style=gnu-makefile
 make_build_args="USE_UPNP=yes"
 makedepends="zlib-devel boost-devel openssl-devel miniupnpc-devel

Re: [PR REVIEW] i2pd: add vlogger

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

New review comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/40926#discussion_r1041614379

Comment:
please align with how other `log/run` use `vlogger`

Re: i2pd: add vlogger

[daniel-eys]

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

New comment by daniel-eys on void-packages repository

https://github.com/void-linux/void-packages/pull/40926#issuecomment-1345262974

Comment:
`pre_install()` can be removed then

Re: [PR PATCH] [Updated] i2pd: add vlogger

[steinex]

[-- Attachment #1: Type: text/plain, Size: 1231 bytes --]

There is an updated pull request by steinex against master on the void-packages repository

https://github.com/steinex/void-packages i2pd
https://github.com/void-linux/void-packages/pull/40926

i2pd: add vlogger
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/40926.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-i2pd-40926.patch --]
[-- Type: text/x-diff, Size: 1312 bytes --]

From 2b239646792bb752cbd8fa5b6282d113520afc72 Mon Sep 17 00:00:00 2001
From: Frank Steinborn <steinex@nognu.de>
Date: Tue, 6 Dec 2022 11:09:17 +0100
Subject: [PATCH] i2pd: add vlogger

---
 srcpkgs/i2pd/files/i2pd/log/run | 1 +
 srcpkgs/i2pd/template           | 9 +--------
 2 files changed, 2 insertions(+), 8 deletions(-)
 create mode 120000 srcpkgs/i2pd/files/i2pd/log/run

diff --git a/srcpkgs/i2pd/files/i2pd/log/run b/srcpkgs/i2pd/files/i2pd/log/run
new file mode 120000
index 000000000000..282a06461da7
--- /dev/null
+++ b/srcpkgs/i2pd/files/i2pd/log/run
@@ -0,0 +1 @@
+/usr/sbin/vlogger
\ No newline at end of file
diff --git a/srcpkgs/i2pd/template b/srcpkgs/i2pd/template
index 239f4b7cd63f..5f99040c599a 100644
--- a/srcpkgs/i2pd/template
+++ b/srcpkgs/i2pd/template
@@ -1,7 +1,7 @@
 # Template file for 'i2pd'
 pkgname=i2pd
 version=2.44.0
-revision=1
+revision=2
 build_style=gnu-makefile
 make_build_args="USE_UPNP=yes"
 makedepends="zlib-devel boost-devel openssl-devel miniupnpc-devel
@@ -26,13 +26,6 @@ case "${XBPS_TARGET_MACHINE}" in
 	*) make_build_args+=" USE_AESNI=no" ;;
 esac
 
-pre_install() {
-	# Log errors to syslog
-	vsed -e "s/^# log = .*/log = syslog/" \
-		-e "s/^# loglevel = .*/loglevel = error/" \
-		-i contrib/i2pd.conf
-}
-
 do_install() {
 	vbin i2pd
 	vman debian/i2pd.1

Re: [PR REVIEW] i2pd: add vlogger

[steinex]

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

New review comment by steinex on void-packages repository

https://github.com/void-linux/void-packages/pull/40926#discussion_r1045130371

Comment:
It's a symlink, I thought thats how it's supposed to be these days? Did I miss something?

Re: [PR REVIEW] i2pd: add vlogger

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 300 bytes --]

New review comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/40926#discussion_r1045302563

Comment:
oh i missed it's a symlink.
`fd --full-path 'log/run' -l ` reveals 25% of them are just symlinks to vlogger,  all others are scripts that `exec vlogger`

Re: [PR REVIEW] i2pd: add vlogger

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/40926#discussion_r1045458315

Comment:
symlink to /usr/bin/ not /usr/sbin

Re: [PR PATCH] [Updated] i2pd: add vlogger

[steinex]

[-- Attachment #1: Type: text/plain, Size: 1231 bytes --]

There is an updated pull request by steinex against master on the void-packages repository

https://github.com/steinex/void-packages i2pd
https://github.com/void-linux/void-packages/pull/40926

i2pd: add vlogger
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/40926.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-i2pd-40926.patch --]
[-- Type: text/x-diff, Size: 1311 bytes --]

From d689d9fc37a7247e2ea8b2bfe8b6434f57fe9ad0 Mon Sep 17 00:00:00 2001
From: Frank Steinborn <steinex@nognu.de>
Date: Tue, 6 Dec 2022 11:09:17 +0100
Subject: [PATCH] i2pd: add vlogger

---
 srcpkgs/i2pd/files/i2pd/log/run | 1 +
 srcpkgs/i2pd/template           | 9 +--------
 2 files changed, 2 insertions(+), 8 deletions(-)
 create mode 120000 srcpkgs/i2pd/files/i2pd/log/run

diff --git a/srcpkgs/i2pd/files/i2pd/log/run b/srcpkgs/i2pd/files/i2pd/log/run
new file mode 120000
index 000000000000..3a5b4a586051
--- /dev/null
+++ b/srcpkgs/i2pd/files/i2pd/log/run
@@ -0,0 +1 @@
+/usr/bin/vlogger
\ No newline at end of file
diff --git a/srcpkgs/i2pd/template b/srcpkgs/i2pd/template
index 239f4b7cd63f..5f99040c599a 100644
--- a/srcpkgs/i2pd/template
+++ b/srcpkgs/i2pd/template
@@ -1,7 +1,7 @@
 # Template file for 'i2pd'
 pkgname=i2pd
 version=2.44.0
-revision=1
+revision=2
 build_style=gnu-makefile
 make_build_args="USE_UPNP=yes"
 makedepends="zlib-devel boost-devel openssl-devel miniupnpc-devel
@@ -26,13 +26,6 @@ case "${XBPS_TARGET_MACHINE}" in
 	*) make_build_args+=" USE_AESNI=no" ;;
 esac
 
-pre_install() {
-	# Log errors to syslog
-	vsed -e "s/^# log = .*/log = syslog/" \
-		-e "s/^# loglevel = .*/loglevel = error/" \
-		-i contrib/i2pd.conf
-}
-
 do_install() {
 	vbin i2pd
 	vman debian/i2pd.1

Re: [PR REVIEW] i2pd: add vlogger

[steinex]

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

New review comment by steinex on void-packages repository

https://github.com/void-linux/void-packages/pull/40926#discussion_r1045461316

Comment:
I think we have it now. I'm sorry for the confusion. ;)

Re: [PR PATCH] [Merged]: i2pd: add vlogger

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 1078 bytes --]

There's a merged pull request on the void-packages repository

i2pd: add vlogger
https://github.com/void-linux/void-packages/pull/40926

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->