Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] mitmproxy: fix for python 3.11
@ 2022-12-29 17:39 tornaria
  2022-12-29 18:54 ` icp1994
  2022-12-31  0:59 ` [PR PATCH] [Closed]: " sgn
  0 siblings, 2 replies; 3+ messages in thread
From: tornaria @ 2022-12-29 17:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1483 bytes --]

There is a new pull request by tornaria against master on the void-packages repository

https://github.com/tornaria/void-packages mitmproxy
https://github.com/void-linux/void-packages/pull/41348

mitmproxy: fix for python 3.11
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

Without this patch, mitmproxy doesn't even start. I also disabled two tests that are broken with python 3.11.

Upgrading to 9.0.1 needs https://github.com/decathorpe/mitmproxy_wireguard which is a python module written in rust.

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/41348.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mitmproxy-41348.patch --]
[-- Type: text/x-diff, Size: 1959 bytes --]

From 61a97bd60e4358940a962b8288f05f61df497bb3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Thu, 29 Dec 2022 14:03:19 -0300
Subject: [PATCH] mitmproxy: fix for python 3.11

---
 srcpkgs/mitmproxy/patches/dataclass.patch | 11 +++++++++++
 srcpkgs/mitmproxy/template                |  6 +++++-
 2 files changed, 16 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/mitmproxy/patches/dataclass.patch

diff --git a/srcpkgs/mitmproxy/patches/dataclass.patch b/srcpkgs/mitmproxy/patches/dataclass.patch
new file mode 100644
index 000000000000..f9047df2bb1e
--- /dev/null
+++ b/srcpkgs/mitmproxy/patches/dataclass.patch
@@ -0,0 +1,11 @@
+--- a/mitmproxy/contentviews/grpc.py
++++ b/mitmproxy/contentviews/grpc.py
+@@ -951,7 +951,7 @@
+ 
+ @dataclass
+ class ViewConfig:
+-    parser_options: ProtoParser.ParserOptions = ProtoParser.ParserOptions()
++    parser_options: ProtoParser.ParserOptions = field(default_factory=ProtoParser.ParserOptions)
+     parser_rules: list[ProtoParser.ParserRule] = field(default_factory=list)
+ 
+
diff --git a/srcpkgs/mitmproxy/template b/srcpkgs/mitmproxy/template
index ea33d3571a35..07f49258cbd3 100644
--- a/srcpkgs/mitmproxy/template
+++ b/srcpkgs/mitmproxy/template
@@ -1,7 +1,7 @@
 # Template file for 'mitmproxy'
 pkgname=mitmproxy
 version=8.1.1
-revision=3
+revision=4
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3-Brotli python3-Flask python3-asgiref python3-blinker python3-certifi
@@ -21,6 +21,10 @@ checksum=212e81bec40e1d2a894d73a337f076a3010d981249e513565e9246f29822d06c
 
 _skip="(test_get_version)" # This test fails without a git repository
 
+# these two are broken in 8.1.1, possibly fixed in 9.0
+_skip+="or(test_roundtrip_big_integer)" # parses an int too large
+_skip+="or(test_onboarding.py)" # broken (?) skip the whole file
+
 if [ ${XBPS_TARGET_MACHINE%-musl} = "i686" ]; then
 	_skip+="or(test_refresh)"
 fi

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: mitmproxy: fix for python 3.11
  2022-12-29 17:39 [PR PATCH] mitmproxy: fix for python 3.11 tornaria
@ 2022-12-29 18:54 ` icp1994
  2022-12-31  0:59 ` [PR PATCH] [Closed]: " sgn
  1 sibling, 0 replies; 3+ messages in thread
From: icp1994 @ 2022-12-29 18:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

New comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/41348#issuecomment-1367521736

Comment:
https://github.com/void-linux/void-packages/pull/40343

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PR PATCH] [Closed]: mitmproxy: fix for python 3.11
  2022-12-29 17:39 [PR PATCH] mitmproxy: fix for python 3.11 tornaria
  2022-12-29 18:54 ` icp1994
@ 2022-12-31  0:59 ` sgn
  1 sibling, 0 replies; 3+ messages in thread
From: sgn @ 2022-12-31  0:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1328 bytes --]

There's a closed pull request on the void-packages repository

mitmproxy: fix for python 3.11
https://github.com/void-linux/void-packages/pull/41348

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

Without this patch, mitmproxy doesn't even start. I also disabled two tests that are broken with python 3.11.

Upgrading to 9.0.1 needs https://github.com/decathorpe/mitmproxy_wireguard which is a python module written in rust.

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-12-31  0:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-29 17:39 [PR PATCH] mitmproxy: fix for python 3.11 tornaria
2022-12-29 18:54 ` icp1994
2022-12-31  0:59 ` [PR PATCH] [Closed]: " sgn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).