* [PR PATCH] bspwm: patch windows sometimes not appearing
@ 2023-01-01 4:14 kruceter
2023-01-01 5:44 ` classabbyamp
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: kruceter @ 2023-01-01 4:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 685 bytes --]
There is a new pull request by kruceter against master on the void-packages repository
https://github.com/kruceter/void-packages bspwm
https://github.com/void-linux/void-packages/pull/41389
bspwm: patch windows sometimes not appearing
Apparently gtk-based software used to be affected by this bug.
I use this window manager as my "daily driver" with the upstream patch applied.
The issue at hand is gone far, far away.
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, x86_64-musl
A patch file from https://github.com/void-linux/void-packages/pull/41389.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-bspwm-41389.patch --]
[-- Type: text/x-diff, Size: 2123 bytes --]
From 95282842e07096da1816170b5c2030bc8c1d281b Mon Sep 17 00:00:00 2001
From: Krul Ceter <kruceter@proton.me>
Date: Thu, 29 Dec 2022 08:44:05 +0300
Subject: [PATCH] bspwm: patch windows sometimes not appearing
Apparently gtk-based software used to be affected by this bug.
---
.../patches/fix-windows-not-appearing.patch | 32 +++++++++++++++++++
srcpkgs/bspwm/template | 2 +-
2 files changed, 33 insertions(+), 1 deletion(-)
create mode 100644 srcpkgs/bspwm/patches/fix-windows-not-appearing.patch
diff --git a/srcpkgs/bspwm/patches/fix-windows-not-appearing.patch b/srcpkgs/bspwm/patches/fix-windows-not-appearing.patch
new file mode 100644
index 000000000000..1dbd87c46ba0
--- /dev/null
+++ b/srcpkgs/bspwm/patches/fix-windows-not-appearing.patch
@@ -0,0 +1,32 @@
+https://github.com/baskerville/bspwm/commit/1560df35be303807052c235634eb8d59415c37ff
+
+From 1560df35be303807052c235634eb8d59415c37ff Mon Sep 17 00:00:00 2001
+From: David Hoppenbrouwers <david@salt-inc.org>
+Date: Tue, 25 Jan 2022 00:09:42 +0100
+Subject: [PATCH] Fix windows sometimes not appearing
+
+Fixes #935.
+---
+ src/bspwm.c | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/src/bspwm.c b/src/bspwm.c
+index 9c6be76c..8b9b5d14 100644
+--- a/src/bspwm.c
++++ b/src/bspwm.c
+@@ -36,6 +36,7 @@
+ #include <stdbool.h>
+ #include <string.h>
+ #include <xcb/xinerama.h>
++#include <xcb/xcb_aux.h>
+ #include "types.h"
+ #include "desktop.h"
+ #include "monitor.h"
+@@ -248,6 +249,7 @@ int main(int argc, char *argv[])
+ }
+
+ if (FD_ISSET(dpy_fd, &descriptors)) {
++ xcb_aux_sync(dpy);
+ while ((event = xcb_poll_for_event(dpy)) != NULL) {
+ handle_event(event);
+ free(event);
diff --git a/srcpkgs/bspwm/template b/srcpkgs/bspwm/template
index c8092a46b2da..f257a820b9ae 100644
--- a/srcpkgs/bspwm/template
+++ b/srcpkgs/bspwm/template
@@ -1,7 +1,7 @@
# Template file for 'bspwm'
pkgname=bspwm
version=0.9.10
-revision=1
+revision=2
build_style=gnu-makefile
makedepends="xcb-util-wm-devel xcb-util-keysyms-devel"
short_desc="Tiling window manager based on binary space partitioning"
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: bspwm: patch windows sometimes not appearing
2023-01-01 4:14 [PR PATCH] bspwm: patch windows sometimes not appearing kruceter
@ 2023-01-01 5:44 ` classabbyamp
2023-01-01 6:01 ` [PR PATCH] [Updated] " kruceter
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: classabbyamp @ 2023-01-01 5:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 202 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/41389#issuecomment-1368358858
Comment:
"used to be"? if it's not a problem anymore why patch?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Updated] bspwm: patch windows sometimes not appearing
2023-01-01 4:14 [PR PATCH] bspwm: patch windows sometimes not appearing kruceter
2023-01-01 5:44 ` classabbyamp
@ 2023-01-01 6:01 ` kruceter
2023-01-01 6:06 ` kruceter
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: kruceter @ 2023-01-01 6:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 690 bytes --]
There is an updated pull request by kruceter against master on the void-packages repository
https://github.com/kruceter/void-packages bspwm
https://github.com/void-linux/void-packages/pull/41389
bspwm: patch windows sometimes not appearing
Apparently gtk-based software used to be affected by this bug.
I use this window manager as my "daily driver" with the upstream patch applied.
The issue at hand is gone far, far away.
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, x86_64-musl
A patch file from https://github.com/void-linux/void-packages/pull/41389.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-bspwm-41389.patch --]
[-- Type: text/x-diff, Size: 2164 bytes --]
From 4d2414703dc7a88aa3bbca0d83fa8f7b2ed19f68 Mon Sep 17 00:00:00 2001
From: Krul Ceter <kruceter@proton.me>
Date: Thu, 29 Dec 2022 08:44:05 +0300
Subject: [PATCH] bspwm: patch windows sometimes not appearing
Apparently gtk-based software is affected by this bug.
The upstream patch fixes the issue in question.
---
.../patches/fix-windows-not-appearing.patch | 32 +++++++++++++++++++
srcpkgs/bspwm/template | 2 +-
2 files changed, 33 insertions(+), 1 deletion(-)
create mode 100644 srcpkgs/bspwm/patches/fix-windows-not-appearing.patch
diff --git a/srcpkgs/bspwm/patches/fix-windows-not-appearing.patch b/srcpkgs/bspwm/patches/fix-windows-not-appearing.patch
new file mode 100644
index 000000000000..1dbd87c46ba0
--- /dev/null
+++ b/srcpkgs/bspwm/patches/fix-windows-not-appearing.patch
@@ -0,0 +1,32 @@
+https://github.com/baskerville/bspwm/commit/1560df35be303807052c235634eb8d59415c37ff
+
+From 1560df35be303807052c235634eb8d59415c37ff Mon Sep 17 00:00:00 2001
+From: David Hoppenbrouwers <david@salt-inc.org>
+Date: Tue, 25 Jan 2022 00:09:42 +0100
+Subject: [PATCH] Fix windows sometimes not appearing
+
+Fixes #935.
+---
+ src/bspwm.c | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/src/bspwm.c b/src/bspwm.c
+index 9c6be76c..8b9b5d14 100644
+--- a/src/bspwm.c
++++ b/src/bspwm.c
+@@ -36,6 +36,7 @@
+ #include <stdbool.h>
+ #include <string.h>
+ #include <xcb/xinerama.h>
++#include <xcb/xcb_aux.h>
+ #include "types.h"
+ #include "desktop.h"
+ #include "monitor.h"
+@@ -248,6 +249,7 @@ int main(int argc, char *argv[])
+ }
+
+ if (FD_ISSET(dpy_fd, &descriptors)) {
++ xcb_aux_sync(dpy);
+ while ((event = xcb_poll_for_event(dpy)) != NULL) {
+ handle_event(event);
+ free(event);
diff --git a/srcpkgs/bspwm/template b/srcpkgs/bspwm/template
index c8092a46b2da..f257a820b9ae 100644
--- a/srcpkgs/bspwm/template
+++ b/srcpkgs/bspwm/template
@@ -1,7 +1,7 @@
# Template file for 'bspwm'
pkgname=bspwm
version=0.9.10
-revision=1
+revision=2
build_style=gnu-makefile
makedepends="xcb-util-wm-devel xcb-util-keysyms-devel"
short_desc="Tiling window manager based on binary space partitioning"
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: bspwm: patch windows sometimes not appearing
2023-01-01 4:14 [PR PATCH] bspwm: patch windows sometimes not appearing kruceter
2023-01-01 5:44 ` classabbyamp
2023-01-01 6:01 ` [PR PATCH] [Updated] " kruceter
@ 2023-01-01 6:06 ` kruceter
2023-01-06 12:32 ` [PR PATCH] [Closed]: " kruceter
2023-01-11 21:03 ` [PR PATCH] [Merged]: " classabbyamp
4 siblings, 0 replies; 6+ messages in thread
From: kruceter @ 2023-01-01 6:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 289 bytes --]
New comment by kruceter on void-packages repository
https://github.com/void-linux/void-packages/pull/41389#issuecomment-1368362712
Comment:
> if it's not a problem anymore why patch?
It still is a problem without the attached patch. Fixed wording in the commit and starting messages.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Closed]: bspwm: patch windows sometimes not appearing
2023-01-01 4:14 [PR PATCH] bspwm: patch windows sometimes not appearing kruceter
` (2 preceding siblings ...)
2023-01-01 6:06 ` kruceter
@ 2023-01-06 12:32 ` kruceter
2023-01-11 21:03 ` [PR PATCH] [Merged]: " classabbyamp
4 siblings, 0 replies; 6+ messages in thread
From: kruceter @ 2023-01-06 12:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 450 bytes --]
There's a closed pull request on the void-packages repository
bspwm: patch windows sometimes not appearing
https://github.com/void-linux/void-packages/pull/41389
Description:
Apparently gtk-based software is affected by this bug.
The upstream patch fixes the issue in question.
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, x86_64-musl
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Merged]: bspwm: patch windows sometimes not appearing
2023-01-01 4:14 [PR PATCH] bspwm: patch windows sometimes not appearing kruceter
` (3 preceding siblings ...)
2023-01-06 12:32 ` [PR PATCH] [Closed]: " kruceter
@ 2023-01-11 21:03 ` classabbyamp
4 siblings, 0 replies; 6+ messages in thread
From: classabbyamp @ 2023-01-11 21:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 450 bytes --]
There's a merged pull request on the void-packages repository
bspwm: patch windows sometimes not appearing
https://github.com/void-linux/void-packages/pull/41389
Description:
Apparently gtk-based software is affected by this bug.
The upstream patch fixes the issue in question.
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, x86_64-musl
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-01-11 21:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-01 4:14 [PR PATCH] bspwm: patch windows sometimes not appearing kruceter
2023-01-01 5:44 ` classabbyamp
2023-01-01 6:01 ` [PR PATCH] [Updated] " kruceter
2023-01-01 6:06 ` kruceter
2023-01-06 12:32 ` [PR PATCH] [Closed]: " kruceter
2023-01-11 21:03 ` [PR PATCH] [Merged]: " classabbyamp
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).