Github messages for voidlinux
 help / color / mirror / Atom feed
From: classabbyamp <classabbyamp@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: chrono-date-3.0.1
Date: Fri, 20 Jan 2023 07:21:20 +0100	[thread overview]
Message-ID: <20230120062120.9n0D8_S1wXlfPwqarldR-EBGAoeA74DDwyYprQHDuQQ@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-41750@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1535 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/41750#issuecomment-1397969504

Comment:
how about this?

```bash
# Template file for 'chrono-date'
pkgname=chrono-date
version=3.0.1
revision=1
build_style=cmake
configure_args="-DBUILD_SHARED_LIBS=true -DBUILD_TZ_LIB=true
 -DUSE_SYSTEM_TZ_DB=true -DENABLE_DATE_TESTING=true"
short_desc="Date and time library based on the C++11/14/17 <chrono> header"
maintainer="lz-coder <lzcoder@proton.me>"
license="MIT"
homepage="https://howardhinnant.github.io/date/date.html"
changelog="https://github.com/HowardHinnant/date/releases"
distfiles="https://github.com/HowardHinnant/date/archive/v${version}.tar.gz"
checksum=7a390f200f0ccd207e8cff6757e04817c1a0aec3e327b006b7eb451c57ee3538

post_install() {
	vlicense LICENSE.txt
}

chrono-date-devel_package() {
	depends="${sourcepkg}>=${version}_${revision}"
	short_desc+=" - development files"
	pkg_install() {
		vmove usr/include
		vmove usr/lib/cmake
		vmove "usr/lib/*.so"
	}
}
```

- used the cmake `build_style`
    - removes need for manual `do_build` and `do_install`
    - allows usage of `configure_args`
    - removed unnecessary cmake arguments
- added a -devel subpackage (you will need to `ln -sr srcpkgs/chrono-date srcpkgs/chrono-date-devel`)
- removed the README... I don't think it's necessary to include
- you willl also need to add `libdate-tz.so.3 chrono-date-3.0.1_1` to `common/shlibs` to be able to use this with other packages

  parent reply	other threads:[~2023-01-20  6:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-20  5:37 [PR PATCH] " lz-coder
2023-01-20  5:46 ` [PR PATCH] [Updated] " lz-coder
2023-01-20  6:21 ` classabbyamp [this message]
2023-01-20  7:01 ` lz-coder
2023-01-20 15:34 ` lz-coder
2023-01-20 15:38 ` lz-coder
2023-01-22  1:47 ` [PR REVIEW] " classabbyamp
2023-01-22  3:12 ` [PR PATCH] [Updated] " lz-coder
2023-02-07  7:46 ` [PR PATCH] [Merged]: " classabbyamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230120062120.9n0D8_S1wXlfPwqarldR-EBGAoeA74DDwyYprQHDuQQ@z \
    --to=classabbyamp@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).