[PR PATCH] sic: update to 1.3.

[PR PATCH] sic: update to 1.3.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 700 bytes --]

There is a new pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages sic
https://github.com/void-linux/void-packages/pull/41920

sic: update to 1.3.
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture: **x86_64**

Everything in pre-build has been incorporated upstream (I think)
- https://git.suckless.org/sic/commit/f2c5daa9fe8ee9da89b9596c2b316ba7f9bd64a7.html
- https://git.suckless.org/sic/commit/ec293427a0cc2ef7f561a60347ce940d567efb72.html

A patch file from https://github.com/void-linux/void-packages/pull/41920.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sic-41920.patch --]
[-- Type: text/x-diff, Size: 1383 bytes --]

From 19773b98b6404920d3477764173b4abcc9f67297 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Sat, 28 Jan 2023 12:23:18 +0530
Subject: [PATCH] sic: update to 1.3.

---
 srcpkgs/sic/template | 17 +++++------------
 1 file changed, 5 insertions(+), 12 deletions(-)

diff --git a/srcpkgs/sic/template b/srcpkgs/sic/template
index 3269fe5c85da..60a971fcca52 100644
--- a/srcpkgs/sic/template
+++ b/srcpkgs/sic/template
@@ -1,24 +1,17 @@
 # Template file for 'sic'
 pkgname=sic
-version=1.2
-revision=5
+version=1.3
+revision=1
 build_style=gnu-makefile
 make_build_args="INCS=-I. LIBS="
 short_desc="Simple irc client"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="MIT"
-homepage="http://tools.suckless.org/${pkgname}"
-distfiles="http://dl.suckless.org/tools/${pkgname}-${version}.tar.gz"
-checksum=ac07f905995e13ba2c43912d7a035fbbe78a628d7ba1c256f4ca1372fb565185
+homepage="https://tools.suckless.org/sic/"
+distfiles="https://dl.suckless.org/tools/sic-${version}.tar.gz"
+checksum=30478fab3ebc75f2eb5d08cbb5b2fedcaf489116e75a2dd7197e3e9c733d65d2
 replaces="sic-git>=0"
 
-pre_build() {
-	sed -i '10i #include <sys/select.h>' sic.c
-	sed -i 's|^CPPFLAGS *=|override CPPFLAGS +=|g' config.mk
-	sed -i 's|^CFLAGS *=|override CFLAGS +=|g' config.mk
-	sed -i 's|^LDFLAGS *=|override LDFLAGS +=|g' config.mk
-}
-
 post_install() {
 	vlicense LICENSE
 	vdoc README

Re: [PR REVIEW] sic: update to 1.3.

[liarimu]

[-- Attachment #1: Type: text/plain, Size: 363 bytes --]

New review comment by liarimu on void-packages repository

https://github.com/void-linux/void-packages/pull/41920#discussion_r1089802402

Comment:
According to links you have attached in the starting message, upstream makefile does not appear to be using `INCS` and `LIBS` anymore. Could you please verify this by removing `make_build_args`? Thank you very much.

Re: [PR PATCH] [Updated] sic: update to 1.3.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 705 bytes --]

There is an updated pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages sic
https://github.com/void-linux/void-packages/pull/41920

sic: update to 1.3.
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture: **x86_64**

Everything in pre-build has been incorporated upstream (I think)
- https://git.suckless.org/sic/commit/f2c5daa9fe8ee9da89b9596c2b316ba7f9bd64a7.html
- https://git.suckless.org/sic/commit/ec293427a0cc2ef7f561a60347ce940d567efb72.html

A patch file from https://github.com/void-linux/void-packages/pull/41920.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sic-41920.patch --]
[-- Type: text/x-diff, Size: 1384 bytes --]

From e170df06fa129cd502289bd6d929ed759260794d Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Sat, 28 Jan 2023 12:23:18 +0530
Subject: [PATCH] sic: update to 1.3.

---
 srcpkgs/sic/template | 18 +++++-------------
 1 file changed, 5 insertions(+), 13 deletions(-)

diff --git a/srcpkgs/sic/template b/srcpkgs/sic/template
index 3269fe5c85da..05e188c2a983 100644
--- a/srcpkgs/sic/template
+++ b/srcpkgs/sic/template
@@ -1,24 +1,16 @@
 # Template file for 'sic'
 pkgname=sic
-version=1.2
-revision=5
+version=1.3
+revision=1
 build_style=gnu-makefile
-make_build_args="INCS=-I. LIBS="
 short_desc="Simple irc client"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="MIT"
-homepage="http://tools.suckless.org/${pkgname}"
-distfiles="http://dl.suckless.org/tools/${pkgname}-${version}.tar.gz"
-checksum=ac07f905995e13ba2c43912d7a035fbbe78a628d7ba1c256f4ca1372fb565185
+homepage="https://tools.suckless.org/sic/"
+distfiles="https://dl.suckless.org/tools/sic-${version}.tar.gz"
+checksum=30478fab3ebc75f2eb5d08cbb5b2fedcaf489116e75a2dd7197e3e9c733d65d2
 replaces="sic-git>=0"
 
-pre_build() {
-	sed -i '10i #include <sys/select.h>' sic.c
-	sed -i 's|^CPPFLAGS *=|override CPPFLAGS +=|g' config.mk
-	sed -i 's|^CFLAGS *=|override CFLAGS +=|g' config.mk
-	sed -i 's|^LDFLAGS *=|override LDFLAGS +=|g' config.mk
-}
-
 post_install() {
 	vlicense LICENSE
 	vdoc README

Re: [PR REVIEW] sic: update to 1.3.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 179 bytes --]

New review comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/41920#discussion_r1089803166

Comment:
Ah, forgot about removing that.

Re: [PR PATCH] [Merged]: sic: update to 1.3.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 553 bytes --]

There's a merged pull request on the void-packages repository

sic: update to 1.3.
https://github.com/void-linux/void-packages/pull/41920

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture: **x86_64**

Everything in pre-build has been incorporated upstream (I think)
- https://git.suckless.org/sic/commit/f2c5daa9fe8ee9da89b9596c2b316ba7f9bd64a7.html
- https://git.suckless.org/sic/commit/ec293427a0cc2ef7f561a60347ce940d567efb72.html