[PR PATCH] WoeUSB: make some room for uefi image.

[PR PATCH] WoeUSB: make some room for uefi image.

[sinetek]

[-- Attachment #1: Type: text/plain, Size: 755 bytes --]

There is a new pull request by sinetek against master on the void-packages repository

https://github.com/sinetek/void-packages woe
https://github.com/void-linux/void-packages/pull/41669

WoeUSB: make some room for uefi image.
Add a patch for WoeUSB. Version of the program stays the same.
The patch is required because one of the files that is used, downloaded from a github repository at runtime, has doubled in size, and so a small change in the code is needed to accommodate this boot file.

#### Testing the changes
- I tested the changes in this PR: YES

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc



A patch file from https://github.com/void-linux/void-packages/pull/41669.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-woe-41669.patch --]
[-- Type: text/x-diff, Size: 2338 bytes --]

From 4348a95c62648434d2c9698a8f91321c6b900136 Mon Sep 17 00:00:00 2001
From: sinetek <pitwuu@gmail.com>
Date: Sun, 15 Jan 2023 19:25:07 +0100
Subject: [PATCH] WoeUSB: make some room for uefi image.

---
 .../0001-Make-some-room-for-uefi-img.patch    | 34 +++++++++++++++++++
 srcpkgs/WoeUSB/template                       |  2 +-
 2 files changed, 35 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/WoeUSB/patches/0001-Make-some-room-for-uefi-img.patch

diff --git a/srcpkgs/WoeUSB/patches/0001-Make-some-room-for-uefi-img.patch b/srcpkgs/WoeUSB/patches/0001-Make-some-room-for-uefi-img.patch
new file mode 100644
index 0000000000000..1135b19630ba5
--- /dev/null
+++ b/srcpkgs/WoeUSB/patches/0001-Make-some-room-for-uefi-img.patch
@@ -0,0 +1,34 @@
+From aa1299fdbc92a2723016568735a07ebc5bc85914 Mon Sep 17 00:00:00 2001
+From: sinetek <pitwuu@gmail.com>
+Date: Sun, 15 Jan 2023 19:21:18 +0100
+Subject: [PATCH] Make some room for uefi img
+
+---
+ src/woeusb | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/src/woeusb b/src/woeusb
+index 8cb292c..f9986c4 100755
+--- a/src/woeusb
++++ b/src/woeusb
+@@ -1093,7 +1093,7 @@ create_target_partition(){
+ 				primary \
+ 				"${parted_mkpart_fs_type}" \
+ 				4MiB \
+-				-- -1025s # Leave 512KiB==1024sector in traditional 512bytes/sector disk, disks with sector with more than 512bytes only result in partition size greater than 512KiB and is intentionally let-it-be.
++				-- -2049s # Leave 512KiB==1024sector in traditional 512bytes/sector disk, disks with sector with more than 512bytes only result in partition size greater than 512KiB and is intentionally let-it-be.
+ 				# FIXME: Leave exact 512KiB in all circumstances is better, but the algorithm to do so is quite brainkilling.
+ 			;;
+ 		*)
+@@ -1149,7 +1149,7 @@ create_uefi_ntfs_support_partition(){
+ 		primary \
+ 		fat16 \
+ 		--  \
+-		-1024s \
++		-2048s \
+ 		-1s
+ 
+ 	return "$?"
+-- 
+2.39.0
+
diff --git a/srcpkgs/WoeUSB/template b/srcpkgs/WoeUSB/template
index 32298bc2f32fa..bd00e84da9eb1 100644
--- a/srcpkgs/WoeUSB/template
+++ b/srcpkgs/WoeUSB/template
@@ -1,7 +1,7 @@
 # Template file for 'WoeUSB'
 pkgname=WoeUSB
 version=3.3.1
-revision=3
+revision=4
 build_style=gnu-configure
 configure_args="--with-wx-config=wx-config-gtk3"
 hostmakedepends="automake gettext libtool"

Re: WoeUSB: make some room for uefi image.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 260 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/41669#issuecomment-1383220433

Comment:
looks like this has been fixed upstream already in [v5.1.3](https://github.com/WoeUSB/WoeUSB/releases/tag/v5.1.3)

Re: WoeUSB: make some room for uefi image.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 292 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/41669#issuecomment-1383220433

Comment:
looks like this has been fixed upstream already in [v5.1.3](https://github.com/WoeUSB/WoeUSB/releases/tag/v5.1.3). might be better to just update

Re: WoeUSB: make some room for uefi image.

[sinetek]

[-- Attachment #1: Type: text/plain, Size: 506 bytes --]

New comment by sinetek on void-packages repository

https://github.com/void-linux/void-packages/pull/41669#issuecomment-1383221151

Comment:
> looks like this has been fixed upstream already in [v5.1.3](https://github.com/WoeUSB/WoeUSB/releases/tag/v5.1.3). might be better to just update

Someone tried to update to 5.1.3 but the pull request was closed for reasons I don't understand. This just fixes the current package instead of trying to migrate to the new project which has a different code base.

Re: WoeUSB: make some room for uefi image.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/41669#issuecomment-1383222231

Comment:
looks like it was closed because the author never finished working on requested changes

Re: WoeUSB: make some room for uefi image.

[sinetek]

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

New comment by sinetek on void-packages repository

https://github.com/void-linux/void-packages/pull/41669#issuecomment-1383222510

Comment:
It could be done as subsequent work I suppose. I'm not interested at this time to do it.

Re: WoeUSB: make some room for uefi image.

[kruceter]

[-- Attachment #1: Type: text/plain, Size: 291 bytes --]

New comment by kruceter on void-packages repository

https://github.com/void-linux/void-packages/pull/41669#issuecomment-1398196194

Comment:
`WoeUSB` was separated into `WoeUSB-cli` and updated in https://github.com/void-linux/void-packages/commit/d4625ea63dda3f681a8240ae2a61579f834ba1e2.

Re: [PR PATCH] [Closed]: WoeUSB: make some room for uefi image.

[the-maldridge]

[-- Attachment #1: Type: text/plain, Size: 608 bytes --]

There's a closed pull request on the void-packages repository

WoeUSB: make some room for uefi image.
https://github.com/void-linux/void-packages/pull/41669

Description:
Add a patch for WoeUSB. Version of the program stays the same.
The patch is required because one of the files that is used, downloaded from a github repository at runtime, has doubled in size, and so a small change in the code is needed to accommodate this boot file.

#### Testing the changes
- I tested the changes in this PR: YES

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

Re: WoeUSB: make some room for uefi image.

[sinetek]

[-- Attachment #1: Type: text/plain, Size: 408 bytes --]

New comment by sinetek on void-packages repository

https://github.com/void-linux/void-packages/pull/41669#issuecomment-1410748938

Comment:
> `WoeUSB` was separated into `WoeUSB-cli` and updated in [d4625ea](https://github.com/void-linux/void-packages/commit/d4625ea63dda3f681a8240ae2a61579f834ba1e2).

Woeusb-cli is not the same program. As I understand it, it is a command line client, this is a GUI.

Re: WoeUSB: make some room for uefi image.

[liarimu]

[-- Attachment #1: Type: text/plain, Size: 243 bytes --]

New comment by liarimu on void-packages repository

https://github.com/void-linux/void-packages/pull/41669#issuecomment-1410824382

Comment:
> As I understand it, it is a command line client, this is a GUI.

gui is a wrapper for WoeUSB-cli.