From: sgn <sgn@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] [RFC] common/environment/setup/install.sh: always add log service
Date: Thu, 02 Feb 2023 12:33:02 +0100 [thread overview]
Message-ID: <20230202113302.C0Rb0km6qt68Vkx8CTDFi64IOONAPey2PI2Njilhssg@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-42026@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 323 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/42026#discussion_r1094400944
Comment:
```suggestion
cat <<-EOF >$svdir/log/run
#!/bin/sh
exec vlogger -p daemon -t $service
EOF
```
While the printf is correct, it isn't visualized as good as heredoc.
next prev parent reply other threads:[~2023-02-02 11:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 8:21 [PR PATCH] " classabbyamp
2023-02-02 8:27 ` [RFC] " classabbyamp
2023-02-02 8:36 ` [PR REVIEW] " paper42
2023-02-02 11:33 ` sgn [this message]
2023-02-07 7:26 ` [PR PATCH] [Updated] " classabbyamp
2023-02-07 7:34 ` classabbyamp
2023-02-07 11:08 ` ahesford
2023-02-07 16:07 ` classabbyamp
2023-02-10 1:13 ` [PR PATCH] [Updated] " classabbyamp
2023-02-10 2:36 ` [PR PATCH] [Merged]: " classabbyamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230202113302.C0Rb0km6qt68Vkx8CTDFi64IOONAPey2PI2Njilhssg@z \
--to=sgn@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).