From: classabbyamp <classabbyamp@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Merged]: [RFC] common/environment/setup/install.sh: always add log service
Date: Fri, 10 Feb 2023 03:36:15 +0100 [thread overview]
Message-ID: <20230210023615.z4oHMgO9KBPJa5aSdcm8hXCOMXRwi7JjCP0YVRMdfr0@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-42026@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1435 bytes --]
There's a merged pull request on the void-packages repository
[RFC] common/environment/setup/install.sh: always add log service
https://github.com/void-linux/void-packages/pull/42026
Description:
- common/environment/setup/install.sh: always add log service
- overridable by having a log service at `$pkgname/files/$service/log`
- uses a sane default run script with the service name set as tag and daemon facility
- warns if stderr is not redirected in the main service
- example of warnings:
```
=> soju-0.5.2_1: running post_install ...
=> WARNING: soju-0.5.2_1: vsv: service 'soju' does not contain 'exec 2>&1' to log stderr
=> WARNING: soju-0.5.2_1: vsv: overriding default log service
```
- Manual.md: document vsv log autocreation
- *: remove log dir en-masse
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
### TODO
- [x] go through all removed log services and see if any need overrides
- candidates at a glance: cronie, dcron, dkimproxy, dnscrypt-proxy, dq, postgres13/14, sqmail
- [x] add/fix redirection to main run file of all services
### Questions
- ~~Should there be a possible second vlogger argument that sets the facility? This would remove the need for overrides for the few services that set cron/mail as facility~~
- added this for ease-of-use
[ci skip]
prev parent reply other threads:[~2023-02-10 2:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 8:21 [PR PATCH] " classabbyamp
2023-02-02 8:27 ` [RFC] " classabbyamp
2023-02-02 8:36 ` [PR REVIEW] " paper42
2023-02-02 11:33 ` sgn
2023-02-07 7:26 ` [PR PATCH] [Updated] " classabbyamp
2023-02-07 7:34 ` classabbyamp
2023-02-07 11:08 ` ahesford
2023-02-07 16:07 ` classabbyamp
2023-02-10 1:13 ` [PR PATCH] [Updated] " classabbyamp
2023-02-10 2:36 ` classabbyamp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230210023615.z4oHMgO9KBPJa5aSdcm8hXCOMXRwi7JjCP0YVRMdfr0@z \
--to=classabbyamp@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).