From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] Update libnvme and nvme-cli
Date: Sun, 05 Feb 2023 11:22:45 +0100 [thread overview]
Message-ID: <20230205102245.Rb0PSIE_bgitFk-HPm-mU4iKRplqcNfym0OJuTMC_d8@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-41919@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 373 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/41919#discussion_r1096658986
Comment:
```suggestion
depends="${sourcepkg}>=${version}_${revision} json-c-devel openssl-devel"
```
and remove the `depends+=` line, it's not necessary to have a comment about this because every -devel package works the same way.
next prev parent reply other threads:[~2023-02-05 10:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-28 17:17 [PR PATCH] nvme subnut
2023-02-05 10:22 ` paper42 [this message]
2023-02-05 10:24 ` [PR REVIEW] Update libnvme and nvme-cli paper42
2023-02-06 18:15 ` subnut
2023-02-06 18:18 ` subnut
2023-02-06 18:20 ` [PR PATCH] [Updated] " subnut
2023-02-07 5:10 ` [PR REVIEW] " subnut
2023-02-07 5:20 ` kruceter
2023-02-07 5:20 ` kruceter
2023-02-14 21:09 ` [PR PATCH] [Merged]: " paper42
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230205102245.Rb0PSIE_bgitFk-HPm-mU4iKRplqcNfym0OJuTMC_d8@z \
--to=paper42@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).