Github messages for voidlinux
 help / color / mirror / Atom feed
From: subnut <subnut@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] Update libnvme and nvme-cli
Date: Mon, 06 Feb 2023 19:18:30 +0100	[thread overview]
Message-ID: <20230206181830.3IwPzVYJVtrQmxWbnLSYkK9dcH-i3LoIQyqBlRri9qc@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-41919@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

New review comment by subnut on void-packages repository

https://github.com/void-linux/void-packages/pull/41919#discussion_r1097759875

Comment:
Ah, I see it's mentioned in `Manual.md`

> If the package installs a systemd service file or other unit, leave it in place as a
reference point so long as including it has no negative side effects.

But I still don't understand. What does it mean by _reference point_?

  parent reply	other threads:[~2023-02-06 18:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-28 17:17 [PR PATCH] nvme subnut
2023-02-05 10:22 ` [PR REVIEW] Update libnvme and nvme-cli paper42
2023-02-05 10:24 ` paper42
2023-02-06 18:15 ` subnut
2023-02-06 18:18 ` subnut [this message]
2023-02-06 18:20 ` [PR PATCH] [Updated] " subnut
2023-02-07  5:10 ` [PR REVIEW] " subnut
2023-02-07  5:20 ` kruceter
2023-02-07  5:20 ` kruceter
2023-02-14 21:09 ` [PR PATCH] [Merged]: " paper42

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230206181830.3IwPzVYJVtrQmxWbnLSYkK9dcH-i3LoIQyqBlRri9qc@z \
    --to=subnut@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).