Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] gap: update to 4.12.2
@ 2023-01-11  7:43 fingolfin
  2023-01-11 13:36 ` tornaria
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: fingolfin @ 2023-01-11  7:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 393 bytes --]

There is a new pull request by fingolfin against master on the void-packages repository

https://github.com/fingolfin/void-packages patch-2
https://github.com/void-linux/void-packages/pull/41572

gap: update to 4.12.2
#### Testing the changes
- I tested the changes in this PR: **NO**

CC @tornaria

A patch file from https://github.com/void-linux/void-packages/pull/41572.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-2-41572.patch --]
[-- Type: text/x-diff, Size: 1100 bytes --]

From 222434802ebc1056c4813dceae1b2427eb9b00d6 Mon Sep 17 00:00:00 2001
From: Max Horn <max@quendi.de>
Date: Wed, 11 Jan 2023 08:41:45 +0100
Subject: [PATCH] gap: update to 4.12.2

---
 srcpkgs/gap/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/gap/template b/srcpkgs/gap/template
index 277537fe0fa3..63d1194d45dd 100644
--- a/srcpkgs/gap/template
+++ b/srcpkgs/gap/template
@@ -1,6 +1,6 @@
 # Template file for 'gap'
 pkgname=gap
-version=4.12.1
+version=4.12.2
 revision=1
 build_style=gnu-configure
 makedepends="gmp-devel zlib-devel readline-devel"
@@ -11,7 +11,7 @@ license="GPL-2.0-or-later"
 homepage="https://www.gap-system.org/"
 changelog="https://raw.githubusercontent.com/gap-system/gap/master/CHANGES.md"
 distfiles="https://github.com/gap-system/gap/releases/download/v${version}/gap-${version}.tar.gz"
-checksum=f9ebef11ee31b210ce36e3c70960742b4e253282bbd5270adc9324273c92b016
+checksum=672308745eb78a222494ee8dd6786edd5bc331456fcc6456ac064bdb28d587a8
 
 if [ "$XBPS_CHECK_PKGS" = full ]; then
 	# not sure about this -- takes about 25 minutes

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: gap: update to 4.12.2
  2023-01-11  7:43 [PR PATCH] gap: update to 4.12.2 fingolfin
@ 2023-01-11 13:36 ` tornaria
  2023-02-02 22:38 ` tornaria
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: tornaria @ 2023-01-11 13:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 510 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/41572#issuecomment-1378763257

Comment:
Looks an easy upgrade, but it has to be tested with sagemath, i.e. run `sage -tp --all --long` with this package installed. Be warned that there will be a few failures due to deprecation warnings in numpy 1.24 which can be ignored (I already have a patch, I'm planning to revbump sagemath 9.7 with upgraded fplll, gap, giac, igraph, pari and brial rebuilt for boost).

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: gap: update to 4.12.2
  2023-01-11  7:43 [PR PATCH] gap: update to 4.12.2 fingolfin
  2023-01-11 13:36 ` tornaria
@ 2023-02-02 22:38 ` tornaria
  2023-02-03  0:37 ` fingolfin
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: tornaria @ 2023-02-02 22:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 457 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/41572#issuecomment-1414467683

Comment:
@fingolfin: a minor nitpick, something changed in `make install` for headers. In 4.12.1 it would install a symlink `src -> .` in `/usr/include/gap/`. But in 4.12.2 it actually creates a directory and duplicates all the files. Is there a reason for this change?

The update seems to work ok with our sagemath 9.7.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: gap: update to 4.12.2
  2023-01-11  7:43 [PR PATCH] gap: update to 4.12.2 fingolfin
  2023-01-11 13:36 ` tornaria
  2023-02-02 22:38 ` tornaria
@ 2023-02-03  0:37 ` fingolfin
  2023-02-03  1:47 ` tornaria
  2023-02-13 16:23 ` [PR PATCH] [Merged]: " leahneukirchen
  4 siblings, 0 replies; 6+ messages in thread
From: fingolfin @ 2023-02-03  0:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 413 bytes --]

New comment by fingolfin on void-packages repository

https://github.com/void-linux/void-packages/pull/41572#issuecomment-1414555458

Comment:
Reason for the change: the Debian maintainer complained about the symlink, implying this would cause all kinds of potential problems... In the end, I really don't care much either way :-). Longterm I hope we can get rid of this hack anyway, perhaps already in GAP 4.13.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: gap: update to 4.12.2
  2023-01-11  7:43 [PR PATCH] gap: update to 4.12.2 fingolfin
                   ` (2 preceding siblings ...)
  2023-02-03  0:37 ` fingolfin
@ 2023-02-03  1:47 ` tornaria
  2023-02-13 16:23 ` [PR PATCH] [Merged]: " leahneukirchen
  4 siblings, 0 replies; 6+ messages in thread
From: tornaria @ 2023-02-03  1:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 655 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/41572#issuecomment-1414608109

Comment:
> Reason for the change: the Debian maintainer complained about the symlink, implying this would cause all kinds of potential problems... In the end, I really don't care much either way :-). Longterm I hope we can get rid of this hack anyway, perhaps already in GAP 4.13.

Ok, so we might as well `rm -rf` the whole redundant thing (and maybe redo the symlink) in `post_install()`. Or maybe just ignore, gap-4.12.2 is saving 120MB because datafiles are compressed so 1MB of redundant header files is nothing...

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Merged]: gap: update to 4.12.2
  2023-01-11  7:43 [PR PATCH] gap: update to 4.12.2 fingolfin
                   ` (3 preceding siblings ...)
  2023-02-03  1:47 ` tornaria
@ 2023-02-13 16:23 ` leahneukirchen
  4 siblings, 0 replies; 6+ messages in thread
From: leahneukirchen @ 2023-02-13 16:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

There's a merged pull request on the void-packages repository

gap: update to 4.12.2
https://github.com/void-linux/void-packages/pull/41572

Description:
#### Testing the changes
- I tested the changes in this PR: **NO**

CC @tornaria

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-02-13 16:23 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-11  7:43 [PR PATCH] gap: update to 4.12.2 fingolfin
2023-01-11 13:36 ` tornaria
2023-02-02 22:38 ` tornaria
2023-02-03  0:37 ` fingolfin
2023-02-03  1:47 ` tornaria
2023-02-13 16:23 ` [PR PATCH] [Merged]: " leahneukirchen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).