[PR PATCH] python3-xlib: update to 0.33.

[PR PATCH] python3-xlib: update to 0.33.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 1234 bytes --]

There is a new pull request by mhmdanas against master on the void-packages repository

https://github.com/mhmdanas/void-packages python3-xlib-0.33
https://github.com/void-linux/void-packages/pull/42205

python3-xlib: update to 0.33.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/42205.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-xlib-0.33-42205.patch --]
[-- Type: text/x-diff, Size: 1490 bytes --]

From c780da1d23c01d9b68cdd9a50a688a508e1043c1 Mon Sep 17 00:00:00 2001
From: mhmdanas <triallax@tutanota.com>
Date: Fri, 10 Feb 2023 20:08:26 +0000
Subject: [PATCH] python3-xlib: update to 0.33.

---
 srcpkgs/python3-xlib/template | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/python3-xlib/template b/srcpkgs/python3-xlib/template
index c7dae28a8344..abdcf0200365 100644
--- a/srcpkgs/python3-xlib/template
+++ b/srcpkgs/python3-xlib/template
@@ -1,17 +1,18 @@
 # Template file for 'python3-xlib'
 pkgname=python3-xlib
-version=0.30
-revision=3
+version=0.33
+revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools_scm"
 depends="python3-six"
-checkdepends="$depends xvfb-run python3-nose python3-mock"
+checkdepends="${depends} xvfb-run python3-nose python3-mock"
 short_desc="Fully functional X client library for Python3"
 maintainer="Enno Boland <gottox@voidlinux.org>"
 license="LGPL-2.1-or-later"
 homepage="https://github.com/python-xlib/python-xlib"
-distfiles="${homepage}/releases/download/${version}/python-xlib-${version}.tar.bz2"
-checksum=fd237f4eed494bb6fc6f0f94a15279aa9a50c90eeaef4fc57d1f9e923818456b
+changelog="https://github.com/python-xlib/python-xlib/raw/master/CHANGELOG.md"
+distfiles="https://github.com/python-xlib/python-xlib/releases/download/${version}/python-xlib-${version}.tar.bz2"
+checksum=b7a45aaf919915f4908e4b2d79fc2ff3abbbec3b801a45162b3d0f67ed581b37
 
 do_check() {
 	python3 runtests.py

Re: python3-xlib: update to 0.33.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 267 bytes --]

New comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/42205#issuecomment-1426696565

Comment:
The check failures are also present on python3-xlib 0.30, and I couldn't figure out how to fix them. Disable checks for now?

Re: [PR REVIEW] python3-xlib: update to 0.33.

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/42205#discussion_r1105152955

Comment:
```suggestion
checkdepends="${depends} xvfb-run python3-pytest-xdist python3-mock"
```

Re: [PR REVIEW] python3-xlib: update to 0.33.

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 269 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/42205#discussion_r1105153265

Comment:
```suggestion
checksum=b7a45aaf919915f4908e4b2d79fc2ff3abbbec3b801a45162b3d0f67ed581b37
make_check_pre="xvfb-run"
```

Re: [PR REVIEW] python3-xlib: update to 0.33.

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/42205#discussion_r1105152783

Comment:
```suggestion
build_style=python3-module
make_check_target="test"
```

Re: [PR REVIEW] python3-xlib: update to 0.33.

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/42205#discussion_r1105153497

Comment:
You can delete this entire function with the other changes I suggest.

Re: [PR PATCH] [Updated] python3-xlib: update to 0.33.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 1239 bytes --]

There is an updated pull request by mhmdanas against master on the void-packages repository

https://github.com/mhmdanas/void-packages python3-xlib-0.33
https://github.com/void-linux/void-packages/pull/42205

python3-xlib: update to 0.33.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/42205.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-xlib-0.33-42205.patch --]
[-- Type: text/x-diff, Size: 1560 bytes --]

From 5417ef96d32fcaf4d52f23a49a6e983f82ea8e9c Mon Sep 17 00:00:00 2001
From: mhmdanas <triallax@tutanota.com>
Date: Fri, 10 Feb 2023 20:08:26 +0000
Subject: [PATCH] python3-xlib: update to 0.33.

---
 srcpkgs/python3-xlib/template | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/srcpkgs/python3-xlib/template b/srcpkgs/python3-xlib/template
index c7dae28a8344..6e8fb0e1119c 100644
--- a/srcpkgs/python3-xlib/template
+++ b/srcpkgs/python3-xlib/template
@@ -1,18 +1,17 @@
 # Template file for 'python3-xlib'
 pkgname=python3-xlib
-version=0.30
-revision=3
+version=0.33
+revision=1
 build_style=python3-module
+make_check_target="test"
 hostmakedepends="python3-setuptools_scm"
 depends="python3-six"
-checkdepends="$depends xvfb-run python3-nose python3-mock"
+checkdepends="${depends} xvfb-run python3-pytest-xdist python3-mock"
 short_desc="Fully functional X client library for Python3"
 maintainer="Enno Boland <gottox@voidlinux.org>"
 license="LGPL-2.1-or-later"
 homepage="https://github.com/python-xlib/python-xlib"
-distfiles="${homepage}/releases/download/${version}/python-xlib-${version}.tar.bz2"
-checksum=fd237f4eed494bb6fc6f0f94a15279aa9a50c90eeaef4fc57d1f9e923818456b
-
-do_check() {
-	python3 runtests.py
-}
+changelog="https://github.com/python-xlib/python-xlib/raw/master/CHANGELOG.md"
+distfiles="https://github.com/python-xlib/python-xlib/releases/download/${version}/python-xlib-${version}.tar.bz2"
+checksum=b7a45aaf919915f4908e4b2d79fc2ff3abbbec3b801a45162b3d0f67ed581b37
+make_check_pre="xvfb-run"

Re: python3-xlib: update to 0.33.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/42205#issuecomment-1430367668

Comment:
@ahesford I suspect the failing test in the CI is flaky. I _think_ I had the failure happen locally once, but three subsequent runs did not have the same problem.

Re: [PR PATCH] [Merged]: python3-xlib: update to 0.33.

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 1071 bytes --]

There's a merged pull request on the void-packages repository

python3-xlib: update to 0.33.
https://github.com/void-linux/void-packages/pull/42205

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

Re: python3-xlib: update to 0.33.

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 297 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/42205#issuecomment-1430381270

Comment:
Could be a race, and may be exacerbated by pytest-xdist parallelizing things. It passes locally for me, so we can defer a resolution until a later update.