From: dkwo <dkwo@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: sioyek: don't depend on mupdf
Date: Wed, 22 Feb 2023 17:40:54 +0100 [thread overview]
Message-ID: <20230222164054.VU0SK8MmWjmFSE94qyskrMHME42FOXt1M3_wn4EXaso@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-42386@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1437 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/42386#issuecomment-1440393971
Comment:
Looks good to me, thanks. Moreover, it seems it crosscompiles (at least for aarc64) with
```
diff --git a/srcpkgs/sioyek/template b/srcpkgs/sioyek/template
index 3d96eb044a..8500bdf8e4 100644
--- a/srcpkgs/sioyek/template
+++ b/srcpkgs/sioyek/template
@@ -1,26 +1,20 @@
# Template file for 'sioyek'
pkgname=sioyek
version=2.0.0
-revision=2
+revision=3
build_style=qmake
+configure_args="pdf_viewer_build_config.pro"
hostmakedepends="qt5-qmake qt5-host-tools
qt5-opengl qt5-gui qt5-widgets qt5-network"
makedepends="zlib-devel qt5-3d-devel qt5-gamepad-devel mupdf-devel
gumbo-parser-devel harfbuzz-devel qt5-opengl mujs-devel freetype-devel
libjbig2dec libjpeg-turbo-devel libopenjpeg2-devel"
-depends="mupdf"
short_desc="PDF viewer designed for reading research papers and technical books"
maintainer="dkwo <npiazza@disroot.org>"
license="GPL-3.0-or-later"
homepage="https://sioyek.info/"
distfiles="https://github.com/ahrm/sioyek/archive/refs/tags/v${version}.tar.gz"
checksum=92398b6da5e297c59f22cd3c6b562194846f28bc17bb4ae9432869aafeb5df17
-nocross=yes
-
-do_build() {
- qmake pdf_viewer_build_config.pro
- make ${makejobs} CC="$CC" CXX="$CXX" LINK="$CXX"
-}
do_install() {
vbin sioyek
```
Can you change that as well?
next prev parent reply other threads:[~2023-02-22 16:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 22:43 [PR PATCH] " classabbyamp
2023-02-22 16:40 ` dkwo [this message]
2023-02-22 20:34 ` [PR PATCH] [Updated] " classabbyamp
2023-02-22 20:34 ` classabbyamp
2023-02-22 20:40 ` [PR PATCH] [Merged]: sioyek: don't depend on mupdf, fix cross classabbyamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230222164054.VU0SK8MmWjmFSE94qyskrMHME42FOXt1M3_wn4EXaso@z \
--to=dkwo@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).