Github messages for voidlinux
 help / color / mirror / Atom feed
From: classabbyamp <classabbyamp@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] sioyek: don't depend on mupdf
Date: Wed, 22 Feb 2023 21:34:26 +0100	[thread overview]
Message-ID: <20230222203426.TAXoVe87xdbPNij6mFRaiqlE_lDJZe2TEIPnCW5w8Fg@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-42386@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 598 bytes --]

There is an updated pull request by classabbyamp against master on the void-packages repository

https://github.com/classabbyamp/void-packages fix/sioyek-no-mupdf
https://github.com/void-linux/void-packages/pull/42386

sioyek: don't depend on mupdf
doesn't seem to be needed, as mupdf only available as a statically linkable library

cc maintainer @dkwo

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**



A patch file from https://github.com/void-linux/void-packages/pull/42386.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix/sioyek-no-mupdf-42386.patch --]
[-- Type: text/x-diff, Size: 1514 bytes --]

From f894172e5e0888f2cbeb484361022c54d8d71dc2 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Tue, 21 Feb 2023 17:41:31 -0500
Subject: [PATCH] sioyek: don't depend on mupdf, fix cross

doesn't seem to be needed, as mupdf only available as a statically
linkable library
---
 srcpkgs/sioyek/template | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/srcpkgs/sioyek/template b/srcpkgs/sioyek/template
index 3d96eb044aa6..8500bdf8e43b 100644
--- a/srcpkgs/sioyek/template
+++ b/srcpkgs/sioyek/template
@@ -1,26 +1,20 @@
 # Template file for 'sioyek'
 pkgname=sioyek
 version=2.0.0
-revision=2
+revision=3
 build_style=qmake
+configure_args="pdf_viewer_build_config.pro"
 hostmakedepends="qt5-qmake qt5-host-tools
  qt5-opengl qt5-gui qt5-widgets qt5-network"
 makedepends="zlib-devel qt5-3d-devel qt5-gamepad-devel mupdf-devel
  gumbo-parser-devel harfbuzz-devel qt5-opengl mujs-devel freetype-devel
  libjbig2dec libjpeg-turbo-devel libopenjpeg2-devel"
-depends="mupdf"
 short_desc="PDF viewer designed for reading research papers and technical books"
 maintainer="dkwo <npiazza@disroot.org>"
 license="GPL-3.0-or-later"
 homepage="https://sioyek.info/"
 distfiles="https://github.com/ahrm/sioyek/archive/refs/tags/v${version}.tar.gz"
 checksum=92398b6da5e297c59f22cd3c6b562194846f28bc17bb4ae9432869aafeb5df17
-nocross=yes
-
-do_build() {
-	qmake pdf_viewer_build_config.pro
-	make ${makejobs} CC="$CC" CXX="$CXX" LINK="$CXX"
-}
 
 do_install() {
 	vbin sioyek

  parent reply	other threads:[~2023-02-22 20:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-21 22:43 [PR PATCH] " classabbyamp
2023-02-22 16:40 ` dkwo
2023-02-22 20:34 ` classabbyamp [this message]
2023-02-22 20:34 ` classabbyamp
2023-02-22 20:40 ` [PR PATCH] [Merged]: sioyek: don't depend on mupdf, fix cross classabbyamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230222203426.TAXoVe87xdbPNij6mFRaiqlE_lDJZe2TEIPnCW5w8Fg@z \
    --to=classabbyamp@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).