[PR PATCH] cups: add support for gnutls to enable https

[PR PATCH] cups: add support for gnutls to enable https

[tsndqst]

[-- Attachment #1: Type: text/plain, Size: 1114 bytes --]

There is a new pull request by tsndqst against master on the void-packages repository

https://github.com/tsndqst/void-packages cups-gnutls
https://github.com/void-linux/void-packages/pull/40467

cups: add support for gnutls to enable https
Without gnutls CUPS defaults to the MacOS path for certificates. https://github.com/OpenPrinting/cups/blob/19047059/scheduler/conf.c#L607-L612

When administering printers in CUPS UI (localhost:631) I noticed that the connection could not upgrade to HTTPS.  Upon investigation with `strace` I saw that CUPS was trying to load certificates from `/Library/Keychains/System.keychain`.
```
openat(AT_FDCWD, "/Library/Keychains/System.keychain/void.key", O_WRONLY|O_CREAT|O_TRUNC, 0666) = -1 ENOENT (No such file or directory)
```
Enabling GNUTLS causes CUPS to look in the correct location for certificates.

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-GLIBC)


A patch file from https://github.com/void-linux/void-packages/pull/40467.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cups-gnutls-40467.patch --]
[-- Type: text/x-diff, Size: 1509 bytes --]

From 011bfa6ef9a961ffd1db9fc59b1d6a093a4be19e Mon Sep 17 00:00:00 2001
From: Tim Sandquist <tim.sandquist@gmail.com>
Date: Fri, 11 Nov 2022 07:06:25 -0600
Subject: [PATCH] cups: add support for gnutls to enable https

Without gnutls CUPS defaults to the MacOS path for certificates.
https://github.com/OpenPrinting/cups/blob/19047059/scheduler/conf.c#L607-L612
---
 srcpkgs/cups/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/cups/template b/srcpkgs/cups/template
index 0776928f2609..d53d2e354dd2 100644
--- a/srcpkgs/cups/template
+++ b/srcpkgs/cups/template
@@ -1,14 +1,14 @@
 # Template file for 'cups'
 pkgname=cups
 version=2.4.2
-revision=1
+revision=2
 build_style=gnu-configure
 make_install_args="BUILDROOT=${DESTDIR}"
 hostmakedepends="gnutls-devel pkg-config
  $(vopt_if avahi avahi-libs-devel)"
 makedepends="acl-devel gnutls-devel libpaper-devel libusb-devel pam-devel
  zlib-devel $(vopt_if avahi avahi-libs-devel) $(vopt_if gssapi mit-krb5-devel)"
-depends="xdg-utils"
+depends="xdg-utils gnutls"
 short_desc="Common Unix Printing System"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="Apache-2.0"
@@ -41,7 +41,7 @@ do_configure() {
 		--with-system-groups="lpadmin sys root" --enable-relro \
 		--enable-libpaper --with-menudir=/usr/share/applications \
 		--with-xinetd=/etc/xinetd.d --with-optim="${CFLAGS}" \
-		--with-rcdir=no \
+		--with-rcdir=no --with-tls=gnutls \
 		$(vopt_if avahi '--with-dnssd=avahi') $(vopt_enable gssapi)
 }
 

Re: cups: add support for gnutls to enable https

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/40467#issuecomment-1425097516

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: cups: add support for gnutls to enable https

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 959 bytes --]

There's a closed pull request on the void-packages repository

cups: add support for gnutls to enable https
https://github.com/void-linux/void-packages/pull/40467

Description:
Without gnutls CUPS defaults to the MacOS path for certificates. https://github.com/OpenPrinting/cups/blob/19047059/scheduler/conf.c#L607-L612

When administering printers in CUPS UI (localhost:631) I noticed that the connection could not upgrade to HTTPS.  Upon investigation with `strace` I saw that CUPS was trying to load certificates from `/Library/Keychains/System.keychain`.
```
openat(AT_FDCWD, "/Library/Keychains/System.keychain/void.key", O_WRONLY|O_CREAT|O_TRUNC, 0666) = -1 ENOENT (No such file or directory)
```
Enabling GNUTLS causes CUPS to look in the correct location for certificates.

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-GLIBC)