[PR PATCH] sway: added pcre2 runtime dependency

[PR PATCH] sway: added pcre2 runtime dependency

[Clos3y]

[-- Attachment #1: Type: text/plain, Size: 487 bytes --]

There is a new pull request by Clos3y against master on the void-packages repository

https://github.com/Clos3y/void-packages sway-dependency-fix
https://github.com/void-linux/void-packages/pull/42513

sway: added pcre2 runtime dependency
#### Testing the changes
- I tested the changes in this PR: YES

#### Local build testing
- I built this PR locally for my native architecture, (x86-64)

A patch file from https://github.com/void-linux/void-packages/pull/42513.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sway-dependency-fix-42513.patch --]
[-- Type: text/x-diff, Size: 1133 bytes --]

From a4ef2fb42db56e23fa8d3264c9ddc4bfa14b54f7 Mon Sep 17 00:00:00 2001
From: Sam <39468367+Clos3y@users.noreply.github.com>
Date: Tue, 28 Feb 2023 21:21:54 +0000
Subject: [PATCH] sway: added pcre2 runtime dependency

pcre2 is a runtime dependency of swaywm
---
 srcpkgs/sway/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/sway/template b/srcpkgs/sway/template
index 1eca32f6b8e5..6f3356a6f67e 100644
--- a/srcpkgs/sway/template
+++ b/srcpkgs/sway/template
@@ -1,14 +1,14 @@
 # Template file for 'sway'
 pkgname=sway
 version=1.8
-revision=2
+revision=3
 build_style=meson
 configure_args="-Dwerror=false -Db_ndebug=false"
 conf_files="/etc/sway/config"
 hostmakedepends="pkg-config wayland-devel scdoc"
 makedepends="wlroots-devel pcre2-devel json-c-devel pango-devel cairo-devel
  gdk-pixbuf-devel libevdev-devel"
-depends="libcap-progs swaybg xorg-server-xwayland libxkbcommon>=1.5.0_1"
+depends="libcap-progs swaybg pcre2 xorg-server-xwayland libxkbcommon>=1.5.0_1"
 short_desc="Tiling Wayland compositor compatible with i3"
 maintainer="Olaf Mersmann <olafm@p-value.net>"
 license="MIT"

Re: sway: added pcre2 runtime dependency

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 249 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42513#issuecomment-1448950767

Comment:
is it not already there?

```
$ xbps-query -Rp run_depends sway | grep pcre
libpcre2>=10.22_1
```

Re: sway: added pcre2 runtime dependency

[Clos3y]

[-- Attachment #1: Type: text/plain, Size: 367 bytes --]

New comment by Clos3y on void-packages repository

https://github.com/void-linux/void-packages/pull/42513#issuecomment-1448952759

Comment:
> is it not already there?
> 
> ```
> $ xbps-query -Rp run_depends sway | grep pcre
> libpcre2>=10.22_1
> ```

On a fresh install, sway would not install without me explicitly installing pcre2, rather than the library. 

Re: sway: added pcre2 runtime dependency

[Clos3y]

[-- Attachment #1: Type: text/plain, Size: 423 bytes --]

New comment by Clos3y on void-packages repository

https://github.com/void-linux/void-packages/pull/42513#issuecomment-1448952759

Comment:
> is it not already there?
> 
> ```
> $ xbps-query -Rp run_depends sway | grep pcre
> libpcre2>=10.22_1
> ```

On a fresh install, sway would not install without me explicitly installing pcre2, rather than the library. 

EDIT: Sorry, it would install but not run correctly.

Re: sway: added pcre2 runtime dependency

[subnut]

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

New comment by subnut on void-packages repository

https://github.com/void-linux/void-packages/pull/42513#issuecomment-1448954590

Comment:
wait a minute... sway uses the pcre2 binary itself instead of using the library?

Re: sway: added pcre2 runtime dependency

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 166 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42513#issuecomment-1448954620

Comment:
what was the error?

Re: sway: added pcre2 runtime dependency

[subnut]

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

New comment by subnut on void-packages repository

https://github.com/void-linux/void-packages/pull/42513#issuecomment-1448954590

Comment:
wait a minute... sway uses the pcre2 binary itself instead of using the library?

Re: sway: added pcre2 runtime dependency

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 352 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42513#issuecomment-1448955788

Comment:
> wait a minute... sway uses the pcre2 binary itself instead of using the library?

from a quick github search, it uses neither `pcre2grep` nor `pcre2test`, which are the only things in the pcre2 package

Re: sway: added pcre2 runtime dependency

[Clos3y]

[-- Attachment #1: Type: text/plain, Size: 316 bytes --]

New comment by Clos3y on void-packages repository

https://github.com/void-linux/void-packages/pull/42513#issuecomment-1448955806

Comment:
> wait a minute... sway uses the pcre2 binary itself instead of using the library?

I guess? It's not libpcre2 that's listed as a dependency on their github, it's just pcre2

Re: sway: added pcre2 runtime dependency

[subnut]

[-- Attachment #1: Type: text/plain, Size: 233 bytes --]

New comment by subnut on void-packages repository

https://github.com/void-linux/void-packages/pull/42513#issuecomment-1448956507

Comment:
I'm currently using sway without having pcre2 installed, and I don't see any problems ....

Re: sway: added pcre2 runtime dependency

[subnut]

[-- Attachment #1: Type: text/plain, Size: 208 bytes --]

New comment by subnut on void-packages repository

https://github.com/void-linux/void-packages/pull/42513#issuecomment-1448957015

Comment:
@Clos3y did you face any problem due to not having pcre2 installed?

Re: sway: added pcre2 runtime dependency

[Clos3y]

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

New comment by Clos3y on void-packages repository

https://github.com/void-linux/void-packages/pull/42513#issuecomment-1448957064

Comment:
> what was the error?

Okay let me spin up the VM one second

Re: sway: added pcre2 runtime dependency

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42513#issuecomment-1448957248

Comment:
you can't expect upstreams to list things in exactly the way that void packages them most of the time, they probably mean libpcre2 but just say the name of the whole library

Re: sway: added pcre2 runtime dependency

[Clos3y]

[-- Attachment #1: Type: text/plain, Size: 339 bytes --]

New comment by Clos3y on void-packages repository

https://github.com/void-linux/void-packages/pull/42513#issuecomment-1448957064

Comment:
> what was the error?

Okay let me spin up the VM one second

EDIT: Okay my dl speed from the repos has tanked to 20kB/s, so it's gonna take _a while_ for me to get the VM to the state it was in

Re: sway: added pcre2 runtime dependency

[Clos3y]

[-- Attachment #1: Type: text/plain, Size: 319 bytes --]

New comment by Clos3y on void-packages repository

https://github.com/void-linux/void-packages/pull/42513#issuecomment-1449027377

Comment:
Sorry, I can't get the vm up yet, my download speed from the repos is too low to do it in a reasonable time. I'll close this pr and once I've confirmed the issue raise it as such

Re: [PR PATCH] [Closed]: sway: added pcre2 runtime dependency

[Clos3y]

[-- Attachment #1: Type: text/plain, Size: 326 bytes --]

There's a closed pull request on the void-packages repository

sway: added pcre2 runtime dependency
https://github.com/void-linux/void-packages/pull/42513

Description:
#### Testing the changes
- I tested the changes in this PR: YES

#### Local build testing
- I built this PR locally for my native architecture, (x86-64)

Re: sway: added pcre2 runtime dependency

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 267 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42513#issuecomment-1449074643

Comment:
next time, just leave it open, there's no urgency. opening/closing creates extra noise for people subscribed to the repo

Re: sway: added pcre2 runtime dependency

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 287 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42513#issuecomment-1449074643

Comment:
next time, just leave it open or mark it as draft, there's no urgency. opening/closing creates extra noise for people subscribed to the repo

Re: sway: added pcre2 runtime dependency

[Clos3y]

[-- Attachment #1: Type: text/plain, Size: 270 bytes --]

New comment by Clos3y on void-packages repository

https://github.com/void-linux/void-packages/pull/42513#issuecomment-1450636962

Comment:
My bad, it wasn't pcre2 that fixed the issue: it was just a ttf font missing. Apologies for that, I'll be more careful next time.