[PR PATCH] obs: depend on v4l2loopback for virtual camera support

[PR PATCH] obs: depend on v4l2loopback for virtual camera support

[larsgrah]

[-- Attachment #1: Type: text/plain, Size: 458 bytes --]

There is a new pull request by larsgrah against master on the void-packages repository

https://github.com/larsgrah/void-packages master
https://github.com/void-linux/void-packages/pull/42563

obs: depend on v4l2loopback for virtual camera support
#### Testing the changes
- I tested the changes in this PR: **YES**

This dependency enables virtual camera support

A patch file from https://github.com/void-linux/void-packages/pull/42563.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-42563.patch --]
[-- Type: text/x-diff, Size: 1125 bytes --]

From cf2d7ad9ea5a36e97575957aef42a43c6f43950d Mon Sep 17 00:00:00 2001
From: Lars Grahmann <lars.grahmann@virtualminds.com>
Date: Fri, 3 Mar 2023 10:27:33 +0100
Subject: [PATCH] obs: depend on v4l2loopback for virtual camera support

---
 srcpkgs/obs/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/obs/template b/srcpkgs/obs/template
index 1a7132ae832f..54c0c9acdd4f 100644
--- a/srcpkgs/obs/template
+++ b/srcpkgs/obs/template
@@ -1,7 +1,7 @@
 # Template file for 'obs'
 pkgname=obs
 version=29.0.2
-revision=1
+revision=2
 archs="i686* x86_64* ppc64le* aarch64*"
 build_style=cmake
 configure_args="-DOBS_VERSION_OVERRIDE=${version} -DENABLE_JACK=ON
@@ -13,7 +13,7 @@ makedepends="LuaJIT-devel fdk-aac-devel ffmpeg-devel glu-devel
  vlc-devel qt6-svg-devel x264-devel mbedtls-devel jansson-devel
  wayland-devel pipewire-devel libxkbcommon-devel pciutils-devel
  librist-devel srt-devel"
-depends="xset xdg-desktop-portal"
+depends="xset xdg-desktop-portal v4l2loopback"
 short_desc="Open Broadcaster Software"
 maintainer="lemmi <lemmi@nerd2nerd.org>"
 license="GPL-2.0-or-later"

Re: obs: depend on v4l2loopback for virtual camera support

[lemmi]

[-- Attachment #1: Type: text/plain, Size: 674 bytes --]

New comment by lemmi on void-packages repository

https://github.com/void-linux/void-packages/pull/42563#issuecomment-1453254010

Comment:
I'm not a fan of including `v4l2loopback` as a dependency. Since it is a `dkms` module, it pulls in a whole bunch of other stuff like `gcc` and `linux-headers` that not everybody necessarily needs. Also installing `v4l2loopback` alone won't magically make virtual cam work. You still need to load the module and configure it. At that point you already need to know enough that I would assume installing a package manually shouldn't be too hard a task. 
At the moment this doesn't have my support, but I'm open hearing other opinions.

Re: obs: depend on v4l2loopback for virtual camera support

[larsgrah]

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

New comment by larsgrah on void-packages repository

https://github.com/void-linux/void-packages/pull/42563#issuecomment-1453260619

Comment:
Not entirely sure what you mean, when installing v4l2loopback the modues got configured automatically for me. In what setup would that not work? After starting obs after installing it, virtual camera worked ootb

Re: obs: depend on v4l2loopback for virtual camera support

[larsgrah]

[-- Attachment #1: Type: text/plain, Size: 357 bytes --]

New comment by larsgrah on void-packages repository

https://github.com/void-linux/void-packages/pull/42563#issuecomment-1453260619

Comment:
Not entirely sure what you mean, when installing v4l2loopback the modules got configured automatically for me. In what setup would that not work? After starting obs after installing it, virtual camera worked ootb

Re: obs: depend on v4l2loopback for virtual camera support

[lemmi]

[-- Attachment #1: Type: text/plain, Size: 432 bytes --]

New comment by lemmi on void-packages repository

https://github.com/void-linux/void-packages/pull/42563#issuecomment-1453274522

Comment:
I quickly checked again and the module isn't loaded for me by default as far as I can tell. I'm also not sure whether adding `exclusive_caps=1` is still required for it to show up in `chromium`. So no ootb experience for me and the other point of quite a large number of dependencies remains.

Re: obs: depend on v4l2loopback for virtual camera support

[larsgrah]

[-- Attachment #1: Type: text/plain, Size: 332 bytes --]

New comment by larsgrah on void-packages repository

https://github.com/void-linux/void-packages/pull/42563#issuecomment-1453285601

Comment:
Hm, unfortunately i cannot reproduce your experience. Currently unsure why it would not be loaded after being installed.

FWIW https://bugs.archlinux.org/task/69918 on arch it is included

Re: obs: depend on v4l2loopback for virtual camera support

[larsgrah]

[-- Attachment #1: Type: text/plain, Size: 450 bytes --]

New comment by larsgrah on void-packages repository

https://github.com/void-linux/void-packages/pull/42563#issuecomment-1453285601

Comment:
Hm, unfortunately i cannot reproduce your experience. Currently unsure why it would not be loaded after being installed.

FWIW https://bugs.archlinux.org/task/69918 on arch it is included, not sure if xbps has the concept of optional deps though https://archlinux.org/packages/community/x86_64/obs-studio/

Re: obs: depend on v4l2loopback for virtual camera support

[larsgrah]

[-- Attachment #1: Type: text/plain, Size: 634 bytes --]

New comment by larsgrah on void-packages repository

https://github.com/void-linux/void-packages/pull/42563#issuecomment-1453285601

Comment:
Hm, unfortunately i cannot reproduce your experience. Currently unsure why it would not be loaded after being installed.

FWIW https://bugs.archlinux.org/task/69918 on arch it is included, not sure if xbps has the concept of optional deps though https://archlinux.org/packages/community/x86_64/obs-studio/

If its not merged based on the added deps its fine too i think, since its easy to solve the problem by manually installing the pkg. Just a bit confusing why the button was missing.

Re: obs: depend on v4l2loopback for virtual camera support

[larsgrah]

[-- Attachment #1: Type: text/plain, Size: 652 bytes --]

New comment by larsgrah on void-packages repository

https://github.com/void-linux/void-packages/pull/42563#issuecomment-1453285601

Comment:
Hm, unfortunately i cannot reproduce your experience. Currently unsure why it would not be loaded after being installed.

FWIW https://bugs.archlinux.org/task/69918 on arch it is included, not sure if xbps has the concept of optional deps though https://archlinux.org/packages/community/x86_64/obs-studio/

If its not merged based on the added deps its fine too i think, since its easy to solve the problem by manually installing the pkg. Just a bit confusing why the button for remote camera was missing.

Re: obs: depend on v4l2loopback for virtual camera support

[lemmi]

[-- Attachment #1: Type: text/plain, Size: 560 bytes --]

New comment by lemmi on void-packages repository

https://github.com/void-linux/void-packages/pull/42563#issuecomment-1453308919

Comment:
Sadly we don't have optional dependencies, it would definitely be the right use case here. Maybe upstream could be convinced to display an error or hint that the module needs to be installed and loaded for virtual cam to work. Most we can do is display an install message, but I doubt it has the necessary visibility to justify the added spam.
For the moment I considered this closed. Still, thank your for your effort.

Re: [PR PATCH] [Closed]: obs: depend on v4l2loopback for virtual camera support

[lemmi]

[-- Attachment #1: Type: text/plain, Size: 306 bytes --]

There's a closed pull request on the void-packages repository

obs: depend on v4l2loopback for virtual camera support
https://github.com/void-linux/void-packages/pull/42563

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

This dependency enables virtual camera support