[PR PATCH] qpdfview: update to 0.5

[PR PATCH] qpdfview: update to 0.5

[zen0bit]

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

There is a new pull request by zen0bit against master on the void-packages repository

https://github.com/oSoWoSo/VUR qpdfview
https://github.com/void-linux/void-packages/pull/42542

qpdfview: update to 0.5
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (x64 glibc)

A patch file from https://github.com/void-linux/void-packages/pull/42542.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-qpdfview-42542.patch --]
[-- Type: text/x-diff, Size: 1235 bytes --]

From 5b1697a6396799a12d96b74c7806b44a91dd82d9 Mon Sep 17 00:00:00 2001
From: zenobit <zen@osowoso.xyz>
Date: Thu, 2 Mar 2023 05:25:50 +0100
Subject: [PATCH] qpdfview: update to 0.5

---
 srcpkgs/qpdfview/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/qpdfview/template b/srcpkgs/qpdfview/template
index 39b48cb70a95..a51d65de20a6 100644
--- a/srcpkgs/qpdfview/template
+++ b/srcpkgs/qpdfview/template
@@ -1,7 +1,7 @@
 # Template file for 'qpdfview'
 pkgname=qpdfview
-version=0.4.18
-revision=2
+version=0.5
+revision=1
 build_style=qmake
 configure_args="qpdfview.pro"
 hostmakedepends="pkg-config qt5-host-tools qt5-qmake"
@@ -12,8 +12,8 @@ short_desc="Tabbed document viewer"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
 homepage="https://launchpad.net/qpdfview"
-distfiles="https://launchpad.net/qpdfview/trunk/${version}/+download/qpdfview-${version}.tar.gz"
-checksum=cc642e7fa74029373ca9b9fbc29adc4883f8b455130a78ad54746d6844a0396c
+distfiles="https://launchpad.net/qpdfview/trunk/${version}.0/+download/qpdfview-${version}.tar.gz"
+checksum=44efc440a461cbdd757a9b396f1461ee7a2f4364e81df55bd0221f910219be99
 
 pre_configure() {
 	lrelease qpdfview.pro

Re: [PR REVIEW] qpdfview: update to 0.5

[abenson]

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/42542#discussion_r1123944758

Comment:
Why not set version as 0.5.0?

Re: [PR REVIEW] qpdfview: update to 0.5

[zen0bit]

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

New review comment by zen0bit on void-packages repository

https://github.com/void-linux/void-packages/pull/42542#discussion_r1123986588

Comment:
Because full link is...

https://launchpad.net/qpdfview/trunk/0.5.0/+download/qpdfview-0.5.tar.gz

Re: [PR REVIEW] qpdfview: update to 0.5

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42542#discussion_r1125621390

Comment:
upstream calls the release 0.5.0: https://launchpad.net/qpdfview/+announcement/30778

Re: [PR PATCH] [Updated] qpdfview: update to 0.5

[zen0bit]

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]

There is an updated pull request by zen0bit against master on the void-packages repository

https://github.com/oSoWoSo/VUR qpdfview
https://github.com/void-linux/void-packages/pull/42542

qpdfview: update to 0.5
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (x64 glibc)

A patch file from https://github.com/void-linux/void-packages/pull/42542.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-qpdfview-42542.patch --]
[-- Type: text/x-diff, Size: 1228 bytes --]

From f8884c237bb68831b8a5ad1091154c8791078f1b Mon Sep 17 00:00:00 2001
From: zenobit <zen@osowoso.xyz>
Date: Thu, 2 Mar 2023 05:25:50 +0100
Subject: [PATCH] qpdfview: update to 0.5

---
 srcpkgs/qpdfview/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/qpdfview/template b/srcpkgs/qpdfview/template
index 39b48cb70a95..335c95eeb6e2 100644
--- a/srcpkgs/qpdfview/template
+++ b/srcpkgs/qpdfview/template
@@ -1,7 +1,7 @@
 # Template file for 'qpdfview'
 pkgname=qpdfview
-version=0.4.18
-revision=2
+version=0.5.0
+revision=1
 build_style=qmake
 configure_args="qpdfview.pro"
 hostmakedepends="pkg-config qt5-host-tools qt5-qmake"
@@ -12,8 +12,8 @@ short_desc="Tabbed document viewer"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
 homepage="https://launchpad.net/qpdfview"
-distfiles="https://launchpad.net/qpdfview/trunk/${version}/+download/qpdfview-${version}.tar.gz"
-checksum=cc642e7fa74029373ca9b9fbc29adc4883f8b455130a78ad54746d6844a0396c
+distfiles="https://launchpad.net/qpdfview/trunk/${version}/+download/qpdfview-0.5.tar.gz"
+checksum=44efc440a461cbdd757a9b396f1461ee7a2f4364e81df55bd0221f910219be99
 
 pre_configure() {
 	lrelease qpdfview.pro

Re: [PR REVIEW] qpdfview: update to 0.5

[zen0bit]

[-- Attachment #1: Type: text/plain, Size: 162 bytes --]

New review comment by zen0bit on void-packages repository

https://github.com/void-linux/void-packages/pull/42542#discussion_r1125641822

Comment:
As you wish...

Re: [PR PATCH] [Updated] qpdfview: update to 0.5.0

[zen0bit]

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

There is an updated pull request by zen0bit against master on the void-packages repository

https://github.com/oSoWoSo/VUR qpdfview
https://github.com/void-linux/void-packages/pull/42542

qpdfview: update to 0.5.0
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (x64 glibc)

A patch file from https://github.com/void-linux/void-packages/pull/42542.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-qpdfview-42542.patch --]
[-- Type: text/x-diff, Size: 1230 bytes --]

From 1ed35a3d83f6cdb871dfdd5b955cd5b7ac9d7d98 Mon Sep 17 00:00:00 2001
From: zenobit <zen@osowoso.xyz>
Date: Thu, 2 Mar 2023 05:25:50 +0100
Subject: [PATCH] qpdfview: update to 0.5.0

---
 srcpkgs/qpdfview/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/qpdfview/template b/srcpkgs/qpdfview/template
index 39b48cb70a95..335c95eeb6e2 100644
--- a/srcpkgs/qpdfview/template
+++ b/srcpkgs/qpdfview/template
@@ -1,7 +1,7 @@
 # Template file for 'qpdfview'
 pkgname=qpdfview
-version=0.4.18
-revision=2
+version=0.5.0
+revision=1
 build_style=qmake
 configure_args="qpdfview.pro"
 hostmakedepends="pkg-config qt5-host-tools qt5-qmake"
@@ -12,8 +12,8 @@ short_desc="Tabbed document viewer"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
 homepage="https://launchpad.net/qpdfview"
-distfiles="https://launchpad.net/qpdfview/trunk/${version}/+download/qpdfview-${version}.tar.gz"
-checksum=cc642e7fa74029373ca9b9fbc29adc4883f8b455130a78ad54746d6844a0396c
+distfiles="https://launchpad.net/qpdfview/trunk/${version}/+download/qpdfview-0.5.tar.gz"
+checksum=44efc440a461cbdd757a9b396f1461ee7a2f4364e81df55bd0221f910219be99
 
 pre_configure() {
 	lrelease qpdfview.pro

Re: [PR PATCH] [Updated] qpdfview: update to 0.5.0

[zen0bit]

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

There is an updated pull request by zen0bit against master on the void-packages repository

https://github.com/oSoWoSo/VUR qpdfview
https://github.com/void-linux/void-packages/pull/42542

qpdfview: update to 0.5.0
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (x64 glibc)

A patch file from https://github.com/void-linux/void-packages/pull/42542.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-qpdfview-42542.patch --]
[-- Type: text/x-diff, Size: 1230 bytes --]

From ea54d69769e68987411f8b918c66cc36dc032f15 Mon Sep 17 00:00:00 2001
From: zenobit <zen@osowoso.xyz>
Date: Sun, 5 Mar 2023 12:25:41 +0100
Subject: [PATCH] qpdfview: update to 0.5.0

---
 srcpkgs/qpdfview/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/qpdfview/template b/srcpkgs/qpdfview/template
index 39b48cb70a95..335c95eeb6e2 100644
--- a/srcpkgs/qpdfview/template
+++ b/srcpkgs/qpdfview/template
@@ -1,7 +1,7 @@
 # Template file for 'qpdfview'
 pkgname=qpdfview
-version=0.4.18
-revision=2
+version=0.5.0
+revision=1
 build_style=qmake
 configure_args="qpdfview.pro"
 hostmakedepends="pkg-config qt5-host-tools qt5-qmake"
@@ -12,8 +12,8 @@ short_desc="Tabbed document viewer"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
 homepage="https://launchpad.net/qpdfview"
-distfiles="https://launchpad.net/qpdfview/trunk/${version}/+download/qpdfview-${version}.tar.gz"
-checksum=cc642e7fa74029373ca9b9fbc29adc4883f8b455130a78ad54746d6844a0396c
+distfiles="https://launchpad.net/qpdfview/trunk/${version}/+download/qpdfview-0.5.tar.gz"
+checksum=44efc440a461cbdd757a9b396f1461ee7a2f4364e81df55bd0221f910219be99
 
 pre_configure() {
 	lrelease qpdfview.pro

Re: [PR REVIEW] qpdfview: update to 0.5.0

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

New review comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/42542#discussion_r1133288287

Comment:
use ${version} here

Re: [PR REVIEW] qpdfview: update to 0.5.0

[zen0bit]

[-- Attachment #1: Type: text/plain, Size: 378 bytes --]

New review comment by zen0bit on void-packages repository

https://github.com/void-linux/void-packages/pull/42542#discussion_r1133823093

Comment:
it wouldnt match then

version=**0.5.0**
file name qpdfview-**0.5**.tar.gz no **.0** here

I think better leave as is for now
then
Could be changed with new release with proper naming convention

or maybe patch for now?

Re: [PR REVIEW] qpdfview: update to 0.5.0

[zen0bit]

[-- Attachment #1: Type: text/plain, Size: 467 bytes --]

New review comment by zen0bit on void-packages repository

https://github.com/void-linux/void-packages/pull/42542#discussion_r1133834186

Comment:
`version=0.5.0`
`distfiles="https://launchpad.net/qpdfview/trunk/${version}/+download/qpdfview-0.5.tar.gz"`

or

`version=0.5`
`distfiles="https://launchpad.net/qpdfview/trunk/${version}.0/+download/qpdfview-${version}.tar.gz"`

File name version number differ from upstream version number 
How to handle that?

Re: [PR PATCH] [Merged]: qpdfview: update to 0.5.0

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 326 bytes --]

There's a merged pull request on the void-packages repository

qpdfview: update to 0.5.0
https://github.com/void-linux/void-packages/pull/42542

Description:
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (x64 glibc)