[PR PATCH] New package: bash-language-server-4.8.3

[PR PATCH] New package: bash-language-server-4.8.3

[sirkhancision]

[-- Attachment #1: Type: text/plain, Size: 776 bytes --]

There is a new pull request by sirkhancision against master on the void-packages repository

https://github.com/sirkhancision/void-packages bash-language-server
https://github.com/void-linux/void-packages/pull/42818

New package: bash-language-server-4.8.3
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures:
  - i686
  - x86_64-musl


A patch file from https://github.com/void-linux/void-packages/pull/42818.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-bash-language-server-42818.patch --]
[-- Type: text/x-diff, Size: 1645 bytes --]

From 5573f695fa7ee77a1ac35cea40ab27e0e9f7b1b6 Mon Sep 17 00:00:00 2001
From: sirkhancision <jsantiago12tone@gmail.com>
Date: Fri, 17 Mar 2023 04:28:47 -0300
Subject: [PATCH] New package: bash-language-server-4.8.3

---
 srcpkgs/bash-language-server/template | 37 +++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 srcpkgs/bash-language-server/template

diff --git a/srcpkgs/bash-language-server/template b/srcpkgs/bash-language-server/template
new file mode 100644
index 000000000000..a5618ac20daa
--- /dev/null
+++ b/srcpkgs/bash-language-server/template
@@ -0,0 +1,37 @@
+# Template file for 'bash-language-server'
+pkgname=bash-language-server
+version=4.8.3
+revision=1
+archs="i686 x86_64"
+hostmakedepends="jq yarn"
+depends="nodejs"
+short_desc="Bash language server"
+maintainer="sirkhancision <jsantiago12tone@gmail.com>"
+license="MIT"
+homepage="https://github.com/bash-lsp/bash-language-server"
+distfiles="https://github.com/bash-lsp/bash-language-server/archive/refs/tags/server-${version}.tar.gz"
+checksum=a6c367e19a007b889f59fa7aa6a8c4fb0fae83fbfcc928e7a8f4366015dedbd6
+
+do_build() {
+	yarn
+	yarn run compile
+}
+
+do_install() {
+	TARGET_PATH="usr/lib/${pkgname}"
+	cd server
+
+	cp package.json{,.bak}
+	read -ra devDependencies < <(jq -r '.devDependencies | keys | join(" ")' package.json)
+	yarn remove --frozen-lockfile "${devDependencies[@]}"
+	mv package.json{.bak,}
+
+	vmkdir ${TARGET_PATH}
+	vcopy * ${TARGET_PATH}
+
+	vmkdir usr/bin
+	ln -sf /${TARGET_PATH}/out/cli.js ${DESTDIR}/usr/bin/${pkgname}
+	chmod 0755 ${DESTDIR}/${TARGET_PATH}/out/cli.js
+
+	vlicense ${wrksrc}/LICENSE
+}

Re: New package: bash-language-server-4.8.3

[sirkhancision]

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

New comment by sirkhancision on void-packages repository

https://github.com/void-linux/void-packages/pull/42818#issuecomment-1473981574

Comment:
This also resolves #38606

Re: New package: bash-language-server-4.8.3

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

New comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/42818#issuecomment-1474327927

Comment:
Unfortunate to have a language server for bash being available only under `i686` & `x86_64`.

Re: New package: bash-language-server-4.8.3

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42818#issuecomment-1474442320

Comment:
how did you build this for x86_64-musl when `archs="i686 x86_64"`?

Re: [PR PATCH] [Updated] New package: bash-language-server-4.8.3

[sirkhancision]

[-- Attachment #1: Type: text/plain, Size: 781 bytes --]

There is an updated pull request by sirkhancision against master on the void-packages repository

https://github.com/sirkhancision/void-packages bash-language-server
https://github.com/void-linux/void-packages/pull/42818

New package: bash-language-server-4.8.3
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures:
  - i686
  - x86_64-musl


A patch file from https://github.com/void-linux/void-packages/pull/42818.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-bash-language-server-42818.patch --]
[-- Type: text/x-diff, Size: 1654 bytes --]

From b933346ebf00d5c5869da417c6d0ff5e7a7434da Mon Sep 17 00:00:00 2001
From: sirkhancision <jsantiago12tone@gmail.com>
Date: Fri, 17 Mar 2023 04:28:47 -0300
Subject: [PATCH] New package: bash-language-server-4.8.3

---
 srcpkgs/bash-language-server/template | 37 +++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 srcpkgs/bash-language-server/template

diff --git a/srcpkgs/bash-language-server/template b/srcpkgs/bash-language-server/template
new file mode 100644
index 000000000000..1537340f3f37
--- /dev/null
+++ b/srcpkgs/bash-language-server/template
@@ -0,0 +1,37 @@
+# Template file for 'bash-language-server'
+pkgname=bash-language-server
+version=4.8.3
+revision=1
+#archs="i686-glibc x86_64-*"
+hostmakedepends="jq yarn"
+depends="nodejs"
+short_desc="Bash language server"
+maintainer="sirkhancision <jsantiago12tone@gmail.com>"
+license="MIT"
+homepage="https://github.com/bash-lsp/bash-language-server"
+distfiles="https://github.com/bash-lsp/bash-language-server/archive/refs/tags/server-${version}.tar.gz"
+checksum=a6c367e19a007b889f59fa7aa6a8c4fb0fae83fbfcc928e7a8f4366015dedbd6
+
+do_build() {
+	yarn
+	yarn run compile
+}
+
+do_install() {
+	TARGET_PATH="usr/lib/${pkgname}"
+	cd server
+
+	cp package.json{,.bak}
+	read -ra devDependencies < <(jq -r '.devDependencies | keys | join(" ")' package.json)
+	yarn remove --frozen-lockfile "${devDependencies[@]}"
+	mv package.json{.bak,}
+
+	vmkdir ${TARGET_PATH}
+	vcopy * ${TARGET_PATH}
+
+	vmkdir usr/bin
+	ln -sf /${TARGET_PATH}/out/cli.js ${DESTDIR}/usr/bin/${pkgname}
+	chmod 0755 ${DESTDIR}/${TARGET_PATH}/out/cli.js
+
+	vlicense ${wrksrc}/LICENSE
+}

Re: New package: bash-language-server-4.8.3

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 285 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42818#issuecomment-1474467934

Comment:
> Unfortunate to have a language server for bash being available only under `i686` & `x86_64`.

cross-compiles fine for me 🤷‍♀️

Re: [PR REVIEW] New package: bash-language-server-4.8.3

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42818#discussion_r1140761902

Comment:
```suggestion
	read -ra _devDependencies < <(jq -r '.devDependencies | keys | join(" ")' package.json)
	yarn remove --frozen-lockfile "${_devDependencies[@]}"
```

Re: [PR REVIEW] New package: bash-language-server-4.8.3

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42818#discussion_r1140762181

Comment:
```suggestion
	vlicense LICENSE
```

Re: New package: bash-language-server-4.8.3

[sirkhancision]

[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

New comment by sirkhancision on void-packages repository

https://github.com/void-linux/void-packages/pull/42818#issuecomment-1474468393

Comment:
> how did you build this for x86_64-musl when `archs="i686 x86_64"`?

My bad, I had built it before restricting the architectures, and I thought x86_64 meant both glibc and musl. It's corrected now, and limiting i686 to glibc, as building it for me fails in other architectures.

Re: New package: bash-language-server-4.8.3

[sirkhancision]

[-- Attachment #1: Type: text/plain, Size: 418 bytes --]

New comment by sirkhancision on void-packages repository

https://github.com/void-linux/void-packages/pull/42818#issuecomment-1474468393

Comment:
> how did you build this for x86_64-musl when `archs="i686 x86_64"`?

My bad, I had built it before restricting the architectures, and I thought x86_64 meant both glibc and musl. It's corrected now, and limiting i686 to glibc, as building it in i686-musl fails for me.

Re: New package: bash-language-server-4.8.3

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 285 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42818#issuecomment-1474470176

Comment:
i686-musl doesn't really exist, so don't worry about it.

`[archname]` means glibc, `[archname]-musl` means musl, `[archname]-*` is both

Re: [PR REVIEW] New package: bash-language-server-4.8.3

[sirkhancision]

[-- Attachment #1: Type: text/plain, Size: 248 bytes --]

New review comment by sirkhancision on void-packages repository

https://github.com/void-linux/void-packages/pull/42818#discussion_r1140777513

Comment:
This is because of the previous `cd` used, meaning that the license is at the child directory.

Re: [PR REVIEW] New package: bash-language-server-4.8.3

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 168 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42818#discussion_r1140778523

Comment:
../LICENSE then

Re: New package: bash-language-server-4.8.3

[sirkhancision]

[-- Attachment #1: Type: text/plain, Size: 429 bytes --]

New comment by sirkhancision on void-packages repository

https://github.com/void-linux/void-packages/pull/42818#issuecomment-1474478893

Comment:
> i686-musl doesn't really exist, so don't worry about it.
> 
> `[archname]` means glibc, `[archname]-musl` means musl, `[archname]-*` is both

I rewrote it as `x86_64-*` but it's now saying that the package can't be built for x86_64, any ideas as to why that is happening now?

Re: New package: bash-language-server-4.8.3

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 248 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42818#issuecomment-1474479923

Comment:
sorry `x86_64*` (no dash), but you shouldn't need to specify the archs, it should work on all of them

Re: New package: bash-language-server-4.8.3

[sirkhancision]

[-- Attachment #1: Type: text/plain, Size: 453 bytes --]

New comment by sirkhancision on void-packages repository

https://github.com/void-linux/void-packages/pull/42818#issuecomment-1474480051

Comment:
> > Unfortunate to have a language server for bash being available only under `i686` & `x86_64`.
> 
> cross-compiles fine for me woman_shrugging

To me, it says:
`=> ERROR: nodejs-16.19.0_1: cannot be cross compiled...`

`=> ERROR: nodejs-16.19.0_1: host and target must have the same pointer size`

Re: New package: bash-language-server-4.8.3

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42818#issuecomment-1474483939

Comment:
it works on aarch64, but you shouldn't limit the arch because of that error: someone can still build it for themselves either natively or cross from 32bit

Re: [PR PATCH] [Updated] New package: bash-language-server-4.8.3

[sirkhancision]

[-- Attachment #1: Type: text/plain, Size: 781 bytes --]

There is an updated pull request by sirkhancision against master on the void-packages repository

https://github.com/sirkhancision/void-packages bash-language-server
https://github.com/void-linux/void-packages/pull/42818

New package: bash-language-server-4.8.3
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures:
  - i686
  - x86_64-musl


A patch file from https://github.com/void-linux/void-packages/pull/42818.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-bash-language-server-42818.patch --]
[-- Type: text/x-diff, Size: 1619 bytes --]

From 93fb792e99e77eb5e71dce6b544e41bb8e85675e Mon Sep 17 00:00:00 2001
From: sirkhancision <jsantiago12tone@gmail.com>
Date: Fri, 17 Mar 2023 04:28:47 -0300
Subject: [PATCH] New package: bash-language-server-4.8.3

---
 srcpkgs/bash-language-server/template | 36 +++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)
 create mode 100644 srcpkgs/bash-language-server/template

diff --git a/srcpkgs/bash-language-server/template b/srcpkgs/bash-language-server/template
new file mode 100644
index 000000000000..02fcb44dfbf2
--- /dev/null
+++ b/srcpkgs/bash-language-server/template
@@ -0,0 +1,36 @@
+# Template file for 'bash-language-server'
+pkgname=bash-language-server
+version=4.8.3
+revision=1
+hostmakedepends="jq yarn"
+depends="nodejs"
+short_desc="Bash language server"
+maintainer="sirkhancision <jsantiago12tone@gmail.com>"
+license="MIT"
+homepage="https://github.com/bash-lsp/bash-language-server"
+distfiles="https://github.com/bash-lsp/bash-language-server/archive/refs/tags/server-${version}.tar.gz"
+checksum=a6c367e19a007b889f59fa7aa6a8c4fb0fae83fbfcc928e7a8f4366015dedbd6
+
+do_build() {
+	yarn
+	yarn run compile
+}
+
+do_install() {
+	TARGET_PATH="usr/lib/${pkgname}"
+	cd server
+
+	cp package.json{,.bak}
+	read -ra _devDependencies < <(jq -r '.devDependencies | keys | join(" ")' package.json)
+	yarn remove --frozen-lockfile "${_devDependencies[@]}"
+	mv package.json{.bak,}
+
+	vmkdir ${TARGET_PATH}
+	vcopy * ${TARGET_PATH}
+
+	vmkdir usr/bin
+	ln -sf /${TARGET_PATH}/out/cli.js ${DESTDIR}/usr/bin/${pkgname}
+	chmod 0755 ${DESTDIR}/${TARGET_PATH}/out/cli.js
+
+	vlicense ../LICENSE
+}

Re: New package: bash-language-server-4.8.3

[sirkhancision]

[-- Attachment #1: Type: text/plain, Size: 446 bytes --]

New comment by sirkhancision on void-packages repository

https://github.com/void-linux/void-packages/pull/42818#issuecomment-1474500540

Comment:
> it works on aarch64, but you shouldn't limit the arch because of that error: someone can still build it for themselves either natively or cross from 32bit

Indeed, it built fine on aarch64. Thanks for the help with these packages, and the tips, you're awesome!

I think it might be fine, now.