* [PR PATCH] vault: enable UI build by default
@ 2023-03-20 17:42 Vaelatern
2023-03-20 18:00 ` the-maldridge
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Vaelatern @ 2023-03-20 17:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 514 bytes --]
There is a new pull request by Vaelatern against master on the void-packages repository
https://github.com/Vaelatern/void-packages vault-ui
https://github.com/void-linux/void-packages/pull/42884
vault: enable UI build by default
@the-maldridge I got this working, do we want it enabled by default like upstream?
I checked for a distfile that had the assets already built, would welcome someone finding such a tarball.
A patch file from https://github.com/void-linux/void-packages/pull/42884.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-vault-ui-42884.patch --]
[-- Type: text/x-diff, Size: 1460 bytes --]
From 85169c650ad278a70c4fa78ae6f1e21ac31f582a Mon Sep 17 00:00:00 2001
From: Toyam Cox <Vaelatern@voidlinux.org>
Date: Mon, 20 Mar 2023 13:41:22 -0400
Subject: [PATCH] vault: enable UI build by default
---
srcpkgs/vault/template | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/vault/template b/srcpkgs/vault/template
index 28bff52ec6f0..04d6bd3da931 100644
--- a/srcpkgs/vault/template
+++ b/srcpkgs/vault/template
@@ -1,12 +1,13 @@
# Template file for 'vault'
pkgname=vault
version=1.13.0
-revision=1
+revision=2
build_style=go
go_import_path="github.com/hashicorp/vault"
-go_build_tags="release"
+go_build_tags="release $(vopt_if ui ui)"
_git_commit=a4cf0dc4437de35fce4860857b64569d092a9b5a
go_ldflags="-X ${go_import_path}/sdk/version.GitCommit=${_git_commit}"
+hostmakedepends="$(vopt_if ui yarn)"
depends="libcap-progs"
short_desc="Manage Secrets and Protect Sensitive Data"
maintainer="Michael Aldridge <maldridge@voidlinux.org>"
@@ -17,11 +18,19 @@ checksum=ebffe482b9e23346862272fbab7d589315200f2004b63b26b2df43823a5d3fb6
system_accounts="_vault"
make_dirs="/var/lib/vault 0700 _vault _vault
/etc/vault 0750 root _vault"
+build_options="ui"
+build_options_default="ui"
case "$XBPS_TARGET_MACHINE" in
arm*) go_ldflags="$go_ldflags -linkmode=external";;
esac
+pre_build() {
+ if [ "$build_option_ui" ]; then
+ make static-dist
+ fi
+}
+
post_install() {
vlicense LICENSE
vsv vault
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: vault: enable UI build by default
2023-03-20 17:42 [PR PATCH] vault: enable UI build by default Vaelatern
@ 2023-03-20 18:00 ` the-maldridge
2023-06-19 1:59 ` github-actions
2023-06-19 16:04 ` [PR PATCH] [Closed]: " Vaelatern
2 siblings, 0 replies; 4+ messages in thread
From: the-maldridge @ 2023-03-20 18:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 198 bytes --]
New comment by the-maldridge on void-packages repository
https://github.com/void-linux/void-packages/pull/42884#issuecomment-1476696457
Comment:
Cf. https://github.com/hashicorp/vault/issues/7350
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: vault: enable UI build by default
2023-03-20 17:42 [PR PATCH] vault: enable UI build by default Vaelatern
2023-03-20 18:00 ` the-maldridge
@ 2023-06-19 1:59 ` github-actions
2023-06-19 16:04 ` [PR PATCH] [Closed]: " Vaelatern
2 siblings, 0 replies; 4+ messages in thread
From: github-actions @ 2023-06-19 1:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/42884#issuecomment-1596374349
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PR PATCH] [Closed]: vault: enable UI build by default
2023-03-20 17:42 [PR PATCH] vault: enable UI build by default Vaelatern
2023-03-20 18:00 ` the-maldridge
2023-06-19 1:59 ` github-actions
@ 2023-06-19 16:04 ` Vaelatern
2 siblings, 0 replies; 4+ messages in thread
From: Vaelatern @ 2023-06-19 16:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 358 bytes --]
There's a closed pull request on the void-packages repository
vault: enable UI build by default
https://github.com/void-linux/void-packages/pull/42884
Description:
@the-maldridge I got this working, do we want it enabled by default like upstream?
I checked for a distfile that had the assets already built, would welcome someone finding such a tarball.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-19 16:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-20 17:42 [PR PATCH] vault: enable UI build by default Vaelatern
2023-03-20 18:00 ` the-maldridge
2023-06-19 1:59 ` github-actions
2023-06-19 16:04 ` [PR PATCH] [Closed]: " Vaelatern
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).