* [PR PATCH] Waybar: add libevdev to fix keyboard-status module
@ 2023-03-27 17:08 FalsePattern
2023-03-27 17:58 ` cinerea0
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: FalsePattern @ 2023-03-27 17:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 961 bytes --]
There is a new pull request by FalsePattern against master on the void-packages repository
https://github.com/FalsePattern/void-packages waybar-keyboard-state
https://github.com/void-linux/void-packages/pull/43048
Waybar: add libevdev to fix keyboard-status module
This fixes the num lock / caps lock visualizer (available in the default waybar config for verification)
I noticed that these indicators were missing, apparently this module depends on libevdev at compile time.
#### Testing the changes
- I tested the changes in this PR: **YES**
- Waybar will spam a bunch of errors if `keyboard-state` is enabled and the current user is not part of the `input` group. Once the user is added to the group, the errors disappear and the indicators work as expected.
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
A patch file from https://github.com/void-linux/void-packages/pull/43048.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-waybar-keyboard-state-43048.patch --]
[-- Type: text/x-diff, Size: 2067 bytes --]
From f7f51ba97c2083d749d25437ec7f3779e862b3c1 Mon Sep 17 00:00:00 2001
From: FalsePattern <30945458+FalsePattern@users.noreply.github.com>
Date: Mon, 27 Mar 2023 18:58:11 +0200
Subject: [PATCH] Waybar: add libevdev to fix keyboard-status module This fixes
the num lock / caps lock visualizer in the example config.
---
srcpkgs/Waybar/template | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/srcpkgs/Waybar/template b/srcpkgs/Waybar/template
index 3d3a889229f2..48dc220e8cc7 100644
--- a/srcpkgs/Waybar/template
+++ b/srcpkgs/Waybar/template
@@ -1,7 +1,7 @@
# Template file for 'Waybar'
pkgname=Waybar
version=0.9.16
-revision=1
+revision=2
_date_version=3.0.1
_mesonbuild_date_ver=3.0.0-1
build_wrksrc=Waybar-${version}
@@ -21,7 +21,8 @@ makedepends="libinput-devel wayland-devel gtkmm-devel spdlog eudev-libudev-devel
$(vopt_if pulseaudio pulseaudio-devel)
$(vopt_if dbusmenugtk libdbusmenu-gtk3-devel)
$(vopt_if mpd libmpdclient-devel)
- $(vopt_if sndio sndio-devel)"
+ $(vopt_if sndio sndio-devel)
+ $(vopt_if libevdev libevdev-devel)"
short_desc="Polybar-like Wayland Bar for Sway and Wlroots based compositors"
maintainer="Érico Nogueira <ericonr@disroot.org>"
license="MIT"
@@ -35,12 +36,13 @@ checksum="37ebd7b10e32e802afe9236ea9374fabb77b1abb2c203ca6173b27dc03128096
7a390f200f0ccd207e8cff6757e04817c1a0aec3e327b006b7eb451c57ee3538
f2aa492b59893f69367228bf802cbb0a07c4d52fac2185dfd8ebb5d16295d893"
-build_options="libnl pulseaudio dbusmenugtk mpd sndio"
-build_options_default="libnl pulseaudio dbusmenugtk mpd sndio"
+build_options="libnl pulseaudio dbusmenugtk mpd sndio libevdev"
+build_options_default="libnl pulseaudio dbusmenugtk mpd sndio libevdev"
desc_option_libnl="Enable libnl support for network related features"
desc_option_dbusmenugtk="Enable support for tray"
desc_option_mpd="Enable support for MPD"
+desc_option_libevdev="Enable support for num/caps/scroll lock visualization"
post_extract() {
mv hinnant-date-${_mesonbuild_date_ver}/meson_options.txt date-${_date_version}/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Waybar: add libevdev to fix keyboard-status module
2023-03-27 17:08 [PR PATCH] Waybar: add libevdev to fix keyboard-status module FalsePattern
@ 2023-03-27 17:58 ` cinerea0
2023-03-27 18:10 ` FalsePattern
2023-03-27 18:10 ` [PR PATCH] [Closed]: " FalsePattern
2 siblings, 0 replies; 4+ messages in thread
From: cinerea0 @ 2023-03-27 17:58 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 218 bytes --]
New comment by cinerea0 on void-packages repository
https://github.com/void-linux/void-packages/pull/43048#issuecomment-1485585293
Comment:
It seems like the changes here would be covered by #41610, is that correct?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Waybar: add libevdev to fix keyboard-status module
2023-03-27 17:08 [PR PATCH] Waybar: add libevdev to fix keyboard-status module FalsePattern
2023-03-27 17:58 ` cinerea0
@ 2023-03-27 18:10 ` FalsePattern
2023-03-27 18:10 ` [PR PATCH] [Closed]: " FalsePattern
2 siblings, 0 replies; 4+ messages in thread
From: FalsePattern @ 2023-03-27 18:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 251 bytes --]
New comment by FalsePattern on void-packages repository
https://github.com/void-linux/void-packages/pull/43048#issuecomment-1485617854
Comment:
Ah, my bad, i forgot to re-test that PR after fixing the user group, so i assumed it was something else.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PR PATCH] [Closed]: Waybar: add libevdev to fix keyboard-status module
2023-03-27 17:08 [PR PATCH] Waybar: add libevdev to fix keyboard-status module FalsePattern
2023-03-27 17:58 ` cinerea0
2023-03-27 18:10 ` FalsePattern
@ 2023-03-27 18:10 ` FalsePattern
2 siblings, 0 replies; 4+ messages in thread
From: FalsePattern @ 2023-03-27 18:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 786 bytes --]
There's a closed pull request on the void-packages repository
Waybar: add libevdev to fix keyboard-status module
https://github.com/void-linux/void-packages/pull/43048
Description:
This fixes the num lock / caps lock visualizer (available in the default waybar config for verification)
I noticed that these indicators were missing, apparently this module depends on libevdev at compile time.
#### Testing the changes
- I tested the changes in this PR: **YES**
- Waybar will spam a bunch of errors if `keyboard-state` is enabled and the current user is not part of the `input` group. Once the user is added to the group, the errors disappear and the indicators work as expected.
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-27 18:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-27 17:08 [PR PATCH] Waybar: add libevdev to fix keyboard-status module FalsePattern
2023-03-27 17:58 ` cinerea0
2023-03-27 18:10 ` FalsePattern
2023-03-27 18:10 ` [PR PATCH] [Closed]: " FalsePattern
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).