[PR PATCH] New package: font-terminus-ttf-4.49.2

[PR PATCH] New package: font-terminus-ttf-4.49.2

[milgra]

[-- Attachment #1: Type: text/plain, Size: 1016 bytes --]

There is a new pull request by milgra against master on the void-packages repository

https://github.com/milgra/void-packages font-terminus-ttf-branch
https://github.com/void-linux/void-packages/pull/42598

New package: font-terminus-ttf-4.49.2
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)

If you need terminus font in a different size what the bitmap version provides or your app doesn't support bitmap fonts then the TTF version can come handy. It is also the default font for all my applications ( https://github.com/milgra/sov, https://github.com/milgra/wcp, https://github.com/milgra/mmfm, https://github.com/milgra/vmp ) so it would be nice to have it in the source packages collection.

A patch file from https://github.com/void-linux/void-packages/pull/42598.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-font-terminus-ttf-branch-42598.patch --]
[-- Type: text/x-diff, Size: 1226 bytes --]

From da6e30172430857ffa35d5fe853abbc1785770df Mon Sep 17 00:00:00 2001
From: Milan Toth <milgra@milgra.com>
Date: Sun, 5 Mar 2023 14:11:16 +0100
Subject: [PATCH] New package: font-terminus-ttf-4.49.2

---
 srcpkgs/font-terminus-ttf/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/font-terminus-ttf/template

diff --git a/srcpkgs/font-terminus-ttf/template b/srcpkgs/font-terminus-ttf/template
new file mode 100644
index 000000000000..3d48067fe45d
--- /dev/null
+++ b/srcpkgs/font-terminus-ttf/template
@@ -0,0 +1,18 @@
+# Template file for 'font-terminus-ttf'
+pkgname=font-terminus-ttf
+version=4.49.2
+revision=1
+hostmakedepends="unzip"
+depends="font-util"
+short_desc="TTF version of the terminus monospaced bitmap font"
+maintainer="Milan Toth <milgra@milgra.com>"
+license="OFL-1.1"
+homepage="https://files.ax86.net/terminus-ttf"
+distfiles="https://files.ax86.net/terminus-ttf/files/${version}/terminus-ttf-${version}.zip"
+checksum=523bb09ec554514bedecd4d068b9d89b3bf124189542b82ab221c972d3d54664
+font_dirs="/usr/share/fonts/TTF"
+
+do_install() {
+	vmkdir usr/share/fonts/TTF
+	install -m644 terminus-ttf-${version}/TerminusTTF*.ttf ${DESTDIR}/usr/share/fonts/TTF
+}

Re: [PR REVIEW] New package: font-terminus-ttf-4.49.2

[LucasTavaresA]

[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

New review comment by LucasTavaresA on void-packages repository

https://github.com/void-linux/void-packages/pull/42598#discussion_r1127802743

Comment:
use vinstall

```suggestion
	vinstall "TerminusTTF-${version}.ttf" 644 usr/share/fonts/TTF/
	vinstall "TerminusTTF-Bold-${version}.ttf" 644 usr/share/fonts/TTF/
	vinstall "TerminusTTF-Italic-${version}.ttf" 644 usr/share/fonts/TTF/
	vinstall "TerminusTTF-Bold Italic-${version}.ttf" 644 usr/share/fonts/TTF/
```

Re: New package: font-terminus-ttf-4.49.2

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 935 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/42598#issuecomment-1458125194

Comment:
From the upstream homepage:
> While this TTF version contains both the original bitmaps from Terminus Font and new scalable outlines, the latter are somewhat ugly (and may have slightly wrong proportions). That is because they are generated automatically from the original bitmaps using [Potrace](http://potrace.sf.net/).
>
>This is not a problem if you use the font in e. g. Java applications, because they will automatically use the bitmaps (which look sharp and crisp), provided that you use a font size that has corresponding bitmaps.

Even the creator seems to think this font offers effectively nothing over the standard bitmap font. How does this square with our [quality requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements)?

Re: [PR REVIEW] New package: font-terminus-ttf-4.49.2

[milgra]

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

New review comment by milgra on void-packages repository

https://github.com/void-linux/void-packages/pull/42598#discussion_r1129203951

Comment:
Thanks, I will use this.

Re: New package: font-terminus-ttf-4.49.2

[milgra]

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

New comment by milgra on void-packages repository

https://github.com/void-linux/void-packages/pull/42598#issuecomment-1459923635

Comment:
The other TTF Terminus font option is the Terminess font in the nerd-fonts-ttf package but it's baseline is one pixel lower than Terminus TTF's and that causes problems, for example glyph-bottom-cutoff in foot ( https://codeberg.org/dnkl/foot/issues/533 ), so it is still a better quality solution. I never had quality problems with it.

Re: [PR PATCH] [Updated] New package: font-terminus-ttf-4.49.2

[milgra]

[-- Attachment #1: Type: text/plain, Size: 1021 bytes --]

There is an updated pull request by milgra against master on the void-packages repository

https://github.com/milgra/void-packages font-terminus-ttf-branch
https://github.com/void-linux/void-packages/pull/42598

New package: font-terminus-ttf-4.49.2
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)

If you need terminus font in a different size than the bitmap version provides or your app doesn't support bitmap fonts then the TTF version can come handy. It is also the default font for all my applications ( https://github.com/milgra/sov, https://github.com/milgra/wcp, https://github.com/milgra/mmfm, https://github.com/milgra/vmp ) so it would be nice to have it in the source packages collection.

A patch file from https://github.com/void-linux/void-packages/pull/42598.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-font-terminus-ttf-branch-42598.patch --]
[-- Type: text/x-diff, Size: 1454 bytes --]

From c44f8d24d1d9c101a08bb3f3916e4e700c65e4d7 Mon Sep 17 00:00:00 2001
From: Milan Toth <milgra@milgra.com>
Date: Sun, 5 Mar 2023 14:11:16 +0100
Subject: [PATCH] New package: font-terminus-ttf-4.49.2

---
 srcpkgs/font-terminus-ttf/template | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 srcpkgs/font-terminus-ttf/template

diff --git a/srcpkgs/font-terminus-ttf/template b/srcpkgs/font-terminus-ttf/template
new file mode 100644
index 000000000000..ebc12dfa1fb2
--- /dev/null
+++ b/srcpkgs/font-terminus-ttf/template
@@ -0,0 +1,21 @@
+# Template file for 'font-terminus-ttf'
+pkgname=font-terminus-ttf
+version=4.49.2
+revision=1
+hostmakedepends="unzip"
+depends="font-util"
+short_desc="TTF version of the terminus monospaced bitmap font"
+maintainer="Milan Toth <milgra@milgra.com>"
+license="OFL-1.1"
+homepage="https://files.ax86.net/terminus-ttf"
+distfiles="https://files.ax86.net/terminus-ttf/files/${version}/terminus-ttf-${version}.zip"
+checksum=523bb09ec554514bedecd4d068b9d89b3bf124189542b82ab221c972d3d54664
+font_dirs="/usr/share/fonts/TTF"
+
+do_install() {
+	vmkdir usr/share/fonts/TTF
+	vinstall "TerminusTTF-${version}.ttf" 644 usr/share/fonts/TTF/
+	vinstall "TerminusTTF-Bold-${version}.ttf" 644 usr/share/fonts/TTF/
+	vinstall "TerminusTTF-Italic-${version}.ttf" 644 usr/share/fonts/TTF/
+	vinstall "TerminusTTF-Bold Italic-${version}.ttf" 644 usr/share/fonts/TTF/}
+}
\ No newline at end of file

Re: [PR PATCH] [Updated] New package: font-terminus-ttf-4.49.2

[milgra]

[-- Attachment #1: Type: text/plain, Size: 1021 bytes --]

There is an updated pull request by milgra against master on the void-packages repository

https://github.com/milgra/void-packages font-terminus-ttf-branch
https://github.com/void-linux/void-packages/pull/42598

New package: font-terminus-ttf-4.49.2
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)

If you need terminus font in a different size than the bitmap version provides or your app doesn't support bitmap fonts then the TTF version can come handy. It is also the default font for all my applications ( https://github.com/milgra/sov, https://github.com/milgra/wcp, https://github.com/milgra/mmfm, https://github.com/milgra/vmp ) so it would be nice to have it in the source packages collection.

A patch file from https://github.com/void-linux/void-packages/pull/42598.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-font-terminus-ttf-branch-42598.patch --]
[-- Type: text/x-diff, Size: 1426 bytes --]

From 8ee0bb325d7f85214332d526716b6b0e089c238b Mon Sep 17 00:00:00 2001
From: Milan Toth <milgra@milgra.com>
Date: Sun, 5 Mar 2023 14:11:16 +0100
Subject: [PATCH] New package: font-terminus-ttf-4.49.2

---
 srcpkgs/font-terminus-ttf/template | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 srcpkgs/font-terminus-ttf/template

diff --git a/srcpkgs/font-terminus-ttf/template b/srcpkgs/font-terminus-ttf/template
new file mode 100644
index 000000000000..0d85ff3f05f9
--- /dev/null
+++ b/srcpkgs/font-terminus-ttf/template
@@ -0,0 +1,21 @@
+# Template file for 'font-terminus-ttf'
+pkgname=font-terminus-ttf
+version=4.49.2
+revision=1
+hostmakedepends="unzip"
+depends="font-util"
+short_desc="TTF version of the terminus monospaced bitmap font"
+maintainer="Milan Toth <milgra@milgra.com>"
+license="OFL-1.1"
+homepage="https://files.ax86.net/terminus-ttf"
+distfiles="https://files.ax86.net/terminus-ttf/files/${version}/terminus-ttf-${version}.zip"
+checksum=523bb09ec554514bedecd4d068b9d89b3bf124189542b82ab221c972d3d54664
+font_dirs="/usr/share/fonts/TTF"
+
+do_install() {
+	vmkdir usr/share/fonts/TTF
+	vinstall "TerminusTTF-${version}.ttf" 644 usr/share/fonts/TTF/
+	vinstall "TerminusTTF-Bold-${version}.ttf" 644 usr/share/fonts/TTF/
+	vinstall "TerminusTTF-Italic-${version}.ttf" 644 usr/share/fonts/TTF/
+	vinstall "TerminusTTF-Bold Italic-${version}.ttf" 644 usr/share/fonts/TTF/}
+}

Re: New package: font-terminus-ttf-4.49.2

[LucasTavaresA]

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

New comment by LucasTavaresA on void-packages repository

https://github.com/void-linux/void-packages/pull/42598#issuecomment-1460083074

Comment:
there is an extra '}'

Re: [PR PATCH] [Updated] New package: font-terminus-ttf-4.49.2

[milgra]

[-- Attachment #1: Type: text/plain, Size: 1021 bytes --]

There is an updated pull request by milgra against master on the void-packages repository

https://github.com/milgra/void-packages font-terminus-ttf-branch
https://github.com/void-linux/void-packages/pull/42598

New package: font-terminus-ttf-4.49.2
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)

If you need terminus font in a different size than the bitmap version provides or your app doesn't support bitmap fonts then the TTF version can come handy. It is also the default font for all my applications ( https://github.com/milgra/sov, https://github.com/milgra/wcp, https://github.com/milgra/mmfm, https://github.com/milgra/vmp ) so it would be nice to have it in the source packages collection.

A patch file from https://github.com/void-linux/void-packages/pull/42598.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-font-terminus-ttf-branch-42598.patch --]
[-- Type: text/x-diff, Size: 1425 bytes --]

From eba4de05ff2134c9a5385ab67ec2bbd801b14645 Mon Sep 17 00:00:00 2001
From: Milan Toth <milgra@milgra.com>
Date: Sun, 5 Mar 2023 14:11:16 +0100
Subject: [PATCH] New package: font-terminus-ttf-4.49.2

---
 srcpkgs/font-terminus-ttf/template | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 srcpkgs/font-terminus-ttf/template

diff --git a/srcpkgs/font-terminus-ttf/template b/srcpkgs/font-terminus-ttf/template
new file mode 100644
index 000000000000..6fb821ede6c6
--- /dev/null
+++ b/srcpkgs/font-terminus-ttf/template
@@ -0,0 +1,21 @@
+# Template file for 'font-terminus-ttf'
+pkgname=font-terminus-ttf
+version=4.49.2
+revision=1
+hostmakedepends="unzip"
+depends="font-util"
+short_desc="TTF version of the terminus monospaced bitmap font"
+maintainer="Milan Toth <milgra@milgra.com>"
+license="OFL-1.1"
+homepage="https://files.ax86.net/terminus-ttf"
+distfiles="https://files.ax86.net/terminus-ttf/files/${version}/terminus-ttf-${version}.zip"
+checksum=523bb09ec554514bedecd4d068b9d89b3bf124189542b82ab221c972d3d54664
+font_dirs="/usr/share/fonts/TTF"
+
+do_install() {
+	vmkdir usr/share/fonts/TTF
+	vinstall "TerminusTTF-${version}.ttf" 644 usr/share/fonts/TTF/
+	vinstall "TerminusTTF-Bold-${version}.ttf" 644 usr/share/fonts/TTF/
+	vinstall "TerminusTTF-Italic-${version}.ttf" 644 usr/share/fonts/TTF/
+	vinstall "TerminusTTF-Bold Italic-${version}.ttf" 644 usr/share/fonts/TTF/
+}

Re: New package: font-terminus-ttf-4.49.2

[milgra]

[-- Attachment #1: Type: text/plain, Size: 155 bytes --]

New comment by milgra on void-packages repository

https://github.com/void-linux/void-packages/pull/42598#issuecomment-1460096034

Comment:
Fixed, my bad.

Re: New package: font-terminus-ttf-4.49.2

[milgra]

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

New comment by milgra on void-packages repository

https://github.com/void-linux/void-packages/pull/42598#issuecomment-1487525886

Comment:
May I ask for an other reviewer?

Re: New package: font-terminus-ttf-4.49.2

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42598#issuecomment-1487553613

Comment:
I agree with ahesford on this one

Re: New package: font-terminus-ttf-4.49.2

[abenson]

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

New comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/42598#issuecomment-1487553824

Comment:
I agree with ahesford

Re: New package: font-terminus-ttf-4.49.2

[paper42]

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/42598#issuecomment-1487555465

Comment:
I agree with ahesford as well

Re: New package: font-terminus-ttf-4.49.2

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 268 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/42598#issuecomment-1487556205

Comment:
Packaging this font doesn't offer any value above just saving the files to `~/.local/share/fonts` or another system location.

Re: [PR PATCH] [Closed]: New package: font-terminus-ttf-4.49.2

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 850 bytes --]

There's a closed pull request on the void-packages repository

New package: font-terminus-ttf-4.49.2
https://github.com/void-linux/void-packages/pull/42598

Description:
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)

If you need terminus font in a different size than the bitmap version provides or your app doesn't support bitmap fonts then the TTF version can come handy. It is also the default font for all my applications ( https://github.com/milgra/sov, https://github.com/milgra/wcp, https://github.com/milgra/mmfm, https://github.com/milgra/vmp ) so it would be nice to have it in the source packages collection.