[PR PATCH] comrak: update to 0.18.0.

[PR PATCH] comrak: update to 0.18.0.

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 1230 bytes --]

There is a new pull request by jcgruenhage against master on the void-packages repository

https://github.com/jcgruenhage/void-packages comrak-0.18.0_1
https://github.com/void-linux/void-packages/pull/43167

comrak: update to 0.18.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/43167.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-comrak-0.18.0_1-43167.patch --]
[-- Type: text/x-diff, Size: 1175 bytes --]

From bb626b15835d09b6ae9d24d2e94d38c46c8088da Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
 <jan.christian@gruenhage.xyz>
Date: Sat, 1 Apr 2023 22:19:01 +0200
Subject: [PATCH] comrak: update to 0.18.0.

---
 srcpkgs/comrak/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/comrak/template b/srcpkgs/comrak/template
index de5c8679d4bd..40c80484db1d 100644
--- a/srcpkgs/comrak/template
+++ b/srcpkgs/comrak/template
@@ -1,6 +1,6 @@
 # Template file for 'comrak'
 pkgname=comrak
-version=0.16.0
+version=0.18.0
 revision=1
 build_style=cargo
 short_desc="CommonMark + GFM compatible Markdown parser and renderer"
@@ -9,7 +9,7 @@ license="BSD-2-Clause"
 homepage="https://github.com/kivikakk/comrak"
 changelog="https://github.com/kivikakk/comrak/raw/main/changelog.txt"
 distfiles="https://github.com/kivikakk/comrak/archive/${version}.tar.gz"
-checksum=72f7ecbef6df715f14a61242fea0cbb450bbf1d10eb38acd99502daed04f8c07
+checksum=fce21e382e3c21064a364c6993ff6387fd481efd859c71c7e059cbfcdf14e832
 
 case "$XBPS_TARGET_MACHINE" in
 # Tests don't compile on i686: ran out of registers during register allocation

Re: comrak: update to 0.18.0.

[tranzystorek-io]

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

New comment by tranzystorek-io on void-packages repository

https://github.com/void-linux/void-packages/pull/43167#issuecomment-1493111491

Comment:
Comrak uses oniguruma, we can link void's dynlibs

Re: comrak: update to 0.18.0.

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

New comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/43167#issuecomment-1493269601

Comment:
Sorry, hadn't seen your PR, but you're right, we should link oniguruma dynamically

Re: [PR PATCH] [Updated] comrak: update to 0.18.0.

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 1235 bytes --]

There is an updated pull request by jcgruenhage against master on the void-packages repository

https://github.com/jcgruenhage/void-packages comrak-0.18.0_1
https://github.com/void-linux/void-packages/pull/43167

comrak: update to 0.18.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/43167.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-comrak-0.18.0_1-43167.patch --]
[-- Type: text/x-diff, Size: 1977 bytes --]

From 08cb1f99da52c4b734802fc63c468c5166dc2686 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
 <jan.christian@gruenhage.xyz>
Date: Sun, 2 Apr 2023 10:41:11 +0200
Subject: [PATCH 1/2] common/build-helper/rust.sh: dynamic linking to oniguruma

---
 common/build-helper/rust.sh | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/common/build-helper/rust.sh b/common/build-helper/rust.sh
index 2b15bde3a1ed..d831c15df1d0 100644
--- a/common/build-helper/rust.sh
+++ b/common/build-helper/rust.sh
@@ -51,3 +51,6 @@ export OPENSSL_NO_VENDOR=1
 
 # pcre2-sys, only necessary for musl targets
 export PCRE2_SYS_STATIC=0
+
+# onig-sys
+export RUSTONIG_SYSTEM_LIBONIG=1

From b58b30a9580d4cd4d9f1504dbe3ec2d6ffc96d9b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
 <jan.christian@gruenhage.xyz>
Date: Sat, 1 Apr 2023 22:19:01 +0200
Subject: [PATCH 2/2] comrak: update to 0.18.0.

---
 srcpkgs/comrak/template | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/comrak/template b/srcpkgs/comrak/template
index de5c8679d4bd..d1811e89a1f9 100644
--- a/srcpkgs/comrak/template
+++ b/srcpkgs/comrak/template
@@ -1,15 +1,17 @@
 # Template file for 'comrak'
 pkgname=comrak
-version=0.16.0
+version=0.18.0
 revision=1
 build_style=cargo
+hostmakedepends="pkg-config"
+makedepends="oniguruma-devel"
 short_desc="CommonMark + GFM compatible Markdown parser and renderer"
 maintainer="jcgruenhage <jan.christian@gruenhage.xyz>"
 license="BSD-2-Clause"
 homepage="https://github.com/kivikakk/comrak"
 changelog="https://github.com/kivikakk/comrak/raw/main/changelog.txt"
 distfiles="https://github.com/kivikakk/comrak/archive/${version}.tar.gz"
-checksum=72f7ecbef6df715f14a61242fea0cbb450bbf1d10eb38acd99502daed04f8c07
+checksum=fce21e382e3c21064a364c6993ff6387fd481efd859c71c7e059cbfcdf14e832
 
 case "$XBPS_TARGET_MACHINE" in
 # Tests don't compile on i686: ran out of registers during register allocation

Re: comrak: update to 0.18.0.

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

New comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/43167#issuecomment-1493271058

Comment:
To make sure this linking is happening automatically the way we'd want it to, I've added the env var to the rust build helper instead of the comrak template. If I should split that out into a separate PR though, I could do that as well.

Re: [PR REVIEW] comrak: update to 0.18.0.

[tranzystorek-io]

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

New review comment by tranzystorek-io on void-packages repository

https://github.com/void-linux/void-packages/pull/43167#discussion_r1155270848

Comment:
Is the rust helper included automatically?

Re: [PR REVIEW] comrak: update to 0.18.0.

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

New review comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/43167#discussion_r1155275038

Comment:
`build_style=cargo` includes `build_helper=rust`, yea

Re: [PR REVIEW] comrak: update to 0.18.0.

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 257 bytes --]

New review comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/43167#discussion_r1155275136

Comment:
(See https://github.com/void-linux/void-packages/blob/master/common/environment/build-style/cargo.sh#L11)

Re: [PR PATCH] [Updated] comrak: update to 0.18.0.

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 1235 bytes --]

There is an updated pull request by jcgruenhage against master on the void-packages repository

https://github.com/jcgruenhage/void-packages comrak-0.18.0_1
https://github.com/void-linux/void-packages/pull/43167

comrak: update to 0.18.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/43167.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-comrak-0.18.0_1-43167.patch --]
[-- Type: text/x-diff, Size: 1949 bytes --]

From 3cf3ba1206b3b681280cade02d9b770c3cc0327d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
 <jan.christian@gruenhage.xyz>
Date: Sun, 2 Apr 2023 10:41:11 +0200
Subject: [PATCH 1/2] common/build-helper/rust.sh: dynamic linking to oniguruma

---
 common/build-helper/rust.sh | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/common/build-helper/rust.sh b/common/build-helper/rust.sh
index 94a69510f2ba..f689f7c7f9d9 100644
--- a/common/build-helper/rust.sh
+++ b/common/build-helper/rust.sh
@@ -54,3 +54,6 @@ export PCRE2_SYS_STATIC=0
 
 # zstd-sys
 export ZSTD_SYS_USE_PKG_CONFIG=1
+
+# onig-sys
+export RUSTONIG_SYSTEM_LIBONIG=1

From 49f6f392815ba50cade377a7a03782a7caffe831 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
 <jan.christian@gruenhage.xyz>
Date: Sat, 1 Apr 2023 22:19:01 +0200
Subject: [PATCH 2/2] comrak: update to 0.18.0.

---
 srcpkgs/comrak/template | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/comrak/template b/srcpkgs/comrak/template
index de5c8679d4bd..d1811e89a1f9 100644
--- a/srcpkgs/comrak/template
+++ b/srcpkgs/comrak/template
@@ -1,15 +1,17 @@
 # Template file for 'comrak'
 pkgname=comrak
-version=0.16.0
+version=0.18.0
 revision=1
 build_style=cargo
+hostmakedepends="pkg-config"
+makedepends="oniguruma-devel"
 short_desc="CommonMark + GFM compatible Markdown parser and renderer"
 maintainer="jcgruenhage <jan.christian@gruenhage.xyz>"
 license="BSD-2-Clause"
 homepage="https://github.com/kivikakk/comrak"
 changelog="https://github.com/kivikakk/comrak/raw/main/changelog.txt"
 distfiles="https://github.com/kivikakk/comrak/archive/${version}.tar.gz"
-checksum=72f7ecbef6df715f14a61242fea0cbb450bbf1d10eb38acd99502daed04f8c07
+checksum=fce21e382e3c21064a364c6993ff6387fd481efd859c71c7e059cbfcdf14e832
 
 case "$XBPS_TARGET_MACHINE" in
 # Tests don't compile on i686: ran out of registers during register allocation

Re: [PR PATCH] [Merged]: comrak: update to 0.18.0.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]

There's a merged pull request on the void-packages repository

comrak: update to 0.18.0.
https://github.com/void-linux/void-packages/pull/43167

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

Re: comrak: update to 0.18.0

[tranzystorek-io]

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]

New comment by tranzystorek-io on void-packages repository

https://github.com/void-linux/void-packages/pull/43141#issuecomment-1493113830

Comment:
Closing in favor of #43167