* Re: python3-pylast: update to 5.1.0.
2023-04-01 12:15 [PR PATCH] python3-pylast: update to 5.1.0 Luc-Saccoccio
@ 2023-04-01 12:28 ` nekopsykose
2023-04-01 13:32 ` [PR PATCH] [Updated] " Luc-Saccoccio
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: nekopsykose @ 2023-04-01 12:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 288 bytes --]
New comment by nekopsykose on void-packages repository
https://github.com/void-linux/void-packages/pull/43161#issuecomment-1492957347
Comment:
python3-importlib_metadata is only for python versions below 3.8 (by dep declaration in pyproject.toml), so not the case here and isn't needed
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PR PATCH] [Updated] python3-pylast: update to 5.1.0.
2023-04-01 12:15 [PR PATCH] python3-pylast: update to 5.1.0 Luc-Saccoccio
2023-04-01 12:28 ` nekopsykose
@ 2023-04-01 13:32 ` Luc-Saccoccio
2023-04-09 19:05 ` Luc-Saccoccio
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Luc-Saccoccio @ 2023-04-01 13:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 402 bytes --]
There is an updated pull request by Luc-Saccoccio against master on the void-packages repository
https://github.com/Luc-Saccoccio/void-packages master
https://github.com/void-linux/void-packages/pull/43161
python3-pylast: update to 5.1.0.
#### Testing the changes
- I tested the changes in this PR: ***YES**
A patch file from https://github.com/void-linux/void-packages/pull/43161.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-43161.patch --]
[-- Type: text/x-diff, Size: 1376 bytes --]
From 1fba90dbd217e5d087e94ec6786299ab82d9986b Mon Sep 17 00:00:00 2001
From: Luc-Saccoccio <lucsaccoccio@disroot.org>
Date: Sat, 1 Apr 2023 14:01:20 +0200
Subject: [PATCH] python3-pylast: update to 5.1.0.
---
srcpkgs/python3-pylast/template | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/srcpkgs/python3-pylast/template b/srcpkgs/python3-pylast/template
index 9999e43a61a0..287ae698f72d 100644
--- a/srcpkgs/python3-pylast/template
+++ b/srcpkgs/python3-pylast/template
@@ -1,14 +1,14 @@
# Template file for 'python3-pylast'
pkgname=python3-pylast
-version=4.1.0
-revision=5
-build_style=python3-module
-hostmakedepends="python3-setuptools_scm"
-depends="python3-setuptools"
+version=5.1.0
+revision=1
+build_style=python3-pep517
+hostmakedepends="hatchling hatch-vcs"
+depends="python3-httpx"
short_desc="Python3 interface to last.fm and libre.fm"
maintainer="Orphaned <orphan@voidlinux.org>"
license="Apache-2.0"
homepage="https://github.com/pylast/pylast"
distfiles="${PYPI_SITE}/p/pylast/pylast-${version}.tar.gz"
-checksum=ad084aec1bf7e307bc42d7cc1a003851f5bee1ad24fb697a9fdc300bbfe63932
-make_check=no # The 'pylast' distribution was not found and is required by the application
+checksum=89300fdcdf423d7be0606bdc44da27c3b48c4d73aa1d4cb12672cc006c979bdc
+make_check=no # Unable to determine tests for PEP517 Python templates
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PR PATCH] [Updated] python3-pylast: update to 5.1.0.
2023-04-01 12:15 [PR PATCH] python3-pylast: update to 5.1.0 Luc-Saccoccio
2023-04-01 12:28 ` nekopsykose
2023-04-01 13:32 ` [PR PATCH] [Updated] " Luc-Saccoccio
@ 2023-04-09 19:05 ` Luc-Saccoccio
2023-04-09 19:06 ` Luc-Saccoccio
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Luc-Saccoccio @ 2023-04-09 19:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 402 bytes --]
There is an updated pull request by Luc-Saccoccio against master on the void-packages repository
https://github.com/Luc-Saccoccio/void-packages master
https://github.com/void-linux/void-packages/pull/43161
python3-pylast: update to 5.1.0.
#### Testing the changes
- I tested the changes in this PR: ***YES**
A patch file from https://github.com/void-linux/void-packages/pull/43161.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-43161.patch --]
[-- Type: text/x-diff, Size: 1376 bytes --]
From 1fba90dbd217e5d087e94ec6786299ab82d9986b Mon Sep 17 00:00:00 2001
From: Luc-Saccoccio <lucsaccoccio@disroot.org>
Date: Sat, 1 Apr 2023 14:01:20 +0200
Subject: [PATCH] python3-pylast: update to 5.1.0.
---
srcpkgs/python3-pylast/template | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/srcpkgs/python3-pylast/template b/srcpkgs/python3-pylast/template
index 9999e43a61a0..287ae698f72d 100644
--- a/srcpkgs/python3-pylast/template
+++ b/srcpkgs/python3-pylast/template
@@ -1,14 +1,14 @@
# Template file for 'python3-pylast'
pkgname=python3-pylast
-version=4.1.0
-revision=5
-build_style=python3-module
-hostmakedepends="python3-setuptools_scm"
-depends="python3-setuptools"
+version=5.1.0
+revision=1
+build_style=python3-pep517
+hostmakedepends="hatchling hatch-vcs"
+depends="python3-httpx"
short_desc="Python3 interface to last.fm and libre.fm"
maintainer="Orphaned <orphan@voidlinux.org>"
license="Apache-2.0"
homepage="https://github.com/pylast/pylast"
distfiles="${PYPI_SITE}/p/pylast/pylast-${version}.tar.gz"
-checksum=ad084aec1bf7e307bc42d7cc1a003851f5bee1ad24fb697a9fdc300bbfe63932
-make_check=no # The 'pylast' distribution was not found and is required by the application
+checksum=89300fdcdf423d7be0606bdc44da27c3b48c4d73aa1d4cb12672cc006c979bdc
+make_check=no # Unable to determine tests for PEP517 Python templates
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PR PATCH] [Updated] python3-pylast: update to 5.1.0.
2023-04-01 12:15 [PR PATCH] python3-pylast: update to 5.1.0 Luc-Saccoccio
` (2 preceding siblings ...)
2023-04-09 19:05 ` Luc-Saccoccio
@ 2023-04-09 19:06 ` Luc-Saccoccio
2023-04-12 18:47 ` paper42
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Luc-Saccoccio @ 2023-04-09 19:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 402 bytes --]
There is an updated pull request by Luc-Saccoccio against master on the void-packages repository
https://github.com/Luc-Saccoccio/void-packages master
https://github.com/void-linux/void-packages/pull/43161
python3-pylast: update to 5.1.0.
#### Testing the changes
- I tested the changes in this PR: ***YES**
A patch file from https://github.com/void-linux/void-packages/pull/43161.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-43161.patch --]
[-- Type: text/x-diff, Size: 1376 bytes --]
From 43f51a924c86617df114b0870af942ce7752ccf1 Mon Sep 17 00:00:00 2001
From: Luc-Saccoccio <lucsaccoccio@disroot.org>
Date: Sat, 1 Apr 2023 14:01:20 +0200
Subject: [PATCH] python3-pylast: update to 5.1.0.
---
srcpkgs/python3-pylast/template | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/srcpkgs/python3-pylast/template b/srcpkgs/python3-pylast/template
index 9999e43a61a0..287ae698f72d 100644
--- a/srcpkgs/python3-pylast/template
+++ b/srcpkgs/python3-pylast/template
@@ -1,14 +1,14 @@
# Template file for 'python3-pylast'
pkgname=python3-pylast
-version=4.1.0
-revision=5
-build_style=python3-module
-hostmakedepends="python3-setuptools_scm"
-depends="python3-setuptools"
+version=5.1.0
+revision=1
+build_style=python3-pep517
+hostmakedepends="hatchling hatch-vcs"
+depends="python3-httpx"
short_desc="Python3 interface to last.fm and libre.fm"
maintainer="Orphaned <orphan@voidlinux.org>"
license="Apache-2.0"
homepage="https://github.com/pylast/pylast"
distfiles="${PYPI_SITE}/p/pylast/pylast-${version}.tar.gz"
-checksum=ad084aec1bf7e307bc42d7cc1a003851f5bee1ad24fb697a9fdc300bbfe63932
-make_check=no # The 'pylast' distribution was not found and is required by the application
+checksum=89300fdcdf423d7be0606bdc44da27c3b48c4d73aa1d4cb12672cc006c979bdc
+make_check=no # Unable to determine tests for PEP517 Python templates
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: python3-pylast: update to 5.1.0.
2023-04-01 12:15 [PR PATCH] python3-pylast: update to 5.1.0 Luc-Saccoccio
` (3 preceding siblings ...)
2023-04-09 19:06 ` Luc-Saccoccio
@ 2023-04-12 18:47 ` paper42
2023-04-12 19:34 ` [PR REVIEW] " paper42
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: paper42 @ 2023-04-12 18:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 201 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/43161#issuecomment-1505762407
Comment:
did you test if packages which depend on pylast still work?
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PR REVIEW] python3-pylast: update to 5.1.0.
2023-04-01 12:15 [PR PATCH] python3-pylast: update to 5.1.0 Luc-Saccoccio
` (4 preceding siblings ...)
2023-04-12 18:47 ` paper42
@ 2023-04-12 19:34 ` paper42
2023-04-12 21:47 ` paper42
2023-04-20 19:52 ` [PR PATCH] [Closed]: " Luc-Saccoccio
7 siblings, 0 replies; 9+ messages in thread
From: paper42 @ 2023-04-12 19:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 590 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/43161#discussion_r1164560205
Comment:
that's a harmless warning, there should be no reason to explicitly disable tests, also, we can run at least some tests, it's currently ugly, but it works.
```
checkdepends="python3-pytest python3-flaky ${depends}"
do_check() {
rm -rf tmp # remove artifacts from previous unsuccessful check run
mkdir tmp
bsdtar xf dist/pylast-$version-py3-none-any.whl -C tmp
PYTHONPATH=tmp pytest
rm -rf tmp
}
```
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PR REVIEW] python3-pylast: update to 5.1.0.
2023-04-01 12:15 [PR PATCH] python3-pylast: update to 5.1.0 Luc-Saccoccio
` (5 preceding siblings ...)
2023-04-12 19:34 ` [PR REVIEW] " paper42
@ 2023-04-12 21:47 ` paper42
2023-04-20 19:52 ` [PR PATCH] [Closed]: " Luc-Saccoccio
7 siblings, 0 replies; 9+ messages in thread
From: paper42 @ 2023-04-12 21:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 268 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/43161#discussion_r1164683765
Comment:
now when https://github.com/void-linux/void-packages/pull/42013 has been merged, you can leave out the do_check function
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PR PATCH] [Closed]: python3-pylast: update to 5.1.0.
2023-04-01 12:15 [PR PATCH] python3-pylast: update to 5.1.0 Luc-Saccoccio
` (6 preceding siblings ...)
2023-04-12 21:47 ` paper42
@ 2023-04-20 19:52 ` Luc-Saccoccio
7 siblings, 0 replies; 9+ messages in thread
From: Luc-Saccoccio @ 2023-04-20 19:52 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 235 bytes --]
There's a closed pull request on the void-packages repository
python3-pylast: update to 5.1.0.
https://github.com/void-linux/void-packages/pull/43161
Description:
#### Testing the changes
- I tested the changes in this PR: ***YES**
^ permalink raw reply [flat|nested] 9+ messages in thread