[PR PATCH] New package: notes 2.1.0

[PR PATCH] New package: notes 2.1.0

[AgarimOSLinux]

[-- Attachment #1: Type: text/plain, Size: 589 bytes --]

There is a new pull request by AgarimOSLinux against master on the void-packages repository

https://github.com/AgarimOSLinux/void-packages notes
https://github.com/void-linux/void-packages/pull/43365

New package: notes 2.1.0
- I tested the changes in this PR: YES

- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): YES


- I built this PR locally for my native architecture, (x86_64)



A patch file from https://github.com/void-linux/void-packages/pull/43365.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-notes-43365.patch --]
[-- Type: text/x-diff, Size: 1850 bytes --]

From 89e34a5011f0c61852f3e329d8d84efd7c4aca55 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20Santos?= <agarimos@tutanota.com>
Date: Mon, 10 Apr 2023 00:17:56 +0200
Subject: [PATCH] New package: notes 2.1.0

---
 srcpkgs/notes/template | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)
 create mode 100644 srcpkgs/notes/template

diff --git a/srcpkgs/notes/template b/srcpkgs/notes/template
new file mode 100644
index 000000000000..381519aef7c3
--- /dev/null
+++ b/srcpkgs/notes/template
@@ -0,0 +1,39 @@
+# Template file for 'notes'
+pkgname=notes
+version=2.1.0
+revision=1
+build_style=cmake
+configure_args="-DUSE_QT_VERSION=5 -DUPDATE_CHECKER=OFF"
+hostmakedepends="gcc git"
+makedepends="qt5-devel libSM-devel qt5-plugin-mysql qt5-plugin-odbc qt5-plugin-pgsql qt5-plugin-sqlite qt5-plugin-tds"
+short_desc="Fast and beautiful note-taking app written in C++"
+maintainer="José Santos <agarimos@tutanota.com>"
+license="MPL-2.0"
+homepage="https://github.com/nuttyartist/notes"
+changelog="https://github.com/nuttyartist/${pkgname}/releases/tag/v${version}"
+distfiles="https://github.com/nuttyartist/${pkgname}/archive/refs/tags/v${version}.tar.gz"
+checksum=8a8ae079fad6d9d5e9206acf5f4d19e1e73e1196e6c27408072b5cccf8778b95
+
+post_extract() {
+git clone https://github.com/alex-spataru/QSimpleUpdater.git --depth=1
+cd QSimpleUpdater || exit
+cp -r include ../3rdParty/QSimpleUpdater
+cp -r src ../3rdParty/QSimpleUpdater
+cd ..
+
+git clone https://github.com/b00f/qautostart.git --depth=1
+cd qautostart || exit
+cp -r src ../3rdParty/qautostart
+cd ..
+
+git clone https://github.com/pbek/qmarkdowntextedit.git --depth=1
+cd qmarkdowntextedit || exit
+for _file in CMakeLists.txt LICENSE *.cpp *.h *.ui; do
+cp $_file ../3rdParty/qmarkdowntextedit
+done
+cd ..
+}
+
+post_install() {
+	vlicense LICENSE
+}

Re: [PR REVIEW] New package: notes 2.1.0

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 241 bytes --]

New review comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/43365#discussion_r1161352475

Comment:
gcc should be already installed in the masterdir:
```suggestion
hostmakedepends="git"
```

Re: [PR REVIEW] New package: notes 2.1.0

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 422 bytes --]

New review comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/43365#discussion_r1161353147

Comment:
Is there no other way other than cloning these repos, especially manually in the template? Additionally,  the update checker is disabled in `configure_args`, so why is this repo in particular required?

Also, please indent your template properly (with tabs, not spaces!).

Re: [PR REVIEW] New package: notes 2.1.0

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 313 bytes --]

New review comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/43365#discussion_r1161354056

Comment:
```suggestion
changelog="https://github.com/nuttyartist/notes/releases"
distfiles="https://github.com/nuttyartist/notes/archive/refs/tags/v${version}.tar.gz"
```

Re: [PR REVIEW] New package: notes 2.1.0

[AgarimOSLinux]

[-- Attachment #1: Type: text/plain, Size: 246 bytes --]

New review comment by AgarimOSLinux on void-packages repository

https://github.com/void-linux/void-packages/pull/43365#discussion_r1161357362

Comment:
https://github.com/nuttyartist/notes/tree/master/3rdParty
Without them the build will fail.

Re: [PR REVIEW] New package: notes 2.1.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 295 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/43365#discussion_r1161374224

Comment:
> Is there no other way other than cloning these repos, especially manually in the template?

the proper way is to include them as distfiles

Re: [PR PATCH] [Updated] New package: notes 2.1.0

[AgarimOSLinux]

[-- Attachment #1: Type: text/plain, Size: 594 bytes --]

There is an updated pull request by AgarimOSLinux against master on the void-packages repository

https://github.com/AgarimOSLinux/void-packages notes
https://github.com/void-linux/void-packages/pull/43365

New package: notes 2.1.0
- I tested the changes in this PR: YES

- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): YES


- I built this PR locally for my native architecture, (x86_64)



A patch file from https://github.com/void-linux/void-packages/pull/43365.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-notes-43365.patch --]
[-- Type: text/x-diff, Size: 2990 bytes --]

From 89e34a5011f0c61852f3e329d8d84efd7c4aca55 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20Santos?= <agarimos@tutanota.com>
Date: Mon, 10 Apr 2023 00:17:56 +0200
Subject: [PATCH 1/2] New package: notes 2.1.0

---
 srcpkgs/notes/template | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)
 create mode 100644 srcpkgs/notes/template

diff --git a/srcpkgs/notes/template b/srcpkgs/notes/template
new file mode 100644
index 000000000000..381519aef7c3
--- /dev/null
+++ b/srcpkgs/notes/template
@@ -0,0 +1,39 @@
+# Template file for 'notes'
+pkgname=notes
+version=2.1.0
+revision=1
+build_style=cmake
+configure_args="-DUSE_QT_VERSION=5 -DUPDATE_CHECKER=OFF"
+hostmakedepends="gcc git"
+makedepends="qt5-devel libSM-devel qt5-plugin-mysql qt5-plugin-odbc qt5-plugin-pgsql qt5-plugin-sqlite qt5-plugin-tds"
+short_desc="Fast and beautiful note-taking app written in C++"
+maintainer="José Santos <agarimos@tutanota.com>"
+license="MPL-2.0"
+homepage="https://github.com/nuttyartist/notes"
+changelog="https://github.com/nuttyartist/${pkgname}/releases/tag/v${version}"
+distfiles="https://github.com/nuttyartist/${pkgname}/archive/refs/tags/v${version}.tar.gz"
+checksum=8a8ae079fad6d9d5e9206acf5f4d19e1e73e1196e6c27408072b5cccf8778b95
+
+post_extract() {
+git clone https://github.com/alex-spataru/QSimpleUpdater.git --depth=1
+cd QSimpleUpdater || exit
+cp -r include ../3rdParty/QSimpleUpdater
+cp -r src ../3rdParty/QSimpleUpdater
+cd ..
+
+git clone https://github.com/b00f/qautostart.git --depth=1
+cd qautostart || exit
+cp -r src ../3rdParty/qautostart
+cd ..
+
+git clone https://github.com/pbek/qmarkdowntextedit.git --depth=1
+cd qmarkdowntextedit || exit
+for _file in CMakeLists.txt LICENSE *.cpp *.h *.ui; do
+cp $_file ../3rdParty/qmarkdowntextedit
+done
+cd ..
+}
+
+post_install() {
+	vlicense LICENSE
+}

From 30ce086a546d17f0330fd2663625469fc79e5f93 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20Santos?= <agarimos@tutanota.com>
Date: Mon, 10 Apr 2023 14:29:14 +0200
Subject: [PATCH 2/2] Update srcpkgs/notes/template

Co-authored-by: Mohammed Anas <triallax@tutanota.com>
---
 srcpkgs/notes/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/notes/template b/srcpkgs/notes/template
index 381519aef7c3..3647d3735417 100644
--- a/srcpkgs/notes/template
+++ b/srcpkgs/notes/template
@@ -10,8 +10,8 @@ short_desc="Fast and beautiful note-taking app written in C++"
 maintainer="José Santos <agarimos@tutanota.com>"
 license="MPL-2.0"
 homepage="https://github.com/nuttyartist/notes"
-changelog="https://github.com/nuttyartist/${pkgname}/releases/tag/v${version}"
-distfiles="https://github.com/nuttyartist/${pkgname}/archive/refs/tags/v${version}.tar.gz"
+changelog="https://github.com/nuttyartist/notes/releases"
+distfiles="https://github.com/nuttyartist/notes/archive/refs/tags/v${version}.tar.gz"
 checksum=8a8ae079fad6d9d5e9206acf5f4d19e1e73e1196e6c27408072b5cccf8778b95
 
 post_extract() {

Re: [PR PATCH] [Updated] New package: notes 2.1.0

[AgarimOSLinux]

[-- Attachment #1: Type: text/plain, Size: 594 bytes --]

There is an updated pull request by AgarimOSLinux against master on the void-packages repository

https://github.com/AgarimOSLinux/void-packages notes
https://github.com/void-linux/void-packages/pull/43365

New package: notes 2.1.0
- I tested the changes in this PR: YES

- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): YES


- I built this PR locally for my native architecture, (x86_64)



A patch file from https://github.com/void-linux/void-packages/pull/43365.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-notes-43365.patch --]
[-- Type: text/x-diff, Size: 3913 bytes --]

From 89e34a5011f0c61852f3e329d8d84efd7c4aca55 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20Santos?= <agarimos@tutanota.com>
Date: Mon, 10 Apr 2023 00:17:56 +0200
Subject: [PATCH 1/3] New package: notes 2.1.0

---
 srcpkgs/notes/template | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)
 create mode 100644 srcpkgs/notes/template

diff --git a/srcpkgs/notes/template b/srcpkgs/notes/template
new file mode 100644
index 000000000000..381519aef7c3
--- /dev/null
+++ b/srcpkgs/notes/template
@@ -0,0 +1,39 @@
+# Template file for 'notes'
+pkgname=notes
+version=2.1.0
+revision=1
+build_style=cmake
+configure_args="-DUSE_QT_VERSION=5 -DUPDATE_CHECKER=OFF"
+hostmakedepends="gcc git"
+makedepends="qt5-devel libSM-devel qt5-plugin-mysql qt5-plugin-odbc qt5-plugin-pgsql qt5-plugin-sqlite qt5-plugin-tds"
+short_desc="Fast and beautiful note-taking app written in C++"
+maintainer="José Santos <agarimos@tutanota.com>"
+license="MPL-2.0"
+homepage="https://github.com/nuttyartist/notes"
+changelog="https://github.com/nuttyartist/${pkgname}/releases/tag/v${version}"
+distfiles="https://github.com/nuttyartist/${pkgname}/archive/refs/tags/v${version}.tar.gz"
+checksum=8a8ae079fad6d9d5e9206acf5f4d19e1e73e1196e6c27408072b5cccf8778b95
+
+post_extract() {
+git clone https://github.com/alex-spataru/QSimpleUpdater.git --depth=1
+cd QSimpleUpdater || exit
+cp -r include ../3rdParty/QSimpleUpdater
+cp -r src ../3rdParty/QSimpleUpdater
+cd ..
+
+git clone https://github.com/b00f/qautostart.git --depth=1
+cd qautostart || exit
+cp -r src ../3rdParty/qautostart
+cd ..
+
+git clone https://github.com/pbek/qmarkdowntextedit.git --depth=1
+cd qmarkdowntextedit || exit
+for _file in CMakeLists.txt LICENSE *.cpp *.h *.ui; do
+cp $_file ../3rdParty/qmarkdowntextedit
+done
+cd ..
+}
+
+post_install() {
+	vlicense LICENSE
+}

From 30ce086a546d17f0330fd2663625469fc79e5f93 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20Santos?= <agarimos@tutanota.com>
Date: Mon, 10 Apr 2023 14:29:14 +0200
Subject: [PATCH 2/3] Update srcpkgs/notes/template

Co-authored-by: Mohammed Anas <triallax@tutanota.com>
---
 srcpkgs/notes/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/notes/template b/srcpkgs/notes/template
index 381519aef7c3..3647d3735417 100644
--- a/srcpkgs/notes/template
+++ b/srcpkgs/notes/template
@@ -10,8 +10,8 @@ short_desc="Fast and beautiful note-taking app written in C++"
 maintainer="José Santos <agarimos@tutanota.com>"
 license="MPL-2.0"
 homepage="https://github.com/nuttyartist/notes"
-changelog="https://github.com/nuttyartist/${pkgname}/releases/tag/v${version}"
-distfiles="https://github.com/nuttyartist/${pkgname}/archive/refs/tags/v${version}.tar.gz"
+changelog="https://github.com/nuttyartist/notes/releases"
+distfiles="https://github.com/nuttyartist/notes/archive/refs/tags/v${version}.tar.gz"
 checksum=8a8ae079fad6d9d5e9206acf5f4d19e1e73e1196e6c27408072b5cccf8778b95
 
 post_extract() {

From da8780c01a3942bef5679860269b82d876b8f3e7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20Santos?= <agarimos@tutanota.com>
Date: Mon, 10 Apr 2023 14:31:21 +0200
Subject: [PATCH 3/3] Update srcpkgs/notes/template

Co-authored-by: Mohammed Anas <triallax@tutanota.com>
---
 srcpkgs/notes/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/notes/template b/srcpkgs/notes/template
index 3647d3735417..581f86a8b27b 100644
--- a/srcpkgs/notes/template
+++ b/srcpkgs/notes/template
@@ -4,7 +4,7 @@ version=2.1.0
 revision=1
 build_style=cmake
 configure_args="-DUSE_QT_VERSION=5 -DUPDATE_CHECKER=OFF"
-hostmakedepends="gcc git"
+hostmakedepends="git"
 makedepends="qt5-devel libSM-devel qt5-plugin-mysql qt5-plugin-odbc qt5-plugin-pgsql qt5-plugin-sqlite qt5-plugin-tds"
 short_desc="Fast and beautiful note-taking app written in C++"
 maintainer="José Santos <agarimos@tutanota.com>"

Re: [PR PATCH] [Updated] New package: notes 2.1.0

[AgarimOSLinux]

[-- Attachment #1: Type: text/plain, Size: 594 bytes --]

There is an updated pull request by AgarimOSLinux against master on the void-packages repository

https://github.com/AgarimOSLinux/void-packages notes
https://github.com/void-linux/void-packages/pull/43365

New package: notes 2.1.0
- I tested the changes in this PR: YES

- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): YES


- I built this PR locally for my native architecture, (x86_64)



A patch file from https://github.com/void-linux/void-packages/pull/43365.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-notes-43365.patch --]
[-- Type: text/x-diff, Size: 2075 bytes --]

From 188bb19c3783ce6c6b8c380766b376eceb01f0d3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20Santos?= <agarimos@tutanota.com>
Date: Mon, 10 Apr 2023 00:17:56 +0200
Subject: [PATCH] New package: notes 2.1.0

---
 srcpkgs/notes/template | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)
 create mode 100644 srcpkgs/notes/template

diff --git a/srcpkgs/notes/template b/srcpkgs/notes/template
new file mode 100644
index 000000000000..113a728b596b
--- /dev/null
+++ b/srcpkgs/notes/template
@@ -0,0 +1,39 @@
+# Template file for 'notes'
+pkgname=notes
+version=2.1.0
+revision=1
+build_style=cmake
+configure_args="-DUSE_QT_VERSION=5 -DUPDATE_CHECKER=ON"
+hostmakedepends="git"
+makedepends="qt5-devel libSM-devel qt5-plugin-mysql qt5-plugin-odbc qt5-plugin-pgsql qt5-plugin-sqlite qt5-plugin-tds"
+short_desc="Fast and beautiful note-taking app written in C++"
+maintainer="José Santos <agarimos@tutanota.com>"
+license="MPL-2.0"
+homepage="https://github.com/nuttyartist/notes"
+changelog="https://github.com/nuttyartist/notes/releases"
+distfiles="https://github.com/nuttyartist/notes/archive/refs/tags/v${version}.tar.gz"
+checksum=8a8ae079fad6d9d5e9206acf5f4d19e1e73e1196e6c27408072b5cccf8778b95
+
+post_extract() {
+                git clone https://github.com/alex-spataru/QSimpleUpdater.git --depth=1
+                cd QSimpleUpdater || exit
+                cp -r include ../3rdParty/QSimpleUpdater
+                cp -r src ../3rdParty/QSimpleUpdater
+                cd ..
+
+                git clone https://github.com/b00f/qautostart.git --depth=1
+                cd qautostart || exit
+                cp -r src ../3rdParty/qautostart
+                cd ..
+
+                git clone https://github.com/pbek/qmarkdowntextedit.git --depth=1
+                cd qmarkdowntextedit || exit
+                for _file in CMakeLists.txt LICENSE *.cpp *.h *.ui; do
+                cp $_file ../3rdParty/qmarkdowntextedit
+                done
+                cd ..
+                }
+
+post_install() {
+	vlicense LICENSE
+}

Re: [PR PATCH] [Updated] New package: notes 2.1.0

[AgarimOSLinux]

[-- Attachment #1: Type: text/plain, Size: 594 bytes --]

There is an updated pull request by AgarimOSLinux against master on the void-packages repository

https://github.com/AgarimOSLinux/void-packages notes
https://github.com/void-linux/void-packages/pull/43365

New package: notes 2.1.0
- I tested the changes in this PR: YES

- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): YES


- I built this PR locally for my native architecture, (x86_64)



A patch file from https://github.com/void-linux/void-packages/pull/43365.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-notes-43365.patch --]
[-- Type: text/x-diff, Size: 2011 bytes --]

From d60bdf3361e5766b160667d53a03c4ac4315a860 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20Santos?= <agarimos@tutanota.com>
Date: Mon, 10 Apr 2023 00:17:56 +0200
Subject: [PATCH] New package: notes 2.1.0

---
 srcpkgs/notes/template | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 srcpkgs/notes/template

diff --git a/srcpkgs/notes/template b/srcpkgs/notes/template
new file mode 100644
index 000000000000..adefa2a4e6c8
--- /dev/null
+++ b/srcpkgs/notes/template
@@ -0,0 +1,38 @@
+# Template file for 'notes'
+pkgname=notes
+version=2.1.0
+revision=1
+build_style=cmake
+hostmakedepends="git"
+makedepends="qt5-devel libSM qt5-plugin-mysql qt5-plugin-odbc qt5-plugin-pgsql qt5-plugin-sqlite qt5-plugin-tds"
+short_desc="Fast and beautiful note-taking app written in C++"
+maintainer="José Santos <agarimos@tutanota.com>"
+license="MPL-2.0"
+homepage="https://github.com/nuttyartist/notes"
+changelog="https://github.com/nuttyartist/notes/releases"
+distfiles="https://github.com/nuttyartist/notes/archive/refs/tags/v${version}.tar.gz"
+checksum=8a8ae079fad6d9d5e9206acf5f4d19e1e73e1196e6c27408072b5cccf8778b95
+
+post_extract() {
+                git clone https://github.com/alex-spataru/QSimpleUpdater.git --depth=1
+                cd QSimpleUpdater || exit
+                cp -r include ../3rdParty/QSimpleUpdater
+                cp -r src ../3rdParty/QSimpleUpdater
+                cd ..
+
+                git clone https://github.com/b00f/qautostart.git --depth=1
+                cd qautostart || exit
+                cp -r src ../3rdParty/qautostart
+                cd ..
+
+                git clone https://github.com/pbek/qmarkdowntextedit.git --depth=1
+                cd qmarkdowntextedit || exit
+                for _file in CMakeLists.txt LICENSE *.cpp *.h *.ui; do
+                cp $_file ../3rdParty/qmarkdowntextedit
+                done
+                cd ..
+                }
+
+post_install() {
+	vlicense LICENSE
+}

Re: [PR PATCH] [Closed]: New package: notes 2.1.0

[AgarimOSLinux]

[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

There's a closed pull request on the void-packages repository

New package: notes 2.1.0
https://github.com/void-linux/void-packages/pull/43365

Description:
- I tested the changes in this PR: YES

- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): YES


- I built this PR locally for my native architecture, (x86_64)