Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] tofi: update to 0.9.1
@ 2023-04-16  0:43 LucasTavaresA
  2023-04-19  2:27 ` [PR PATCH] [Updated] " LucasTavaresA
                   ` (12 more replies)
  0 siblings, 13 replies; 14+ messages in thread
From: LucasTavaresA @ 2023-04-16  0:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1217 bytes --]

There is a new pull request by LucasTavaresA against master on the void-packages repository

https://github.com/LucasTavaresA/void-packages tofi
https://github.com/void-linux/void-packages/pull/43470

tofi: update to 0.9.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl **cross**

A patch file from https://github.com/void-linux/void-packages/pull/43470.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tofi-43470.patch --]
[-- Type: text/x-diff, Size: 1090 bytes --]

From c23ff89b6467a819a094ff70299f5b03ca20b744 Mon Sep 17 00:00:00 2001
From: LucasTavaresA <tavares.lassuncao@gmail.com>
Date: Sun, 9 Apr 2023 17:10:03 -0300
Subject: [PATCH] tofi: update to 0.9.1

---
 srcpkgs/tofi/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/tofi/template b/srcpkgs/tofi/template
index 813356a0b1db..1704b4db3822 100644
--- a/srcpkgs/tofi/template
+++ b/srcpkgs/tofi/template
@@ -1,6 +1,6 @@
 # Template file for 'tofi'
 pkgname=tofi
-version=0.8.1
+version=0.9.1
 revision=1
 build_style=meson
 hostmakedepends="scdoc pkg-config wayland-devel wayland-protocols"
@@ -12,7 +12,7 @@ license="MIT"
 homepage="https://github.com/philj56/tofi"
 changelog="https://raw.githubusercontent.com/philj56/tofi/master/CHANGELOG.md"
 distfiles="https://github.com/philj56/tofi/archive/refs/tags/v${version}.tar.gz"
-checksum=0a700f8b0291ef08b3544cd589157393101d52bbd1e7e6aeee8484f9d520a338
+checksum=dd55347b509af786f133def64f3a86f1db258b5e196de80e53d62827bdcc37bc
 
 if [ "$XBPS_TARGET_LIBC" = musl ]; then
 	makedepends+=" musl-fts-devel"

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PR PATCH] [Updated] tofi: update to 0.9.1
  2023-04-16  0:43 [PR PATCH] tofi: update to 0.9.1 LucasTavaresA
@ 2023-04-19  2:27 ` LucasTavaresA
  2023-04-19  2:33 ` LucasTavaresA
                   ` (11 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: LucasTavaresA @ 2023-04-19  2:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]

There is an updated pull request by LucasTavaresA against master on the void-packages repository

https://github.com/LucasTavaresA/void-packages tofi
https://github.com/void-linux/void-packages/pull/43470

tofi: update to 0.9.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl **cross**

A patch file from https://github.com/void-linux/void-packages/pull/43470.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tofi-43470.patch --]
[-- Type: text/x-diff, Size: 1169 bytes --]

From 9eba921775fe0d0cc0d2e6b0b284b629bef352f2 Mon Sep 17 00:00:00 2001
From: LucasTavaresA <tavares.lassuncao@gmail.com>
Date: Sun, 9 Apr 2023 17:10:03 -0300
Subject: [PATCH] tofi: update to 0.9.1

---
 srcpkgs/tofi/template | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/tofi/template b/srcpkgs/tofi/template
index 813356a0b1db..ef9c4672d1ad 100644
--- a/srcpkgs/tofi/template
+++ b/srcpkgs/tofi/template
@@ -1,6 +1,6 @@
 # Template file for 'tofi'
 pkgname=tofi
-version=0.8.1
+version=0.9.1
 revision=1
 build_style=meson
 hostmakedepends="scdoc pkg-config wayland-devel wayland-protocols"
@@ -12,7 +12,13 @@ license="MIT"
 homepage="https://github.com/philj56/tofi"
 changelog="https://raw.githubusercontent.com/philj56/tofi/master/CHANGELOG.md"
 distfiles="https://github.com/philj56/tofi/archive/refs/tags/v${version}.tar.gz"
-checksum=0a700f8b0291ef08b3544cd589157393101d52bbd1e7e6aeee8484f9d520a338
+checksum=dd55347b509af786f133def64f3a86f1db258b5e196de80e53d62827bdcc37bc
+
+if [ "$XBPS_TARGET_ARCH" = i686 ]; then
+	do_check() {
+		:
+	}
+fi
 
 if [ "$XBPS_TARGET_LIBC" = musl ]; then
 	makedepends+=" musl-fts-devel"

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PR PATCH] [Updated] tofi: update to 0.9.1
  2023-04-16  0:43 [PR PATCH] tofi: update to 0.9.1 LucasTavaresA
  2023-04-19  2:27 ` [PR PATCH] [Updated] " LucasTavaresA
@ 2023-04-19  2:33 ` LucasTavaresA
  2023-04-30  7:35 ` [PR REVIEW] " classabbyamp
                   ` (10 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: LucasTavaresA @ 2023-04-19  2:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]

There is an updated pull request by LucasTavaresA against master on the void-packages repository

https://github.com/LucasTavaresA/void-packages tofi
https://github.com/void-linux/void-packages/pull/43470

tofi: update to 0.9.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl **cross**

A patch file from https://github.com/void-linux/void-packages/pull/43470.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tofi-43470.patch --]
[-- Type: text/x-diff, Size: 1174 bytes --]

From 48b5281a0c2481ae20c4f4fa71d052df9f35c61c Mon Sep 17 00:00:00 2001
From: LucasTavaresA <tavares.lassuncao@gmail.com>
Date: Sun, 9 Apr 2023 17:10:03 -0300
Subject: [PATCH] tofi: update to 0.9.1

---
 srcpkgs/tofi/template | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/tofi/template b/srcpkgs/tofi/template
index 813356a0b1db..df0c8ff224c1 100644
--- a/srcpkgs/tofi/template
+++ b/srcpkgs/tofi/template
@@ -1,6 +1,6 @@
 # Template file for 'tofi'
 pkgname=tofi
-version=0.8.1
+version=0.9.1
 revision=1
 build_style=meson
 hostmakedepends="scdoc pkg-config wayland-devel wayland-protocols"
@@ -12,7 +12,13 @@ license="MIT"
 homepage="https://github.com/philj56/tofi"
 changelog="https://raw.githubusercontent.com/philj56/tofi/master/CHANGELOG.md"
 distfiles="https://github.com/philj56/tofi/archive/refs/tags/v${version}.tar.gz"
-checksum=0a700f8b0291ef08b3544cd589157393101d52bbd1e7e6aeee8484f9d520a338
+checksum=dd55347b509af786f133def64f3a86f1db258b5e196de80e53d62827bdcc37bc
+
+if [ "$XBPS_TARGET_MACHINE" = "i686" ]; then
+	do_check() {
+		:
+	}
+fi
 
 if [ "$XBPS_TARGET_LIBC" = musl ]; then
 	makedepends+=" musl-fts-devel"

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PR REVIEW] tofi: update to 0.9.1
  2023-04-16  0:43 [PR PATCH] tofi: update to 0.9.1 LucasTavaresA
  2023-04-19  2:27 ` [PR PATCH] [Updated] " LucasTavaresA
  2023-04-19  2:33 ` LucasTavaresA
@ 2023-04-30  7:35 ` classabbyamp
  2023-04-30 14:47 ` [PR PATCH] [Updated] " LucasTavaresA
                   ` (9 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: classabbyamp @ 2023-04-30  7:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/43470#discussion_r1181181099

Comment:
don't do this, use `make_check=no`

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PR PATCH] [Updated] tofi: update to 0.9.1
  2023-04-16  0:43 [PR PATCH] tofi: update to 0.9.1 LucasTavaresA
                   ` (2 preceding siblings ...)
  2023-04-30  7:35 ` [PR REVIEW] " classabbyamp
@ 2023-04-30 14:47 ` LucasTavaresA
  2023-04-30 15:03 ` LucasTavaresA
                   ` (8 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: LucasTavaresA @ 2023-04-30 14:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]

There is an updated pull request by LucasTavaresA against master on the void-packages repository

https://github.com/LucasTavaresA/void-packages tofi
https://github.com/void-linux/void-packages/pull/43470

tofi: update to 0.9.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl **cross**

A patch file from https://github.com/void-linux/void-packages/pull/43470.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tofi-43470.patch --]
[-- Type: text/x-diff, Size: 1163 bytes --]

From 0976ed06082ab074bcc71750b7dc2e49bbfb8615 Mon Sep 17 00:00:00 2001
From: LucasTavaresA <tavares.lassuncao@gmail.com>
Date: Sun, 9 Apr 2023 17:10:03 -0300
Subject: [PATCH] tofi: update to 0.9.1

---
 srcpkgs/tofi/template | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/tofi/template b/srcpkgs/tofi/template
index 813356a0b1db..72105b1e63b4 100644
--- a/srcpkgs/tofi/template
+++ b/srcpkgs/tofi/template
@@ -1,6 +1,6 @@
 # Template file for 'tofi'
 pkgname=tofi
-version=0.8.1
+version=0.9.1
 revision=1
 build_style=meson
 hostmakedepends="scdoc pkg-config wayland-devel wayland-protocols"
@@ -12,7 +12,11 @@ license="MIT"
 homepage="https://github.com/philj56/tofi"
 changelog="https://raw.githubusercontent.com/philj56/tofi/master/CHANGELOG.md"
 distfiles="https://github.com/philj56/tofi/archive/refs/tags/v${version}.tar.gz"
-checksum=0a700f8b0291ef08b3544cd589157393101d52bbd1e7e6aeee8484f9d520a338
+checksum=dd55347b509af786f133def64f3a86f1db258b5e196de80e53d62827bdcc37bc
+
+if [ "$XBPS_TARGET_MACHINE" = "i686" ]; then
+	make_check=no
+fi
 
 if [ "$XBPS_TARGET_LIBC" = musl ]; then
 	makedepends+=" musl-fts-devel"

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PR PATCH] [Updated] tofi: update to 0.9.1
  2023-04-16  0:43 [PR PATCH] tofi: update to 0.9.1 LucasTavaresA
                   ` (3 preceding siblings ...)
  2023-04-30 14:47 ` [PR PATCH] [Updated] " LucasTavaresA
@ 2023-04-30 15:03 ` LucasTavaresA
  2023-04-30 15:11 ` [PR REVIEW] " classabbyamp
                   ` (7 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: LucasTavaresA @ 2023-04-30 15:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]

There is an updated pull request by LucasTavaresA against master on the void-packages repository

https://github.com/LucasTavaresA/void-packages tofi
https://github.com/void-linux/void-packages/pull/43470

tofi: update to 0.9.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl **cross**

A patch file from https://github.com/void-linux/void-packages/pull/43470.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tofi-43470.patch --]
[-- Type: text/x-diff, Size: 1193 bytes --]

From 6f70e0f276a1f075dd68b91939ffafa4ffe0fab7 Mon Sep 17 00:00:00 2001
From: LucasTavaresA <tavares.lassuncao@gmail.com>
Date: Sun, 9 Apr 2023 17:10:03 -0300
Subject: [PATCH] tofi: update to 0.9.1

---
 srcpkgs/tofi/template | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/tofi/template b/srcpkgs/tofi/template
index 813356a0b1db..31b05a15b53f 100644
--- a/srcpkgs/tofi/template
+++ b/srcpkgs/tofi/template
@@ -1,6 +1,6 @@
 # Template file for 'tofi'
 pkgname=tofi
-version=0.8.1
+version=0.9.1
 revision=1
 build_style=meson
 hostmakedepends="scdoc pkg-config wayland-devel wayland-protocols"
@@ -12,7 +12,12 @@ license="MIT"
 homepage="https://github.com/philj56/tofi"
 changelog="https://raw.githubusercontent.com/philj56/tofi/master/CHANGELOG.md"
 distfiles="https://github.com/philj56/tofi/archive/refs/tags/v${version}.tar.gz"
-checksum=0a700f8b0291ef08b3544cd589157393101d52bbd1e7e6aeee8484f9d520a338
+checksum=dd55347b509af786f133def64f3a86f1db258b5e196de80e53d62827bdcc37bc
+
+if [ "$XBPS_TARGET_MACHINE" = "i686" ]; then
+	# some tests fail on i686.
+	make_check=no
+fi
 
 if [ "$XBPS_TARGET_LIBC" = musl ]; then
 	makedepends+=" musl-fts-devel"

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PR REVIEW] tofi: update to 0.9.1
  2023-04-16  0:43 [PR PATCH] tofi: update to 0.9.1 LucasTavaresA
                   ` (4 preceding siblings ...)
  2023-04-30 15:03 ` LucasTavaresA
@ 2023-04-30 15:11 ` classabbyamp
  2023-04-30 15:19 ` LucasTavaresA
                   ` (6 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: classabbyamp @ 2023-04-30 15:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 179 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/43470#discussion_r1181247170

Comment:
can you be more specific? 

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PR REVIEW] tofi: update to 0.9.1
  2023-04-16  0:43 [PR PATCH] tofi: update to 0.9.1 LucasTavaresA
                   ` (5 preceding siblings ...)
  2023-04-30 15:11 ` [PR REVIEW] " classabbyamp
@ 2023-04-30 15:19 ` LucasTavaresA
  2023-04-30 15:19 ` LucasTavaresA
                   ` (5 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: LucasTavaresA @ 2023-04-30 15:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 268 bytes --]

New review comment by LucasTavaresA on void-packages repository

https://github.com/void-linux/void-packages/pull/43470#discussion_r1181248300

Comment:
the only pattern after checking logs and looking at the tests, is that it fails checking options should be invalid

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PR REVIEW] tofi: update to 0.9.1
  2023-04-16  0:43 [PR PATCH] tofi: update to 0.9.1 LucasTavaresA
                   ` (6 preceding siblings ...)
  2023-04-30 15:19 ` LucasTavaresA
@ 2023-04-30 15:19 ` LucasTavaresA
  2023-04-30 15:21 ` [PR PATCH] [Updated] " LucasTavaresA
                   ` (4 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: LucasTavaresA @ 2023-04-30 15:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 200 bytes --]

New review comment by LucasTavaresA on void-packages repository

https://github.com/void-linux/void-packages/pull/43470#discussion_r1181248384

Comment:
not sure if that's correct info or even useful

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PR PATCH] [Updated] tofi: update to 0.9.1
  2023-04-16  0:43 [PR PATCH] tofi: update to 0.9.1 LucasTavaresA
                   ` (7 preceding siblings ...)
  2023-04-30 15:19 ` LucasTavaresA
@ 2023-04-30 15:21 ` LucasTavaresA
  2023-04-30 15:40 ` classabbyamp
                   ` (3 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: LucasTavaresA @ 2023-04-30 15:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]

There is an updated pull request by LucasTavaresA against master on the void-packages repository

https://github.com/LucasTavaresA/void-packages tofi
https://github.com/void-linux/void-packages/pull/43470

tofi: update to 0.9.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl **cross**

A patch file from https://github.com/void-linux/void-packages/pull/43470.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tofi-43470.patch --]
[-- Type: text/x-diff, Size: 1226 bytes --]

From b2efaec9f5661798bdc100e11157dae5112573f5 Mon Sep 17 00:00:00 2001
From: LucasTavaresA <tavares.lassuncao@gmail.com>
Date: Sun, 9 Apr 2023 17:10:03 -0300
Subject: [PATCH] tofi: update to 0.9.1

---
 srcpkgs/tofi/template | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/tofi/template b/srcpkgs/tofi/template
index 813356a0b1db..a8e5d24ed61a 100644
--- a/srcpkgs/tofi/template
+++ b/srcpkgs/tofi/template
@@ -1,6 +1,6 @@
 # Template file for 'tofi'
 pkgname=tofi
-version=0.8.1
+version=0.9.1
 revision=1
 build_style=meson
 hostmakedepends="scdoc pkg-config wayland-devel wayland-protocols"
@@ -12,7 +12,12 @@ license="MIT"
 homepage="https://github.com/philj56/tofi"
 changelog="https://raw.githubusercontent.com/philj56/tofi/master/CHANGELOG.md"
 distfiles="https://github.com/philj56/tofi/archive/refs/tags/v${version}.tar.gz"
-checksum=0a700f8b0291ef08b3544cd589157393101d52bbd1e7e6aeee8484f9d520a338
+checksum=dd55347b509af786f133def64f3a86f1db258b5e196de80e53d62827bdcc37bc
+
+if [ "$XBPS_TARGET_MACHINE" = "i686" ]; then
+	# broken tests on i686, fails checking for invalid options.
+	make_check=no
+fi
 
 if [ "$XBPS_TARGET_LIBC" = musl ]; then
 	makedepends+=" musl-fts-devel"

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: tofi: update to 0.9.1
  2023-04-16  0:43 [PR PATCH] tofi: update to 0.9.1 LucasTavaresA
                   ` (8 preceding siblings ...)
  2023-04-30 15:21 ` [PR PATCH] [Updated] " LucasTavaresA
@ 2023-04-30 15:40 ` classabbyamp
  2023-05-03  5:25 ` [PR REVIEW] " classabbyamp
                   ` (2 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: classabbyamp @ 2023-04-30 15:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 265 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/43470#issuecomment-1529056578

Comment:
I would make an issue about those test failures upstream, they are probably not dealing with 32-bit platforms properly

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PR REVIEW] tofi: update to 0.9.1
  2023-04-16  0:43 [PR PATCH] tofi: update to 0.9.1 LucasTavaresA
                   ` (9 preceding siblings ...)
  2023-04-30 15:40 ` classabbyamp
@ 2023-05-03  5:25 ` classabbyamp
  2023-05-03 18:28 ` [PR PATCH] [Updated] " LucasTavaresA
  2023-05-03 18:34 ` [PR PATCH] [Merged]: " classabbyamp
  12 siblings, 0 replies; 14+ messages in thread
From: classabbyamp @ 2023-05-03  5:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/43470#discussion_r1183249159

Comment:
let's add https://github.com/philj56/tofi/commit/667075f0920da3c2b353fbce54b6430c195ef031 as a patch instead

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PR PATCH] [Updated] tofi: update to 0.9.1
  2023-04-16  0:43 [PR PATCH] tofi: update to 0.9.1 LucasTavaresA
                   ` (10 preceding siblings ...)
  2023-05-03  5:25 ` [PR REVIEW] " classabbyamp
@ 2023-05-03 18:28 ` LucasTavaresA
  2023-05-03 18:34 ` [PR PATCH] [Merged]: " classabbyamp
  12 siblings, 0 replies; 14+ messages in thread
From: LucasTavaresA @ 2023-05-03 18:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]

There is an updated pull request by LucasTavaresA against master on the void-packages repository

https://github.com/LucasTavaresA/void-packages tofi
https://github.com/void-linux/void-packages/pull/43470

tofi: update to 0.9.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl **cross**

A patch file from https://github.com/void-linux/void-packages/pull/43470.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tofi-43470.patch --]
[-- Type: text/x-diff, Size: 4483 bytes --]

From 223f4586ae8e81d710157f087beababceb900d84 Mon Sep 17 00:00:00 2001
From: LucasTavaresA <tavares.lassuncao@gmail.com>
Date: Sun, 9 Apr 2023 17:10:03 -0300
Subject: [PATCH] tofi: update to 0.9.1

---
 srcpkgs/tofi/patches/fix-32bit-tests.patch | 84 ++++++++++++++++++++++
 srcpkgs/tofi/template                      |  4 +-
 2 files changed, 86 insertions(+), 2 deletions(-)
 create mode 100644 srcpkgs/tofi/patches/fix-32bit-tests.patch

diff --git a/srcpkgs/tofi/patches/fix-32bit-tests.patch b/srcpkgs/tofi/patches/fix-32bit-tests.patch
new file mode 100644
index 0000000000000..3a853408335bf
--- /dev/null
+++ b/srcpkgs/tofi/patches/fix-32bit-tests.patch
@@ -0,0 +1,84 @@
+From 667075f0920da3c2b353fbce54b6430c195ef031 Mon Sep 17 00:00:00 2001
+From: Phil Jones <philj56@gmail.com>
+Date: Sun, 30 Apr 2023 20:08:57 +0100
+Subject: [PATCH] Replace `strto[u]l` with `strto[u]ll`.
+
+On 32-bit systems, using `strtoul` was causing negative values for
+unsigned options to be treated as valid, as the value was being parsed
+as a 32-bit unsigned int, then cast to a 64-bit signed int, which
+remained positive.
+---
+ src/color.c  | 8 ++++----
+ src/config.c | 6 +++---
+ 2 files changed, 7 insertions(+), 7 deletions(-)
+
+diff --git a/src/color.c b/src/color.c
+index 4b6b356..b1d5e90 100644
+--- a/src/color.c
++++ b/src/color.c
+@@ -22,7 +22,7 @@ struct color hex_to_color(const char *hex)
+ 			hex[2], hex[2],
+ 			'\0'};
+ 		char *endptr;
+-		tmp = strtol(str, &endptr, 16);
++		tmp = strtoll(str, &endptr, 16);
+ 		if (errno || *endptr != '\0' || tmp < 0) {
+ 			return (struct color) { -1, -1, -1, -1 };
+ 		}
+@@ -37,14 +37,14 @@ struct color hex_to_color(const char *hex)
+ 			hex[3], hex[3],
+ 			'\0'};
+ 		char *endptr;
+-		tmp = strtol(str, &endptr, 16);
++		tmp = strtoll(str, &endptr, 16);
+ 		if (errno || *endptr != '\0' || tmp < 0) {
+ 			return (struct color) { -1, -1, -1, -1 };
+ 		}
+ 		val = tmp;
+ 	} else if (len == 6) {
+ 		char *endptr;
+-		tmp = strtol(hex, &endptr, 16);
++		tmp = strtoll(hex, &endptr, 16);
+ 		if (errno || *endptr != '\0' || tmp < 0) {
+ 			return (struct color) { -1, -1, -1, -1 };
+ 		}
+@@ -53,7 +53,7 @@ struct color hex_to_color(const char *hex)
+ 		val |= 0xFFu;
+ 	} else if (len == 8) {
+ 		char *endptr;
+-		tmp = strtol(hex, &endptr, 16);
++		tmp = strtoll(hex, &endptr, 16);
+ 		if (errno || *endptr != '\0' || tmp < 0) {
+ 			return (struct color) { -1, -1, -1, -1 };
+ 		}
+diff --git a/src/config.c b/src/config.c
+index 2b85028..556199d 100644
+--- a/src/config.c
++++ b/src/config.c
+@@ -1027,7 +1027,7 @@ uint32_t parse_uint32(const char *filename, size_t lineno, const char *str, bool
+ {
+ 	errno = 0;
+ 	char *endptr;
+-	int64_t ret = strtoul(str, &endptr, 0);
++	int64_t ret = strtoull(str, &endptr, 0);
+ 	if (endptr == str || *endptr != '\0') {
+ 		PARSE_ERROR(filename, lineno, "Failed to parse \"%s\" as unsigned int.\n", str);
+ 		if (err) {
+@@ -1046,7 +1046,7 @@ int32_t parse_int32(const char *filename, size_t lineno, const char *str, bool *
+ {
+ 	errno = 0;
+ 	char *endptr;
+-	int64_t ret = strtol(str, &endptr, 0);
++	int64_t ret = strtoll(str, &endptr, 0);
+ 	if (endptr == str || *endptr != '\0') {
+ 		PARSE_ERROR(filename, lineno, "Failed to parse \"%s\" as int.\n", str);
+ 		if (err) {
+@@ -1065,7 +1065,7 @@ struct uint32_percent parse_uint32_percent(const char *filename, size_t lineno,
+ {
+ 	errno = 0;
+ 	char *endptr;
+-	int64_t val = strtoul(str, &endptr, 0);
++	int64_t val = strtoull(str, &endptr, 0);
+ 	bool percent = false;
+ 	if (endptr == str || (*endptr != '\0' && *endptr != '%')) {
+ 		PARSE_ERROR(filename, lineno, "Failed to parse \"%s\" as unsigned int.\n", str);
diff --git a/srcpkgs/tofi/template b/srcpkgs/tofi/template
index 813356a0b1db7..1704b4db3822b 100644
--- a/srcpkgs/tofi/template
+++ b/srcpkgs/tofi/template
@@ -1,6 +1,6 @@
 # Template file for 'tofi'
 pkgname=tofi
-version=0.8.1
+version=0.9.1
 revision=1
 build_style=meson
 hostmakedepends="scdoc pkg-config wayland-devel wayland-protocols"
@@ -12,7 +12,7 @@ license="MIT"
 homepage="https://github.com/philj56/tofi"
 changelog="https://raw.githubusercontent.com/philj56/tofi/master/CHANGELOG.md"
 distfiles="https://github.com/philj56/tofi/archive/refs/tags/v${version}.tar.gz"
-checksum=0a700f8b0291ef08b3544cd589157393101d52bbd1e7e6aeee8484f9d520a338
+checksum=dd55347b509af786f133def64f3a86f1db258b5e196de80e53d62827bdcc37bc
 
 if [ "$XBPS_TARGET_LIBC" = musl ]; then
 	makedepends+=" musl-fts-devel"

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PR PATCH] [Merged]: tofi: update to 0.9.1
  2023-04-16  0:43 [PR PATCH] tofi: update to 0.9.1 LucasTavaresA
                   ` (11 preceding siblings ...)
  2023-05-03 18:28 ` [PR PATCH] [Updated] " LucasTavaresA
@ 2023-05-03 18:34 ` classabbyamp
  12 siblings, 0 replies; 14+ messages in thread
From: classabbyamp @ 2023-05-03 18:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1057 bytes --]

There's a merged pull request on the void-packages repository

tofi: update to 0.9.1
https://github.com/void-linux/void-packages/pull/43470

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl **cross**

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2023-05-03 18:34 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-16  0:43 [PR PATCH] tofi: update to 0.9.1 LucasTavaresA
2023-04-19  2:27 ` [PR PATCH] [Updated] " LucasTavaresA
2023-04-19  2:33 ` LucasTavaresA
2023-04-30  7:35 ` [PR REVIEW] " classabbyamp
2023-04-30 14:47 ` [PR PATCH] [Updated] " LucasTavaresA
2023-04-30 15:03 ` LucasTavaresA
2023-04-30 15:11 ` [PR REVIEW] " classabbyamp
2023-04-30 15:19 ` LucasTavaresA
2023-04-30 15:19 ` LucasTavaresA
2023-04-30 15:21 ` [PR PATCH] [Updated] " LucasTavaresA
2023-04-30 15:40 ` classabbyamp
2023-05-03  5:25 ` [PR REVIEW] " classabbyamp
2023-05-03 18:28 ` [PR PATCH] [Updated] " LucasTavaresA
2023-05-03 18:34 ` [PR PATCH] [Merged]: " classabbyamp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).