Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: flutter-3.7.11
@ 2023-04-14 11:27 Bnyro
  2023-04-14 16:28 ` [PR PATCH] [Updated] " Bnyro
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: Bnyro @ 2023-04-14 11:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 867 bytes --]

There is a new pull request by Bnyro against master on the void-packages repository

https://github.com/Bnyro/void-packages flutter
https://github.com/void-linux/void-packages/pull/43438

New package: flutter-3.7.11
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)

as per #12749

Currently, it's still required to run `chmod -R {username}:{username} /opt/flutter` in order for flutter to work properly, I'd be happy to get an advice how to handle this inside the `template`.


A patch file from https://github.com/void-linux/void-packages/pull/43438.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-flutter-43438.patch --]
[-- Type: text/x-diff, Size: 1357 bytes --]

From ad7be40d7c5db3f94428a312a8a2c96b7d182536 Mon Sep 17 00:00:00 2001
From: Bnyro <bnyro@tutanota.com>
Date: Fri, 14 Apr 2023 12:48:35 +0200
Subject: [PATCH] New package: flutter-3.7.11

---
 srcpkgs/flutter/template | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 srcpkgs/flutter/template

diff --git a/srcpkgs/flutter/template b/srcpkgs/flutter/template
new file mode 100644
index 000000000000..1d68d0d60d16
--- /dev/null
+++ b/srcpkgs/flutter/template
@@ -0,0 +1,24 @@
+# Template file for 'flutter'
+pkgname=flutter
+version=3.7.11
+revision=1
+archs="aarch64 x86_64"
+depends="bash zip xz unzip git curl"
+short_desc="SDK to build modern mobile apps for iOS and Android"
+maintainer="Bnyro <bnyro@tutanota.com>"
+license="BSD-3-Clause"
+homepage="https://flutter.dev"
+distfiles="https://storage.googleapis.com/flutter_infra_release/releases/stable/linux/flutter_linux_${version}-stable.tar.xz"
+checksum=fefb63a0f0781e7f11b4fd3db8c75462d0d2ee5cd0bec91dacdb331189693817
+
+do_install() {
+	vlicense LICENSE
+	vmkdir opt/${pkgname}
+	vcopy bin opt/${pkgname}
+	vcopy packages opt/${pkgname}
+	# Otherwise it'd complaint about not being inside a git repo
+	vcopy .git opt/${pkgname}
+	vmkdir usr/bin
+	ln -s /opt/flutter/bin/flutter ${DESTDIR}/usr/bin/flutter
+	ln -s /opt/flutter/bin/dart ${DESTDIR}/usr/bin/dart
+}

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Updated] New package: flutter-3.7.11
  2023-04-14 11:27 [PR PATCH] New package: flutter-3.7.11 Bnyro
@ 2023-04-14 16:28 ` Bnyro
  2023-04-14 21:03 ` Chocimier
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Bnyro @ 2023-04-14 16:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 872 bytes --]

There is an updated pull request by Bnyro against master on the void-packages repository

https://github.com/Bnyro/void-packages flutter
https://github.com/void-linux/void-packages/pull/43438

New package: flutter-3.7.11
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)

as per #12749

Currently, it's still required to run `chmod -R {username}:{username} /opt/flutter` in order for flutter to work properly, I'd be happy to get an advice how to handle this inside the `template`.


A patch file from https://github.com/void-linux/void-packages/pull/43438.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-flutter-43438.patch --]
[-- Type: text/x-diff, Size: 1218 bytes --]

From a1e207f4e0f2f4e266385de75f8c7ab56dc3caad Mon Sep 17 00:00:00 2001
From: Bnyro <bnyro@tutanota.com>
Date: Fri, 14 Apr 2023 18:28:38 +0200
Subject: [PATCH] New package: flutter-3.7.11

---
 srcpkgs/flutter/template | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 srcpkgs/flutter/template

diff --git a/srcpkgs/flutter/template b/srcpkgs/flutter/template
new file mode 100644
index 000000000000..023b75b2033b
--- /dev/null
+++ b/srcpkgs/flutter/template
@@ -0,0 +1,21 @@
+# Template file for 'flutter'
+pkgname=flutter
+version=3.7.11
+revision=1
+archs="x86_64"
+depends="bash zip xz unzip git curl"
+short_desc="SDK to build modern mobile apps for iOS and Android"
+maintainer="Bnyro <bnyro@tutanota.com>"
+license="BSD-3-Clause"
+homepage="https://flutter.dev"
+distfiles="https://storage.googleapis.com/flutter_infra_release/releases/stable/linux/flutter_linux_${version}-stable.tar.xz"
+checksum=fefb63a0f0781e7f11b4fd3db8c75462d0d2ee5cd0bec91dacdb331189693817
+
+do_install() {
+	vlicense LICENSE
+	vmkdir opt/flutter
+	vcopy . opt/${pkgname}
+	vmkdir usr/bin
+	ln -s /opt/flutter/bin/flutter ${DESTDIR}/usr/bin/flutter
+	ln -s /opt/flutter/bin/dart ${DESTDIR}/usr/bin/dart
+}

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: New package: flutter-3.7.11
  2023-04-14 11:27 [PR PATCH] New package: flutter-3.7.11 Bnyro
  2023-04-14 16:28 ` [PR PATCH] [Updated] " Bnyro
@ 2023-04-14 21:03 ` Chocimier
  2023-04-14 21:11 ` mhmdanas
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Chocimier @ 2023-04-14 21:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/43438#issuecomment-1509264902

Comment:
> chown {username}

Void is multi-user OS, so if /opt/ need to be owned to be useful, this not packagable.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: New package: flutter-3.7.11
  2023-04-14 11:27 [PR PATCH] New package: flutter-3.7.11 Bnyro
  2023-04-14 16:28 ` [PR PATCH] [Updated] " Bnyro
  2023-04-14 21:03 ` Chocimier
@ 2023-04-14 21:11 ` mhmdanas
  2023-04-14 21:23 ` paper42
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: mhmdanas @ 2023-04-14 21:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

New comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/43438#issuecomment-1509276936

Comment:
Would this fit in better as a restricted package? It essentially just redistributes the Flutter tarball.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: New package: flutter-3.7.11
  2023-04-14 11:27 [PR PATCH] New package: flutter-3.7.11 Bnyro
                   ` (2 preceding siblings ...)
  2023-04-14 21:11 ` mhmdanas
@ 2023-04-14 21:23 ` paper42
  2023-04-16  8:19 ` Bnyro
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: paper42 @ 2023-04-14 21:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 627 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/43438#issuecomment-1509290155

Comment:
> Would this fit in better as a restricted package? It essentially just redistributes the Flutter tarball.

I think it should be nonfree because we are not building from source. Afaik restricted is usually used for packages we can not distribute, is it this case?

Either way, building from source would be much better, we could build for multiple architectures, modify the source when needed and remove the nonfree restriction. This way it's equivalent to 2 commands - curl and tar xf

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: New package: flutter-3.7.11
  2023-04-14 11:27 [PR PATCH] New package: flutter-3.7.11 Bnyro
                   ` (3 preceding siblings ...)
  2023-04-14 21:23 ` paper42
@ 2023-04-16  8:19 ` Bnyro
  2023-04-17 11:38 ` mhmdanas
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Bnyro @ 2023-04-16  8:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 690 bytes --]

New comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/43438#issuecomment-1510181244

Comment:
> Either way, building from source would be much better, we could build for multiple architectures, modify the source when needed and remove the nonfree restriction. This way it's equivalent to 2 commands - curl and tar xf
>
Yes, I agree on that. I've been looking into the documentation on how to build flutter from source, however I doubt I'll be able to get that working given my few experience on building and packaging. I assume the best thing would be to close this PR and wait for somebody else to take the efforts to build it from source?


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: New package: flutter-3.7.11
  2023-04-14 11:27 [PR PATCH] New package: flutter-3.7.11 Bnyro
                   ` (4 preceding siblings ...)
  2023-04-16  8:19 ` Bnyro
@ 2023-04-17 11:38 ` mhmdanas
  2023-04-20 19:37 ` mhmdanas
  2023-06-01 13:00 ` [PR PATCH] [Closed]: " Bnyro
  7 siblings, 0 replies; 9+ messages in thread
From: mhmdanas @ 2023-04-17 11:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 717 bytes --]

New comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/43438#issuecomment-1511179089

Comment:
> I think it should be nonfree because we are not building from source. Afaik restricted is usually used for packages we can not distribute, is it this case?

Yeah, I didn't consider that, I guess this might better fit in in nonfree.

> Either way, building from source would be much better, we could build for multiple architectures, modify the source when needed and remove the nonfree restriction. This way it's equivalent to 2 commands - curl and tar xf

I agree, but this is the best we can do until somebody comes up with a template to build Flutter from source.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: New package: flutter-3.7.11
  2023-04-14 11:27 [PR PATCH] New package: flutter-3.7.11 Bnyro
                   ` (5 preceding siblings ...)
  2023-04-17 11:38 ` mhmdanas
@ 2023-04-20 19:37 ` mhmdanas
  2023-06-01 13:00 ` [PR PATCH] [Closed]: " Bnyro
  7 siblings, 0 replies; 9+ messages in thread
From: mhmdanas @ 2023-04-20 19:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 528 bytes --]

New comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/43438#issuecomment-1516851557

Comment:
An update, somebody pointed me to this recently:
> There seems to be some work over at Alpine Linux to package Flutter from source: https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/44347
>
> Predictably, it doesn't look trivial at all.

_Originally posted by @mhmdanas in https://github.com/void-linux/void-packages/issues/12749#issuecomment-1516845013_
            

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Closed]: New package: flutter-3.7.11
  2023-04-14 11:27 [PR PATCH] New package: flutter-3.7.11 Bnyro
                   ` (6 preceding siblings ...)
  2023-04-20 19:37 ` mhmdanas
@ 2023-06-01 13:00 ` Bnyro
  7 siblings, 0 replies; 9+ messages in thread
From: Bnyro @ 2023-06-01 13:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 720 bytes --]

There's a closed pull request on the void-packages repository

New package: flutter-3.7.11
https://github.com/void-linux/void-packages/pull/43438

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)

as per #12749

Currently, it's still required to run `chmod -R {username}:{username} /opt/flutter` in order for flutter to work properly, I'd be happy to get an advice how to handle this inside the `template`.


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2023-06-01 13:00 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-14 11:27 [PR PATCH] New package: flutter-3.7.11 Bnyro
2023-04-14 16:28 ` [PR PATCH] [Updated] " Bnyro
2023-04-14 21:03 ` Chocimier
2023-04-14 21:11 ` mhmdanas
2023-04-14 21:23 ` paper42
2023-04-16  8:19 ` Bnyro
2023-04-17 11:38 ` mhmdanas
2023-04-20 19:37 ` mhmdanas
2023-06-01 13:00 ` [PR PATCH] [Closed]: " Bnyro

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).