Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] qt6ct: qt6ct.sh should not set QT_QPA_PLATFORMTHEME=qt5ct
@ 2022-11-19 17:10 Firgen
  2022-11-20  5:20 ` classabbyamp
                   ` (10 more replies)
  0 siblings, 11 replies; 12+ messages in thread
From: Firgen @ 2022-11-19 17:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1250 bytes --]

There is a new pull request by Firgen against master on the void-packages repository

https://github.com/Firgen/void-packages qt6ct
https://github.com/void-linux/void-packages/pull/40619

qt6ct: qt6ct.sh should not set QT_QPA_PLATFORMTHEME=qt5ct
qt6ct.sh should not set QT_QPA_PLATFORMTHEME=qt5ct unconditionally because it is already set in qt5ct.sh conditionally.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/40619.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-qt6ct-40619.patch --]
[-- Type: text/x-diff, Size: 1177 bytes --]

From dd4d31a23550cbd54c4d7005c7ec21b7932d7868 Mon Sep 17 00:00:00 2001
From: Firgen <filip.frgelec@disroot.org>
Date: Sat, 19 Nov 2022 18:04:49 +0100
Subject: [PATCH] qt6ct: qt6ct.sh should not set QT_QPA_PLATFORMTHEME=qt5ct

qt6ct.sh should not set QT_QPA_PLATFORMTHEME=qt5ct unconditionally
because it is already set in qt5ct.sh conditionally.
---
 srcpkgs/qt6ct/files/qt6ct.sh | 3 +--
 srcpkgs/qt6ct/template       | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/qt6ct/files/qt6ct.sh b/srcpkgs/qt6ct/files/qt6ct.sh
index e4e7708d8a299..d8ee1a3c9a003 100644
--- a/srcpkgs/qt6ct/files/qt6ct.sh
+++ b/srcpkgs/qt6ct/files/qt6ct.sh
@@ -1,6 +1,5 @@
-#!/usr/bin/env sh
+#!/bin/sh
 
-export QT_QPA_PLATFORMTHEME=qt5ct
 if [ "$XDG_SESSION_TYPE" = "wayland" ]; then
 	export QT_QPA_PLATFORM=wayland
 fi
diff --git a/srcpkgs/qt6ct/template b/srcpkgs/qt6ct/template
index db5aac26a3648..aed240a398da2 100644
--- a/srcpkgs/qt6ct/template
+++ b/srcpkgs/qt6ct/template
@@ -1,7 +1,7 @@
 # Template file for 'qt6ct'
 pkgname=qt6ct
 version=0.7
-revision=1
+revision=2
 build_style=cmake
 configure_args="-DQT_HOST_PATH=/usr"
 hostmakedepends="qt6-tools-devel"

^ permalink raw reply	[flat|nested] 12+ messages in thread
end of thread, other threads:[~2023-04-21  1:52 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-19 17:10 [PR PATCH] qt6ct: qt6ct.sh should not set QT_QPA_PLATFORMTHEME=qt5ct Firgen
2022-11-20  5:20 ` classabbyamp
2022-11-20  5:22 ` [PR REVIEW] " classabbyamp
2022-11-20 11:10 ` [PR PATCH] [Closed]: " Firgen
2022-11-20 11:10 ` [PR PATCH] [Updated] " Firgen
2022-11-20 11:19 ` Firgen
2022-11-20 11:19 ` Firgen
2022-11-20 15:58 ` classabbyamp
2022-11-21 20:03 ` Firgen
2023-01-06 22:29 ` Firgen
2023-04-07  1:49 ` github-actions
2023-04-21  1:52 ` [PR PATCH] [Closed]: " github-actions

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).