[PR PATCH] disklow: workaround distfiles cert error.

[PR PATCH] disklow: workaround distfiles cert error.

[yoshiyoshyosh]

[-- Attachment #1: Type: text/plain, Size: 714 bytes --]

There is a new pull request by yoshiyoshyosh against master on the void-packages repository

https://github.com/yoshiyoshyosh/void-packages disklow-distfiles
https://github.com/void-linux/void-packages/pull/43648

disklow: workaround distfiles cert error.
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

Addresses #42403.
I tried finding any precedence for an alive distfile but with broken certs and could only find #7512. Don't know if this is still the right way to workaround this 4 years later.

A patch file from https://github.com/void-linux/void-packages/pull/43648.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-disklow-distfiles-43648.patch --]
[-- Type: text/x-diff, Size: 1061 bytes --]

From 28b2b4b64c58ce4febe984509efb9d4c7d3a5630 Mon Sep 17 00:00:00 2001
From: yosh <yosh-git@riseup.net>
Date: Thu, 27 Apr 2023 11:09:03 -0400
Subject: [PATCH] disklow: workaround distfiles cert error.

---
 srcpkgs/disklow/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/disklow/template b/srcpkgs/disklow/template
index 1e0ccd108ffc..1f67f23732a7 100644
--- a/srcpkgs/disklow/template
+++ b/srcpkgs/disklow/template
@@ -1,7 +1,7 @@
 # Template file for 'disklow'
 pkgname=disklow
 version=1.2
-revision=1
+revision=2
 depends="perl-Filesys-Df perl-Config-General perl-Mail-Sendmail
  perl-Net-SMTP-SSL perl-Authen-SASL"
 short_desc="Fine grained disk space reporting with emphasis on mail functionality"
@@ -10,6 +10,7 @@ license="Artistic-1.0-Perl"
 homepage="https://loomsday.co.nz/development?id=linuxutils"
 distfiles="https://loomsday.co.nz/sources/disklow-${version}.tar.gz"
 checksum=05b9f510278147f24b0556eb745ff2b71c98c00fedf33434744fbe76ec884c26
+export SSL_NO_VERIFY_PEER=yes
 
 do_install() {
 	vbin  disklow

Re: disklow: workaround distfiles cert error.

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 334 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/43648#issuecomment-1526199974

Comment:
This variable would probably leak into other things when defined at the toplevel.

The certificate seems to work fine in firefox and chromium, this maybe an issue with voids ca-certificates.

Re: disklow: workaround distfiles cert error.

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/43648#issuecomment-1526199974

Comment:
This variable would probably leak into other things when defined at the toplevel.

The certificate seems to work fine in firefox and chromium, this may be an issue with voids ca-certificates.

Re: disklow: workaround distfiles cert error.

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 337 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/43648#issuecomment-1526199974

Comment:
This variable would probably leak into other things when defined at the toplevel.

The certificate seems to work fine in firefox and chromium, this might be an issue with voids ca-certificates.

Re: disklow: workaround distfiles cert error.

[yoshiyoshyosh]

[-- Attachment #1: Type: text/plain, Size: 547 bytes --]

New comment by yoshiyoshyosh on void-packages repository

https://github.com/void-linux/void-packages/pull/43648#issuecomment-1526255917

Comment:
Hmm, didn't think about that. It does work fine in web browsers, but CLI downloads with `wget` or `curl` also don't work unless `--no-check-certificate` or `-k` is passed.
Was also thinking of using `hostmakedepends=wget` and `fetch_cmd=wget --no-check-certificate` if the export is shaky and it's unable to be figured out on void's end (I'm not quite knowledgeable with working with certs myself).

Re: disklow: workaround distfiles cert error.

[yoshiyoshyosh]

[-- Attachment #1: Type: text/plain, Size: 551 bytes --]

New comment by yoshiyoshyosh on void-packages repository

https://github.com/void-linux/void-packages/pull/43648#issuecomment-1526255917

Comment:
Hmm, didn't think about that. It does work fine in web browsers, but CLI downloads with `wget` or `curl` also don't work unless `--no-check-certificate` or `-k` is passed.
Was also thinking of using `hostmakedepends="wget"` and `fetch_cmd="wget --no-check-certificate"` if the export is shaky and it's unable to be figured out on void's end (I'm not quite knowledgeable with working with certs myself).

Re: disklow: workaround distfiles cert error.

[yoshiyoshyosh]

[-- Attachment #1: Type: text/plain, Size: 627 bytes --]

New comment by yoshiyoshyosh on void-packages repository

https://github.com/void-linux/void-packages/pull/43648#issuecomment-1526255917

Comment:
Hmm, didn't think about if void's missing certs. It does work fine in web browsers, but CLI downloads with `wget` or `curl` also don't work unless `--no-check-certificate` or `-k` is passed.
Was also thinking of using `hostmakedepends="wget"` and `fetch_cmd="wget --no-check-certificate"` if the export is shaky and it's unable to be figured out on void's end (I'm not quite knowledgeable with working with certs myself; just wanted to try and bring a bit of attention to this).

Re: disklow: workaround distfiles cert error.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/43648#issuecomment-1527885314

Comment:
`fetch_cmd="env SSL_NO_VERIFY_PEER=1 $XBPS_FETCH_CMD"`

Re: disklow: workaround distfiles cert error.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/43648#issuecomment-1527885314

Comment:
```bash
fetch_cmd="env SSL_NO_VERIFY_PEER=1 $XBPS_FETCH_CMD"
```

Re: disklow: workaround distfiles cert error.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/43648#issuecomment-1527885314

Comment:
```bash
# xbps-fetch cannot verify this cert
fetch_cmd="env SSL_NO_VERIFY_PEER=1 $XBPS_FETCH_CMD"
```

Re: [PR PATCH] [Updated] disklow: workaround distfiles cert error.

[yoshiyoshyosh]

[-- Attachment #1: Type: text/plain, Size: 719 bytes --]

There is an updated pull request by yoshiyoshyosh against master on the void-packages repository

https://github.com/yoshiyoshyosh/void-packages disklow-distfiles
https://github.com/void-linux/void-packages/pull/43648

disklow: workaround distfiles cert error.
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

Addresses #42403.
I tried finding any precedence for an alive distfile but with broken certs and could only find #7512. Don't know if this is still the right way to workaround this 4 years later.

A patch file from https://github.com/void-linux/void-packages/pull/43648.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-disklow-distfiles-43648.patch --]
[-- Type: text/x-diff, Size: 1118 bytes --]

From 1d59ea429079ef578efdf713d3f4b711d6169024 Mon Sep 17 00:00:00 2001
From: yosh <yosh-git@riseup.net>
Date: Thu, 27 Apr 2023 11:09:03 -0400
Subject: [PATCH] disklow: workaround distfiles cert error.

---
 srcpkgs/disklow/template | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/disklow/template b/srcpkgs/disklow/template
index 1e0ccd108ffc..b5e9aae8efb2 100644
--- a/srcpkgs/disklow/template
+++ b/srcpkgs/disklow/template
@@ -1,7 +1,7 @@
 # Template file for 'disklow'
 pkgname=disklow
 version=1.2
-revision=1
+revision=2
 depends="perl-Filesys-Df perl-Config-General perl-Mail-Sendmail
  perl-Net-SMTP-SSL perl-Authen-SASL"
 short_desc="Fine grained disk space reporting with emphasis on mail functionality"
@@ -11,6 +11,9 @@ homepage="https://loomsday.co.nz/development?id=linuxutils"
 distfiles="https://loomsday.co.nz/sources/disklow-${version}.tar.gz"
 checksum=05b9f510278147f24b0556eb745ff2b71c98c00fedf33434744fbe76ec884c26
 
+# xbps-fetch cannot verify this cert
+fetch_cmd="env SSL_NO_VERIFY_PEER=1 $XBPS_FETCH_CMD"
+
 do_install() {
 	vbin  disklow
 	vconf disklow.conf

Re: [PR PATCH] [Merged]: disklow: workaround distfiles cert error.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 541 bytes --]

There's a merged pull request on the void-packages repository

disklow: workaround distfiles cert error.
https://github.com/void-linux/void-packages/pull/43648

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

Addresses #42403.
I tried finding any precedence for an alive distfile but with broken certs and could only find #7512. Don't know if this is still the right way to workaround this 4 years later.