[PR PATCH] mkinitcpio: add missing runtime dependency

[PR PATCH] mkinitcpio: add missing runtime dependency

[kenrap]

[-- Attachment #1: Type: text/plain, Size: 650 bytes --]

There is a new pull request by kenrap against master on the void-packages repository

https://github.com/kenrap/void-packages kenrap-mkinitcpio-fix
https://github.com/void-linux/void-packages/pull/43778

mkinitcpio: add missing runtime dependency
Because this error shows up when generating a new initramfs:
```
/usr/lib/initcpio/functions: line 1030: zstd: command not found
```

#### Testing the changes
- I tested the changes in this PR: **NO** (N/A?)

#### Local build testing
- I built this PR locally for my native architecture, (**x86_64**)


A patch file from https://github.com/void-linux/void-packages/pull/43778.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-kenrap-mkinitcpio-fix-43778.patch --]
[-- Type: text/x-diff, Size: 1014 bytes --]

From 751d94a8862b2860e1a4df1bd2f73c518caaef99 Mon Sep 17 00:00:00 2001
From: Kenneth Raplee <kenrap@kennethraplee.com>
Date: Sat, 6 May 2023 20:18:53 -0700
Subject: [PATCH] mkinitcpio: add missing runtime dependency

Because this error shows up when generating a new initramfs:
/usr/lib/initcpio/functions: line 1030: zstd: command not found
---
 srcpkgs/mkinitcpio/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/mkinitcpio/template b/srcpkgs/mkinitcpio/template
index 80b06163ade0..d7d5698807b3 100644
--- a/srcpkgs/mkinitcpio/template
+++ b/srcpkgs/mkinitcpio/template
@@ -1,10 +1,10 @@
 # Template file for 'mkinitcpio'
 pkgname=mkinitcpio
 version=35.2
-revision=1
+revision=2
 build_style=gnu-makefile
 hostmakedepends="asciidoc"
-depends="busybox-static bsdtar bash"
+depends="busybox-static bsdtar bash zstd"
 checkdepends="busybox-static bats-assert lz4 xz zstd"
 short_desc="Next generation of initramfs creation"
 maintainer="Andrea Brancaleoni <abc@pompel.me>"

Re: mkinitcpio: add missing runtime dependency

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/43778#issuecomment-1537279491

Comment:
zstd isn't required if you don't use zstd compression for the initramfs 

Re: mkinitcpio: add missing runtime dependency

[kenrap]

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

New comment by kenrap on void-packages repository

https://github.com/void-linux/void-packages/pull/43778#issuecomment-1537279562

Comment:
I guess it's the default now?

Re: mkinitcpio: add missing runtime dependency

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 646 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/43778#issuecomment-1537279888

Comment:
No, this is about zstd compression of kernel modules; `mkinitcpio` now attempts to decompress modules to "improve performance". This is optional because
1. Not all kernel packages use `zstd` compression, only newer ones
2. Setting `MODULES_DECOMPRESS=yes` in the config will disable decompression entirely
3. The message isn't a failure, it is just verbosely failing to decompress but will still include the compressed modules for a fully functional initramfs

For these reasons, this is a WONTFIX.

Re: [PR PATCH] [Closed]: mkinitcpio: add missing runtime dependency

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 487 bytes --]

There's a closed pull request on the void-packages repository

mkinitcpio: add missing runtime dependency
https://github.com/void-linux/void-packages/pull/43778

Description:
Because this error shows up when generating a new initramfs:
```
/usr/lib/initcpio/functions: line 1030: zstd: command not found
```

#### Testing the changes
- I tested the changes in this PR: **NO** (N/A?)

#### Local build testing
- I built this PR locally for my native architecture, (**x86_64**)

Re: mkinitcpio: add missing runtime dependency

[kenrap]

[-- Attachment #1: Type: text/plain, Size: 274 bytes --]

New comment by kenrap on void-packages repository

https://github.com/void-linux/void-packages/pull/43778#issuecomment-1537281771

Comment:
@ahesford 

Regarding item number 2 in your notes:

Is it actually `MODULES_DECOMPRESS=no`?

That seems to do the trick for me.

Re: mkinitcpio: add missing runtime dependency

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 822 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/43778#issuecomment-1537282987

Comment:
Yes, sorry; `MODULES_DECOMPRESS=yes` is the (new) default behavior that tries to decompress kernel modules, but setting to `no` (actually anything other than `yes`) will restore the original behavior of copying the modules in as they appear on disk.

Frankly, I don't really see the benefit of decompressing modules. It might trivially improve boot times because critical modules loaded by the initramfs don't need to be decompressed after the initramfs image is loaded, but a) how many modules are people really loading in an initramfs image that the difference is even measurable; and b) it increases the memory footprint of the initramfs, although this is an ephemeral cost.