Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: CBQN-0.2.0
@ 2023-05-04 21:09 BryceVandegrift
  2023-05-04 21:27 ` [PR REVIEW] " abenson
                   ` (20 more replies)
  0 siblings, 21 replies; 22+ messages in thread
From: BryceVandegrift @ 2023-05-04 21:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 890 bytes --]

There is a new pull request by BryceVandegrift against master on the void-packages repository

https://github.com/BryceVandegrift/void-packages CBQN
https://github.com/void-linux/void-packages/pull/43752

New package: CBQN-0.2.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl (crossbuild)

This is a continuation of [this](https://github.com/void-linux/void-packages/pull/43737) pull request.

A patch file from https://github.com/void-linux/void-packages/pull/43752.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-CBQN-43752.patch --]
[-- Type: text/x-diff, Size: 2320 bytes --]

From 7c6e8688640ec98ca2e99a86bd0802826be9bc30 Mon Sep 17 00:00:00 2001
From: Bryce Vandegrift <bryce@brycevandegrift.xyz>
Date: Thu, 4 May 2023 17:06:56 -0400
Subject: [PATCH] New package: CBQN-0.2.0

---
 srcpkgs/CBQN/template | 50 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 50 insertions(+)
 create mode 100644 srcpkgs/CBQN/template

diff --git a/srcpkgs/CBQN/template b/srcpkgs/CBQN/template
new file mode 100644
index 000000000000..da42d78edad4
--- /dev/null
+++ b/srcpkgs/CBQN/template
@@ -0,0 +1,50 @@
+# Template file for 'CBQN'
+pkgname=CBQN
+version=0.2.0
+revision=1
+archs="x86_64*"
+_singeli_hash=853ab1a06ae8d8603f228d8e784fa319cc401459
+_replxx_hash=1da4681a8814366ec51e7630b76558e53be0997d
+_bytecode_hash=78ed4102f914eb5fa490d76d4dcd4f8be6e53417
+hostmakedepends="clang libffi-devel"
+depends="libffi"
+short_desc="BQN implementation in C"
+maintainer="Bryce Vandegrift <bryce@brycevandegrift.xyz>"
+license="GPL-3.0-only, MIT, Apache-2.0, BSL-1.0"
+homepage="https://github.com/dzaima/CBQN"
+distfiles="https://github.com/dzaima/CBQN/archive/refs/tags/v${version}.tar.gz
+ https://github.com/mlochbaum/Singeli/archive/${_singeli_hash}.tar.gz
+ https://github.com/dzaima/replxx/archive/${_replxx_hash}.tar.gz
+ https://github.com/dzaima/cbqnBytecode/archive/${_bytecode_hash}.tar.gz"
+checksum="70525117364edefb6c8906e269a5b1b17c8647f516b6599fecdc53ba6e57530e
+ a0a8b48aac23bfa458c3af13cfcad1fb6889151e72b7983e85521245e367c1d4
+ 60ba4d8b566d8af1330f2f4b67d712da8efeb018f53f5055898d8b86a325088f
+ f99c10fc674e673bd8253a90e9676d070aadb4decc3f59766bed3b0295f47a1a"
+
+post_extract() {
+	rm -r CBQN-${version}/build/{bytecode,replxx,singeli}Submodule
+	mv "cbqnBytecode-${_bytecode_hash}" "CBQN-${version}/build/bytecodeSubmodule"
+	mv "replxx-${_replxx_hash}" "CBQN-${version}/build/replxxSubmodule"
+	mv "Singeli-${_singeli_hash}" "CBQN-${version}/build/singeliSubmodule"
+	cd CBQN-${version}
+	vsed -i makefile -e 's/@git/@true/g'
+	vsed -i makefile -e '/SHELL =.*/ d'
+}
+
+do_build() {
+	cd CBQN-${version}
+	make REPLXX=1 j=$(nproc)
+}
+
+do_install() {
+	cd CBQN-${version}
+	vbin BQN bqn
+
+	vdoc docs/commands.md
+	vdoc docs/system.md
+
+	vlicense licenses/LICENSE-Apache2
+	vlicense licenses/LICENSE-Boost
+	vlicense licenses/LICENSE-GPLv3
+	vlicense licenses/LICENSE-MIT-sort
+}

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PR REVIEW] New package: CBQN-0.2.0
  2023-05-04 21:09 [PR PATCH] New package: CBQN-0.2.0 BryceVandegrift
@ 2023-05-04 21:27 ` abenson
  2023-05-04 21:27 ` abenson
                   ` (19 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: abenson @ 2023-05-04 21:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/43752#discussion_r1185535255

Comment:
This isn't needed, it'll detect the requirement.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PR REVIEW] New package: CBQN-0.2.0
  2023-05-04 21:09 [PR PATCH] New package: CBQN-0.2.0 BryceVandegrift
  2023-05-04 21:27 ` [PR REVIEW] " abenson
@ 2023-05-04 21:27 ` abenson
  2023-05-04 21:27 ` abenson
                   ` (18 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: abenson @ 2023-05-04 21:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/43752#discussion_r1185535511

Comment:
`libffi-devel` should be in `makedepends`.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PR REVIEW] New package: CBQN-0.2.0
  2023-05-04 21:09 [PR PATCH] New package: CBQN-0.2.0 BryceVandegrift
  2023-05-04 21:27 ` [PR REVIEW] " abenson
  2023-05-04 21:27 ` abenson
@ 2023-05-04 21:27 ` abenson
  2023-05-04 21:28 ` abenson
                   ` (17 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: abenson @ 2023-05-04 21:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/43752#discussion_r1185535690

Comment:
Why is this restricted?

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PR REVIEW] New package: CBQN-0.2.0
  2023-05-04 21:09 [PR PATCH] New package: CBQN-0.2.0 BryceVandegrift
                   ` (2 preceding siblings ...)
  2023-05-04 21:27 ` abenson
@ 2023-05-04 21:28 ` abenson
  2023-05-04 21:28 ` abenson
                   ` (16 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: abenson @ 2023-05-04 21:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 211 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/43752#discussion_r1185536307

Comment:
set `build_wrksrc=CBQN-${version}" and you can get rid of this.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PR REVIEW] New package: CBQN-0.2.0
  2023-05-04 21:09 [PR PATCH] New package: CBQN-0.2.0 BryceVandegrift
                   ` (3 preceding siblings ...)
  2023-05-04 21:28 ` abenson
@ 2023-05-04 21:28 ` abenson
  2023-05-04 21:55 ` BryceVandegrift
                   ` (15 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: abenson @ 2023-05-04 21:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 226 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/43752#discussion_r1185536661

Comment:
could set `make_build_args="REPLXX=1"` and just use `build_style=gnu-makefile`

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PR REVIEW] New package: CBQN-0.2.0
  2023-05-04 21:09 [PR PATCH] New package: CBQN-0.2.0 BryceVandegrift
                   ` (4 preceding siblings ...)
  2023-05-04 21:28 ` abenson
@ 2023-05-04 21:55 ` BryceVandegrift
  2023-05-04 22:00 ` BryceVandegrift
                   ` (14 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: BryceVandegrift @ 2023-05-04 21:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]

New review comment by BryceVandegrift on void-packages repository

https://github.com/void-linux/void-packages/pull/43752#discussion_r1185553341

Comment:
CBQN will only compile correctly for x86_64-glibc and x86_64-musl.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PR REVIEW] New package: CBQN-0.2.0
  2023-05-04 21:09 [PR PATCH] New package: CBQN-0.2.0 BryceVandegrift
                   ` (5 preceding siblings ...)
  2023-05-04 21:55 ` BryceVandegrift
@ 2023-05-04 22:00 ` BryceVandegrift
  2023-05-04 22:04 ` BryceVandegrift
                   ` (13 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: BryceVandegrift @ 2023-05-04 22:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

New review comment by BryceVandegrift on void-packages repository

https://github.com/void-linux/void-packages/pull/43752#discussion_r1185556264

Comment:
I put this here because the build system cannot find the makefile so I have to manually `cd` into `CBQN-${version}`.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PR REVIEW] New package: CBQN-0.2.0
  2023-05-04 21:09 [PR PATCH] New package: CBQN-0.2.0 BryceVandegrift
                   ` (6 preceding siblings ...)
  2023-05-04 22:00 ` BryceVandegrift
@ 2023-05-04 22:04 ` BryceVandegrift
  2023-05-04 22:18 ` abenson
                   ` (12 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: BryceVandegrift @ 2023-05-04 22:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 255 bytes --]

New review comment by BryceVandegrift on void-packages repository

https://github.com/void-linux/void-packages/pull/43752#discussion_r1185558822

Comment:
Building for x86_64-musl will fail if `libffi-devel` is in `makedepends` and not `hostmakedepends`.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PR REVIEW] New package: CBQN-0.2.0
  2023-05-04 21:09 [PR PATCH] New package: CBQN-0.2.0 BryceVandegrift
                   ` (7 preceding siblings ...)
  2023-05-04 22:04 ` BryceVandegrift
@ 2023-05-04 22:18 ` abenson
  2023-05-04 22:22 ` abenson
                   ` (11 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: abenson @ 2023-05-04 22:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/43752#discussion_r1185566584

Comment:
 You shouldn't cross-build for `-musl`.  Create a `-musl` `masterdir` and build in it: `./xbps-src -m masterdir-musl binary-bootstrap x86_64-musl ; ./xbps-src -m masterdir-musl pkg CBQN`.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PR REVIEW] New package: CBQN-0.2.0
  2023-05-04 21:09 [PR PATCH] New package: CBQN-0.2.0 BryceVandegrift
                   ` (8 preceding siblings ...)
  2023-05-04 22:18 ` abenson
@ 2023-05-04 22:22 ` abenson
  2023-05-04 22:23 ` abenson
                   ` (10 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: abenson @ 2023-05-04 22:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 223 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/43752#discussion_r1185568718

Comment:
Yeah, the makefile needs to be fixed (or replaced) to work for cross-build.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PR REVIEW] New package: CBQN-0.2.0
  2023-05-04 21:09 [PR PATCH] New package: CBQN-0.2.0 BryceVandegrift
                   ` (9 preceding siblings ...)
  2023-05-04 22:22 ` abenson
@ 2023-05-04 22:23 ` abenson
  2023-05-04 23:41 ` [PR PATCH] [Updated] " BryceVandegrift
                   ` (9 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: abenson @ 2023-05-04 22:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 236 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/43752#discussion_r1185569022

Comment:
Yeah, it'll switch to the right directory if you set `build_wrksrc` as mentioned before.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PR PATCH] [Updated] New package: CBQN-0.2.0
  2023-05-04 21:09 [PR PATCH] New package: CBQN-0.2.0 BryceVandegrift
                   ` (10 preceding siblings ...)
  2023-05-04 22:23 ` abenson
@ 2023-05-04 23:41 ` BryceVandegrift
  2023-05-11 12:59 ` [PR REVIEW] " dzaima
                   ` (8 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: BryceVandegrift @ 2023-05-04 23:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 895 bytes --]

There is an updated pull request by BryceVandegrift against master on the void-packages repository

https://github.com/BryceVandegrift/void-packages CBQN
https://github.com/void-linux/void-packages/pull/43752

New package: CBQN-0.2.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl (crossbuild)

This is a continuation of [this](https://github.com/void-linux/void-packages/pull/43737) pull request.

A patch file from https://github.com/void-linux/void-packages/pull/43752.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-CBQN-43752.patch --]
[-- Type: text/x-diff, Size: 2307 bytes --]

From 15f022eee6b3a62eea42b5e9be62fe2e9b551ef1 Mon Sep 17 00:00:00 2001
From: Bryce Vandegrift <bryce@brycevandegrift.xyz>
Date: Thu, 4 May 2023 17:06:56 -0400
Subject: [PATCH] New package: CBQN-0.2.0

---
 srcpkgs/CBQN/template | 46 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 46 insertions(+)
 create mode 100644 srcpkgs/CBQN/template

diff --git a/srcpkgs/CBQN/template b/srcpkgs/CBQN/template
new file mode 100644
index 000000000000..ba287c7658af
--- /dev/null
+++ b/srcpkgs/CBQN/template
@@ -0,0 +1,46 @@
+# Template file for 'CBQN'
+pkgname=CBQN
+version=0.2.0
+revision=1
+build_style=gnu-makefile
+make_build_args="REPLXX=1 j=$(nproc)"
+_singeli_hash=853ab1a06ae8d8603f228d8e784fa319cc401459
+_replxx_hash=1da4681a8814366ec51e7630b76558e53be0997d
+_bytecode_hash=78ed4102f914eb5fa490d76d4dcd4f8be6e53417
+build_wrksrc="CBQN-$version"
+hostmakedepends="clang"
+makedepends="libffi-devel"
+short_desc="BQN implementation in C"
+maintainer="Bryce Vandegrift <bryce@brycevandegrift.xyz>"
+license="GPL-3.0-only, MIT, Apache-2.0, BSL-1.0"
+homepage="https://github.com/dzaima/CBQN"
+distfiles="https://github.com/dzaima/CBQN/archive/refs/tags/v${version}.tar.gz
+ https://github.com/mlochbaum/Singeli/archive/${_singeli_hash}.tar.gz
+ https://github.com/dzaima/replxx/archive/${_replxx_hash}.tar.gz
+ https://github.com/dzaima/cbqnBytecode/archive/${_bytecode_hash}.tar.gz"
+checksum="70525117364edefb6c8906e269a5b1b17c8647f516b6599fecdc53ba6e57530e
+ a0a8b48aac23bfa458c3af13cfcad1fb6889151e72b7983e85521245e367c1d4
+ 60ba4d8b566d8af1330f2f4b67d712da8efeb018f53f5055898d8b86a325088f
+ f99c10fc674e673bd8253a90e9676d070aadb4decc3f59766bed3b0295f47a1a"
+
+post_extract() {
+	rm -r CBQN-${version}/build/{bytecode,replxx,singeli}Submodule
+	mv "cbqnBytecode-${_bytecode_hash}" "CBQN-${version}/build/bytecodeSubmodule"
+	mv "replxx-${_replxx_hash}" "CBQN-${version}/build/replxxSubmodule"
+	mv "Singeli-${_singeli_hash}" "CBQN-${version}/build/singeliSubmodule"
+	cd CBQN-${version}
+	vsed -i makefile -e 's/@git/@true/g'
+	vsed -i makefile -e '/SHELL =.*/ d'
+}
+
+do_install() {
+	vbin BQN bqn
+
+	vdoc docs/commands.md
+	vdoc docs/system.md
+
+	vlicense licenses/LICENSE-Apache2
+	vlicense licenses/LICENSE-Boost
+	vlicense licenses/LICENSE-GPLv3
+	vlicense licenses/LICENSE-MIT-sort
+}

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PR REVIEW] New package: CBQN-0.2.0
  2023-05-04 21:09 [PR PATCH] New package: CBQN-0.2.0 BryceVandegrift
                   ` (11 preceding siblings ...)
  2023-05-04 23:41 ` [PR PATCH] [Updated] " BryceVandegrift
@ 2023-05-11 12:59 ` dzaima
  2023-05-11 20:02 ` [PR PATCH] [Updated] " BryceVandegrift
                   ` (7 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: dzaima @ 2023-05-11 12:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]

New review comment by dzaima on void-packages repository

https://github.com/void-linux/void-packages/pull/43752#discussion_r1191146530

Comment:
The preferred way to override the CBQN submodules is to put local copies at `build/bytecodeLocal` & `build/replxxLocal` & `build/singeliLocal` instead of the `*Submodule` ones. That way, `git` won't be invoked and its substitution is unnecessary, and it'll work with `build/src/build.bqn` too, when that becomes the default.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PR PATCH] [Updated] New package: CBQN-0.2.0
  2023-05-04 21:09 [PR PATCH] New package: CBQN-0.2.0 BryceVandegrift
                   ` (12 preceding siblings ...)
  2023-05-11 12:59 ` [PR REVIEW] " dzaima
@ 2023-05-11 20:02 ` BryceVandegrift
  2023-05-11 20:02 ` BryceVandegrift
                   ` (6 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: BryceVandegrift @ 2023-05-11 20:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1048 bytes --]

There is an updated pull request by BryceVandegrift against master on the void-packages repository

https://github.com/BryceVandegrift/void-packages CBQN
https://github.com/void-linux/void-packages/pull/43752

New package: CBQN-0.2.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl (crossbuild)
  - i686-glibc (crossbuild)
  - aarch64-glibc (crossbuild)
  - aarch64-musl (crossbuild)
  - armv7l-glibc (crossbuild)
  - armv7l-musl (crossbuild)

This is a continuation of [this](https://github.com/void-linux/void-packages/pull/43737) pull request.

A patch file from https://github.com/void-linux/void-packages/pull/43752.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-CBQN-43752.patch --]
[-- Type: text/x-diff, Size: 2256 bytes --]

From b1ddea8775634f09fd59358d97ccc3d13533f971 Mon Sep 17 00:00:00 2001
From: Bryce Vandegrift <bryce@brycevandegrift.xyz>
Date: Thu, 4 May 2023 17:06:56 -0400
Subject: [PATCH] New package: CBQN-0.2.0

---
 srcpkgs/CBQN/template | 45 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)
 create mode 100644 srcpkgs/CBQN/template

diff --git a/srcpkgs/CBQN/template b/srcpkgs/CBQN/template
new file mode 100644
index 000000000000..8dff6956d4af
--- /dev/null
+++ b/srcpkgs/CBQN/template
@@ -0,0 +1,45 @@
+# Template file for 'CBQN'
+pkgname=CBQN
+version=0.2.0
+revision=1
+build_style=gnu-makefile
+make_build_args="REPLXX=1 j=$(nproc)"
+_singeli_hash=853ab1a06ae8d8603f228d8e784fa319cc401459
+_replxx_hash=1da4681a8814366ec51e7630b76558e53be0997d
+_bytecode_hash=78ed4102f914eb5fa490d76d4dcd4f8be6e53417
+build_wrksrc="CBQN-$version"
+hostmakedepends="clang"
+makedepends="libffi-devel"
+short_desc="BQN implementation in C"
+maintainer="Bryce Vandegrift <bryce@brycevandegrift.xyz>"
+license="GPL-3.0-only, MIT, Apache-2.0, BSL-1.0"
+homepage="https://github.com/dzaima/CBQN"
+distfiles="https://github.com/dzaima/CBQN/archive/refs/tags/v${version}.tar.gz
+ https://github.com/mlochbaum/Singeli/archive/${_singeli_hash}.tar.gz
+ https://github.com/dzaima/replxx/archive/${_replxx_hash}.tar.gz
+ https://github.com/dzaima/cbqnBytecode/archive/${_bytecode_hash}.tar.gz"
+checksum="70525117364edefb6c8906e269a5b1b17c8647f516b6599fecdc53ba6e57530e
+ a0a8b48aac23bfa458c3af13cfcad1fb6889151e72b7983e85521245e367c1d4
+ 60ba4d8b566d8af1330f2f4b67d712da8efeb018f53f5055898d8b86a325088f
+ f99c10fc674e673bd8253a90e9676d070aadb4decc3f59766bed3b0295f47a1a"
+
+post_extract() {
+	rm -r CBQN-${version}/build/{bytecode,replxx,singeli}Submodule
+	mv "cbqnBytecode-${_bytecode_hash}" "CBQN-${version}/build/bytecodeLocal"
+	mv "replxx-${_replxx_hash}" "CBQN-${version}/build/replxxLocal"
+	mv "Singeli-${_singeli_hash}" "CBQN-${version}/build/singeliLocal"
+	cd CBQN-${version}
+	vsed -i makefile -e '/SHELL =.*/ d'
+}
+
+do_install() {
+	vbin BQN bqn
+
+	vdoc docs/commands.md
+	vdoc docs/system.md
+
+	vlicense licenses/LICENSE-Apache2
+	vlicense licenses/LICENSE-Boost
+	vlicense licenses/LICENSE-GPLv3
+	vlicense licenses/LICENSE-MIT-sort
+}

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: New package: CBQN-0.2.0
  2023-05-04 21:09 [PR PATCH] New package: CBQN-0.2.0 BryceVandegrift
                   ` (13 preceding siblings ...)
  2023-05-11 20:02 ` [PR PATCH] [Updated] " BryceVandegrift
@ 2023-05-11 20:02 ` BryceVandegrift
  2023-05-11 21:16 ` [PR REVIEW] " abenson
                   ` (5 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: BryceVandegrift @ 2023-05-11 20:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

New comment by BryceVandegrift on void-packages repository

https://github.com/void-linux/void-packages/pull/43752#issuecomment-1544601192

Comment:
@dzaima Ok, it has been fixed.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PR REVIEW] New package: CBQN-0.2.0
  2023-05-04 21:09 [PR PATCH] New package: CBQN-0.2.0 BryceVandegrift
                   ` (14 preceding siblings ...)
  2023-05-11 20:02 ` BryceVandegrift
@ 2023-05-11 21:16 ` abenson
  2023-05-11 21:19 ` abenson
                   ` (4 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: abenson @ 2023-05-11 21:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/43752#discussion_r1191696933

Comment:
```suggestion
make_build_args="REPLXX=1 j=${XBPS_MAKEJOBS}"
```

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PR REVIEW] New package: CBQN-0.2.0
  2023-05-04 21:09 [PR PATCH] New package: CBQN-0.2.0 BryceVandegrift
                   ` (15 preceding siblings ...)
  2023-05-11 21:16 ` [PR REVIEW] " abenson
@ 2023-05-11 21:19 ` abenson
  2023-05-12  1:07 ` BryceVandegrift
                   ` (3 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: abenson @ 2023-05-11 21:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 167 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/43752#discussion_r1191699257

Comment:
Why is this needed?

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PR REVIEW] New package: CBQN-0.2.0
  2023-05-04 21:09 [PR PATCH] New package: CBQN-0.2.0 BryceVandegrift
                   ` (16 preceding siblings ...)
  2023-05-11 21:19 ` abenson
@ 2023-05-12  1:07 ` BryceVandegrift
  2023-05-12 18:07 ` [PR PATCH] [Updated] " BryceVandegrift
                   ` (2 subsequent siblings)
  20 siblings, 0 replies; 22+ messages in thread
From: BryceVandegrift @ 2023-05-12  1:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 289 bytes --]

New review comment by BryceVandegrift on void-packages repository

https://github.com/void-linux/void-packages/pull/43752#discussion_r1191812398

Comment:
Removes the `SHELL = /usr/bin/env bash` at the beginning of the makefile. It's a useless variable that could interfere with building.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PR PATCH] [Updated] New package: CBQN-0.2.0
  2023-05-04 21:09 [PR PATCH] New package: CBQN-0.2.0 BryceVandegrift
                   ` (17 preceding siblings ...)
  2023-05-12  1:07 ` BryceVandegrift
@ 2023-05-12 18:07 ` BryceVandegrift
  2023-06-25 17:20 ` Duncaen
  2023-07-04 12:31 ` [PR PATCH] [Closed]: " BryceVandegrift
  20 siblings, 0 replies; 22+ messages in thread
From: BryceVandegrift @ 2023-05-12 18:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1048 bytes --]

There is an updated pull request by BryceVandegrift against master on the void-packages repository

https://github.com/BryceVandegrift/void-packages CBQN
https://github.com/void-linux/void-packages/pull/43752

New package: CBQN-0.2.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl (crossbuild)
  - i686-glibc (crossbuild)
  - aarch64-glibc (crossbuild)
  - aarch64-musl (crossbuild)
  - armv7l-glibc (crossbuild)
  - armv7l-musl (crossbuild)

This is a continuation of [this](https://github.com/void-linux/void-packages/pull/43737) pull request.

A patch file from https://github.com/void-linux/void-packages/pull/43752.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-CBQN-43752.patch --]
[-- Type: text/x-diff, Size: 2264 bytes --]

From 95c084c143ff9c4ecf67b52b84f877d3e07e0e76 Mon Sep 17 00:00:00 2001
From: Bryce Vandegrift <bryce@brycevandegrift.xyz>
Date: Thu, 4 May 2023 17:06:56 -0400
Subject: [PATCH] New package: CBQN-0.2.0

---
 srcpkgs/CBQN/template | 45 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)
 create mode 100644 srcpkgs/CBQN/template

diff --git a/srcpkgs/CBQN/template b/srcpkgs/CBQN/template
new file mode 100644
index 000000000000..3597bb363834
--- /dev/null
+++ b/srcpkgs/CBQN/template
@@ -0,0 +1,45 @@
+# Template file for 'CBQN'
+pkgname=CBQN
+version=0.2.0
+revision=1
+build_style=gnu-makefile
+make_build_args="REPLXX=1 j=${XBPS_MAKEJOBS}"
+_singeli_hash=853ab1a06ae8d8603f228d8e784fa319cc401459
+_replxx_hash=1da4681a8814366ec51e7630b76558e53be0997d
+_bytecode_hash=78ed4102f914eb5fa490d76d4dcd4f8be6e53417
+build_wrksrc="CBQN-$version"
+hostmakedepends="clang"
+makedepends="libffi-devel"
+short_desc="BQN implementation in C"
+maintainer="Bryce Vandegrift <bryce@brycevandegrift.xyz>"
+license="GPL-3.0-only, MIT, Apache-2.0, BSL-1.0"
+homepage="https://github.com/dzaima/CBQN"
+distfiles="https://github.com/dzaima/CBQN/archive/refs/tags/v${version}.tar.gz
+ https://github.com/mlochbaum/Singeli/archive/${_singeli_hash}.tar.gz
+ https://github.com/dzaima/replxx/archive/${_replxx_hash}.tar.gz
+ https://github.com/dzaima/cbqnBytecode/archive/${_bytecode_hash}.tar.gz"
+checksum="70525117364edefb6c8906e269a5b1b17c8647f516b6599fecdc53ba6e57530e
+ a0a8b48aac23bfa458c3af13cfcad1fb6889151e72b7983e85521245e367c1d4
+ 60ba4d8b566d8af1330f2f4b67d712da8efeb018f53f5055898d8b86a325088f
+ f99c10fc674e673bd8253a90e9676d070aadb4decc3f59766bed3b0295f47a1a"
+
+post_extract() {
+	rm -r CBQN-${version}/build/{bytecode,replxx,singeli}Submodule
+	mv "cbqnBytecode-${_bytecode_hash}" "CBQN-${version}/build/bytecodeLocal"
+	mv "replxx-${_replxx_hash}" "CBQN-${version}/build/replxxLocal"
+	mv "Singeli-${_singeli_hash}" "CBQN-${version}/build/singeliLocal"
+	cd CBQN-${version}
+	vsed -i makefile -e '/SHELL =.*/ d'
+}
+
+do_install() {
+	vbin BQN bqn
+
+	vdoc docs/commands.md
+	vdoc docs/system.md
+
+	vlicense licenses/LICENSE-Apache2
+	vlicense licenses/LICENSE-Boost
+	vlicense licenses/LICENSE-GPLv3
+	vlicense licenses/LICENSE-MIT-sort
+}

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: New package: CBQN-0.2.0
  2023-05-04 21:09 [PR PATCH] New package: CBQN-0.2.0 BryceVandegrift
                   ` (18 preceding siblings ...)
  2023-05-12 18:07 ` [PR PATCH] [Updated] " BryceVandegrift
@ 2023-06-25 17:20 ` Duncaen
  2023-07-04 12:31 ` [PR PATCH] [Closed]: " BryceVandegrift
  20 siblings, 0 replies; 22+ messages in thread
From: Duncaen @ 2023-06-25 17:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/43752#issuecomment-1606171474

Comment:
Might make sense to add `alternatives` for `bqn` just in case there will be future packages.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PR PATCH] [Closed]: New package: CBQN-0.2.0
  2023-05-04 21:09 [PR PATCH] New package: CBQN-0.2.0 BryceVandegrift
                   ` (19 preceding siblings ...)
  2023-06-25 17:20 ` Duncaen
@ 2023-07-04 12:31 ` BryceVandegrift
  20 siblings, 0 replies; 22+ messages in thread
From: BryceVandegrift @ 2023-07-04 12:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 879 bytes --]

There's a closed pull request on the void-packages repository

New package: CBQN-0.2.0
https://github.com/void-linux/void-packages/pull/43752

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl (crossbuild)
  - i686-glibc (crossbuild)
  - aarch64-glibc (crossbuild)
  - aarch64-musl (crossbuild)
  - armv7l-glibc (crossbuild)
  - armv7l-musl (crossbuild)

This is a continuation of [this](https://github.com/void-linux/void-packages/pull/43737) pull request.

^ permalink raw reply	[flat|nested] 22+ messages in thread

end of thread, other threads:[~2023-07-04 12:31 UTC | newest]

Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-04 21:09 [PR PATCH] New package: CBQN-0.2.0 BryceVandegrift
2023-05-04 21:27 ` [PR REVIEW] " abenson
2023-05-04 21:27 ` abenson
2023-05-04 21:27 ` abenson
2023-05-04 21:28 ` abenson
2023-05-04 21:28 ` abenson
2023-05-04 21:55 ` BryceVandegrift
2023-05-04 22:00 ` BryceVandegrift
2023-05-04 22:04 ` BryceVandegrift
2023-05-04 22:18 ` abenson
2023-05-04 22:22 ` abenson
2023-05-04 22:23 ` abenson
2023-05-04 23:41 ` [PR PATCH] [Updated] " BryceVandegrift
2023-05-11 12:59 ` [PR REVIEW] " dzaima
2023-05-11 20:02 ` [PR PATCH] [Updated] " BryceVandegrift
2023-05-11 20:02 ` BryceVandegrift
2023-05-11 21:16 ` [PR REVIEW] " abenson
2023-05-11 21:19 ` abenson
2023-05-12  1:07 ` BryceVandegrift
2023-05-12 18:07 ` [PR PATCH] [Updated] " BryceVandegrift
2023-06-25 17:20 ` Duncaen
2023-07-04 12:31 ` [PR PATCH] [Closed]: " BryceVandegrift

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).