[PR PATCH] maxima: dont default sbcl on aarch64, dont makedepends on emacs

[PR PATCH] maxima: dont default sbcl on aarch64, dont makedepends on emacs

[tornaria]

[-- Attachment #1: Type: text/plain, Size: 999 bytes --]

There is a new pull request by tornaria against master on the void-packages repository

https://github.com/tornaria/void-packages maxima-aarch64
https://github.com/void-linux/void-packages/pull/43311

maxima: dont default sbcl on aarch64, dont makedepends on emacs
@dkwo: try this.

 - Default to `~sbcl` for aarch64 since you say it's broken
 - Remove emacs from hostmakedepends; it seems the emacs support files don't really need emacs.

Let's see how this works. Note that your `maxima` package will not contain any binary, you will have to manually install `maxima-ecl`. If this is a good setup we can figure out how to address this. Not a problem for sagemath which depends on `maxima-ecl`.

For cross compiling, we would need to do something more fancy, i.e. an `ecl` binary that can cross-compile for aarch64. This is in principle possible as ecl compiles itself this way using the host ecl.


A patch file from https://github.com/void-linux/void-packages/pull/43311.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-maxima-aarch64-43311.patch --]
[-- Type: text/x-diff, Size: 1179 bytes --]

From 2e44d4a752bec8d41d2aeb0c8291012ece1dd022 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Thu, 6 Apr 2023 18:59:36 -0300
Subject: [PATCH] maxima: dont default sbcl on aarch64, dont makedepends on
 emacs

---
 srcpkgs/maxima/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/maxima/template b/srcpkgs/maxima/template
index 69e85ec833e8..cfb7470e0a25 100644
--- a/srcpkgs/maxima/template
+++ b/srcpkgs/maxima/template
@@ -4,7 +4,7 @@ version=5.45.1
 revision=4
 build_style=gnu-configure
 configure_args="$(vopt_enable clisp) $(vopt_enable sbcl sbcl-exec) $(vopt_enable ecl)"
-hostmakedepends="python3 perl emacs texinfo patchelf"
+hostmakedepends="python3 perl texinfo patchelf $(vopt_if ecl ecl)"
 makedepends="$(vopt_if clisp clisp) $(vopt_if sbcl sbcl) $(vopt_if ecl ecl)"
 depends="$(vopt_if clisp clisp) rlwrap"
 checkdepends="gnuplot"
@@ -32,7 +32,7 @@ build_options_default="ecl"
 
 # sbcl is only available for these architectures
 case "$XBPS_TARGET_MACHINE" in
-	i686|x86_64*|armv7l|aarch64|ppc64le*)
+	i686|x86_64*|armv7l|ppc64le*)
 		build_options_default+=" sbcl"
 		;;
 esac

Re: maxima: dont default sbcl on aarch64, dont makedepends on emacs

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/43311#issuecomment-1500375239

Comment:
hmm, that's not enough: i also have to remove the package maxima-emacs, otherwise emacs is in rundepends for both maxima and maxima-ecl. can it be made conditional on arch? (i only care about using maxima in sage btw :)

Re: maxima: dont default sbcl on aarch64, dont makedepends on emacs

[tornaria]

[-- Attachment #1: Type: text/plain, Size: 603 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/43311#issuecomment-1500437107

Comment:
> hmm, that's not enough: i also have to remove the package maxima-emacs, otherwise emacs is in rundepends for both maxima and maxima-ecl. can it be made conditional on arch? (i only care about using maxima in sage btw :)

That's weird, nothing depends on `maxima-emacs` afaict. That's the point of splitting this as a subpackage, that you don't have to pull emacs as a dependency.

I don't have maxima-emacs installed in my box and nothing pulls in emacs.

Re: maxima: dont default sbcl on aarch64, dont makedepends on emacs

[tornaria]

[-- Attachment #1: Type: text/plain, Size: 619 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/43311#issuecomment-1500440971

Comment:
:man_facepalming: sorry, now I see what you mean. Because we are building `maxima-emacs` and this rundepends on `emacs`, then xbps-src wants to build emacs anyway...

So yeah, the only way out of this is to make `maxima-emacs` an optional build.

As a workaround, you can use `-I` with xbps-src, then it should not try to build emacs. But it's better to add emacs as an option.

As an immediate workaround, try removing `maxima-emacs` from the last line of the template.

Re: maxima: dont default sbcl on aarch64, dont makedepends on emacs

[tornaria]

[-- Attachment #1: Type: text/plain, Size: 345 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/43311#issuecomment-1500442844

Comment:
Also: since emacs is not required anyway to build the emacs support, we might as well ship the emacs files in the main `maxima` package and get rid of the `maxima-emacs` subpkg and the emacs dependency.

Re: maxima: dont default sbcl on aarch64, dont makedepends on emacs

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/43311#issuecomment-1500506736

Comment:
immediate workarounds are fine. i agree we should get rid of/make optional emacs subpk and dep.

Re: maxima: dont default sbcl on aarch64, dont makedepends on emacs

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 396 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/43311#issuecomment-1525882792

Comment:
> Also: since emacs is not required anyway to build the emacs support, we might as well ship the emacs files in the main `maxima` package and get rid of the `maxima-emacs` subpkg and the emacs dependency.

if you implement that, I'm happy to test it here.

Re: maxima: dont default sbcl on aarch64, dont makedepends on emacs

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 212 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/43311#issuecomment-1542201278

Comment:
@tornaria Should we include this emacs change in the other maxima update?

Re: maxima: dont default sbcl on aarch64, dont makedepends on emacs

[tornaria]

[-- Attachment #1: Type: text/plain, Size: 279 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/43311#issuecomment-1542203680

Comment:
> @tornaria Should we include this emacs change in the other maxima update?

Thanks for the reminder, yes we should. I'll do it later.

Re: maxima: dont default sbcl on aarch64, dont makedepends on emacs

[tornaria]

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/43311#issuecomment-1546502116

Comment:
I've included these changes in the update to 5.46.0 that is part of #43659 .

Re: [PR PATCH] [Closed]: maxima: dont default sbcl on aarch64, dont makedepends on emacs

[tornaria]

[-- Attachment #1: Type: text/plain, Size: 839 bytes --]

There's a closed pull request on the void-packages repository

maxima: dont default sbcl on aarch64, dont makedepends on emacs
https://github.com/void-linux/void-packages/pull/43311

Description:
@dkwo: try this.

 - Default to `~sbcl` for aarch64 since you say it's broken
 - Remove emacs from hostmakedepends; it seems the emacs support files don't really need emacs.

Let's see how this works. Note that your `maxima` package will not contain any binary, you will have to manually install `maxima-ecl`. If this is a good setup we can figure out how to address this. Not a problem for sagemath which depends on `maxima-ecl`.

For cross compiling, we would need to do something more fancy, i.e. an `ecl` binary that can cross-compile for aarch64. This is in principle possible as ecl compiles itself this way using the host ecl.