Github messages for voidlinux
 help / color / mirror / Atom feed
From: carvalhudo <carvalhudo@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] ranger: fix check step, adopt
Date: Sat, 13 May 2023 20:57:07 +0200	[thread overview]
Message-ID: <20230513185707.3eAicnnmViHDBjvrEx1vNlu9O2GtLO5BiaguyGG31BQ@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-43796@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 423 bytes --]

New review comment by carvalhudo on void-packages repository

https://github.com/void-linux/void-packages/pull/43796#discussion_r1193025876

Comment:
> Does it work with TERM=ansi? or TERM=xterm?

Yes.

> Also without TERMINFO?

Yes. Do you think we can remove it?I'm not sure about its relevance here. I took a quick look at the project's source code and I figured out ranger doesn't rely on this variable directly.

  parent reply	other threads:[~2023-05-13 18:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-07 20:49 [PR PATCH] ranger: add changelog, adopt carvalhudo
2023-05-07 20:56 ` [PR PATCH] [Updated] " carvalhudo
2023-05-07 22:24 ` carvalhudo
2023-05-08  1:05 ` carvalhudo
2023-05-08  1:08 ` carvalhudo
2023-05-11  2:02 ` [PR REVIEW] ranger: fix check step, adopt sgn
2023-05-11  2:02 ` sgn
2023-05-13 18:57 ` carvalhudo [this message]
2023-08-12  1:43 ` github-actions
2023-08-26  1:44 ` [PR PATCH] [Closed]: " github-actions

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230513185707.3eAicnnmViHDBjvrEx1vNlu9O2GtLO5BiaguyGG31BQ@z \
    --to=carvalhudo@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).