[PR PATCH] ranger: add changelog, adopt

[PR PATCH] ranger: add changelog, adopt

[carvalhudo]

[-- Attachment #1: Type: text/plain, Size: 400 bytes --]

There is a new pull request by carvalhudo against master on the void-packages repository

https://github.com/carvalhudo/void-packages add_changelog_ranger
https://github.com/void-linux/void-packages/pull/43796

ranger: add changelog, adopt
#### Testing the changes
- I tested the changes in this PR: **YES**

A patch file from https://github.com/void-linux/void-packages/pull/43796.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-add_changelog_ranger-43796.patch --]
[-- Type: text/x-diff, Size: 1055 bytes --]

From df89a1a27258d1b378cfcde06ef1025ae10ae54b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20L=2E=20C=2E=20Moreira?=
 <andrelcmoreira@disroot.org>
Date: Sun, 7 May 2023 17:46:11 -0300
Subject: [PATCH] ranger: add changelog, adopt

---
 srcpkgs/ranger/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/ranger/template b/srcpkgs/ranger/template
index 4c2a670374e9..00667b566c6f 100644
--- a/srcpkgs/ranger/template
+++ b/srcpkgs/ranger/template
@@ -9,9 +9,10 @@ makedepends="python3-devel"
 depends="python3"
 checkdepends="python3-pytest flake8 ncurses-term"
 short_desc="File manager with an ncurses frontend written in Python"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="André L. C. Moreira <andrelcmoreira@disroot.org>"
 license="GPL-3.0-only"
 homepage="https://ranger.github.io"
+changelog="https://raw.githubusercontent.com/ranger/ranger/master/CHANGELOG.md"
 distfiles="${homepage}/${pkgname}-${version}.tar.gz"
 checksum=ce088a04c91c25263a9675dc5c43514b7ec1b38c8ea43d9a9d00923ff6cdd251
 

Re: [PR PATCH] [Updated] ranger: add changelog, adopt

[carvalhudo]

[-- Attachment #1: Type: text/plain, Size: 405 bytes --]

There is an updated pull request by carvalhudo against master on the void-packages repository

https://github.com/carvalhudo/void-packages add_changelog_ranger
https://github.com/void-linux/void-packages/pull/43796

ranger: add changelog, adopt
#### Testing the changes
- I tested the changes in this PR: **YES**

A patch file from https://github.com/void-linux/void-packages/pull/43796.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-add_changelog_ranger-43796.patch --]
[-- Type: text/x-diff, Size: 1183 bytes --]

From 1a821a8894cab4c6f3003a351fa560d1d1699f1e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20L=2E=20C=2E=20Moreira?=
 <andrelcmoreira@disroot.org>
Date: Sun, 7 May 2023 17:46:11 -0300
Subject: [PATCH] ranger: add changelog, adopt

---
 srcpkgs/ranger/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/ranger/template b/srcpkgs/ranger/template
index 4c2a670374e9..59ebf5884a9c 100644
--- a/srcpkgs/ranger/template
+++ b/srcpkgs/ranger/template
@@ -3,15 +3,15 @@ pkgname=ranger
 version=1.9.3
 revision=4
 build_style=python3-module
-pycompile_module="ranger"
 hostmakedepends="python3"
 makedepends="python3-devel"
 depends="python3"
 checkdepends="python3-pytest flake8 ncurses-term"
 short_desc="File manager with an ncurses frontend written in Python"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="André L. C. Moreira <andrelcmoreira@disroot.org>"
 license="GPL-3.0-only"
 homepage="https://ranger.github.io"
+changelog="https://raw.githubusercontent.com/ranger/ranger/master/CHANGELOG.md"
 distfiles="${homepage}/${pkgname}-${version}.tar.gz"
 checksum=ce088a04c91c25263a9675dc5c43514b7ec1b38c8ea43d9a9d00923ff6cdd251
 

Re: [PR PATCH] [Updated] ranger: add changelog, adopt

[carvalhudo]

[-- Attachment #1: Type: text/plain, Size: 405 bytes --]

There is an updated pull request by carvalhudo against master on the void-packages repository

https://github.com/carvalhudo/void-packages add_changelog_ranger
https://github.com/void-linux/void-packages/pull/43796

ranger: add changelog, adopt
#### Testing the changes
- I tested the changes in this PR: **YES**

A patch file from https://github.com/void-linux/void-packages/pull/43796.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-add_changelog_ranger-43796.patch --]
[-- Type: text/x-diff, Size: 1445 bytes --]

From 1b66633ceba110f5b9a8a6fab6daba2626f9afc3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20L=2E=20C=2E=20Moreira?=
 <andrelcmoreira@disroot.org>
Date: Sun, 7 May 2023 17:46:11 -0300
Subject: [PATCH] ranger: add changelog, adopt

---
 srcpkgs/ranger/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/ranger/template b/srcpkgs/ranger/template
index 4c2a670374e9..fba220a81c02 100644
--- a/srcpkgs/ranger/template
+++ b/srcpkgs/ranger/template
@@ -3,21 +3,21 @@ pkgname=ranger
 version=1.9.3
 revision=4
 build_style=python3-module
-pycompile_module="ranger"
 hostmakedepends="python3"
 makedepends="python3-devel"
 depends="python3"
 checkdepends="python3-pytest flake8 ncurses-term"
 short_desc="File manager with an ncurses frontend written in Python"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="André L. C. Moreira <andrelcmoreira@disroot.org>"
 license="GPL-3.0-only"
 homepage="https://ranger.github.io"
+changelog="https://raw.githubusercontent.com/ranger/ranger/master/CHANGELOG.md"
 distfiles="${homepage}/${pkgname}-${version}.tar.gz"
 checksum=ce088a04c91c25263a9675dc5c43514b7ec1b38c8ea43d9a9d00923ff6cdd251
 
 do_check() {
 	# test_pylint is failing,
 	# As a distro, we don't want to check their code style
-	TERM=linux TERMINFO=/usr/share/terminfo \
+	PYTHON=python TERM=linux TERMINFO=/usr/share/terminfo \
 		make test_flake8 test_doctest test_pytest test_other
 }

Re: [PR PATCH] [Updated] ranger: add changelog, adopt

[carvalhudo]

[-- Attachment #1: Type: text/plain, Size: 405 bytes --]

There is an updated pull request by carvalhudo against master on the void-packages repository

https://github.com/carvalhudo/void-packages add_changelog_ranger
https://github.com/void-linux/void-packages/pull/43796

ranger: add changelog, adopt
#### Testing the changes
- I tested the changes in this PR: **YES**

A patch file from https://github.com/void-linux/void-packages/pull/43796.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-add_changelog_ranger-43796.patch --]
[-- Type: text/x-diff, Size: 1653 bytes --]

From 0b572c4cf828cd91a905d630a4aeb88cd2c579e6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20L=2E=20C=2E=20Moreira?=
 <andrelcmoreira@disroot.org>
Date: Sun, 7 May 2023 17:46:11 -0300
Subject: [PATCH] ranger: add changelog, adopt

---
 srcpkgs/ranger/template | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/ranger/template b/srcpkgs/ranger/template
index 4c2a670374e9..3ba965172b3b 100644
--- a/srcpkgs/ranger/template
+++ b/srcpkgs/ranger/template
@@ -3,21 +3,25 @@ pkgname=ranger
 version=1.9.3
 revision=4
 build_style=python3-module
-pycompile_module="ranger"
 hostmakedepends="python3"
 makedepends="python3-devel"
 depends="python3"
 checkdepends="python3-pytest flake8 ncurses-term"
 short_desc="File manager with an ncurses frontend written in Python"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="André L. C. Moreira <andrelcmoreira@disroot.org>"
 license="GPL-3.0-only"
 homepage="https://ranger.github.io"
+changelog="https://raw.githubusercontent.com/ranger/ranger/master/CHANGELOG.md"
 distfiles="${homepage}/${pkgname}-${version}.tar.gz"
 checksum=ce088a04c91c25263a9675dc5c43514b7ec1b38c8ea43d9a9d00923ff6cdd251
 
 do_check() {
 	# test_pylint is failing,
 	# As a distro, we don't want to check their code style
-	TERM=linux TERMINFO=/usr/share/terminfo \
+
+  # as workaround to fix this step, we set the 'PYTHON' variable due the lack
+  # of 'which' command (whose is used in the ranger's Makefile to find the
+  # suitable python version) in base-chroot.
+	PYTHON=python TERM=linux TERMINFO=/usr/share/terminfo \
 		make test_flake8 test_doctest test_pytest test_other
 }

Re: [PR PATCH] [Updated] ranger: add changelog, adopt

[carvalhudo]

[-- Attachment #1: Type: text/plain, Size: 405 bytes --]

There is an updated pull request by carvalhudo against master on the void-packages repository

https://github.com/carvalhudo/void-packages add_changelog_ranger
https://github.com/void-linux/void-packages/pull/43796

ranger: add changelog, adopt
#### Testing the changes
- I tested the changes in this PR: **YES**

A patch file from https://github.com/void-linux/void-packages/pull/43796.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-add_changelog_ranger-43796.patch --]
[-- Type: text/x-diff, Size: 1650 bytes --]

From 47b26cb3df7e869682d042bfcba32977b1f4fd37 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20L=2E=20C=2E=20Moreira?=
 <andrelcmoreira@disroot.org>
Date: Sun, 7 May 2023 17:46:11 -0300
Subject: [PATCH] ranger: add changelog, adopt

---
 srcpkgs/ranger/template | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/ranger/template b/srcpkgs/ranger/template
index 4c2a670374e9..9d49a5dbcf8a 100644
--- a/srcpkgs/ranger/template
+++ b/srcpkgs/ranger/template
@@ -3,21 +3,25 @@ pkgname=ranger
 version=1.9.3
 revision=4
 build_style=python3-module
-pycompile_module="ranger"
 hostmakedepends="python3"
 makedepends="python3-devel"
 depends="python3"
 checkdepends="python3-pytest flake8 ncurses-term"
 short_desc="File manager with an ncurses frontend written in Python"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="André L. C. Moreira <andrelcmoreira@disroot.org>"
 license="GPL-3.0-only"
 homepage="https://ranger.github.io"
+changelog="https://raw.githubusercontent.com/ranger/ranger/master/CHANGELOG.md"
 distfiles="${homepage}/${pkgname}-${version}.tar.gz"
 checksum=ce088a04c91c25263a9675dc5c43514b7ec1b38c8ea43d9a9d00923ff6cdd251
 
 do_check() {
 	# test_pylint is failing,
 	# As a distro, we don't want to check their code style
-	TERM=linux TERMINFO=/usr/share/terminfo \
+
+	# as workaround to fix this step, we set the 'PYTHON' variable due the lack
+	# of 'which' command (whose is used in the ranger's Makefile to find the
+	# suitable python version) in base-chroot.
+	PYTHON=python TERM=linux TERMINFO=/usr/share/terminfo \
 		make test_flake8 test_doctest test_pytest test_other
 }

Re: [PR REVIEW] ranger: fix check step, adopt

[sgn]

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/43796#discussion_r1190563440

Comment:
Does it work with `TERM=ansi`? or `TERM=xterm`?

Re: [PR REVIEW] ranger: fix check step, adopt

[sgn]

[-- Attachment #1: Type: text/plain, Size: 168 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/43796#discussion_r1190563571

Comment:
Also without `TERMINFO`?

Re: [PR REVIEW] ranger: fix check step, adopt

[carvalhudo]

[-- Attachment #1: Type: text/plain, Size: 423 bytes --]

New review comment by carvalhudo on void-packages repository

https://github.com/void-linux/void-packages/pull/43796#discussion_r1193025876

Comment:
> Does it work with TERM=ansi? or TERM=xterm?

Yes.

> Also without TERMINFO?

Yes. Do you think we can remove it?I'm not sure about its relevance here. I took a quick look at the project's source code and I figured out ranger doesn't rely on this variable directly.

Re: ranger: fix check step, adopt

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/43796#issuecomment-1675605706

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: ranger: fix check step, adopt

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

There's a closed pull request on the void-packages repository

ranger: fix check step, adopt
https://github.com/void-linux/void-packages/pull/43796

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**