[PR PATCH] python-msp430-tools: use python3

[PR PATCH] python-msp430-tools: use python3

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1450 bytes --]

There is a new pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages msp430-tools-python3
https://github.com/void-linux/void-packages/pull/42223

python-msp430-tools: use python3
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

The readme mentions that python2 is needed for most modules, but we are slowly removing python2 packages, so I would recommend people to use a python2 venv and pip.

cc @leahneukirchen 
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/42223.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-msp430-tools-python3-42223.patch --]
[-- Type: text/x-diff, Size: 6716 bytes --]

From fc89aa6240e7172ec9f3a66f21d03af303a03742 Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sun, 12 Feb 2023 12:49:53 +0100
Subject: [PATCH 1/2] python-msp430-tools: use python3

---
 srcpkgs/python-msp430-tools                   |  1 +
 srcpkgs/python-msp430-tools/template          | 19 ---------------
 srcpkgs/python3-msp430-tools/template         | 24 +++++++++++++++++++
 .../update                                    |  0
 4 files changed, 25 insertions(+), 19 deletions(-)
 create mode 120000 srcpkgs/python-msp430-tools
 delete mode 100644 srcpkgs/python-msp430-tools/template
 create mode 100644 srcpkgs/python3-msp430-tools/template
 rename srcpkgs/{python-msp430-tools => python3-msp430-tools}/update (100%)

diff --git a/srcpkgs/python-msp430-tools b/srcpkgs/python-msp430-tools
new file mode 120000
index 000000000000..1030a1c8323c
--- /dev/null
+++ b/srcpkgs/python-msp430-tools
@@ -0,0 +1 @@
+python3-msp430-tools
\ No newline at end of file
diff --git a/srcpkgs/python-msp430-tools/template b/srcpkgs/python-msp430-tools/template
deleted file mode 100644
index d80188640dec..000000000000
--- a/srcpkgs/python-msp430-tools/template
+++ /dev/null
@@ -1,19 +0,0 @@
-# Template file for 'python-msp430-tools'
-pkgname=python-msp430-tools
-version=0.9.2
-revision=2
-build_style=python2-module
-pycompile_module="msp430"
-hostmakedepends="python-setuptools"
-depends="python-pyserial"
-short_desc="Collection of tools related to the MSP430 embedded processor"
-maintainer="Leah Neukirchen <leah@vuxu.org>"
-license="BSD-3-Clause"
-homepage="https://pypi.org/project/python-msp430-tools/"
-distfiles="${PYPI_SITE}/p/${pkgname}/${pkgname}-${version}.tar.gz"
-checksum=544de0c333a4e58a9f5585454a515c6f6159547a5e9a6103cc1e1f064d8323d8
-
-post_install() {
-	vlicense LICENSE.txt LICENSE
-	rm ${DESTDIR}/usr/bin/msp430-downloader   # needs EasyDialogs
-}
diff --git a/srcpkgs/python3-msp430-tools/template b/srcpkgs/python3-msp430-tools/template
new file mode 100644
index 000000000000..281dfadf591f
--- /dev/null
+++ b/srcpkgs/python3-msp430-tools/template
@@ -0,0 +1,24 @@
+# Template file for 'python3-msp430-tools'
+pkgname=python3-msp430-tools
+version=0.9.2
+revision=3
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="python3-pyserial"
+short_desc="Collection of tools related to the MSP430 embedded processor"
+maintainer="Leah Neukirchen <leah@vuxu.org>"
+license="BSD-3-Clause"
+homepage="https://pypi.org/project/python-msp430-tools/"
+distfiles="${PYPI_SITE}/p/python-msp430-tools/python-msp430-tools-${version}.tar.gz"
+checksum=544de0c333a4e58a9f5585454a515c6f6159547a5e9a6103cc1e1f064d8323d8
+
+post_install() {
+	vlicense LICENSE.txt LICENSE
+	rm ${DESTDIR}/usr/bin/msp430-downloader   # needs EasyDialogs
+}
+
+python-msp430-tools_package() {
+	depends="${sourcepkg}>=${version}_${revision}"
+	short_desc+=" - transitional dummy package"
+	build_style=meta
+}
diff --git a/srcpkgs/python-msp430-tools/update b/srcpkgs/python3-msp430-tools/update
similarity index 100%
rename from srcpkgs/python-msp430-tools/update
rename to srcpkgs/python3-msp430-tools/update

From 07259f934f8de1221e409147660d9abd619484e8 Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sun, 12 Feb 2023 12:52:39 +0100
Subject: [PATCH 2/2] python-pyserial: remove package

python2, not used by any other packages anymore
---
 srcpkgs/python-pyserial/template              | 31 -------------------
 srcpkgs/python3-pyserial                      |  1 -
 srcpkgs/python3-pyserial/template             | 17 ++++++++++
 .../update                                    |  0
 srcpkgs/removed-packages/template             |  1 +
 5 files changed, 18 insertions(+), 32 deletions(-)
 delete mode 100644 srcpkgs/python-pyserial/template
 delete mode 120000 srcpkgs/python3-pyserial
 create mode 100644 srcpkgs/python3-pyserial/template
 rename srcpkgs/{python-pyserial => python3-pyserial}/update (100%)

diff --git a/srcpkgs/python-pyserial/template b/srcpkgs/python-pyserial/template
deleted file mode 100644
index 235ad01c9cdb..000000000000
--- a/srcpkgs/python-pyserial/template
+++ /dev/null
@@ -1,31 +0,0 @@
-# Template file for 'python-pyserial'
-pkgname=python-pyserial
-version=3.4
-revision=7
-build_style=python-module
-hostmakedepends="python-setuptools python3-setuptools"
-depends="python"
-pycompile_module="serial"
-short_desc="Python2 module providing access for the serial port"
-maintainer="Orphaned <orphan@voidlinux.org>"
-homepage="https://github.com/pyserial/pyserial"
-license="3-clause-BSD"
-distfiles="${PYPI_SITE}/p/pyserial/pyserial-${version}.tar.gz"
-checksum=6e2d401fdee0eab996cf734e67773a0143b932772ca8b42451440cfed942c627
-alternatives="pyserial:miniterm:/usr/bin/miniterm.py2"
-
-post_install() {
-	vlicense LICENSE.txt LICENSE
-}
-
-python3-pyserial_package() {
-	depends="python3"
-	pycompile_module="serial"
-	short_desc="${short_desc/Python2/Python3}"
-	alternatives="pyserial:miniterm:/usr/bin/miniterm.py3"
-	pkg_install() {
-		vmove usr/bin/miniterm.py3
-		vmove usr/lib/python3*
-		vlicense LICENSE.txt LICENSE
-	}
-}
diff --git a/srcpkgs/python3-pyserial b/srcpkgs/python3-pyserial
deleted file mode 120000
index b32b82bb9660..000000000000
--- a/srcpkgs/python3-pyserial
+++ /dev/null
@@ -1 +0,0 @@
-python-pyserial
\ No newline at end of file
diff --git a/srcpkgs/python3-pyserial/template b/srcpkgs/python3-pyserial/template
new file mode 100644
index 000000000000..131d91d0aef1
--- /dev/null
+++ b/srcpkgs/python3-pyserial/template
@@ -0,0 +1,17 @@
+# Template file for 'python3-pyserial'
+pkgname=python3-pyserial
+version=3.4
+revision=8
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="python3"
+short_desc="Python module providing access for the serial port"
+maintainer="Orphaned <orphan@voidlinux.org>"
+homepage="https://github.com/pyserial/pyserial"
+license="BSD-3-Clause"
+distfiles="${PYPI_SITE}/p/pyserial/pyserial-${version}.tar.gz"
+checksum=6e2d401fdee0eab996cf734e67773a0143b932772ca8b42451440cfed942c627
+
+post_install() {
+	vlicense LICENSE.txt LICENSE
+}
diff --git a/srcpkgs/python-pyserial/update b/srcpkgs/python3-pyserial/update
similarity index 100%
rename from srcpkgs/python-pyserial/update
rename to srcpkgs/python3-pyserial/update
diff --git a/srcpkgs/removed-packages/template b/srcpkgs/removed-packages/template
index ef781a412eb8..2b465f8719f5 100644
--- a/srcpkgs/removed-packages/template
+++ b/srcpkgs/removed-packages/template
@@ -414,6 +414,7 @@ replaces="
  python-pydns<=2.3.6_4
  python-pyenet<=1.3.13.post7_2
  python-pyglet<=1.4.10_4
+ python-pyserial<=3.4_7
  python-pyside<=1.2.2_7
  python-pystache<=0.5.4_6
  python-pytest-relaxed<=1.1.2_2

Re: python-msp430-tools: use python3

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 209 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/42223#issuecomment-1427054286

Comment:
sgtm, I can't test it as I don't work with MSP430 currently.

Re: python-msp430-tools: use python3

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/42223#issuecomment-1546787145

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: python-msp430-tools: use python3

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 164 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/42223#issuecomment-1547915215

Comment:
Can you rebase?

Re: [PR PATCH] [Updated] python-msp430-tools: use python3

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 1460 bytes --]

There is an updated pull request by classabbyamp against master on the void-packages repository

https://github.com/paper42/void-packages msp430-tools-python3
https://github.com/void-linux/void-packages/pull/42223

python-msp430-tools: use python3
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

The readme mentions that python2 is needed for most modules, but we are slowly removing python2 packages, so I would recommend people to use a python2 venv and pip.

cc @leahneukirchen 
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/42223.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-msp430-tools-python3-42223.patch --]
[-- Type: text/x-diff, Size: 5424 bytes --]

From 7af91ffdc09b5b8920e1c36b9d3e8970edd32816 Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sun, 12 Feb 2023 12:49:53 +0100
Subject: [PATCH 1/2] python-msp430-tools: use python3

---
 srcpkgs/python-msp430-tools                   |  1 +
 srcpkgs/python-msp430-tools/template          | 19 ---------------
 srcpkgs/python3-msp430-tools/template         | 24 +++++++++++++++++++
 .../update                                    |  0
 4 files changed, 25 insertions(+), 19 deletions(-)
 create mode 120000 srcpkgs/python-msp430-tools
 delete mode 100644 srcpkgs/python-msp430-tools/template
 create mode 100644 srcpkgs/python3-msp430-tools/template
 rename srcpkgs/{python-msp430-tools => python3-msp430-tools}/update (100%)

diff --git a/srcpkgs/python-msp430-tools b/srcpkgs/python-msp430-tools
new file mode 120000
index 0000000000000..1030a1c8323cd
--- /dev/null
+++ b/srcpkgs/python-msp430-tools
@@ -0,0 +1 @@
+python3-msp430-tools
\ No newline at end of file
diff --git a/srcpkgs/python-msp430-tools/template b/srcpkgs/python-msp430-tools/template
deleted file mode 100644
index d80188640dec9..0000000000000
--- a/srcpkgs/python-msp430-tools/template
+++ /dev/null
@@ -1,19 +0,0 @@
-# Template file for 'python-msp430-tools'
-pkgname=python-msp430-tools
-version=0.9.2
-revision=2
-build_style=python2-module
-pycompile_module="msp430"
-hostmakedepends="python-setuptools"
-depends="python-pyserial"
-short_desc="Collection of tools related to the MSP430 embedded processor"
-maintainer="Leah Neukirchen <leah@vuxu.org>"
-license="BSD-3-Clause"
-homepage="https://pypi.org/project/python-msp430-tools/"
-distfiles="${PYPI_SITE}/p/${pkgname}/${pkgname}-${version}.tar.gz"
-checksum=544de0c333a4e58a9f5585454a515c6f6159547a5e9a6103cc1e1f064d8323d8
-
-post_install() {
-	vlicense LICENSE.txt LICENSE
-	rm ${DESTDIR}/usr/bin/msp430-downloader   # needs EasyDialogs
-}
diff --git a/srcpkgs/python3-msp430-tools/template b/srcpkgs/python3-msp430-tools/template
new file mode 100644
index 0000000000000..281dfadf591f5
--- /dev/null
+++ b/srcpkgs/python3-msp430-tools/template
@@ -0,0 +1,24 @@
+# Template file for 'python3-msp430-tools'
+pkgname=python3-msp430-tools
+version=0.9.2
+revision=3
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="python3-pyserial"
+short_desc="Collection of tools related to the MSP430 embedded processor"
+maintainer="Leah Neukirchen <leah@vuxu.org>"
+license="BSD-3-Clause"
+homepage="https://pypi.org/project/python-msp430-tools/"
+distfiles="${PYPI_SITE}/p/python-msp430-tools/python-msp430-tools-${version}.tar.gz"
+checksum=544de0c333a4e58a9f5585454a515c6f6159547a5e9a6103cc1e1f064d8323d8
+
+post_install() {
+	vlicense LICENSE.txt LICENSE
+	rm ${DESTDIR}/usr/bin/msp430-downloader   # needs EasyDialogs
+}
+
+python-msp430-tools_package() {
+	depends="${sourcepkg}>=${version}_${revision}"
+	short_desc+=" - transitional dummy package"
+	build_style=meta
+}
diff --git a/srcpkgs/python-msp430-tools/update b/srcpkgs/python3-msp430-tools/update
similarity index 100%
rename from srcpkgs/python-msp430-tools/update
rename to srcpkgs/python3-msp430-tools/update

From 592b62a7d40a17ca3d188caaa50a69f98573f7e7 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Sun, 13 Aug 2023 11:05:51 -0400
Subject: [PATCH 2/2] python-pyserial: remove package

python2, not used by any other packages anymore
---
 srcpkgs/python-pyserial/template  | 19 -------------------
 srcpkgs/python-pyserial/update    |  1 -
 srcpkgs/removed-packages/template |  3 ++-
 3 files changed, 2 insertions(+), 21 deletions(-)
 delete mode 100644 srcpkgs/python-pyserial/template
 delete mode 100644 srcpkgs/python-pyserial/update

diff --git a/srcpkgs/python-pyserial/template b/srcpkgs/python-pyserial/template
deleted file mode 100644
index 198d118b255c9..0000000000000
--- a/srcpkgs/python-pyserial/template
+++ /dev/null
@@ -1,19 +0,0 @@
-# Template file for 'python-pyserial'
-pkgname=python-pyserial
-version=3.4
-revision=7
-build_style=python2-module
-hostmakedepends="python-setuptools"
-depends="python"
-short_desc="Python2 module providing access for the serial port"
-maintainer="Orphaned <orphan@voidlinux.org>"
-license="BSD-3-Clause"
-homepage="https://github.com/pyserial/pyserial"
-distfiles="${PYPI_SITE}/p/pyserial/pyserial-${version}.tar.gz"
-checksum=6e2d401fdee0eab996cf734e67773a0143b932772ca8b42451440cfed942c627
-alternatives="pyserial:miniterm:/usr/bin/miniterm.py2"
-
-post_install() {
-	mv ${DESTDIR}/usr/bin/miniterm.py{,2}
-	vlicense LICENSE.txt LICENSE
-}
diff --git a/srcpkgs/python-pyserial/update b/srcpkgs/python-pyserial/update
deleted file mode 100644
index 5731a163e9c7b..0000000000000
--- a/srcpkgs/python-pyserial/update
+++ /dev/null
@@ -1 +0,0 @@
-ignore="*b[0-9]"
diff --git a/srcpkgs/removed-packages/template b/srcpkgs/removed-packages/template
index 7db7cb21e1057..1008ec2d8fa6d 100644
--- a/srcpkgs/removed-packages/template
+++ b/srcpkgs/removed-packages/template
@@ -1,6 +1,6 @@
 # Template file for 'removed-packages'
 pkgname=removed-packages
-version=0.1.20230805
+version=0.1.20230813
 revision=1
 build_style=meta
 short_desc="Uninstalls packages removed from repository"
@@ -492,6 +492,7 @@ replaces="
  python-pydns<=2.3.6_4
  python-pyenet<=1.3.13.post7_2
  python-pyglet<=1.4.10_4
+ python-pyserial<=3.4_7
  python-pyside<=1.2.2_7
  python-pystache<=0.5.4_6
  python-pytest-relaxed<=1.1.2_2

Re: python-msp430-tools: use python3

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 342 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42223#issuecomment-1676391605

Comment:
I think it might be better to just recommend using a py2 venv + pip2 for msp430-tools too. upstream has done 1 commit in the past 5 years, no indication of them moving most of the package to py3.

Re: [PR PATCH] [Closed]: python-msp430-tools: use python3

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 1286 bytes --]

There's a closed pull request on the void-packages repository

python-msp430-tools: use python3
https://github.com/void-linux/void-packages/pull/42223

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

The readme mentions that python2 is needed for most modules, but we are slowly removing python2 packages, so I would recommend people to use a python2 venv and pip.

cc @leahneukirchen 
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->