[PR PATCH] element-desktop: Updated launch script with electron24

[PR PATCH] element-desktop: Updated launch script with electron24

[fccapria]

[-- Attachment #1: Type: text/plain, Size: 518 bytes --]

There is a new pull request by fccapria against master on the void-packages repository

https://github.com/fccapria/void-packages element-desktop-rev
https://github.com/void-linux/void-packages/pull/43885

element-desktop: Updated launch script with electron24
#### Testing the changes
- I tested the changes in this PR: **YES**
- 
#### Local build testing
- I built this PR locally for my native architecture, (x64-glibc)

A patch file from https://github.com/void-linux/void-packages/pull/43885.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-element-desktop-rev-43885.patch --]
[-- Type: text/x-diff, Size: 1230 bytes --]

From 4b25bb5c6fd308e02225861e933e250942d7773f Mon Sep 17 00:00:00 2001
From: Francesco Carmelo Capria <francesco@capria.eu>
Date: Mon, 15 May 2023 18:02:34 +0200
Subject: [PATCH] element-desktop: Edited launch script

---
 srcpkgs/element-desktop/files/element-desktop | 2 +-
 srcpkgs/element-desktop/template              | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/element-desktop/files/element-desktop b/srcpkgs/element-desktop/files/element-desktop
index 6b1e335e3d46..c2c6d1a0256b 100644
--- a/srcpkgs/element-desktop/files/element-desktop
+++ b/srcpkgs/element-desktop/files/element-desktop
@@ -1,2 +1,2 @@
 #!/bin/sh
-exec electron19 /usr/lib/element-desktop/resources/app.asar "$@"
+exec electron24 /usr/lib/element-desktop/resources/app.asar "$@"
diff --git a/srcpkgs/element-desktop/template b/srcpkgs/element-desktop/template
index 864caebdeccb..38a384f70a35 100644
--- a/srcpkgs/element-desktop/template
+++ b/srcpkgs/element-desktop/template
@@ -1,7 +1,7 @@
 # Template file for 'element-desktop'
 pkgname=element-desktop
 version=1.11.31
-revision=1
+revision=2
 create_wrksrc=yes
 conf_files="/etc/${pkgname}/config.json"
 hostmakedepends="git yarn nodejs rust cargo python3 curl

Re: element-desktop: Updated launch script with electron24

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 216 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/43885#issuecomment-1548376941

Comment:
can you make the commit message more descriptive (like the PR title)?

Re: element-desktop: Updated launch script with electron24

[fccapria]

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

New comment by fccapria on void-packages repository

https://github.com/void-linux/void-packages/pull/43885#issuecomment-1548380247

Comment:
> can you make the commit message more descriptive (like the PR title)?

Of course.

Re: element-desktop: Updated launch script with electron24

[fccapria]

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]

New comment by fccapria on void-packages repository

https://github.com/void-linux/void-packages/pull/43885#issuecomment-1548473593

Comment:
@classabbyamp I don't understand why it's taking so long..
It seems that it's building electron24 (24.3) when in the repos electron24 is at version 24.2.
Why is it doing this?

Re: element-desktop: Updated launch script with electron24

[fccapria]

[-- Attachment #1: Type: text/plain, Size: 433 bytes --]

New comment by fccapria on void-packages repository

https://github.com/void-linux/void-packages/pull/43885#issuecomment-1548473593

Comment:
@classabbyamp I don't understand why it's taking so long..
It seems that it's building electron24 (24.3) when in the repos electron24 is at version 24.2.
Why is it doing this?

Maybe because the template in void-packages has been updated to 24.3 but it's not available in the repos yet?

Re: element-desktop: Updated launch script with electron24

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/43885#issuecomment-1548482481

Comment:
correct, it's [still being built](https://build.voidlinux.org/waterfall)

Re: element-desktop: Updated launch script with electron24

[fccapria]

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

New comment by fccapria on void-packages repository

https://github.com/void-linux/void-packages/pull/43885#issuecomment-1549441264

Comment:
Oh wow.
I see it's been built, can you restart the checks?

Re: [PR PATCH] [Merged]: element-desktop: Updated launch script with electron24

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 639 bytes --]

There's a merged pull request on the void-packages repository

element-desktop: Updated launch script with electron24
https://github.com/void-linux/void-packages/pull/43885

Description:
This PR is for editing the Element startup script:
in the PR I did to update Element (to version 1.11.31 - #43861) I changed the Electron dependencies from version 19 to 24, without updating the startup script with the relevant new version of Electron.
This PR is to fix this error.

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x64-glibc)