Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] python3-flit_core: clean up bootstrapping
@ 2023-05-19 19:42 icp1994
  2023-05-19 20:10 ` ahesford
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: icp1994 @ 2023-05-19 19:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 608 bytes --]

There is a new pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages python3-flit_core
https://github.com/void-linux/void-packages/pull/43948

python3-flit_core: clean up bootstrapping
#### Testing the changes
- I tested the changes in this PR: **briefly**

@ahesford I found [this doc page](https://flit.pypa.io/en/stable/bootstrap.html) yesterday. I thought it might be beneficial to include in this package. Is it something you want for this template?

A patch file from https://github.com/void-linux/void-packages/pull/43948.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-flit_core-43948.patch --]
[-- Type: text/x-diff, Size: 2285 bytes --]

From 5d27ae35048d01704097db6764a0a9500581f65a Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Fri, 19 May 2023 01:37:37 +0530
Subject: [PATCH] python3-flit_core: clean up bootstrapping

---
 srcpkgs/python3-flit_core/template | 28 ++++++++++------------------
 1 file changed, 10 insertions(+), 18 deletions(-)

diff --git a/srcpkgs/python3-flit_core/template b/srcpkgs/python3-flit_core/template
index 0165c5096c1f..839bd40fcb70 100644
--- a/srcpkgs/python3-flit_core/template
+++ b/srcpkgs/python3-flit_core/template
@@ -2,38 +2,30 @@
 pkgname=python3-flit_core
 version=3.9.0
 revision=1
-build_wrksrc="flit-${version}/flit_core"
 # This package is required by python3-build and python3-installer, used by the
 # python3-pep517 style; so using that style here would create a cycle
-build_style=python3-module
 hostmakedepends="python3"
 depends="python3"
 checkdepends="python3-pytest python3-testpath $depends"
 short_desc="Simplified packaging of Python modules - PEP 517 build backend"
 maintainer="Andrew J. Hesford <ajh@sideband.org>"
 license="BSD-3-Clause"
-homepage="https://flit.readthedocs.io"
-changelog="https://flit.readthedocs.io/en/latest/history.html"
-# Pull the installer package directly to bootstrap the pep517 toolchain
-_installer_version="0.5.1"
-distfiles="${PYPI_SITE}/f/flit/flit-${version}.tar.gz
- ${PYPI_SITE}/i/installer/installer-${_installer_version}.tar.gz
-"
-checksum="d75edf5eb324da20d53570a6a6f87f51e606eee8384925cd66a90611140844c7
- f970995ec2bb815e2fdaf7977b26b2091e1e386f0f42eafd5ac811953dc5d445"
+homepage="https://flit.pypa.io/"
+changelog="https://flit.pypa.io/en/stable/history.html"
+distfiles="${PYPI_SITE}/f/flit_core/flit_core-${version}.tar.gz"
+checksum=72ad266176c4a3fcfab5f2930d76896059851240570ce9a98733b658cb786eba
 
 do_build() {
 	python3 -m flit_core.wheel
 }
 
-do_install() {
-	local pypath="../../installer-${_installer_version}/src"
-	if [ -n "${PYTHONPATH}" ]; then
-		pypath="${pypath}:${PYTHONPATH}"
-	fi
+do_check() {
+	python3 -m pytest flit_core/tests
+}
 
-	PYTHONPATH="${pypath}" python3 -m installer --destdir "${DESTDIR}" \
+do_install() {
+	python3 bootstrap_install.py --install-root "${DESTDIR}" \
 		"dist/flit_core-${version}-py3-none-any.whl"
 
-	vlicense ../LICENSE
+	vlicense LICENSE
 }

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: python3-flit_core: clean up bootstrapping
  2023-05-19 19:42 [PR PATCH] python3-flit_core: clean up bootstrapping icp1994
@ 2023-05-19 20:10 ` ahesford
  2023-05-19 20:14 ` [PR PATCH] [Updated] " icp1994
  2023-05-19 20:37 ` [PR PATCH] [Merged]: " ahesford
  2 siblings, 0 replies; 4+ messages in thread
From: ahesford @ 2023-05-19 20:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 254 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/43948#issuecomment-1555181527

Comment:
Thanks, this is a nice improvement. Please revbump because we are changing the sdist used to build the package.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Updated] python3-flit_core: clean up bootstrapping
  2023-05-19 19:42 [PR PATCH] python3-flit_core: clean up bootstrapping icp1994
  2023-05-19 20:10 ` ahesford
@ 2023-05-19 20:14 ` icp1994
  2023-05-19 20:37 ` [PR PATCH] [Merged]: " ahesford
  2 siblings, 0 replies; 4+ messages in thread
From: icp1994 @ 2023-05-19 20:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 613 bytes --]

There is an updated pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages python3-flit_core
https://github.com/void-linux/void-packages/pull/43948

python3-flit_core: clean up bootstrapping
#### Testing the changes
- I tested the changes in this PR: **briefly**

@ahesford I found [this doc page](https://flit.pypa.io/en/stable/bootstrap.html) yesterday. I thought it might be beneficial to include in this package. Is it something you want for this template?

A patch file from https://github.com/void-linux/void-packages/pull/43948.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-flit_core-43948.patch --]
[-- Type: text/x-diff, Size: 2340 bytes --]

From f9a0b97f5610c8866d6cea4310fca5c9de252b21 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Fri, 19 May 2023 01:37:37 +0530
Subject: [PATCH] python3-flit_core: clean up bootstrapping

---
 srcpkgs/python3-flit_core/template | 30 +++++++++++-------------------
 1 file changed, 11 insertions(+), 19 deletions(-)

diff --git a/srcpkgs/python3-flit_core/template b/srcpkgs/python3-flit_core/template
index 0165c5096c1f..36ea6cbf3abc 100644
--- a/srcpkgs/python3-flit_core/template
+++ b/srcpkgs/python3-flit_core/template
@@ -1,39 +1,31 @@
 # Template file for 'python3-flit_core'
 pkgname=python3-flit_core
 version=3.9.0
-revision=1
-build_wrksrc="flit-${version}/flit_core"
+revision=2
 # This package is required by python3-build and python3-installer, used by the
 # python3-pep517 style; so using that style here would create a cycle
-build_style=python3-module
 hostmakedepends="python3"
 depends="python3"
 checkdepends="python3-pytest python3-testpath $depends"
 short_desc="Simplified packaging of Python modules - PEP 517 build backend"
 maintainer="Andrew J. Hesford <ajh@sideband.org>"
 license="BSD-3-Clause"
-homepage="https://flit.readthedocs.io"
-changelog="https://flit.readthedocs.io/en/latest/history.html"
-# Pull the installer package directly to bootstrap the pep517 toolchain
-_installer_version="0.5.1"
-distfiles="${PYPI_SITE}/f/flit/flit-${version}.tar.gz
- ${PYPI_SITE}/i/installer/installer-${_installer_version}.tar.gz
-"
-checksum="d75edf5eb324da20d53570a6a6f87f51e606eee8384925cd66a90611140844c7
- f970995ec2bb815e2fdaf7977b26b2091e1e386f0f42eafd5ac811953dc5d445"
+homepage="https://flit.pypa.io/"
+changelog="https://flit.pypa.io/en/stable/history.html"
+distfiles="${PYPI_SITE}/f/flit_core/flit_core-${version}.tar.gz"
+checksum=72ad266176c4a3fcfab5f2930d76896059851240570ce9a98733b658cb786eba
 
 do_build() {
 	python3 -m flit_core.wheel
 }
 
-do_install() {
-	local pypath="../../installer-${_installer_version}/src"
-	if [ -n "${PYTHONPATH}" ]; then
-		pypath="${pypath}:${PYTHONPATH}"
-	fi
+do_check() {
+	python3 -m pytest flit_core/tests
+}
 
-	PYTHONPATH="${pypath}" python3 -m installer --destdir "${DESTDIR}" \
+do_install() {
+	python3 bootstrap_install.py --install-root "${DESTDIR}" \
 		"dist/flit_core-${version}-py3-none-any.whl"
 
-	vlicense ../LICENSE
+	vlicense LICENSE
 }

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Merged]: python3-flit_core: clean up bootstrapping
  2023-05-19 19:42 [PR PATCH] python3-flit_core: clean up bootstrapping icp1994
  2023-05-19 20:10 ` ahesford
  2023-05-19 20:14 ` [PR PATCH] [Updated] " icp1994
@ 2023-05-19 20:37 ` ahesford
  2 siblings, 0 replies; 4+ messages in thread
From: ahesford @ 2023-05-19 20:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 447 bytes --]

There's a merged pull request on the void-packages repository

python3-flit_core: clean up bootstrapping
https://github.com/void-linux/void-packages/pull/43948

Description:
#### Testing the changes
- I tested the changes in this PR: **briefly**

@ahesford I found [this doc page](https://flit.pypa.io/en/stable/bootstrap.html) yesterday. I thought it might be beneficial to include in this package. Is it something you want for this template?

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-05-19 20:37 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-19 19:42 [PR PATCH] python3-flit_core: clean up bootstrapping icp1994
2023-05-19 20:10 ` ahesford
2023-05-19 20:14 ` [PR PATCH] [Updated] " icp1994
2023-05-19 20:37 ` [PR PATCH] [Merged]: " ahesford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).