[PR PATCH] New package: a4-0.2.1

[PR PATCH] New package: a4-0.2.1

[littlewing7]

[-- Attachment #1: Type: text/plain, Size: 1263 bytes --]

There is a new pull request by littlewing7 against master on the void-packages repository

https://github.com/littlewing7/void-packages a4-terminal.0.2.1
https://github.com/void-linux/void-packages/pull/43734

New package: a4-0.2.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv7l-musl
  - armv6l-musl



A patch file from https://github.com/void-linux/void-packages/pull/43734.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-a4-terminal.0.2.1-43734.patch --]
[-- Type: text/x-diff, Size: 1458 bytes --]

From 26fd975823f7e05403a757782a1eb419e38b40d0 Mon Sep 17 00:00:00 2001
From: Massimo Manzato <massimo.manzato@gmail.com>
Date: Wed, 3 May 2023 23:37:38 +0200
Subject: [PATCH] New package: a4-0.2.1

---
 srcpkgs/a4/template | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)
 create mode 100644 srcpkgs/a4/template

diff --git a/srcpkgs/a4/template b/srcpkgs/a4/template
new file mode 100644
index 000000000000..2bc75157b210
--- /dev/null
+++ b/srcpkgs/a4/template
@@ -0,0 +1,34 @@
+# Template file for 'a4'
+pkgname=a4
+version=0.2.1
+revision=1
+#archs="i686 x86_64"
+#build_wrksrc=
+build_style=gnu-makefile
+#configure_args=""
+#make_build_args=""
+#make_install_args=""
+#conf_files=""
+#make_dirs="/var/log/dir 0755 root root"
+hostmakedepends="libtool pkg-config"
+makedepends="libvterm-devel libtickit-devel"
+depends="libvterm>=0.3.1 libtickit>=0.4.3"
+short_desc="A4 is a dynamic terminal window manager, partial rewrite of dvtm"
+maintainer="Massimo Manzato <massimo.manzato@gmail.com>"
+license="MIT"
+homepage="https://a4term.com/"
+#changelog=""
+distfiles="https://github.com/rpmohn/a4/archive/v${version}.tar.gz"
+checksum=52e16e58ac52b9157933a3fd1063bc79e8dfa2f72ea2b4f03e77327bbec2c59e
+
+post_extract() {
+	if [ "$CROSS_BUILD" ]; then
+		cp /usr/bin/libtool .
+		sed -e "s,CCLD=.*,CCLD=$CC,g;s,CC=.*,CC=$CC,g" -i libtool
+		sed -e "s,libtool,./libtool,g" -i Makefile
+	fi
+}
+
+post_install() {
+	vlicense LICENSE
+}

Re: [PR REVIEW] New package: a4-0.2.1

[abenson]

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/43734#discussion_r1184941535

Comment:
Remove the commented lines.

Re: [PR PATCH] [Updated] New package: a4-0.2.1

[littlewing7]

[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]

There is an updated pull request by littlewing7 against master on the void-packages repository

https://github.com/littlewing7/void-packages a4-terminal.0.2.1
https://github.com/void-linux/void-packages/pull/43734

New package: a4-0.2.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv7l-musl
  - armv6l-musl



A patch file from https://github.com/void-linux/void-packages/pull/43734.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-a4-terminal.0.2.1-43734.patch --]
[-- Type: text/x-diff, Size: 1315 bytes --]

From d3670dcb0580233bc2417eddb181cbf91dec8547 Mon Sep 17 00:00:00 2001
From: Massimo Manzato <massimo.manzato@gmail.com>
Date: Wed, 3 May 2023 23:37:38 +0200
Subject: [PATCH] New package: a4-0.2.1

---
 srcpkgs/a4/template | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 srcpkgs/a4/template

diff --git a/srcpkgs/a4/template b/srcpkgs/a4/template
new file mode 100644
index 000000000000..7cd799e11dde
--- /dev/null
+++ b/srcpkgs/a4/template
@@ -0,0 +1,28 @@
+# Template file for 'a4'
+pkgname=a4
+version=0.2.1
+revision=1
+#archs="i686 x86_64"
+#build_wrksrc=
+build_style=gnu-makefile
+hostmakedepends="libtool pkg-config"
+makedepends="libvterm-devel libtickit-devel"
+depends="libvterm>=0.3.1 libtickit>=0.4.3"
+short_desc="A4 is a dynamic terminal window manager, partial rewrite of dvtm"
+maintainer="Massimo Manzato <massimo.manzato@gmail.com>"
+license="MIT"
+homepage="https://a4term.com/"
+distfiles="https://github.com/rpmohn/a4/archive/v${version}.tar.gz"
+checksum=52e16e58ac52b9157933a3fd1063bc79e8dfa2f72ea2b4f03e77327bbec2c59e
+
+post_extract() {
+	if [ "$CROSS_BUILD" ]; then
+		cp /usr/bin/libtool .
+		sed -e "s,CCLD=.*,CCLD=$CC,g;s,CC=.*,CC=$CC,g" -i libtool
+		sed -e "s,libtool,./libtool,g" -i Makefile
+	fi
+}
+
+post_install() {
+	vlicense LICENSE
+}

Re: [PR REVIEW] New package: a4-0.2.1

[littlewing7]

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

New review comment by littlewing7 on void-packages repository

https://github.com/void-linux/void-packages/pull/43734#discussion_r1185414184

Comment:
I apologize, I'm new to this tasks! 

Commended lines removed!

Many thanks

Max

Re: [PR PATCH] [Updated] New package: a4-0.2.1

[littlewing7]

[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]

There is an updated pull request by littlewing7 against master on the void-packages repository

https://github.com/littlewing7/void-packages a4-terminal.0.2.1
https://github.com/void-linux/void-packages/pull/43734

New package: a4-0.2.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv7l-musl
  - armv6l-musl



A patch file from https://github.com/void-linux/void-packages/pull/43734.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-a4-terminal.0.2.1-43734.patch --]
[-- Type: text/x-diff, Size: 1275 bytes --]

From fa33a87578684ab47a9e0b6b117ec3838b658949 Mon Sep 17 00:00:00 2001
From: Massimo Manzato <massimo.manzato@gmail.com>
Date: Wed, 3 May 2023 23:37:38 +0200
Subject: [PATCH] New package: a4-0.2.1

---
 srcpkgs/a4/template | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 srcpkgs/a4/template

diff --git a/srcpkgs/a4/template b/srcpkgs/a4/template
new file mode 100644
index 000000000000..9ecdfc5f354b
--- /dev/null
+++ b/srcpkgs/a4/template
@@ -0,0 +1,26 @@
+# Template file for 'a4'
+pkgname=a4
+version=0.2.1
+revision=1
+build_style=gnu-makefile
+hostmakedepends="libtool pkg-config"
+makedepends="libvterm-devel libtickit-devel"
+depends="libvterm>=0.3.1 libtickit>=0.4.3"
+short_desc="A4 is a dynamic terminal window manager, partial rewrite of dvtm"
+maintainer="Massimo Manzato <massimo.manzato@gmail.com>"
+license="MIT"
+homepage="https://a4term.com/"
+distfiles="https://github.com/rpmohn/a4/archive/v${version}.tar.gz"
+checksum=52e16e58ac52b9157933a3fd1063bc79e8dfa2f72ea2b4f03e77327bbec2c59e
+
+post_extract() {
+	if [ "$CROSS_BUILD" ]; then
+		cp /usr/bin/libtool .
+		sed -e "s,CCLD=.*,CCLD=$CC,g;s,CC=.*,CC=$CC,g" -i libtool
+		sed -e "s,libtool,./libtool,g" -i Makefile
+	fi
+}
+
+post_install() {
+	vlicense LICENSE
+}

Re: New package: a4-0.2.1

[littlewing7]

[-- Attachment #1: Type: text/plain, Size: 278 bytes --]

New comment by littlewing7 on void-packages repository

https://github.com/void-linux/void-packages/pull/43734#issuecomment-1538018960

Comment:
 I apologize, for some reasons I don't remove all the commented lines. 

now should be ok! 

many thanks for you patience!!
Max

Re: [PR REVIEW] New package: a4-0.2.1

[littlewing7]

[-- Attachment #1: Type: text/plain, Size: 245 bytes --]

New review comment by littlewing7 on void-packages repository

https://github.com/void-linux/void-packages/pull/43734#discussion_r1187913291

Comment:
I think to have cleaned correctly the template, can you please confirm_ 

many thanks 
Max

Re: New package: a4-0.2.1

[littlewing7]

[-- Attachment #1: Type: text/plain, Size: 336 bytes --]

New comment by littlewing7 on void-packages repository

https://github.com/void-linux/void-packages/pull/43734#issuecomment-1555164841

Comment:
Hi Guys, 

this package doesn't break any other packages. 
There are any particular reason preventing this package to be merged?
Can I help ?

Many thanks for your kindly reply.

Max

Re: [PR REVIEW] New package: a4-0.2.1

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 211 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/43734#discussion_r1199475272

Comment:
Is it really required to manually define minimum versions here?

Re: [PR REVIEW] New package: a4-0.2.1

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/43734#discussion_r1199475622

Comment:
This looks kinda wrong, why is this required?

Re: [PR REVIEW] New package: a4-0.2.1

[littlewing7]

[-- Attachment #1: Type: text/plain, Size: 754 bytes --]

New review comment by littlewing7 on void-packages repository

https://github.com/void-linux/void-packages/pull/43734#discussion_r1199565612

Comment:
Hi Duncan, 

many thanks for your reply, regarding this i'm not sure if this is necessary inside the template, but it is a requirements of the original software: https://github.com/rpmohn/a4 (inside the readme I found  this requirements). 

before submitting this new package I already update the void templates for this required packages with this PRs: 
(https://github.com/void-linux/void-packages/pull/43532)
(https://github.com/void-linux/void-packages/pull/43658)

So i'm not sure if the line you mention now in this template is needed or not, please help me to understand

Many thanks

Re: [PR PATCH] [Updated] New package: a4-0.2.1

[littlewing7]

[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]

There is an updated pull request by littlewing7 against master on the void-packages repository

https://github.com/littlewing7/void-packages a4-terminal.0.2.1
https://github.com/void-linux/void-packages/pull/43734

New package: a4-0.2.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv7l-musl
  - armv6l-musl



A patch file from https://github.com/void-linux/void-packages/pull/43734.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-a4-terminal.0.2.1-43734.patch --]
[-- Type: text/x-diff, Size: 1077 bytes --]

From fa1e17a5170922e7030d259f414e1039e9c9402d Mon Sep 17 00:00:00 2001
From: Massimo Manzato <massimo.manzato@gmail.com>
Date: Wed, 3 May 2023 23:37:38 +0200
Subject: [PATCH] New package: a4-0.2.1

---
 srcpkgs/a4/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/a4/template

diff --git a/srcpkgs/a4/template b/srcpkgs/a4/template
new file mode 100644
index 000000000000..5aae174d4fa5
--- /dev/null
+++ b/srcpkgs/a4/template
@@ -0,0 +1,18 @@
+# Template file for 'a4'
+pkgname=a4
+version=0.2.1
+revision=1
+build_style=gnu-makefile
+hostmakedepends="libtool pkg-config"
+makedepends="libvterm-devel libtickit-devel"
+depends="libvterm>=0.3.1 libtickit>=0.4.3"
+short_desc="A4 is a dynamic terminal window manager, partial rewrite of dvtm"
+maintainer="Massimo Manzato <massimo.manzato@gmail.com>"
+license="MIT"
+homepage="https://a4term.com/"
+distfiles="https://github.com/rpmohn/a4/archive/v${version}.tar.gz"
+checksum=52e16e58ac52b9157933a3fd1063bc79e8dfa2f72ea2b4f03e77327bbec2c59e
+
+post_install() {
+	vlicense LICENSE
+}

Re: [PR REVIEW] New package: a4-0.2.1

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 516 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/43734#discussion_r1199600398

Comment:
Defining `depends` manually will overwrite the default minimum version based on the shared library version. 

```
void-packages% cat common/shlibs|grep libvterm
libvterm.so.0 libvterm-0.3_1
void-packages% cat common/shlibs|grep libtickit
libtickit.so.3 libtickit-0.4.1_1
```

Just for simplicity and for future updates I prefer not to manually overwrite this.

Re: New package: a4-0.2.1

[littlewing7]

[-- Attachment #1: Type: text/plain, Size: 699 bytes --]

New comment by littlewing7 on void-packages repository

https://github.com/void-linux/void-packages/pull/43734#issuecomment-1597293841

Comment:
Hi Duncan, 

can help me how to correctly define the template to obtain the right compilation of this new package without breaking the common/shlibs, and contemporary satisfy the requirements of the original software: https://github.com/rpmohn/a4 (inside the readme I found this requirements).

before submitting this new package I already update the void templates for this required packages with this PRs:
(https://github.com/void-linux/void-packages/pull/43532)
(https://github.com/void-linux/void-packages/pull/43658)

Many thanks

Massimo

Re: [PR PATCH] [Updated] New package: a4-0.2.1

[littlewing7]

[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]

There is an updated pull request by littlewing7 against master on the void-packages repository

https://github.com/littlewing7/void-packages a4-terminal.0.2.1
https://github.com/void-linux/void-packages/pull/43734

New package: a4-0.2.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv7l-musl
  - armv6l-musl



A patch file from https://github.com/void-linux/void-packages/pull/43734.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-a4-terminal.0.2.1-43734.patch --]
[-- Type: text/x-diff, Size: 1063 bytes --]

From 8d8b9c094c2472f63ab7b6ae88f321e606be151f Mon Sep 17 00:00:00 2001
From: Massimo Manzato <massimo.manzato@gmail.com>
Date: Wed, 3 May 2023 23:37:38 +0200
Subject: [PATCH] New package: a4-0.2.1

---
 srcpkgs/a4/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/a4/template

diff --git a/srcpkgs/a4/template b/srcpkgs/a4/template
new file mode 100644
index 000000000000..5de1f61504f0
--- /dev/null
+++ b/srcpkgs/a4/template
@@ -0,0 +1,18 @@
+# Template file for 'a4'
+pkgname=a4
+version=0.2.1
+revision=1
+build_style=gnu-makefile
+hostmakedepends="libtool pkg-config"
+makedepends="libvterm-devel libtickit-devel"
+depends="libvterm libtickit"
+short_desc="A4 is a dynamic terminal window manager, partial rewrite of dvtm"
+maintainer="Massimo Manzato <massimo.manzato@gmail.com>"
+license="MIT"
+homepage="https://a4term.com/"
+distfiles="https://github.com/rpmohn/a4/archive/v${version}.tar.gz"
+checksum=52e16e58ac52b9157933a3fd1063bc79e8dfa2f72ea2b4f03e77327bbec2c59e
+
+post_install() {
+	vlicense LICENSE
+}

Re: [PR REVIEW] New package: a4-0.2.1

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 256 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/43734#discussion_r1234162421

Comment:
Those `depends` are automatically detected through the shared library check and don't need to be specified. 

Re: [PR REVIEW] New package: a4-0.2.1

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 365 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/43734#discussion_r1234162421

Comment:
Those `depends` are automatically detected through the shared library check and don't need to be specified.

Edite: see https://github.com/void-linux/void-packages/actions/runs/5313206677/jobs/9618770758#step:7:123 

Re: [PR REVIEW] New package: a4-0.2.1

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 364 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/43734#discussion_r1234162421

Comment:
Those `depends` are automatically detected through the shared library check and don't need to be specified.

Edit: see https://github.com/void-linux/void-packages/actions/runs/5313206677/jobs/9618770758#step:7:123 

Re: [PR PATCH] [Updated] New package: a4-0.2.1

[littlewing7]

[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]

There is an updated pull request by littlewing7 against master on the void-packages repository

https://github.com/littlewing7/void-packages a4-terminal.0.2.1
https://github.com/void-linux/void-packages/pull/43734

New package: a4-0.2.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv7l-musl
  - armv6l-musl



A patch file from https://github.com/void-linux/void-packages/pull/43734.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-a4-terminal.0.2.1-43734.patch --]
[-- Type: text/x-diff, Size: 993 bytes --]

From 7ac3cc644e4693b52d41726706b403a9406731c5 Mon Sep 17 00:00:00 2001
From: Massimo Manzato <massimo.manzato@gmail.com>
Date: Wed, 3 May 2023 23:37:38 +0200
Subject: [PATCH] New package: a4-0.2.1

---
 srcpkgs/a4/template | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 srcpkgs/a4/template

diff --git a/srcpkgs/a4/template b/srcpkgs/a4/template
new file mode 100644
index 000000000000..5641def46d4e
--- /dev/null
+++ b/srcpkgs/a4/template
@@ -0,0 +1,16 @@
+# Template file for 'a4'
+pkgname=a4
+version=0.2.1
+revision=1
+build_style=gnu-makefile
+makedepends="libvterm-devel libtickit-devel"
+short_desc="A4 is a dynamic terminal window manager, partial rewrite of dvtm"
+maintainer="Massimo Manzato <massimo.manzato@gmail.com>"
+license="MIT"
+homepage="https://a4term.com/"
+distfiles="https://github.com/rpmohn/a4/archive/v${version}.tar.gz"
+checksum=52e16e58ac52b9157933a3fd1063bc79e8dfa2f72ea2b4f03e77327bbec2c59e
+
+post_install() {
+	vlicense LICENSE
+}

Re: [PR REVIEW] New package: a4-0.2.1

[abenson]

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/43734#discussion_r1235330042

Comment:
```suggestion
short_desc="Dynamic terminal window manager, partial rewrite of dvtm"
```

Re: [PR PATCH] [Updated] New package: a4-0.2.1

[littlewing7]

[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]

There is an updated pull request by littlewing7 against master on the void-packages repository

https://github.com/littlewing7/void-packages a4-terminal.0.2.1
https://github.com/void-linux/void-packages/pull/43734

New package: a4-0.2.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv7l-musl
  - armv6l-musl



A patch file from https://github.com/void-linux/void-packages/pull/43734.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-a4-terminal.0.2.1-43734.patch --]
[-- Type: text/x-diff, Size: 985 bytes --]

From 0898089dd8d72b3e5368c2ba4b5f5a9c9be498b0 Mon Sep 17 00:00:00 2001
From: Massimo Manzato <massimo.manzato@gmail.com>
Date: Wed, 3 May 2023 23:37:38 +0200
Subject: [PATCH] New package: a4-0.2.1

---
 srcpkgs/a4/template | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 srcpkgs/a4/template

diff --git a/srcpkgs/a4/template b/srcpkgs/a4/template
new file mode 100644
index 000000000000..d2d9600b8659
--- /dev/null
+++ b/srcpkgs/a4/template
@@ -0,0 +1,16 @@
+# Template file for 'a4'
+pkgname=a4
+version=0.2.1
+revision=1
+build_style=gnu-makefile
+makedepends="libvterm-devel libtickit-devel"
+short_desc="Dynamic terminal window manager, partial rewrite of dvtm"
+maintainer="Massimo Manzato <massimo.manzato@gmail.com>"
+license="MIT"
+homepage="https://a4term.com/"
+distfiles="https://github.com/rpmohn/a4/archive/v${version}.tar.gz"
+checksum=52e16e58ac52b9157933a3fd1063bc79e8dfa2f72ea2b4f03e77327bbec2c59e
+
+post_install() {
+	vlicense LICENSE
+}

Re: New package: a4-0.2.1

[littlewing7]

[-- Attachment #1: Type: text/plain, Size: 246 bytes --]

New comment by littlewing7 on void-packages repository

https://github.com/void-linux/void-packages/pull/43734#issuecomment-1602346360

Comment:
Hi guys, 

1. is this template ok now ? 
2. what is needed now to be merged? 

Many thanks
Max

Re: [PR REVIEW] New package: a4-0.2.1

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 239 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/43734#discussion_r1238318735

Comment:
I would match the upstream short description:

> Dynamic terminal manager and multiplexer

Re: [PR PATCH] [Updated] New package: a4-0.2.1

[littlewing7]

[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]

There is an updated pull request by littlewing7 against master on the void-packages repository

https://github.com/littlewing7/void-packages a4-terminal.0.2.1
https://github.com/void-linux/void-packages/pull/43734

New package: a4-0.2.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv7l-musl
  - armv6l-musl



A patch file from https://github.com/void-linux/void-packages/pull/43734.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-a4-terminal.0.2.1-43734.patch --]
[-- Type: text/x-diff, Size: 969 bytes --]

From 16921f001da28ff19f8da4ff318d9664c29d12f2 Mon Sep 17 00:00:00 2001
From: Massimo Manzato <massimo.manzato@gmail.com>
Date: Wed, 3 May 2023 23:37:38 +0200
Subject: [PATCH] New package: a4-0.2.1

---
 srcpkgs/a4/template | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 srcpkgs/a4/template

diff --git a/srcpkgs/a4/template b/srcpkgs/a4/template
new file mode 100644
index 000000000000..42c3ee99ade7
--- /dev/null
+++ b/srcpkgs/a4/template
@@ -0,0 +1,16 @@
+# Template file for 'a4'
+pkgname=a4
+version=0.2.1
+revision=1
+build_style=gnu-makefile
+makedepends="libvterm-devel libtickit-devel"
+short_desc="Dynamic terminal manager and multiplexer"
+maintainer="Massimo Manzato <massimo.manzato@gmail.com>"
+license="MIT"
+homepage="https://a4term.com/"
+distfiles="https://github.com/rpmohn/a4/archive/v${version}.tar.gz"
+checksum=52e16e58ac52b9157933a3fd1063bc79e8dfa2f72ea2b4f03e77327bbec2c59e
+
+post_install() {
+	vlicense LICENSE
+}

Re: New package: a4-0.2.1

[littlewing7]

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

New comment by littlewing7 on void-packages repository

https://github.com/void-linux/void-packages/pull/43734#issuecomment-1602396560

Comment:
Done 

Max 

Re: [PR PATCH] [Merged]: New package: a4-0.2.1

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 1094 bytes --]

There's a merged pull request on the void-packages repository

New package: a4-0.2.1
https://github.com/void-linux/void-packages/pull/43734

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv7l-musl
  - armv6l-musl