Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: rofi-wayland-1.7.5+wayland1
@ 2023-05-23 20:25 inalone
  2023-05-23 20:27 ` classabbyamp
                   ` (17 more replies)
  0 siblings, 18 replies; 38+ messages in thread
From: inalone @ 2023-05-23 20:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1246 bytes --]

There is a new pull request by inalone against master on the void-packages repository

https://github.com/inalone/void-packages rofi-wayland
https://github.com/void-linux/void-packages/pull/44054

New package: rofi-wayland-1.7.5+wayland1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->


#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/44054.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rofi-wayland-44054.patch --]
[-- Type: text/x-diff, Size: 1383 bytes --]

From a05286abac952aea8a2ed1ec8890c8b6c62dfc03 Mon Sep 17 00:00:00 2001
From: inalone <me@inal.one>
Date: Tue, 23 May 2023 21:00:21 +0100
Subject: [PATCH] New package: rofi-wayland-1.7.5+wayland1

---
 srcpkgs/rofi-wayland/template | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 srcpkgs/rofi-wayland/template

diff --git a/srcpkgs/rofi-wayland/template b/srcpkgs/rofi-wayland/template
new file mode 100644
index 000000000000..2e4b2d987251
--- /dev/null
+++ b/srcpkgs/rofi-wayland/template
@@ -0,0 +1,23 @@
+# Template file for 'rofi-wayland'
+pkgname=rofi-wayland
+version=1.7.5
+revision=1
+_ver=${version}+wayland1
+wrksrc=rofi-${_ver}
+build_style=meson
+configure_args="-Dxcb=disabled -Dcheck=disabled"
+hostmakedepends="ninja flex bison glib-devel pkg-config wayland-devel"
+makedepends="gdk-pixbuf-devel libxkbcommon-devel pango-devel
+ wayland-protocols wayland-devel"
+checkdepends="check-devel cppcheck xkeyboard-config"
+short_desc="Window switcher, run dialog and dmenu replacement (Wayland fork)"
+maintainer="Omar Zeghouani <omarzeghouanii@gmail.com>"
+license="MIT"
+homepage="https://github.com/lbonn/rofi"
+distfiles="https://github.com/lbonn/rofi/releases/download/${_ver}/rofi-${_ver}.tar.gz"
+checksum=4b7b5de0606e91380861dce6f2b894bebf63b2031c8746fd4096f72576ce541a
+replaces="rofi>=0"
+
+post_install() {
+	vlicense COPYING
+}

^ permalink raw reply	[flat|nested] 38+ messages in thread

* Re: New package: rofi-wayland-1.7.5+wayland1
  2023-05-23 20:25 [PR PATCH] New package: rofi-wayland-1.7.5+wayland1 inalone
@ 2023-05-23 20:27 ` classabbyamp
  2023-05-23 20:27 ` inalone
                   ` (16 subsequent siblings)
  17 siblings, 0 replies; 38+ messages in thread
From: classabbyamp @ 2023-05-23 20:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 182 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/44054#issuecomment-1560079475

Comment:
previous prs: #33578 #40102 #42064 

^ permalink raw reply	[flat|nested] 38+ messages in thread

* Re: New package: rofi-wayland-1.7.5+wayland1
  2023-05-23 20:25 [PR PATCH] New package: rofi-wayland-1.7.5+wayland1 inalone
  2023-05-23 20:27 ` classabbyamp
@ 2023-05-23 20:27 ` inalone
  2023-05-23 20:27 ` inalone
                   ` (15 subsequent siblings)
  17 siblings, 0 replies; 38+ messages in thread
From: inalone @ 2023-05-23 20:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 677 bytes --]

New comment by inalone on void-packages repository

https://github.com/void-linux/void-packages/pull/44054#issuecomment-1560079678

Comment:
I've read over instances before in which this package was denied due to either
a) the PR being stale
b) maintainers being unconvinced of its usefulness

As a user of both wofi and rofi, rofi's ecosystem is fantastic. I can easily just search up Rofi scripts, some of which really old, some of which well-established, some of which package right here on Void! Using the Wayland friendly rofi "replacements" is not the same experience, even though those projects are great. Rofi is just such a well established project and ecosystem.

^ permalink raw reply	[flat|nested] 38+ messages in thread

* Re: New package: rofi-wayland-1.7.5+wayland1
  2023-05-23 20:25 [PR PATCH] New package: rofi-wayland-1.7.5+wayland1 inalone
  2023-05-23 20:27 ` classabbyamp
  2023-05-23 20:27 ` inalone
@ 2023-05-23 20:27 ` inalone
  2023-05-23 20:28 ` [PR PATCH] [Updated] " inalone
                   ` (14 subsequent siblings)
  17 siblings, 0 replies; 38+ messages in thread
From: inalone @ 2023-05-23 20:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 745 bytes --]

New comment by inalone on void-packages repository

https://github.com/void-linux/void-packages/pull/44054#issuecomment-1560079678

Comment:
I've read over instances before in which this package was denied due to either
a) the PR being stale
b) maintainers being unconvinced of its usefulness

As a user of both wofi and rofi, rofi's ecosystem is fantastic. I can easily just search up Rofi scripts, some of which really old, some of which well-established, some of which package right here on Void! Using the Wayland friendly rofi "replacements" is not the same experience, even though those projects are great. Rofi is just such a well established project and ecosystem and I think having the lbonn Wayland fork of Rofi is well worthwhile

^ permalink raw reply	[flat|nested] 38+ messages in thread

* Re: [PR PATCH] [Updated] New package: rofi-wayland-1.7.5+wayland1
  2023-05-23 20:25 [PR PATCH] New package: rofi-wayland-1.7.5+wayland1 inalone
                   ` (2 preceding siblings ...)
  2023-05-23 20:27 ` inalone
@ 2023-05-23 20:28 ` inalone
  2023-05-23 20:29 ` inalone
                   ` (13 subsequent siblings)
  17 siblings, 0 replies; 38+ messages in thread
From: inalone @ 2023-05-23 20:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1251 bytes --]

There is an updated pull request by inalone against master on the void-packages repository

https://github.com/inalone/void-packages rofi-wayland
https://github.com/void-linux/void-packages/pull/44054

New package: rofi-wayland-1.7.5+wayland1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->


#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/44054.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rofi-wayland-44054.patch --]
[-- Type: text/x-diff, Size: 1363 bytes --]

From 5d201e68eea2ffbb76def6511ddec291aef560b2 Mon Sep 17 00:00:00 2001
From: inalone <me@inal.one>
Date: Tue, 23 May 2023 21:00:21 +0100
Subject: [PATCH] New package: rofi-wayland-1.7.5+wayland1

---
 srcpkgs/rofi-wayland/template | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 srcpkgs/rofi-wayland/template

diff --git a/srcpkgs/rofi-wayland/template b/srcpkgs/rofi-wayland/template
new file mode 100644
index 000000000000..7c4c64d5ac9b
--- /dev/null
+++ b/srcpkgs/rofi-wayland/template
@@ -0,0 +1,23 @@
+# Template file for 'rofi-wayland'
+pkgname=rofi-wayland
+version=1.7.5
+revision=1
+_ver=${version}+wayland1
+wrksrc=rofi-${_ver}
+build_style=meson
+configure_args="-Dxcb=disabled -Dcheck=disabled"
+hostmakedepends="ninja flex bison glib-devel pkg-config wayland-devel"
+makedepends="gdk-pixbuf-devel libxkbcommon-devel pango-devel
+ wayland-protocols wayland-devel"
+checkdepends="check-devel cppcheck xkeyboard-config"
+short_desc="Window switcher, run dialog and dmenu replacement (Wayland fork)"
+maintainer="inalone <me@inal.one>"
+license="MIT"
+homepage="https://github.com/lbonn/rofi"
+distfiles="https://github.com/lbonn/rofi/releases/download/${_ver}/rofi-${_ver}.tar.gz"
+checksum=4b7b5de0606e91380861dce6f2b894bebf63b2031c8746fd4096f72576ce541a
+replaces="rofi>=0"
+
+post_install() {
+	vlicense COPYING
+}

^ permalink raw reply	[flat|nested] 38+ messages in thread

* Re: New package: rofi-wayland-1.7.5+wayland1
  2023-05-23 20:25 [PR PATCH] New package: rofi-wayland-1.7.5+wayland1 inalone
                   ` (3 preceding siblings ...)
  2023-05-23 20:28 ` [PR PATCH] [Updated] " inalone
@ 2023-05-23 20:29 ` inalone
  2023-05-23 20:32 ` [PR REVIEW] " classabbyamp
                   ` (12 subsequent siblings)
  17 siblings, 0 replies; 38+ messages in thread
From: inalone @ 2023-05-23 20:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 746 bytes --]

New comment by inalone on void-packages repository

https://github.com/void-linux/void-packages/pull/44054#issuecomment-1560079678

Comment:
I've read over instances before in which this package was denied due to either
a) the PR being stale
b) maintainers being unconvinced of its usefulness

As a user of both wofi and rofi, rofi's ecosystem is fantastic. I can easily just search up Rofi scripts, some of which really old, some of which well-established, some of which packaged right here on Void! Using the Wayland friendly rofi "replacements" is not the same experience, even though those projects are great. Rofi is just such a well established project and ecosystem and I think having the lbonn Wayland fork of Rofi is well worthwhile

^ permalink raw reply	[flat|nested] 38+ messages in thread

* Re: [PR REVIEW] New package: rofi-wayland-1.7.5+wayland1
  2023-05-23 20:25 [PR PATCH] New package: rofi-wayland-1.7.5+wayland1 inalone
                   ` (6 preceding siblings ...)
  2023-05-23 20:32 ` classabbyamp
@ 2023-05-23 20:32 ` classabbyamp
  2023-05-23 20:38 ` [PR PATCH] [Updated] " inalone
                   ` (9 subsequent siblings)
  17 siblings, 0 replies; 38+ messages in thread
From: classabbyamp @ 2023-05-23 20:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/44054#discussion_r1202966603

Comment:
if this is part of the version, put it in the version

^ permalink raw reply	[flat|nested] 38+ messages in thread

* Re: [PR REVIEW] New package: rofi-wayland-1.7.5+wayland1
  2023-05-23 20:25 [PR PATCH] New package: rofi-wayland-1.7.5+wayland1 inalone
                   ` (4 preceding siblings ...)
  2023-05-23 20:29 ` inalone
@ 2023-05-23 20:32 ` classabbyamp
  2023-05-23 20:32 ` classabbyamp
                   ` (11 subsequent siblings)
  17 siblings, 0 replies; 38+ messages in thread
From: classabbyamp @ 2023-05-23 20:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/44054#discussion_r1202966189

Comment:
this variable is read-only now, do not set it

^ permalink raw reply	[flat|nested] 38+ messages in thread

* Re: [PR REVIEW] New package: rofi-wayland-1.7.5+wayland1
  2023-05-23 20:25 [PR PATCH] New package: rofi-wayland-1.7.5+wayland1 inalone
                   ` (5 preceding siblings ...)
  2023-05-23 20:32 ` [PR REVIEW] " classabbyamp
@ 2023-05-23 20:32 ` classabbyamp
  2023-05-23 20:32 ` classabbyamp
                   ` (10 subsequent siblings)
  17 siblings, 0 replies; 38+ messages in thread
From: classabbyamp @ 2023-05-23 20:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/44054#discussion_r1202967419

Comment:
this should probably be conflicts

^ permalink raw reply	[flat|nested] 38+ messages in thread

* Re: [PR PATCH] [Updated] New package: rofi-wayland-1.7.5+wayland1
  2023-05-23 20:25 [PR PATCH] New package: rofi-wayland-1.7.5+wayland1 inalone
                   ` (7 preceding siblings ...)
  2023-05-23 20:32 ` classabbyamp
@ 2023-05-23 20:38 ` inalone
  2023-05-23 20:40 ` inalone
                   ` (8 subsequent siblings)
  17 siblings, 0 replies; 38+ messages in thread
From: inalone @ 2023-05-23 20:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1251 bytes --]

There is an updated pull request by inalone against master on the void-packages repository

https://github.com/inalone/void-packages rofi-wayland
https://github.com/void-linux/void-packages/pull/44054

New package: rofi-wayland-1.7.5+wayland1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->


#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/44054.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rofi-wayland-44054.patch --]
[-- Type: text/x-diff, Size: 1330 bytes --]

From 17090c4d0e7d3c3138f4bba9b8c71c9685534a4c Mon Sep 17 00:00:00 2001
From: inalone <me@inal.one>
Date: Tue, 23 May 2023 21:00:21 +0100
Subject: [PATCH] New package: rofi-wayland-1.7.5+wayland1

---
 srcpkgs/rofi-wayland/template | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 srcpkgs/rofi-wayland/template

diff --git a/srcpkgs/rofi-wayland/template b/srcpkgs/rofi-wayland/template
new file mode 100644
index 000000000000..fff021d93c39
--- /dev/null
+++ b/srcpkgs/rofi-wayland/template
@@ -0,0 +1,21 @@
+# Template file for 'rofi-wayland'
+pkgname=rofi-wayland
+version=1.7.5+wayland1
+revision=1
+build_style=meson
+configure_args="-Dxcb=disabled -Dcheck=disabled"
+hostmakedepends="ninja flex bison glib-devel pkg-config wayland-devel"
+makedepends="gdk-pixbuf-devel libxkbcommon-devel pango-devel
+ wayland-protocols wayland-devel"
+checkdepends="check-devel cppcheck xkeyboard-config"
+short_desc="Window switcher, run dialog and dmenu replacement (Wayland fork)"
+maintainer="inalone <me@inal.one>"
+license="MIT"
+homepage="https://github.com/lbonn/rofi"
+distfiles="https://github.com/lbonn/rofi/releases/download/${version}/rofi-${version}.tar.gz"
+checksum=4b7b5de0606e91380861dce6f2b894bebf63b2031c8746fd4096f72576ce541a
+conflicts="rofi>=0"
+
+post_install() {
+	vlicense COPYING
+}

^ permalink raw reply	[flat|nested] 38+ messages in thread

* Re: New package: rofi-wayland-1.7.5+wayland1
  2023-05-23 20:25 [PR PATCH] New package: rofi-wayland-1.7.5+wayland1 inalone
                   ` (8 preceding siblings ...)
  2023-05-23 20:38 ` [PR PATCH] [Updated] " inalone
@ 2023-05-23 20:40 ` inalone
  2023-08-22  1:44 ` github-actions
                   ` (7 subsequent siblings)
  17 siblings, 0 replies; 38+ messages in thread
From: inalone @ 2023-05-23 20:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 612 bytes --]

New comment by inalone on void-packages repository

https://github.com/void-linux/void-packages/pull/44054#issuecomment-1560095645

Comment:
> still mightily don't like this. if rofi's devs wanted to support wayland, they'd support wayland.

I completely agree with this, and I think most of the Rofi community has respected the Rofi devs' right to do that. I think however that this fork is of such popularity + with more people moving off Xorg that a large amount of people will be running this on their Void machines regardless, so it should be packaged (albeit obviously different to the upstream version)

^ permalink raw reply	[flat|nested] 38+ messages in thread

* Re: New package: rofi-wayland-1.7.5+wayland1
  2023-05-23 20:25 [PR PATCH] New package: rofi-wayland-1.7.5+wayland1 inalone
                   ` (9 preceding siblings ...)
  2023-05-23 20:40 ` inalone
@ 2023-08-22  1:44 ` github-actions
  2023-08-25 22:35 ` [PR PATCH] [Updated] " inalone
                   ` (6 subsequent siblings)
  17 siblings, 0 replies; 38+ messages in thread
From: github-actions @ 2023-08-22  1:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/44054#issuecomment-1687288496

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 38+ messages in thread

* Re: [PR PATCH] [Updated] New package: rofi-wayland-1.7.5+wayland1
  2023-05-23 20:25 [PR PATCH] New package: rofi-wayland-1.7.5+wayland1 inalone
                   ` (10 preceding siblings ...)
  2023-08-22  1:44 ` github-actions
@ 2023-08-25 22:35 ` inalone
  2023-08-27 10:35 ` inalone
                   ` (5 subsequent siblings)
  17 siblings, 0 replies; 38+ messages in thread
From: inalone @ 2023-08-25 22:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1251 bytes --]

There is an updated pull request by inalone against master on the void-packages repository

https://github.com/inalone/void-packages rofi-wayland
https://github.com/void-linux/void-packages/pull/44054

New package: rofi-wayland-1.7.5+wayland1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->


#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/44054.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rofi-wayland-44054.patch --]
[-- Type: text/x-diff, Size: 1331 bytes --]

From 5be6ded95010f2136ef0466f2d92d80fec06e819 Mon Sep 17 00:00:00 2001
From: inalone <me@inal.one>
Date: Tue, 23 May 2023 21:00:21 +0100
Subject: [PATCH] New package: rofi-wayland-1.7.5+wayland1

---
 srcpkgs/rofi-wayland/template | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 srcpkgs/rofi-wayland/template

diff --git a/srcpkgs/rofi-wayland/template b/srcpkgs/rofi-wayland/template
new file mode 100644
index 0000000000000..ed624192f9f93
--- /dev/null
+++ b/srcpkgs/rofi-wayland/template
@@ -0,0 +1,21 @@
+# Template file for 'rofi-wayland'
+pkgname=rofi-wayland
+version=1.7.5+wayland2
+revision=1
+build_style=meson
+configure_args="-Dxcb=disabled -Dcheck=disabled"
+hostmakedepends="ninja flex bison glib-devel pkg-config wayland-devel"
+makedepends="gdk-pixbuf-devel libxkbcommon-devel pango-devel
+ wayland-protocols wayland-devel"
+checkdepends="check-devel cppcheck xkeyboard-config"
+short_desc="Window switcher, run dialog and dmenu replacement (Wayland fork)"
+maintainer="inalone <me@inal.one>"
+license="MIT"
+homepage="https://github.com/lbonn/rofi"
+distfiles="https://github.com/lbonn/rofi/releases/download/${version}/rofi-${version}.tar.gz"
+checksum=025a390469008179eaffaa599e2eabbd81a77f7141d9038e008304673ba19843
+replaces="rofi>=0"
+
+post_install() {
+	vlicense COPYING
+}

^ permalink raw reply	[flat|nested] 38+ messages in thread

* Re: [PR PATCH] [Updated] New package: rofi-wayland-1.7.5+wayland1
  2023-05-23 20:25 [PR PATCH] New package: rofi-wayland-1.7.5+wayland1 inalone
                   ` (11 preceding siblings ...)
  2023-08-25 22:35 ` [PR PATCH] [Updated] " inalone
@ 2023-08-27 10:35 ` inalone
  2023-09-10 21:59 ` inalone
                   ` (4 subsequent siblings)
  17 siblings, 0 replies; 38+ messages in thread
From: inalone @ 2023-08-27 10:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1251 bytes --]

There is an updated pull request by inalone against master on the void-packages repository

https://github.com/inalone/void-packages rofi-wayland
https://github.com/void-linux/void-packages/pull/44054

New package: rofi-wayland-1.7.5+wayland1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->


#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/44054.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rofi-wayland-44054.patch --]
[-- Type: text/x-diff, Size: 1331 bytes --]

From 95408ec2fb429f16eb52724d965a7f5bf9c981ce Mon Sep 17 00:00:00 2001
From: inalone <me@inal.one>
Date: Tue, 23 May 2023 21:00:21 +0100
Subject: [PATCH] New package: rofi-wayland-1.7.5+wayland1

---
 srcpkgs/rofi-wayland/template | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 srcpkgs/rofi-wayland/template

diff --git a/srcpkgs/rofi-wayland/template b/srcpkgs/rofi-wayland/template
new file mode 100644
index 0000000000000..ed624192f9f93
--- /dev/null
+++ b/srcpkgs/rofi-wayland/template
@@ -0,0 +1,21 @@
+# Template file for 'rofi-wayland'
+pkgname=rofi-wayland
+version=1.7.5+wayland2
+revision=1
+build_style=meson
+configure_args="-Dxcb=disabled -Dcheck=disabled"
+hostmakedepends="ninja flex bison glib-devel pkg-config wayland-devel"
+makedepends="gdk-pixbuf-devel libxkbcommon-devel pango-devel
+ wayland-protocols wayland-devel"
+checkdepends="check-devel cppcheck xkeyboard-config"
+short_desc="Window switcher, run dialog and dmenu replacement (Wayland fork)"
+maintainer="inalone <me@inal.one>"
+license="MIT"
+homepage="https://github.com/lbonn/rofi"
+distfiles="https://github.com/lbonn/rofi/releases/download/${version}/rofi-${version}.tar.gz"
+checksum=025a390469008179eaffaa599e2eabbd81a77f7141d9038e008304673ba19843
+replaces="rofi>=0"
+
+post_install() {
+	vlicense COPYING
+}

^ permalink raw reply	[flat|nested] 38+ messages in thread

* Re: [PR PATCH] [Updated] New package: rofi-wayland-1.7.5+wayland1
  2023-05-23 20:25 [PR PATCH] New package: rofi-wayland-1.7.5+wayland1 inalone
                   ` (12 preceding siblings ...)
  2023-08-27 10:35 ` inalone
@ 2023-09-10 21:59 ` inalone
  2023-09-13 19:17 ` inalone
                   ` (3 subsequent siblings)
  17 siblings, 0 replies; 38+ messages in thread
From: inalone @ 2023-09-10 21:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1251 bytes --]

There is an updated pull request by inalone against master on the void-packages repository

https://github.com/inalone/void-packages rofi-wayland
https://github.com/void-linux/void-packages/pull/44054

New package: rofi-wayland-1.7.5+wayland1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->


#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/44054.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rofi-wayland-44054.patch --]
[-- Type: text/x-diff, Size: 1331 bytes --]

From b2bde71a1c110cc42ca2e2edaf9a0e5b839a2f18 Mon Sep 17 00:00:00 2001
From: inalone <me@inal.one>
Date: Tue, 23 May 2023 21:00:21 +0100
Subject: [PATCH] New package: rofi-wayland-1.7.5+wayland1

---
 srcpkgs/rofi-wayland/template | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 srcpkgs/rofi-wayland/template

diff --git a/srcpkgs/rofi-wayland/template b/srcpkgs/rofi-wayland/template
new file mode 100644
index 0000000000000..ed624192f9f93
--- /dev/null
+++ b/srcpkgs/rofi-wayland/template
@@ -0,0 +1,21 @@
+# Template file for 'rofi-wayland'
+pkgname=rofi-wayland
+version=1.7.5+wayland2
+revision=1
+build_style=meson
+configure_args="-Dxcb=disabled -Dcheck=disabled"
+hostmakedepends="ninja flex bison glib-devel pkg-config wayland-devel"
+makedepends="gdk-pixbuf-devel libxkbcommon-devel pango-devel
+ wayland-protocols wayland-devel"
+checkdepends="check-devel cppcheck xkeyboard-config"
+short_desc="Window switcher, run dialog and dmenu replacement (Wayland fork)"
+maintainer="inalone <me@inal.one>"
+license="MIT"
+homepage="https://github.com/lbonn/rofi"
+distfiles="https://github.com/lbonn/rofi/releases/download/${version}/rofi-${version}.tar.gz"
+checksum=025a390469008179eaffaa599e2eabbd81a77f7141d9038e008304673ba19843
+replaces="rofi>=0"
+
+post_install() {
+	vlicense COPYING
+}

^ permalink raw reply	[flat|nested] 38+ messages in thread

* Re: [PR PATCH] [Updated] New package: rofi-wayland-1.7.5+wayland1
  2023-05-23 20:25 [PR PATCH] New package: rofi-wayland-1.7.5+wayland1 inalone
                   ` (13 preceding siblings ...)
  2023-09-10 21:59 ` inalone
@ 2023-09-13 19:17 ` inalone
  2023-09-24 21:58 ` inalone
                   ` (2 subsequent siblings)
  17 siblings, 0 replies; 38+ messages in thread
From: inalone @ 2023-09-13 19:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1251 bytes --]

There is an updated pull request by inalone against master on the void-packages repository

https://github.com/inalone/void-packages rofi-wayland
https://github.com/void-linux/void-packages/pull/44054

New package: rofi-wayland-1.7.5+wayland1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->


#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/44054.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rofi-wayland-44054.patch --]
[-- Type: text/x-diff, Size: 1331 bytes --]

From afe41e307dd9740b121f8cb9f8da04008530257b Mon Sep 17 00:00:00 2001
From: inalone <me@inal.one>
Date: Tue, 23 May 2023 21:00:21 +0100
Subject: [PATCH] New package: rofi-wayland-1.7.5+wayland2

---
 srcpkgs/rofi-wayland/template | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 srcpkgs/rofi-wayland/template

diff --git a/srcpkgs/rofi-wayland/template b/srcpkgs/rofi-wayland/template
new file mode 100644
index 0000000000000..ed624192f9f93
--- /dev/null
+++ b/srcpkgs/rofi-wayland/template
@@ -0,0 +1,21 @@
+# Template file for 'rofi-wayland'
+pkgname=rofi-wayland
+version=1.7.5+wayland2
+revision=1
+build_style=meson
+configure_args="-Dxcb=disabled -Dcheck=disabled"
+hostmakedepends="ninja flex bison glib-devel pkg-config wayland-devel"
+makedepends="gdk-pixbuf-devel libxkbcommon-devel pango-devel
+ wayland-protocols wayland-devel"
+checkdepends="check-devel cppcheck xkeyboard-config"
+short_desc="Window switcher, run dialog and dmenu replacement (Wayland fork)"
+maintainer="inalone <me@inal.one>"
+license="MIT"
+homepage="https://github.com/lbonn/rofi"
+distfiles="https://github.com/lbonn/rofi/releases/download/${version}/rofi-${version}.tar.gz"
+checksum=025a390469008179eaffaa599e2eabbd81a77f7141d9038e008304673ba19843
+replaces="rofi>=0"
+
+post_install() {
+	vlicense COPYING
+}

^ permalink raw reply	[flat|nested] 38+ messages in thread

* Re: [PR PATCH] [Updated] New package: rofi-wayland-1.7.5+wayland1
  2023-05-23 20:25 [PR PATCH] New package: rofi-wayland-1.7.5+wayland1 inalone
                   ` (14 preceding siblings ...)
  2023-09-13 19:17 ` inalone
@ 2023-09-24 21:58 ` inalone
  2023-12-24  1:47 ` github-actions
  2024-01-07  1:49 ` [PR PATCH] [Closed]: " github-actions
  17 siblings, 0 replies; 38+ messages in thread
From: inalone @ 2023-09-24 21:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1251 bytes --]

There is an updated pull request by inalone against master on the void-packages repository

https://github.com/inalone/void-packages rofi-wayland
https://github.com/void-linux/void-packages/pull/44054

New package: rofi-wayland-1.7.5+wayland1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->


#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/44054.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rofi-wayland-44054.patch --]
[-- Type: text/x-diff, Size: 1331 bytes --]

From 0aae189dd80a01697f46a1a05fa621cad98986b2 Mon Sep 17 00:00:00 2001
From: inalone <me@inal.one>
Date: Tue, 23 May 2023 21:00:21 +0100
Subject: [PATCH] New package: rofi-wayland-1.7.5+wayland2

---
 srcpkgs/rofi-wayland/template | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 srcpkgs/rofi-wayland/template

diff --git a/srcpkgs/rofi-wayland/template b/srcpkgs/rofi-wayland/template
new file mode 100644
index 0000000000000..ed624192f9f93
--- /dev/null
+++ b/srcpkgs/rofi-wayland/template
@@ -0,0 +1,21 @@
+# Template file for 'rofi-wayland'
+pkgname=rofi-wayland
+version=1.7.5+wayland2
+revision=1
+build_style=meson
+configure_args="-Dxcb=disabled -Dcheck=disabled"
+hostmakedepends="ninja flex bison glib-devel pkg-config wayland-devel"
+makedepends="gdk-pixbuf-devel libxkbcommon-devel pango-devel
+ wayland-protocols wayland-devel"
+checkdepends="check-devel cppcheck xkeyboard-config"
+short_desc="Window switcher, run dialog and dmenu replacement (Wayland fork)"
+maintainer="inalone <me@inal.one>"
+license="MIT"
+homepage="https://github.com/lbonn/rofi"
+distfiles="https://github.com/lbonn/rofi/releases/download/${version}/rofi-${version}.tar.gz"
+checksum=025a390469008179eaffaa599e2eabbd81a77f7141d9038e008304673ba19843
+replaces="rofi>=0"
+
+post_install() {
+	vlicense COPYING
+}

^ permalink raw reply	[flat|nested] 38+ messages in thread

* Re: New package: rofi-wayland-1.7.5+wayland1
  2023-05-23 20:25 [PR PATCH] New package: rofi-wayland-1.7.5+wayland1 inalone
                   ` (15 preceding siblings ...)
  2023-09-24 21:58 ` inalone
@ 2023-12-24  1:47 ` github-actions
  2024-01-07  1:49 ` [PR PATCH] [Closed]: " github-actions
  17 siblings, 0 replies; 38+ messages in thread
From: github-actions @ 2023-12-24  1:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/44054#issuecomment-1868410161

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 38+ messages in thread

* Re: [PR PATCH] [Closed]: New package: rofi-wayland-1.7.5+wayland1
  2023-05-23 20:25 [PR PATCH] New package: rofi-wayland-1.7.5+wayland1 inalone
                   ` (16 preceding siblings ...)
  2023-12-24  1:47 ` github-actions
@ 2024-01-07  1:49 ` github-actions
  17 siblings, 0 replies; 38+ messages in thread
From: github-actions @ 2024-01-07  1:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1090 bytes --]

There's a closed pull request on the void-packages repository

New package: rofi-wayland-1.7.5+wayland1
https://github.com/void-linux/void-packages/pull/44054

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->


#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 38+ messages in thread

* Re: [PR REVIEW] New package: rofi-wayland-1.7.5+wayland1
  2023-02-03 20:36 [PR PATCH] " subnut
                   ` (17 preceding siblings ...)
  2023-02-06 19:34 ` subnut
@ 2023-02-06 19:37 ` subnut
  18 siblings, 0 replies; 38+ messages in thread
From: subnut @ 2023-02-06 19:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

New review comment by subnut on void-packages repository

https://github.com/void-linux/void-packages/pull/42064#discussion_r1097836938

Comment:
I guess I could look into xbps-alternatives

^ permalink raw reply	[flat|nested] 38+ messages in thread

* Re: [PR REVIEW] New package: rofi-wayland-1.7.5+wayland1
  2023-02-03 20:36 [PR PATCH] " subnut
                   ` (16 preceding siblings ...)
  2023-02-06 18:52 ` paper42
@ 2023-02-06 19:34 ` subnut
  2023-02-06 19:37 ` subnut
  18 siblings, 0 replies; 38+ messages in thread
From: subnut @ 2023-02-06 19:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 361 bytes --]

New review comment by subnut on void-packages repository

https://github.com/void-linux/void-packages/pull/42064#discussion_r1097834323

Comment:
> scripts that call rofi will just call the xorg rofi


Good point... I hadn't thought about that at all.....

(imma draft this PR now and think about this later. Got an exam coming up :slightly_smiling_face:)

^ permalink raw reply	[flat|nested] 38+ messages in thread

* Re: [PR REVIEW] New package: rofi-wayland-1.7.5+wayland1
  2023-02-03 20:36 [PR PATCH] " subnut
                   ` (15 preceding siblings ...)
  2023-02-06 18:49 ` paper42
@ 2023-02-06 18:52 ` paper42
  2023-02-06 19:34 ` subnut
  2023-02-06 19:37 ` subnut
  18 siblings, 0 replies; 38+ messages in thread
From: paper42 @ 2023-02-06 18:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 343 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/42064#discussion_r1097790865

Comment:
I see, do you still need to run rofi-wayland instead of rofi when you want it to use the rofi with wayland support? If that's the case, then scripts that call rofi will just call the xorg rofi...

^ permalink raw reply	[flat|nested] 38+ messages in thread

* Re: [PR REVIEW] New package: rofi-wayland-1.7.5+wayland1
  2023-02-03 20:36 [PR PATCH] " subnut
                   ` (14 preceding siblings ...)
  2023-02-06 18:48 ` subnut
@ 2023-02-06 18:49 ` paper42
  2023-02-06 18:52 ` paper42
                   ` (2 subsequent siblings)
  18 siblings, 0 replies; 38+ messages in thread
From: paper42 @ 2023-02-06 18:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/42064#discussion_r1097788294

Comment:
During compilation only if tests are enabled, right? In that case it can be in checkdepends.

^ permalink raw reply	[flat|nested] 38+ messages in thread

* Re: [PR REVIEW] New package: rofi-wayland-1.7.5+wayland1
  2023-02-03 20:36 [PR PATCH] " subnut
                   ` (13 preceding siblings ...)
  2023-02-06 18:47 ` subnut
@ 2023-02-06 18:48 ` subnut
  2023-02-06 18:49 ` paper42
                   ` (3 subsequent siblings)
  18 siblings, 0 replies; 38+ messages in thread
From: subnut @ 2023-02-06 18:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

New review comment by subnut on void-packages repository

https://github.com/void-linux/void-packages/pull/42064#discussion_r1097786867

Comment:
i.e. the mentality behind this package is that this package complements the main rofi package. It only provides what isn't already there in the main rofi package.


^ permalink raw reply	[flat|nested] 38+ messages in thread

* Re: [PR REVIEW] New package: rofi-wayland-1.7.5+wayland1
  2023-02-03 20:36 [PR PATCH] " subnut
                   ` (12 preceding siblings ...)
  2023-02-06 18:44 ` subnut
@ 2023-02-06 18:47 ` subnut
  2023-02-06 18:48 ` subnut
                   ` (4 subsequent siblings)
  18 siblings, 0 replies; 38+ messages in thread
From: subnut @ 2023-02-06 18:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 369 bytes --]

New review comment by subnut on void-packages repository

https://github.com/void-linux/void-packages/pull/42064#discussion_r1097785911

Comment:
This package only provides two binaries (rofi-wayland and rofi-theme-selector-wayland) and their corresponding .desktop, icon, and man pages. Everything else needed and related to rofi is provided by the main rofi package.

^ permalink raw reply	[flat|nested] 38+ messages in thread

* Re: [PR REVIEW] New package: rofi-wayland-1.7.5+wayland1
  2023-02-03 20:36 [PR PATCH] " subnut
                   ` (11 preceding siblings ...)
  2023-02-06 18:43 ` subnut
@ 2023-02-06 18:44 ` subnut
  2023-02-06 18:47 ` subnut
                   ` (5 subsequent siblings)
  18 siblings, 0 replies; 38+ messages in thread
From: subnut @ 2023-02-06 18:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 275 bytes --]

New review comment by subnut on void-packages repository

https://github.com/void-linux/void-packages/pull/42064#discussion_r1097783187

Comment:
Those alternatives and clones don't support the plugins that have been specifically written for rofi. (rofi-emoji, for example.)

^ permalink raw reply	[flat|nested] 38+ messages in thread

* Re: [PR REVIEW] New package: rofi-wayland-1.7.5+wayland1
  2023-02-03 20:36 [PR PATCH] " subnut
                   ` (10 preceding siblings ...)
  2023-02-03 23:43 ` classabbyamp
@ 2023-02-06 18:43 ` subnut
  2023-02-06 18:44 ` subnut
                   ` (6 subsequent siblings)
  18 siblings, 0 replies; 38+ messages in thread
From: subnut @ 2023-02-06 18:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

New review comment by subnut on void-packages repository

https://github.com/void-linux/void-packages/pull/42064#discussion_r1097782511

Comment:
check-devel is needed during compilation. 

^ permalink raw reply	[flat|nested] 38+ messages in thread

* Re: [PR REVIEW] New package: rofi-wayland-1.7.5+wayland1
  2023-02-03 20:36 [PR PATCH] " subnut
                   ` (9 preceding siblings ...)
  2023-02-03 23:37 ` paper42
@ 2023-02-03 23:43 ` classabbyamp
  2023-02-06 18:43 ` subnut
                   ` (7 subsequent siblings)
  18 siblings, 0 replies; 38+ messages in thread
From: classabbyamp @ 2023-02-03 23:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 337 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42064#discussion_r1096385753

Comment:
> I am not really interested in merging this

same here, i don't see a reason in packaging a fork when several alternatives/clones to rofi that support wayland are already in the repos

^ permalink raw reply	[flat|nested] 38+ messages in thread

* Re: [PR REVIEW] New package: rofi-wayland-1.7.5+wayland1
  2023-02-03 20:36 [PR PATCH] " subnut
                   ` (6 preceding siblings ...)
  2023-02-03 23:37 ` paper42
@ 2023-02-03 23:37 ` paper42
  2023-02-03 23:37 ` paper42
                   ` (10 subsequent siblings)
  18 siblings, 0 replies; 38+ messages in thread
From: paper42 @ 2023-02-03 23:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 226 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/42064#discussion_r1096381088

Comment:
```suggestion
hostmakedepends="pkg-config flex glib-devel wayland-devel"
```

^ permalink raw reply	[flat|nested] 38+ messages in thread

* Re: [PR REVIEW] New package: rofi-wayland-1.7.5+wayland1
  2023-02-03 20:36 [PR PATCH] " subnut
                   ` (5 preceding siblings ...)
  2023-02-03 22:47 ` kruceter
@ 2023-02-03 23:37 ` paper42
  2023-02-03 23:37 ` paper42
                   ` (11 subsequent siblings)
  18 siblings, 0 replies; 38+ messages in thread
From: paper42 @ 2023-02-03 23:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 245 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/42064#discussion_r1096382626

Comment:
I think we should just make it conflict with rofi, but I am not really interested in merging this

^ permalink raw reply	[flat|nested] 38+ messages in thread

* Re: [PR REVIEW] New package: rofi-wayland-1.7.5+wayland1
  2023-02-03 20:36 [PR PATCH] " subnut
                   ` (8 preceding siblings ...)
  2023-02-03 23:37 ` paper42
@ 2023-02-03 23:37 ` paper42
  2023-02-03 23:43 ` classabbyamp
                   ` (8 subsequent siblings)
  18 siblings, 0 replies; 38+ messages in thread
From: paper42 @ 2023-02-03 23:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/42064#discussion_r1096380804

Comment:
why does this fork depend on the original rofi?

^ permalink raw reply	[flat|nested] 38+ messages in thread

* Re: [PR REVIEW] New package: rofi-wayland-1.7.5+wayland1
  2023-02-03 20:36 [PR PATCH] " subnut
                   ` (7 preceding siblings ...)
  2023-02-03 23:37 ` paper42
@ 2023-02-03 23:37 ` paper42
  2023-02-03 23:37 ` paper42
                   ` (9 subsequent siblings)
  18 siblings, 0 replies; 38+ messages in thread
From: paper42 @ 2023-02-03 23:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/42064#discussion_r1096381262

Comment:
check-devel should probably be in checkdepends

^ permalink raw reply	[flat|nested] 38+ messages in thread

* Re: [PR REVIEW] New package: rofi-wayland-1.7.5+wayland1
  2023-02-03 20:36 [PR PATCH] " subnut
                   ` (2 preceding siblings ...)
  2023-02-03 22:47 ` kruceter
@ 2023-02-03 22:47 ` kruceter
  2023-02-03 22:47 ` kruceter
                   ` (14 subsequent siblings)
  18 siblings, 0 replies; 38+ messages in thread
From: kruceter @ 2023-02-03 22:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 257 bytes --]

New review comment by kruceter on void-packages repository

https://github.com/void-linux/void-packages/pull/42064#discussion_r1096344242

Comment:
```suggestion
--- a/script/rofi-sensible-terminal-wayland
+++ b/script/rofi-sensible-terminal-wayland
```

^ permalink raw reply	[flat|nested] 38+ messages in thread

* Re: [PR REVIEW] New package: rofi-wayland-1.7.5+wayland1
  2023-02-03 20:36 [PR PATCH] " subnut
  2023-02-03 22:47 ` [PR REVIEW] " kruceter
@ 2023-02-03 22:47 ` kruceter
  2023-02-03 22:47 ` kruceter
                   ` (16 subsequent siblings)
  18 siblings, 0 replies; 38+ messages in thread
From: kruceter @ 2023-02-03 22:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]

New review comment by kruceter on void-packages repository

https://github.com/void-linux/void-packages/pull/42064#discussion_r1096344399

Comment:
```suggestion
--- a/script/rofi-theme-selector-wayland
+++ b/script/rofi-theme-selector-wayland
```

^ permalink raw reply	[flat|nested] 38+ messages in thread

* Re: [PR REVIEW] New package: rofi-wayland-1.7.5+wayland1
  2023-02-03 20:36 [PR PATCH] " subnut
                   ` (4 preceding siblings ...)
  2023-02-03 22:47 ` kruceter
@ 2023-02-03 22:47 ` kruceter
  2023-02-03 23:37 ` paper42
                   ` (12 subsequent siblings)
  18 siblings, 0 replies; 38+ messages in thread
From: kruceter @ 2023-02-03 22:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 263 bytes --]

New review comment by kruceter on void-packages repository

https://github.com/void-linux/void-packages/pull/42064#discussion_r1096344694

Comment:
```suggestion
--- a/data/rofi-theme-selector-wayland.desktop
+++ b/data/rofi-theme-selector-wayland.desktop
```

^ permalink raw reply	[flat|nested] 38+ messages in thread

* Re: [PR REVIEW] New package: rofi-wayland-1.7.5+wayland1
  2023-02-03 20:36 [PR PATCH] " subnut
  2023-02-03 22:47 ` [PR REVIEW] " kruceter
  2023-02-03 22:47 ` kruceter
@ 2023-02-03 22:47 ` kruceter
  2023-02-03 22:47 ` kruceter
                   ` (15 subsequent siblings)
  18 siblings, 0 replies; 38+ messages in thread
From: kruceter @ 2023-02-03 22:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

New review comment by kruceter on void-packages repository

https://github.com/void-linux/void-packages/pull/42064#discussion_r1096346079

Comment:
```suggestion
--- a/meson.build
+++ b/meson.build
```

^ permalink raw reply	[flat|nested] 38+ messages in thread

* Re: [PR REVIEW] New package: rofi-wayland-1.7.5+wayland1
  2023-02-03 20:36 [PR PATCH] " subnut
                   ` (3 preceding siblings ...)
  2023-02-03 22:47 ` kruceter
@ 2023-02-03 22:47 ` kruceter
  2023-02-03 22:47 ` kruceter
                   ` (13 subsequent siblings)
  18 siblings, 0 replies; 38+ messages in thread
From: kruceter @ 2023-02-03 22:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 233 bytes --]

New review comment by kruceter on void-packages repository

https://github.com/void-linux/void-packages/pull/42064#discussion_r1096345938

Comment:
```suggestion
--- a/data/rofi-wayland.desktop
+++ b/data/rofi-wayland.desktop
```

^ permalink raw reply	[flat|nested] 38+ messages in thread

* Re: [PR REVIEW] New package: rofi-wayland-1.7.5+wayland1
  2023-02-03 20:36 [PR PATCH] " subnut
@ 2023-02-03 22:47 ` kruceter
  2023-02-03 22:47 ` kruceter
                   ` (17 subsequent siblings)
  18 siblings, 0 replies; 38+ messages in thread
From: kruceter @ 2023-02-03 22:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 192 bytes --]

New review comment by kruceter on void-packages repository

https://github.com/void-linux/void-packages/pull/42064#discussion_r1096349047

Comment:
```suggestion
```

Get rid of this file.

^ permalink raw reply	[flat|nested] 38+ messages in thread

end of thread, other threads:[~2024-01-07  1:49 UTC | newest]

Thread overview: 38+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-23 20:25 [PR PATCH] New package: rofi-wayland-1.7.5+wayland1 inalone
2023-05-23 20:27 ` classabbyamp
2023-05-23 20:27 ` inalone
2023-05-23 20:27 ` inalone
2023-05-23 20:28 ` [PR PATCH] [Updated] " inalone
2023-05-23 20:29 ` inalone
2023-05-23 20:32 ` [PR REVIEW] " classabbyamp
2023-05-23 20:32 ` classabbyamp
2023-05-23 20:32 ` classabbyamp
2023-05-23 20:38 ` [PR PATCH] [Updated] " inalone
2023-05-23 20:40 ` inalone
2023-08-22  1:44 ` github-actions
2023-08-25 22:35 ` [PR PATCH] [Updated] " inalone
2023-08-27 10:35 ` inalone
2023-09-10 21:59 ` inalone
2023-09-13 19:17 ` inalone
2023-09-24 21:58 ` inalone
2023-12-24  1:47 ` github-actions
2024-01-07  1:49 ` [PR PATCH] [Closed]: " github-actions
  -- strict thread matches above, loose matches on Subject: below --
2023-02-03 20:36 [PR PATCH] " subnut
2023-02-03 22:47 ` [PR REVIEW] " kruceter
2023-02-03 22:47 ` kruceter
2023-02-03 22:47 ` kruceter
2023-02-03 22:47 ` kruceter
2023-02-03 22:47 ` kruceter
2023-02-03 22:47 ` kruceter
2023-02-03 23:37 ` paper42
2023-02-03 23:37 ` paper42
2023-02-03 23:37 ` paper42
2023-02-03 23:37 ` paper42
2023-02-03 23:43 ` classabbyamp
2023-02-06 18:43 ` subnut
2023-02-06 18:44 ` subnut
2023-02-06 18:47 ` subnut
2023-02-06 18:48 ` subnut
2023-02-06 18:49 ` paper42
2023-02-06 18:52 ` paper42
2023-02-06 19:34 ` subnut
2023-02-06 19:37 ` subnut

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).