From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: build-style/python3-pep517: use a generic glob for wheels
Date: Thu, 25 May 2023 16:11:04 +0200 [thread overview]
Message-ID: <20230525141104.TTMDHVsIhu6gcX3P3seYa9_P-ZplSAF_SpjT-Jr8XAs@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-44071@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 747 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/44071#issuecomment-1562981730
Comment:
I have made a couple of changes:
1. A squash commit refactors `do_check`: a) to short-circuit checks when `pytest` is not installed, avoiding the need to nest the bulk of the function inside a conditional; b) to avoid setting `make_install_target` in `do_check` when it is undefined in the template, deferring the default assignment to `do_install`.
2. Remove the now-superfluous `make_install_target` in all PEP517 templates.
3. Fix the build of `synapse` and (by updating) `pythone3-xcffib`.
Please confirm that you are OK with these changes, and we can squash down my alterations before merge.
next prev parent reply other threads:[~2023-05-25 14:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 23:04 [PR PATCH] " tornaria
2023-05-25 14:06 ` [PR PATCH] [Updated] " ahesford
2023-05-25 14:11 ` ahesford [this message]
2023-05-25 14:13 ` icp1994
2023-05-25 14:15 ` [PR PATCH] [Updated] " ahesford
2023-05-25 14:16 ` ahesford
2023-05-25 14:51 ` [PR REVIEW] " tornaria
2023-05-25 14:56 ` tornaria
2023-05-25 15:25 ` [PR REVIEW] " ahesford
2023-05-25 17:43 ` [PR PATCH] [Closed]: " ahesford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230525141104.TTMDHVsIhu6gcX3P3seYa9_P-ZplSAF_SpjT-Jr8XAs@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).